[Bug 61977] JNDIRealm with SPNEGO, GSSAPI and SRV record fails to find LDAP SPN due to training sname period

https://bz.apache.org/bugzilla/show_bug.cgi?id=61977 --- Comment #6 from Mark Thomas --- Realm's many be specified at the Context, Host or Engine level. However, the implementation class needs to visible to Tomcat so it needs to be in CATALINA_BASE/lib. So, to apply this patch

[Bug 61977] JNDIRealm with SPNEGO, GSSAPI and SRV record fails to find LDAP SPN due to training sname period

https://bz.apache.org/bugzilla/show_bug.cgi?id=61977 --- Comment #5 from marian.romasc...@nuance.com --- Would it be possible to override in the webapp the JNDIRealm class in catalina.jar with the patched version? I mean providing the class in a webapp-specific jar. This taking advantage of

Re: Http11OutputBuffer mixes write strategies

On 12/01/18 20:58, Christopher Schultz wrote: > Mark, > > On 1/12/18 3:27 AM, Mark Thomas wrote: >> On 11/01/18 23:12, Christopher Schultz wrote: > >> > >>> If performance is a consideration, then most of the calls to >>> write() should probably be calls to headerBuffer.put() because we >>>

Re: Closing channel sockets

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/12/18 3:27 AM, Mark Thomas wrote: > On 12/01/18 08:04, Rémy Maucherat wrote: >> On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas >> wrote: >> >>> Hi, >>> >>> I've been looking at how we close NIO channels and I think

Re: Http11OutputBuffer mixes write strategies

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/12/18 3:27 AM, Mark Thomas wrote: > On 11/01/18 23:12, Christopher Schultz wrote: > > > >> If performance is a consideration, then most of the calls to >> write() should probably be calls to headerBuffer.put() because we >> can be

Re: Closing channel sockets

On Fri, Jan 12, 2018 at 9:27 AM, Mark Thomas wrote: > On 12/01/18 08:04, Rémy Maucherat wrote: > > On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote: > > > >> Hi, > >> > >> I've been looking at how we close NIO channels and I think there is an > >>

[Bug 61993] org.apache.tomcat.util.ByteChunk throws NegativeArray SizeException

https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 --- Comment #2 from Dave Crighton --- Thanks Mark, I did consider submitting my own JUnit with the patch but it causes large allocations which, at least for our own build systems, makes it unsuitable at an

[Bug 61993] org.apache.tomcat.util.ByteChunk throws NegativeArray SizeException

https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 --- Comment #1 from Mark Thomas --- Thanks for the report. On closer inspection there appear to be a couple of other edge cases that could be handled better. I plan on putting together some unit tests to cover this case and

svn commit: r1820994 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

Author: markt Date: Fri Jan 12 14:16:08 2018 New Revision: 1820994 URL: http://svn.apache.org/viewvc?rev=1820994=rev Log: Format classes. No functional change. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

svn commit: r1820981 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

Author: markt Date: Fri Jan 12 13:34:13 2018 New Revision: 1820981 URL: http://svn.apache.org/viewvc?rev=1820981=rev Log: Fix formatting. No functional change. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

Re: JDK 10 entered Rampdown Phase One on 14th of December

On 12/01/18 13:17, Rory O'Donnell wrote: > Hi Mark > > How serious is this issue ? Hi, In terms of functionality, it isn't serious. As far as I can tell, there are no functional side-effects for Tomcat. However, the more I think about this, the more serious an issue I think this will be. A

[Bug 61993] org.apache.tomcat.util.ByteChunk throws NegativeArray SizeException

https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 Dave Crighton changed: What|Removed |Added CC|

Re: JDK 10 entered Rampdown Phase One on 14th of December

Hi Mark How serious is this issue ? It's logged with a low priority, it might have to wait for JDK 11. Rgds,Rory On 12/01/2018 11:39, Rory O'Donnell wrote: Hi Mark, Thanks for the feedback, I'll pass it on. Rgds,Rory On 12/01/2018 10:20, Mark Thomas wrote: On 18/12/17 09:56, Rory

[Bug 61993] New: org.apache.tomcat.util.ByteChunk throws NegativeArray SizeException

https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 Bug ID: 61993 Summary: org.apache.tomcat.util.ByteChunk throws NegativeArray SizeException Product: Tomcat 7 Version: 7.0.82 Hardware: PC OS: Linux

buildbot success in on tomcat-8-trunk

The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/1220 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: JDK 10 entered Rampdown Phase One on 14th of December

Hi Mark, Thanks for the feedback, I'll pass it on. Rgds,Rory On 12/01/2018 10:20, Mark Thomas wrote: On 18/12/17 09:56, Rory O'Donnell wrote: *Feedback* - If you have suggestions or encounter bugs, please submit them using the usual Java SE bug-reporting channel. Be sure to include

svn commit: r1820964 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java

Author: remm Date: Fri Jan 12 11:21:41 2018 New Revision: 1820964 URL: http://svn.apache.org/viewvc?rev=1820964=rev Log: Fix remote host code with the APR connector. This issue is found only in this branch and connector. Modified:

svn commit: r1820963 - in /tomcat/trunk: java/org/apache/coyote/http2/StreamProcessor.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 12 11:19:37 2018 New Revision: 1820963 URL: http://svn.apache.org/viewvc?rev=1820963=rev Log: Fix order issue in the sendfile setup code. Modified: tomcat/trunk/java/org/apache/coyote/http2/StreamProcessor.java tomcat/trunk/webapps/docs/changelog.xml Modified:

[Bug 61992] DOS after "Error parsing HTTP request header" message

https://bz.apache.org/bugzilla/show_bug.cgi?id=61992 --- Comment #2 from Mark Thomas --- For completeness: $telnet localhost 8080 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. GET/ / HTTP/1.1 HTTP/1.1 400 Bad Request Server: Apache-Coyote/1.1

[Bug 61992] DOS after "Error parsing HTTP request header" message

https://bz.apache.org/bugzilla/show_bug.cgi?id=61992 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment

[Bug 61992] New: DOS after "Error parsing HTTP request header" message

https://bz.apache.org/bugzilla/show_bug.cgi?id=61992 Bug ID: 61992 Summary: DOS after "Error parsing HTTP request header" message Product: Tomcat 7 Version: 7.0.82 Hardware: PC OS: Linux Status: NEW

Re: JDK 10 entered Rampdown Phase One on 14th of December

On 18/12/17 09:56, Rory O'Donnell wrote: > *Feedback* - If you have suggestions or encounter bugs, please submit > them using the usual Java SE bug-reporting channel. > Be sure to include complete version information from the output of the > |java --version| command. Hi, I did some testing on

Re: Closing channel sockets

On 12/01/18 08:04, Rémy Maucherat wrote: > On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote: > >> Hi, >> >> I've been looking at how we close NIO channels and I think there is an >> opportunity for a little clean-up that, in turn, may allow a little >> de-duplication between

Re: Http11OutputBuffer mixes write strategies

On 11/01/18 23:12, Christopher Schultz wrote: > If performance is a consideration, then most of the calls to write() > should probably be calls to headerBuffer.put() because we can be > (reasonably?) sure that writing "HTTP/1.1 " to the output buffer isn't > going to overflow the buffer.

Re: Closing channel sockets

On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote: > Hi, > > I've been looking at how we close NIO channels and I think there is an > opportunity for a little clean-up that, in turn, may allow a little > de-duplication between NIO and NIO2. > > Currently, in various places in