Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 23:46 schrieb Michael Osipov: Am 2019-10-09 um 23:23 schrieb Mark Thomas: On 09/10/2019 22:03, Michael Osipov wrote: Am 2019-10-09 um 19:08 schrieb Mark Thomas: On 09/10/2019 16:58, Michael Osipov wrote: Folks, while working on an improvement for Http11Processor I have

Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 23:23 schrieb Mark Thomas: On 09/10/2019 22:03, Michael Osipov wrote: Am 2019-10-09 um 19:08 schrieb Mark Thomas: On 09/10/2019 16:58, Michael Osipov wrote: Folks, while working on an improvement for Http11Processor I have noticed there constructs: if ((contentEncodingMB

[Bug 63826] Don't deliver libtcnative and Commons Daemon tarballs with Windows releases

2019-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63826 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org

[Bug 63826] New: Don't deliver libtcnative and Commons Daemon tarballs with Windows releases

2019-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63826 Bug ID: 63826 Summary: Don't deliver libtcnative and Commons Daemon tarballs with Windows releases Product: Tomcat 8 Version: 8.5.x-trunk Hardware: All

Re: Possible bugs in Http11Processor

2019-10-09 Thread Mark Thomas
On 09/10/2019 22:03, Michael Osipov wrote: > Am 2019-10-09 um 19:08 schrieb Mark Thomas: >> On 09/10/2019 16:58, Michael Osipov wrote: >>> Folks, >>> >>> while working on an improvement for Http11Processor I have noticed there >>> constructs: >>> if ((contentEncodingMB != null)    

[Bug 63825] Http11Processor does not compare request header values for complete tokens

2019-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63825 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 63825] New: Http11Processor does not compare request header values for complete tokens

2019-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63825 Bug ID: 63825 Summary: Http11Processor does not compare request header values for complete tokens Product: Tomcat 8 Version: 8.5.x-trunk Hardware: All

Re: [PROPOSAL] Tomcat 10: Remove WebDAV

2019-10-09 Thread Mark Thomas
On 09/10/2019 21:42, Michael Osipov wrote: > Am 2019-10-09 um 21:35 schrieb Christopher Schultz: >>> The only drawback I see with the current servlet is that I cannot >>> have arbitrary paths of my context served by this servlet. It >>> serves either the entire app or nothing. That's why I have

[Bug 63824] New: Http11Processor does not compare Connection header value case-insensitively

2019-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63824 Bug ID: 63824 Summary: Http11Processor does not compare Connection header value case-insensitively Product: Tomcat 8 Version: 8.5.x-trunk Hardware: All

[Bug 63824] Http11Processor does not compare Connection header value case-insensitively

2019-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63824 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 19:08 schrieb Mark Thomas: On 09/10/2019 16:58, Michael Osipov wrote: Folks, while working on an improvement for Http11Processor I have noticed there constructs: if ((contentEncodingMB != null)    (contentEncodingMB.indexOf("gzip") != -1)) The parsing of this is much

Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-09 Thread Mark Thomas
On 09/10/2019 21:35, Michael Osipov wrote: > Am 2019-10-09 um 18:55 schrieb Mark Thomas: >> On 09/10/2019 16:48, Michael Osipov wrote: >>> and >>> Testcase: testMultipleHostHeaders took 1,385 sec FAILED expected:<...content-length]-[112[7] 1-Header-[date]-[Wed, 11 Nov 2015

Re: Unbundling Commons Daemon and tcnative

2019-10-09 Thread Mark Thomas
On 09/10/2019 21:34, Michael Osipov wrote: > Am 2019-10-09 um 19:14 schrieb Mark Thomas: >> On 09/10/2019 17:36, Michael Osipov wrote: >>> I have been wondering recently why are we bundling >>> commons-daemon-native.tar.gz and tomcat-native.tar.gz every time with a >>> new release at all? >> >>

Re: [PROPOSAL] Tomcat 10: Remove WebDAV

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 21:35 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 10/9/19 11:36, Michael Osipov wrote: Am 2019-10-07 um 16:54 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Or, since svn is HTTP, you can just use

Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 18:55 schrieb Mark Thomas: On 09/10/2019 16:48, Michael Osipov wrote: and Testcase: testMultipleHostHeaders took 1,385 sec     FAILED expected:<...content-length]-[112[7] 1-Header-[date]-[Wed, 11 Nov 2015 19:18:42 GMT] 1-HeadersEnd 1-Body-1127] 1-EndOfStream but

Re: Unbundling Commons Daemon and tcnative

2019-10-09 Thread Michael Osipov
Am 2019-10-09 um 19:14 schrieb Mark Thomas: On 09/10/2019 17:36, Michael Osipov wrote: I have been wondering recently why are we bundling commons-daemon-native.tar.gz and tomcat-native.tar.gz every time with a new release at all? Because users find it convenient to have the latest versions

svn commit: r1868199 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2019-10-09 Thread woonsan
Author: woonsan Date: Wed Oct 9 20:04:34 2019 New Revision: 1868199 URL: http://svn.apache.org/viewvc?rev=1868199=rev Log: fix sort order Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/whoweare.html URL:

Re: [PROPOSAL] Tomcat 10: Drop APR Connector

2019-10-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael On 10/9/19 11:40, Michael Osipov wrote: > Am 2019-10-07 um 16:39 schrieb Christopher Schultz: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> I recently gave a presentation on locking-down Apache Tomcat[1] >> and I

Re: [PROPOSAL] Tomcat 10: Remove WebDAV

2019-10-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Michael, On 10/9/19 11:36, Michael Osipov wrote: > Am 2019-10-07 um 16:54 schrieb Christopher Schultz: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> I recently gave a presentation on locking-down Apache Tomcat[1] >> and I

Re: Possible bugs in Http11Processor

2019-10-09 Thread Mark Thomas
On 09/10/2019 17:49, Michael Osipov wrote: > Just found another bug: >>     private static boolean isConnectionClose(MimeHeaders headers) { >>     MessageBytes connection = headers.getValue(Constants.CONNECTION); >>     if (connection == null) { >>     return false; >>     }

Re: Unbundling Commons Daemon and tcnative

2019-10-09 Thread Mark Thomas
On 09/10/2019 17:36, Michael Osipov wrote: > I have been wondering recently why are we bundling > commons-daemon-native.tar.gz and tomcat-native.tar.gz every time with a > new release at all? Because users find it convenient to have the latest versions available. > There are two scenarios where

Re: Possible bugs in Http11Processor

2019-10-09 Thread Mark Thomas
On 09/10/2019 16:58, Michael Osipov wrote: > Folks, > > while working on an improvement for Http11Processor I have noticed there > constructs: > >> if ((contentEncodingMB != null) >>    (contentEncodingMB.indexOf("gzip") != -1)) The parsing of this is much tighter on input. For output I think

Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-09 Thread Mark Thomas
On 09/10/2019 16:48, Michael Osipov wrote: > Though I see some minor failures I have not investigated yet > with > >> Testcase: testNonBlockingWriteError took 33,493 sec >>     FAILED >> Uri: /, Status: 500, Time: 33456 duration is not < 30600 >> junit.framework.AssertionFailedError: Uri:

Re: Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Just found another bug: private static boolean isConnectionClose(MimeHeaders headers) { MessageBytes connection = headers.getValue(Constants.CONNECTION); if (connection == null) { return false; } return connection.equals(Constants.CLOSE); }

Unbundling Commons Daemon and tcnative

2019-10-09 Thread Michael Osipov
Guys, I have been wondering recently why are we bundling commons-daemon-native.tar.gz and tomcat-native.tar.gz every time with a new release at all? There are two scenarios where people don't require to use it from the tarball: 1. Tomcat Native and Commons Daemon are installed through OS

[tomcat] branch master updated: Remove EL limitations

2019-10-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 6af4862 Remove EL limitations 6af4862 is

Possible bugs in Http11Processor

2019-10-09 Thread Michael Osipov
Folks, while working on an improvement for Http11Processor I have noticed there constructs: if ((contentEncodingMB != null) (contentEncodingMB.indexOf("gzip") != -1)) if (connectionValue != null) foundUpgrade = connectionValue.toLowerCase(Locale.ENGLISH).contains("upgrade");

Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-09 Thread Michael Osipov
Am 2019-10-07 um 15:58 schrieb Mark Thomas: The proposed Apache Tomcat 8.5.47 release is now available for voting. The major changes compared to the 8.5.46 release are: - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in Commons Daemon 1.2.0 and 1.2.1 that triggered a

Re: [PROPOSAL] Tomcat 10: Drop APR Connector

2019-10-09 Thread Michael Osipov
Am 2019-10-07 um 16:39 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I recently gave a presentation on locking-down Apache Tomcat[1] and I briefly discussed the "sharp edges" present in Tomcat. Some of them are unnecessarily sharp and may be actually

Re: [PROPOSAL] Tomcat 10: Remove WebDAV

2019-10-09 Thread Michael Osipov
Am 2019-10-07 um 16:54 schrieb Christopher Schultz: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, I recently gave a presentation on locking-down Apache Tomcat[1] and I briefly discussed the "sharp edges" present in Tomcat. Some of them are unnecessarily sharp and may be actually

[Bug 63820] New: Install with JDK13 is not working

2019-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63820 Bug ID: 63820 Summary: Install with JDK13 is not working Product: Tomcat 9 Version: unspecified Hardware: PC Status: NEW Severity: normal Priority: P2

Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-09 Thread Konstantin Kolinko
пн, 7 окт. 2019 г. в 14:51, Mark Thomas : > > The proposed Apache Tomcat 9.0.27 release is now available for voting. > > The major changes compared to the 9.0.26 release are: > > - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in > Commons Daemon 1.2.0 and 1.2.1 that

[tomcat] branch master updated: Use a much larger timeout to avoid false test failures

2019-10-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new b897bcb Use a much larger timeout to avoid

Re: org.apache.tomcat.jni.TestSocketServer timeout test failures (was: VOTE 9.0.27)

2019-10-09 Thread Mark Thomas
On 09/10/2019 00:51, Konstantin Kolinko wrote: > Hi! > > Splitting from "VOTE 9.0.27" thread. > > вт, 8 окт. 2019 г. в 21:00, Mark Thomas : >> >> On 08/10/2019 17:49, Mark Thomas wrote: >>> On 07/10/2019 17:40, Igal Sapir wrote: >>> >>> >>>