[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943 --- Comment #4 from George Stanchev --- According to [1] it is "x-forwarded-port" https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/x-forwarded-headers.html#x-forwarded-port -- You are receiving this mail because: You are the

Re: [VOTE] Release Apache Tomcat 9.0.29

2019-11-20 Thread Michael Osipov
Am 2019-11-16 um 19:56 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.29 release is now available for voting. The major changes compared to the 9.0.27 release are: - Improvements to Async error handling - Stricter processing of HTTP headers when looking for specific token values -

Re: [VOTE] Release Apache Tomcat 9.0.29

2019-11-20 Thread Jonathan Gallimore
[X] Stable - go ahead and release as 9.0.29 Thanks Jon On Sat, Nov 16, 2019 at 6:56 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.29 release is now available for voting. > > The major changes compared to the 9.0.27 release are: > > - Improvements to Async error handling > > -

buildbot success in on tomcat-85-trunk

2019-11-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2050 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

Using CSRF prevention filter with session-timeout workflow resumption

2019-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, The servlet spec defines the workflow for form-based authentication: if the client requests a protected resource, an authorization check is performed. If the user is unauthenticated, the login form is shown. Successful login allows the user to

[tomcat] branch 8.5.x updated (7c9a50c -> 2c5664d)

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 7c9a50c Adjust changelog to reflect which releases actually contain which improvements to the CSRF prevention

[tomcat] 02/02: Fix typpo

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/2c5664d5a4c8790bc6895a951083d40dffb6518e commit

[tomcat] 01/02: Fix test

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/b97eadb4e3126952f35de8a4b396c4ca46939d12 commit

Re: [tomcat] 04/06: Allow customization of the CSRF prevention filter's request parameter name.

2019-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, On 11/20/19 14:33, Konstantin Kolinko wrote: > ср, 20 нояб. 2019 г. в 22:20, : >> >> This is an automated email from the ASF dual-hosted git >> repository. >> >> schultz pushed a commit to branch 8.5.x in repository >>

[GitHub] [tomcat] dedovich-s commented on issue #222: EmbeddedServletOptions constructor has been refactored

2019-11-20 Thread GitBox
dedovich-s commented on issue #222: EmbeddedServletOptions constructor has been refactored URL: https://github.com/apache/tomcat/pull/222#issuecomment-556295975 yes, my original intention was to reduce the number of lines in constructor and move appropriate code to init methods

[GitHub] [tomcat] 72er-de commented on issue #222: EmbeddedServletOptions constructor has been refactored

2019-11-20 Thread GitBox
72er-de commented on issue #222: EmbeddedServletOptions constructor has been refactored URL: https://github.com/apache/tomcat/pull/222#issuecomment-556292570 I think the constructor has a lot of lines of code and the idea to extract setter could be help to read the code. So I have ordered

Re: [tomcat] 04/06: Allow customization of the CSRF prevention filter's request parameter name.

2019-11-20 Thread Konstantin Kolinko
ср, 20 нояб. 2019 г. в 22:20, : > > This is an automated email from the ASF dual-hosted git repository. > > schultz pushed a commit to branch 8.5.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > View the commit online: >

buildbot failure in on tomcat-85-trunk

2019-11-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2049 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] 05/06: Move initialization of CSRF REST nonce header name context attribute into the RestCsrfPreventionFilter where it belongs.

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/11ad208a44e31c83656e021f7ecb3c4b06962e64 commit

[tomcat] 06/06: Adjust changelog to reflect which releases actually contain which improvements to the CSRF prevention filter.

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/7c9a50c211cc8ccff1c7eac5592affa3fe84eadc commit

[tomcat] 03/06: Add missing changelog for CSRF prevention filter changes.

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/7b55938b7562fa8c6639b3abc45c88d98c09c735 commit

[tomcat] 04/06: Allow customization of the CSRF prevention filter's request parameter name.

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/856a2e2482fde9e8c8d0535942a70c2ddfc8d676 commit

[tomcat] 01/06: Add logging to CSRF prevention listener.

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/6c9bb6914cb51be13c4ae32847db579217f0cb8d commit

[tomcat] branch 8.5.x updated (402acdb -> 7c9a50c)

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 402acdb Correct the docs for maxConnections new 6c9bb69 Add logging to CSRF prevention listener. new

[tomcat] 02/06: Post-review from kkolonko: fix typo in constant name, push initialization down into subclass.

2019-11-20 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/24edf311ce6ffb5d185e96ad4b135bdff5e4af81 commit

Re: Bundling of localized messages

2019-11-20 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/19/19 07:08, Mark Thomas wrote: > > >> Is there a particular reason (a) the translations are in a >> separate JAR file - i.e. not in catalina.jar and (b) they are >> separated by language? Perhaps the thought was that, knowing that >>

Re: [tomcat] branch master updated: Correct the docs for maxConnections

2019-11-20 Thread Rémy Maucherat
On Wed, Nov 20, 2019 at 5:38 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > View the commit online: > >

[tomcat] branch 7.0.x updated: Correct the docs for maxConnections

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/39ddf279a104bcd012d997ffa041318fe4fa9959 The following

[tomcat] branch 8.5.x updated: Correct the docs for maxConnections

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/402acdb5c3099f78cca2d035ff80d69cdd5d5ab9 The following

[tomcat] branch master updated: Correct the docs for maxConnections

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/33e01c97e24e2ccbe1392a2294e77619d8983fdd The following

[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943 Mark Thomas changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943 --- Comment #2 from Peter Gierl --- It's not implemented in RemoteIpValve, only the server port information may be transported, not the remote port. So where is it present? -- You are receiving this mail because: You are the assignee for the

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-20 Thread Mark Thomas
On 20/11/2019 14:03, Konstantin Kolinko wrote: > вт, 19 нояб. 2019 г. в 19:58, Mark Thomas : >> >> On 19/11/2019 00:44, Konstantin Kolinko wrote: >>> вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : >>> >>> I think the single pollset change should not be backported to Tomcat 7. >>> I am OK with it

Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-20 Thread Konstantin Kolinko
вт, 19 нояб. 2019 г. в 19:58, Mark Thomas : > > On 19/11/2019 00:44, Konstantin Kolinko wrote: > > вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : > > > > I think the single pollset change should not be backported to Tomcat 7. > > I am OK with it being backported to Tomcat 8.5. > > In favour of

[tomcat] branch 7.0.x updated: Fix MBean description of keepAliveTimeout

2019-11-20 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/24c3b9e3ac564006754f9f6f9fe278497d2d0db4 The following

[tomcat] branch master updated: Fix MBean description of keepAliveTimeout

2019-11-20 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/d0a9dcf521d35c6a0210bea90d902235446ba680 The following

[tomcat] branch 8.5.x updated: Fix MBean description of keepAliveTimeout

2019-11-20 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/cc2e3882e5ba40850537b619aed894ec0ab4da0e The following

[tomcat] 01/05: Polish. Align with 8.5.x/9.0.x

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/34a0f1156ad88668bbbce83fadc42a69367dfb4f commit

[tomcat] 05/05: Fix a few SpotBugs issues / align with 8.5.x

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/0e3019a82e8ec0a05ce2613f6f3beb9ebda8f78c commit

[tomcat] 02/05: Refactor APR Poller to remove use of multiple pollsets

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/7e853199d4ce0db4cc173f80b39a616890b64dee commit

[tomcat] 03/05: Handle case were Poller may return an entry per event

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/4a8d1ff4f002ddf57883364fa7153e42f40393e6 commit

[tomcat] 04/05: Back-port some SpotBugs fixes and Javadoc alignment.

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/e4b3e7865e43913a32009b4de0c38179d73a74c9 commit

[tomcat] branch 7.0.x updated (e67c01b -> 0e3019a)

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from e67c01b Improve CSRF prevention filter by exposing the request's current nonce to the request. new 34a0f11

[tomcat] 01/02: Remove unused code

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/13c87becb4bf1c57cc5125604ab7ce7b66948a20 commit

[tomcat] 04/04: One missed false positive

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/85ba8b6836e07727def00c4845081eacc7f0f9c8 commit

[tomcat] branch 8.5.x updated (e92da8e -> 85ba8b6)

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from e92da8e Additional debug logging to investigate bug 63859 new 52c6412 Fix SpotBugs warnings in JDBC pool module

[tomcat] branch master updated (9d7cb54 -> 5274de1)

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 9d7cb54 Fix test new 13c87be Remove unused code new 5274de1 Alphabetical order The 2 revisions listed

[tomcat] 02/04: Fix SpotBugs warnings for unit tests

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/065c5d1ca88f00075ffc9d9b15e295ea69733f13 commit

[tomcat] 03/04: Fix SpotBugs issues in JDBC pool tests

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/c4c14207035ac95c99f7c2da1dc326e3e989efa6 commit

[tomcat] 02/02: Alphabetical order

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/5274de17b81c7e1a9e8e3ccb2bc89f71416d26ce commit

[tomcat] 01/04: Fix SpotBugs warnings in JDBC pool module

2019-11-20 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git View the commit online: https://github.com/apache/tomcat/commit/52c6412892def19fdd9a0f341f8c3f772839610d commit

[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 63943] New: Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943 Bug ID: 63943 Summary: Add possibility to overwrite remote port with information from header value Product: Tomcat 9 Version: unspecified Hardware: All