[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-09 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-689825942 @martin-g Thanks for your time on this : ) I have marked all of the conversations as resolved after the latest commits. Do we have any more feedback on this PR?

[GitHub] [tomcat] kamnani edited a comment on pull request #351: Remove White Spaces from the JSP files

2020-09-09 Thread GitBox
kamnani edited a comment on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-689824792 @martin-g @rotty3000 Thanks for your time on this : ) I have marked all of the conversations as resolved after the latest commits. Do we have any more feedback on this

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-09 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-689824792 @markt-asf @rotty3000 Thanks for your time on this : ) I have marked all of the conversations as resolved after the latest commits. Do we have any more feedback on this PR?

buildbot failure in on tomcat-trunk

2020-09-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5408 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 7.0.x updated: Fix (hopefully) intermittent test failures.

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 6f46935 Fix (hopefully) intermittent test

[tomcat] branch 8.5.x updated: Fix (hopefully) intermittent test failures.

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new baf7d8e Fix (hopefully) intermittent test

[tomcat] branch 9.0.x updated: Fix (hopefully) intermittent test failures.

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d56076f Fix (hopefully) intermittent test

[tomcat] branch master updated: Fix (hopefully) intermittent test failures.

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 53c304a Fix (hopefully) intermittent test

Re: [VOTE] Release Apache Tomcat 10.0.0-M8

2020-09-09 Thread Mark Thomas
On 09/09/2020 15:57, Mark Thomas wrote: > > The proposed 10.0.0-M8 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 10.0.0-M8 Unit tests pass for NIO, NIO2, APR/Native (with Tomcat Native 1.2.25) on Windows, Linux and OSX. Mark

[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Mark Thomas changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #15 from Mark

[tomcat] branch master updated: Increment version for next dev cycle

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4dbc475 Increment version for next dev cycle

[VOTE] Release Apache Tomcat 10.0.0-M8

2020-09-09 Thread Mark Thomas
The proposed Apache Tomcat 10.0.0-M8 release is now available for voting. Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary package for all the specification APIs has changed from javax.* to jakarta.* Applications that run on Tomcat 9 will not run on Tomcat 10 without changes.

[tomcat] branch master updated: Fix typo

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 29b09f5 Fix typo 29b09f5 is described below

[tomcat] branch 9.0.x updated: Fix typo

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new b0b2d37 Fix typo b0b2d37 is described below

[tomcat] branch 8.5.x updated: Fix typo

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9d15a7b Fix typo 9d15a7b is described below

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 --- Comment #15 from Robert Rodewald --- I found an interesting differentiation on this page: https://github.com/wildfly/wildfly/blob/master/docs/src/main/asciidoc/_elytron/Elytron_and_Java_Authentication_SPI_for_Containers-JASPI.adoc If a

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 --- Comment #14 from Robert Rodewald --- (In reply to Christopher Schultz from comment #12) > Doesn't this tie the implementation class to Tomcata internals? It would be > nice to implement a CallbackHandler which can be built (and run) >

[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Arshiya changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #13 from Arshiya --- Created attachment 37444 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37444=edit JMX file and Source Code -- You are receiving this mail because: You are the assignee for the bug.

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 --- Comment #13 from Christopher Schultz --- (In reply to Robert Rodewald from comment #9) > Slightly off topic, but could someone explain why the package imports in > CallbackHandlerImpl switched from > > import

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 --- Comment #12 from Christopher Schultz --- (In reply to Mark Thomas from comment #7) > Users may wish to use a 3rd party custom CallbackHandler that knows nothing > about Tomcat internals. A no-arg Constructor needs to be supported. > >

svn commit: r41380 - in /dev/tomcat/tomcat-10/v10.0.0-M8: ./ bin/ bin/embed/ src/

2020-09-09 Thread markt
Author: markt Date: Wed Sep 9 13:28:54 2020 New Revision: 41380 Log: Upload Apache Tomcat 10.0.0-M8 for voting Added: dev/tomcat/tomcat-10/v10.0.0-M8/ dev/tomcat/tomcat-10/v10.0.0-M8/KEYS dev/tomcat/tomcat-10/v10.0.0-M8/README.html dev/tomcat/tomcat-10/v10.0.0-M8/RELEASE-NOTES

Request for documentation improvement: changelog UI

2020-09-09 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Could someone better at CSS look into this for me? I sometimes find myself searching the changelog for some string e.g. "keystore". I generally do that by loading-up the changelog in my browser and using the browser's "Find" feature to search

[GitHub] [tomcat] tandraschko commented on a change in pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

2020-09-09 Thread GitBox
tandraschko commented on a change in pull request #355: URL: https://github.com/apache/tomcat/pull/355#discussion_r485599668 ## File path: java/jakarta/el/ELContext.java ## @@ -139,6 +140,10 @@ public void setLocale(Locale locale) { * @since EL 3.0 */ public

[GitHub] [tomcat] tandraschko commented on a change in pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

2020-09-09 Thread GitBox
tandraschko commented on a change in pull request #355: URL: https://github.com/apache/tomcat/pull/355#discussion_r485599668 ## File path: java/jakarta/el/ELContext.java ## @@ -139,6 +140,10 @@ public void setLocale(Locale locale) { * @since EL 3.0 */ public

[GitHub] [tomcat] martin-g commented on a change in pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

2020-09-09 Thread GitBox
martin-g commented on a change in pull request #355: URL: https://github.com/apache/tomcat/pull/355#discussion_r485590380 ## File path: java/jakarta/el/ELContext.java ## @@ -139,6 +140,10 @@ public void setLocale(Locale locale) { * @since EL 3.0 */ public void

[tomcat] 01/01: Tag 10.0.0-M8

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 10.0.0-M8 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b3f5e0d88336d81a61a767fc10ab06930c9587ee Author: Mark Thomas AuthorDate: Wed Sep 9 11:37:17 2020 +0100 Tag

[tomcat] tag 10.0.0-M8 created (now b3f5e0d)

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 10.0.0-M8 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at b3f5e0d (commit) This tag includes the following new commits: new b3f5e0d Tag 10.0.0-M8 The 1 revisions

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 --- Comment #11 from Robert Rodewald --- Created attachment 37440 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37440=edit Proposed patch for bug 64715 (second attempt), Tomcat 9 The Tomcat 9.0.x version of the patch. Main

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 Robert Rodewald changed: What|Removed |Added Attachment #37438|0 |1 is obsolete|

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 Robert Rodewald changed: What|Removed |Added Attachment #37438|Proposed patch for bug |Proposed patch for bug

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 --- Comment #9 from Robert Rodewald --- Slightly off topic, but could someone explain why the package imports in CallbackHandlerImpl switched from import javax.security.auth.callback.UnsupportedCallbackException; import

[GitHub] [tomcat] tandraschko opened a new pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

2020-09-09 Thread GitBox
tandraschko opened a new pull request #355: URL: https://github.com/apache/tomcat/pull/355 It would also be great if you could port it to older branches This is an automated message from the Apache Git Service. To respond to

[Bug 64715] PasswordValidationCallback not supported

2020-09-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64715 Robert Rodewald changed: What|Removed |Added Attachment #37434|0 |1 is obsolete|

[tomcat] branch 8.5.x updated: Fix intermittently failing test

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new d021d5d Fix intermittently failing test d021d5d

[tomcat] branch 9.0.x updated: Fix intermittently failing test

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ea0a200 Fix intermittently failing test ea0a200

[tomcat] branch master updated: Fix intermittently failing test

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 2348b11 Fix intermittently failing test 2348b11

[tomcat] branch 9.0.x updated: Fix intermittent failures observed running tests locally

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ae1cc8f Fix intermittent failures observed

[tomcat] branch 8.5.x updated: Fix intermittent failures observed running tests locally

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 1ebb3ff Fix intermittent failures observed

[tomcat] branch master updated: Fix intermittent failures observed running tests locally

2020-09-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new b2b72d9 Fix intermittent failures observed