Re: [tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-10 Thread Raymond Auge
missing requirement [org.apache.servicemix.bundles.spring-beans [6](R 6.0)] osgi.wiring.package; (osgi.wiring.package=jakarta.inject)] Is the jakarta.inject package exported by someone (in the framework)? I'm not sure how JIRA sets up it's OSGi runtime. Ray On Wed, Feb 10, 2021 at 11:42 AM

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Mark Thomas
On 10/02/2021 17:13, Christopher Schultz wrote: > Mark, > > On 2/9/21 16:12, Mark Thomas wrote: >> The hard part >> here is the identification of the webapp as a Java EE app. The only >> reliable way to do this is class scanning and that is slow. > > Why not look at the system id or namespace of

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Christopher Schultz
Mark, On 2/9/21 16:12, Mark Thomas wrote: The hard part here is the identification of the webapp as a Java EE app. The only reliable way to do this is class scanning and that is slow. Why not look at the system id or namespace of WEB-INF/web.xml? Anyone using the legacy Java EE will be using

[Bug 65135] New: mbeans-descriptors.xml missing attribute for parallelAnnotationScanning

2021-02-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65135 Bug ID: 65135 Summary: mbeans-descriptors.xml missing attribute for parallelAnnotationScanning Product: Tomcat 9 Version: 9.0.41 Hardware: PC OS: Linux

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Mark Thomas
On 10/02/2021 16:29, Romain Manni-Bucau wrote: > Le mer. 10 févr. 2021 à 17:15, Emmanuel Bourg a écrit : > >> Le 2021-02-10 16:36, Rémy Maucherat a écrit : >> >>> After reading everything, I'd say it's worth adding a second integrated >>> option, and think I'm now swaying towards the runtime

Re: [tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-10 Thread Mark Thomas
On 10/02/2021 10:26, Mark Thomas wrote: > I am still seeing a failure when I start Jira under Tomcat 10. I'm > currently investigating the root cause. I've fixed the simple issues and what I am left with is issues OSGi metadata. I've made some progress but hit a brick wall. Can one of the

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 17:15, Emmanuel Bourg a écrit : > Le 2021-02-10 16:36, Rémy Maucherat a écrit : > > > After reading everything, I'd say it's worth adding a second integrated > > option, and think I'm now swaying towards the runtime option. The main > > problem would be the detection of

[tomcat-jakartaee-migration] branch master updated: Add a few more default excludes

2021-02-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new ff68194 Add a few more

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Emmanuel Bourg
Le 2021-02-10 16:36, Rémy Maucherat a écrit : After reading everything, I'd say it's worth adding a second integrated option, and think I'm now swaying towards the runtime option. The main problem would be the detection of legacy webapps. We could simply mandate using an explicit new

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 16:37, Rémy Maucherat a écrit : > On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways to do

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Rémy Maucherat
On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > Hi all, > > I've been looking at the options to integrate the Java EE to Jakarta EE > migration functionality into Tomcat 10. > > There are essentially two ways to do this: deployment time and runtime. > > The simplest solution to implement is

[tomcat-jakartaee-migration] 02/02: Exclude packages from migration that are part of Java SE.

2021-02-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 5f47a4f3c731ffd9a7a28defdd16a482b651d4df Author: Mark Thomas AuthorDate: Wed Feb 10 15:11:16 2021

[tomcat-jakartaee-migration] 01/02: Update changelog

2021-02-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 3490a6bb8187d28111f410f7c1e157901b680ce8 Author: Mark Thomas AuthorDate: Wed Feb 10 10:00:54 2021

[tomcat-jakartaee-migration] branch master updated (abde81d -> 5f47a4f)

2021-02-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git. from abde81d Fix bug. Constant pool size is defined as u2 new 3490a6b Update changelog

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Martin Grigorov
On Wed, Feb 10, 2021 at 12:24 PM Mark Thomas wrote: > On 10/02/2021 09:30, Martin Grigorov wrote: > > > > > Believe me it is not that simple. > > Spring Boot Maven/Gradle plugins produce a jar file that contains other > jar > > files inside. Those jar files are not compressed for optimization

Re: [tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-10 Thread Mark Thomas
On 10/02/2021 09:56, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository > https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git > > > The following commit(s) were added to

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Mark Thomas
On 10/02/2021 09:30, Martin Grigorov wrote: > Believe me it is not that simple. > Spring Boot Maven/Gradle plugins produce a jar file that contains other jar > files inside. Those jar files are not compressed for optimization reasons > and the Jakarta EE migration tool cannot handle that

[tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-10 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new abde81d Fix bug. Constant

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Martin Grigorov
Hi Romain, On Wed, Feb 10, 2021 at 10:39 AM Romain Manni-Bucau wrote: > Le mer. 10 févr. 2021 à 09:32, Martin Grigorov a > écrit : > > > Hi, > > > > On Tue, Feb 9, 2021 at 11:12 PM Mark Thomas wrote: > > > > > Hi all, > > > > > > I've been looking at the options to integrate the Java EE to

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 09:32, Martin Grigorov a écrit : > Hi, > > On Tue, Feb 9, 2021 at 11:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Martin Grigorov
Hi, On Tue, Feb 9, 2021 at 11:12 PM Mark Thomas wrote: > Hi all, > > I've been looking at the options to integrate the Java EE to Jakarta EE > migration functionality into Tomcat 10. > > There are essentially two ways to do this: deployment time and runtime. > > The simplest solution to

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Hi, I'd go simple: 1. Add in the tool jar a ClassFileTransformer 2. Make this transformer configurable (packages using "startsWith" which is fast and optimizable - maybe something like