Re: [tomcat] branch 9.0.x updated: Fix BZ 66548 - Add validation of Sec-Websocket-Key header

2023-06-07 Thread Rainer Jung
Am 08.06.23 um 05:50 schrieb Rainer Jung: The new TestKeyHeader fails for me very frequently for TC 9 and TC 8.5, but not for 10.1 or 11. For TC 9 it fails roughly 30-50% of the times I run it. It fails for jsse and for tcnative and for a wide range of JDKs and RHEL/SLES Linux versions.

Re: [tomcat] branch 9.0.x updated: Fix BZ 66548 - Add validation of Sec-Websocket-Key header

2023-06-07 Thread Rainer Jung
The new TestKeyHeader fails for me very frequently for TC 9 and TC 8.5, but not for 10.1 or 11. For TC 9 it fails roughly 30-50% of the times I run it. It fails for jsse and for tcnative and for a wide range of JDKs and RHEL/SLES Linux versions. The failure happens only for NIO2, not for

[tomcat] branch 8.5.x updated: Align with 9.0.x/10.1.x/11.0.x

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 07647966c6 Align with 9.0.x/10.1.x/11.0.x

[tomcat] branch 8.5.x updated (81c6ff9301 -> 4fa5131599)

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 81c6ff9301 Improve error handling new 0f282b0159 Prep before applying formatter. new 4fa5131599 Code clean-up

[tomcat] 02/02: Code clean-up - formatting. No functional change.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4fa51315990cf8a8f843aa0b1f3d34bd2deb54d1 Author: Mark Thomas AuthorDate: Wed Jun 7 17:59:53 2023 +0100 Code clean-up

[tomcat] 01/02: Prep before applying formatter.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0f282b015979daf7ed1df80a6cff42559fba6382 Author: Mark Thomas AuthorDate: Wed Jun 7 17:49:29 2023 +0100 Prep before

[tomcat] branch 9.0.x updated (300a482b62 -> 475f43bd1f)

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 300a482b62 Improve error handling new fc09aea586 Prep before applying formatter. new 475f43bd1f Code clean-up

[tomcat] 02/02: Code clean-up - formatting. No functional change.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 475f43bd1f28dff33ad54be1024b529cfc32a1d3 Author: Mark Thomas AuthorDate: Wed Jun 7 17:58:00 2023 +0100 Code clean-up

[tomcat] 01/02: Prep before applying formatter.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fc09aea5860db67a486c9287c3e43ac87534556d Author: Mark Thomas AuthorDate: Wed Jun 7 17:49:29 2023 +0100 Prep before

[tomcat] branch main updated (873051516c -> c114c309a3)

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 873051516c Add Panama module for Java 21 new 7dd802cd4a Prep before applying formatter. new c114c309a3 Code

[tomcat] 02/02: Code clean-up - formatting. No functional change.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c114c309a368527d45d5c4cde210c4541802c3d7 Author: Mark Thomas AuthorDate: Wed Jun 7 17:54:00 2023 +0100 Code clean-up

[tomcat] 01/02: Prep before applying formatter.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7dd802cd4a6a9ef77e8138359f7305652d729d4b Author: Mark Thomas AuthorDate: Wed Jun 7 17:49:29 2023 +0100 Prep before

[tomcat] branch 10.1.x updated (e9b5ebf1d5 -> b93542252e)

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from e9b5ebf1d5 Improve error handling new 74124d78d8 Prep before applying formatter. new b93542252e Code

[tomcat] 01/02: Prep before applying formatter.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 74124d78d8a0bd5cdd80e4af8782b4f886f0d384 Author: Mark Thomas AuthorDate: Wed Jun 7 17:49:29 2023 +0100 Prep before

[tomcat] 02/02: Code clean-up - formatting. No functional change.

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b93542252e2feeb317dd88456ad163ba09683d48 Author: Mark Thomas AuthorDate: Wed Jun 7 17:55:35 2023 +0100 Code

[Bug 66627] Regression due to MessageBytes refactoring

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66627 --- Comment #3 from Mark Thomas --- The API is also documented not to be stable. See the section on API stability in the RELEASE-NOTES.txt file that should be at the root of every Tomcat 9 distribution. That said, I do plan to look at the

[Bug 66627] Regression due to MessageBytes refactoring

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66627 --- Comment #2 from WJCarpenter --- I agree in general with the point about calling internals, but it is, after all, a documented API. Thanks for the pointer about OpenTelemetry's fix. We'll pursue that. -- You are receiving this mail

[Bug 66627] Regression due to MessageBytes refactoring

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66627 --- Comment #1 from Mark Thomas --- The assumption in CoyoteAdater is still valid - assuming no-one is calling Tomcat internals. As soon as components start accessing Tomcat internals then all sorts of things can go wrong unless those

Re: [VOTE] Release Apache Tomcat 11.0.0-M7

2023-06-07 Thread Igal Sapir
On Fri, Jun 2, 2023 at 9:18 AM Mark Thomas wrote: > The proposed Apache Tomcat 11.0.0-M7 release is now available for > voting. > > Apache Tomcat 11.0.0-M7 is a milestone release of the 11.0.x branch and > has been made to provide users with early access to the new features in > Apache Tomcat

Re: [VOTE] Release Apache Tomcat 8.5.90

2023-06-07 Thread Igal Sapir
On Fri, Jun 2, 2023 at 11:08 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > The proposed Apache Tomcat 8.5.90 release is now available for voting. > > The notable changes compared to 8.5.89 are: > > - Add support for virtual threads. (Java 21+ only) > > - Update HTTP/2 to use the

[Bug 66631] Consider moving module-info.class to META-INF/versions/9

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66631 --- Comment #3 from Michael Osipov --- I have raised https://github.com/bndtools/bnd/issues/5687. Let's see what they say. A workaround is to unpack JARs, move the class and repack :-( -- You are receiving this mail because: You are the

[Bug 66631] Consider moving module-info.class to META-INF/versions/9

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66631 --- Comment #2 from Michael Osipov --- (In reply to Mark Thomas from comment #1) > Yes, this applies to most of the Tomcat 9 JARs. > > Tomcat uses BND to insert the module-info.class file. > > A review of the BND documentation and source

[Bug 66631] Consider moving module-info.class to META-INF/versions/9

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66631 --- Comment #1 from Mark Thomas --- Yes, this applies to most of the Tomcat 9 JARs. Tomcat uses BND to insert the module-info.class file. A review of the BND documentation and source code indicates the location of the file is hard coded (so

[Bug 66631] Consider moving module-info.class to META-INF/versions/9

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66631 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 66631] New: Consider moving module-info.class to META-INF/versions/9

2023-06-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66631 Bug ID: 66631 Summary: Consider moving module-info.class to META-INF/versions/9 Product: Tomcat 9 Version: 9.0.75 Hardware: All OS: All

Re: confirm subscribe to dev@tomcat.apache.org

2023-06-07 Thread Christopher Schultz
Koti, On 6/7/23 08:22, koteswara Rao Gundapaneni wrote: Please change my email address to koti.gundapan...@tomcat.apache.org 1. Send an unsubscribe from koti.gundapan...@gmail.com 2. You can't have koti.gundapan...@tomcat.apache.org 3. Maybe subscribe from koti.gundapaneni+tom...@gmail.com?

[tomcat] branch 8.5.x updated: Improve error handling

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 81c6ff9301 Improve error handling 81c6ff9301 is

[tomcat] branch 9.0.x updated: Improve error handling

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 300a482b62 Improve error handling 300a482b62 is

[tomcat] branch 10.1.x updated: Improve error handling

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new e9b5ebf1d5 Improve error handling e9b5ebf1d5 is

[tomcat] branch main updated: Improve error handling

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a2c34d6569 Improve error handling a2c34d6569 is

Re: confirm subscribe to dev@tomcat.apache.org

2023-06-07 Thread koteswara Rao Gundapaneni
Please change my email address to koti.gundapan...@tomcat.apache.org Regards Koti On Fri, 28 Apr 2023, 14:19 , wrote: > Hi! This is the ezmlm program. I'm managing the > dev@tomcat.apache.org mailing list. > > I'm working for my owner, who can be reached > at

[tomcat] branch 8.5.x updated: Fix symlink edge case

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 5b44a238cf Fix symlink edge case 5b44a238cf is

[tomcat] branch 9.0.x updated: Fix symlink edge case

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ba089ab465 Fix symlink edge case ba089ab465 is

[tomcat] branch 10.1.x updated: Fix symlink edge case

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new b5069d405b Fix symlink edge case b5069d405b is

[tomcat] branch main updated: Fix symlink edge case

2023-06-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 9390a1e936 Fix symlink edge case 9390a1e936 is