[VOTE] Release Apache Standard Taglib 1.2.1

2013-11-13 Thread Jeremy Boynes
I'd like to release Apache Standard Taglib 1.2.1. This is an update to the withdrawn 1.2.0, built with JDK 1.7.0_45 to address JavaDoc issues and incorporating feedback on the documentation. Maven Staging Repository: https://repository.apache.org/content/repositories/orgapachetomcat-132/ Source

TldLocation

2013-11-13 Thread Jeremy Boynes
On Nov 12, 2013, at 8:53 AM, Mark Thomas wrote: > On 12/11/2013 15:27, Jeremy Boynes wrote: >> On Nov 12, 2013, at 5:00 AM, ma...@apache.org wrote: >> >>> Author: markt Date: Tue Nov 12 13:00:03 2013 New Revision: >>> 1541041 >>> >>&g

[WITHDRAWN] [VOTE] Release Apache Tomcat Standard Taglib 1.2.0

2013-11-12 Thread Jeremy Boynes
On Nov 10, 2013, at 11:47 AM, Rainer Jung wrote: > On 10.11.2013 00:56, Jeremy Boynes wrote: >> I'd like to release Apache Tomcat Standard Taglib 1.2.0. >> >> This would be the first release in many years, and the first release of an >> implementation o

Re: svn commit: r1541041 - in /tomcat/trunk/java/org/apache/jasper: ./ compiler/ resources/ servlet/

2013-11-12 Thread Jeremy Boynes
On Nov 12, 2013, at 5:00 AM, ma...@apache.org wrote: > Author: markt > Date: Tue Nov 12 13:00:03 2013 > New Revision: 1541041 > > URL: http://svn.apache.org/r1541041 > Log: > Replace TldLocationsCache with the new TldCache that also caches the contents > of the TLDs. This is the next step in the

Re: [VOTE] Release Apache Tomcat Standard Taglib 1.2.0

2013-11-10 Thread Jeremy Boynes
On Nov 10, 2013, at 11:47 AM, Rainer Jung wrote: > On 10.11.2013 00:56, Jeremy Boynes wrote: >> I'd like to release Apache Tomcat Standard Taglib 1.2.0. >> >> This would be the first release in many years, and the first release of an >> implementation o

Re: [VOTE] Release Apache Tomcat Standard Taglib 1.2.0

2013-11-10 Thread Jeremy Boynes
On Nov 9, 2013, at 3:56 PM Jeremy Boynes wrote: > I'd like to release Apache Tomcat Standard Taglib 1.2.0. > > The proposed 1.2.0 release is" > [ ] Broken - do not release > [X] OK - release as 1.2.0 (non-binding) RAT report looked OK. JSTL 1.2 TCK passed (ru

[VOTE] Release Apache Tomcat Standard Taglib 1.2.0

2013-11-09 Thread Jeremy Boynes
I'd like to release Apache Tomcat Standard Taglib 1.2.0. This would be the first release in many years, and the first release of an implementation of JSTL 1.2. Maven Staging Repository: https://repository.apache.org/content/repositories/orgapachetomcat-110 Source Distribution: https://repositor

Release taglibs 1.2.0?

2013-11-07 Thread Jeremy Boynes
I believe I have addressed all the issues raised during the vote for 1.2.0-RC1 so I am planning on tagging 1.2.0 soon (hopefully this weekend). If any has any other issues before then please speak up :) Thanks Jeremy signature.asc Description: Message signed with OpenPGP using GPGMail

Re: Subject: Questions on Jasper's BodyContentImpl, bug #43925, and proposed solution

2013-11-05 Thread Jeremy Boynes
On Nov 1, 2013, at 6:23 AM, Scott Severtson wrote: > All, > > We've noticed that our Tomcat 6.0.37 instances have increasing overhead the > longer they stay up. We've captured some heap dumps, expecting to find memory > leaks within our code, but found something different instead. > > Jasper

LATER vs WONTFIX, was: [Bug 55249] JspC compiles tag files even if compile options is false

2013-10-10 Thread Jeremy Boynes
On Oct 10, 2013, at 12:46 PM, Mark Thomas wrote: > On 10/10/2013 20:40, Jeremy Boynes wrote: >> On Oct 10, 2013, at 7:48 AM, bugzi...@apache.org wrote: >> >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55249 >>> >>> Mark

Re: jasper changes for 8.0: genStringAsCharArray

2013-10-10 Thread Jeremy Boynes
On Oct 9, 2013, at 3:11 AM, Pavel Cibulka wrote: > Hello, both jetty and glassfish have genStringAsByteArray set to "true" by > default. Would it be possible to change this in jasper? I know > that genStringAsByteArray is not implemented yet, what about > making genStringAsCharArray default "true

Re: [Bug 55249] JspC compiles tag files even if compile options is false

2013-10-10 Thread Jeremy Boynes
On Oct 10, 2013, at 7:48 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55249 > > Mark Thomas changed: > > What|Removed |Added > > Stat

Re: [ANN] New committer: Konstantin Preißer

2013-09-26 Thread Jeremy Boynes
On Sep 24, 2013, at 3:20 PM, Mark Thomas wrote: > On behalf of the Tomcat committers I am pleased to announce that > Konstantin Preißer has been voted in as a new Tomcat committer. > > In addition to a number of high quality bug reports and patches, > Konstantin is also responsible for the makeo

Re: SCI discovery ordering

2013-09-22 Thread Jeremy Boynes
On Sep 22, 2013, at 10:55 AM, Jeremy Boynes wrote: > On Sep 22, 2013, at 1:44 AM, Mark Thomas wrote: > >> On 22/09/2013 00:27, Jeremy Boynes wrote: >> >>> As a concrete example of how this impacts the behaviour, consider the case >>> where the applicati

Re: SCI discovery ordering

2013-09-22 Thread Jeremy Boynes
On Sep 22, 2013, at 1:44 AM, Mark Thomas wrote: > On 22/09/2013 00:27, Jeremy Boynes wrote: > >> As a concrete example of how this impacts the behaviour, consider the case >> where the application includes its own JSP engine. With the RI's delegation >> model, t

SERVLET_SPEC-79, was: SCI discovery ordering

2013-09-21 Thread Jeremy Boynes
On Sep 20, 2013, at 2:43 PM, Nick Williams wrote: > > On Sep 20, 2013, at 4:33 PM, Jeremy Boynes wrote: > >> On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas wrote: >> >>> On 20/09/2013 16:02, Jeremy Boynes wrote: >>>> The only ordering con

Re: SCI discovery ordering

2013-09-21 Thread Jeremy Boynes
On Sep 20, 2013, at 8:50 AM, Mark Thomas wrote: > On 20/09/2013 16:02, Jeremy Boynes wrote: >> The only ordering concern for SCIs in the spec is that they are >> "discovered" following the classloader delegation model. This will >> typically be configured to

Re: SCI discovery ordering

2013-09-20 Thread Jeremy Boynes
On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas wrote: > On 20/09/2013 16:02, Jeremy Boynes wrote: > > The only ordering concern for SCIs in the spec is that they are > > "discovered" following the classloader delegation model. This will > > typically be configured to

Re: SCI discovery ordering

2013-09-20 Thread Jeremy Boynes
On Sep 20, 2013, at 12:38 AM, Mark Thomas wrote: > On 20/09/2013 06:11, Jeremy Boynes wrote: >> On Sep 19, 2013, at 8:31 AM, Jeremy Boynes wrote: >> >>> On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: >>> >>>> Author: markt >>>>

Re: SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Sep 19, 2013, at 8:31 AM, Jeremy Boynes wrote: > On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: > >> Author: markt >> Date: Thu Sep 19 13:07:02 2013 >> New Revision: 1524727 >> >> URL: http://svn.apache.org/r1524727 >> Log: >> Always l

Re: SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Thu, Sep 19, 2013 at 11:28 AM, Mark Thomas wrote: > On 19/09/2013 17:39, Nick Williams wrote: > > > > On Sep 19, 2013, at 11:32 AM, Jeremy Boynes wrote: > > > > >> There's a clear model already without assumptions about SCI > >> ordering:

Re: SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Sep 19, 2013, at 8:36 AM, Mark Thomas wrote: > On 19/09/2013 16:31, Jeremy Boynes wrote: >> On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: >> >>> Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: >>> 1524727 >>> >>> U

SCI discovery ordering

2013-09-19 Thread Jeremy Boynes
On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Sep 19 13:07:02 2013 > New Revision: 1524727 > > URL: http://svn.apache.org/r1524727 > Log: > Always load container SCIs first This seems at odds with the requirement that "the order in which these services are dis

Re: Issues in Apache Taglibs 1.2.0-RC1

2013-09-18 Thread Jeremy Boynes
On Sep 15, 2013, at 4:49 PM, sebb wrote: > On 14 September 2013 17:09, Jeremy Boynes wrote: >> >> I think addressed those issues in the following changes: >> http://svn.apache.org/r1512150 >> http://svn.apache.org/r1512151 >> http://svn.apache.org/r1512153

Re: [Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

2013-09-17 Thread Jeremy Boynes
On Sep 17, 2013, at 11:10 PM, Violeta Georgieva wrote: > Hi Jeremy, > > 2013/9/13 >> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55508 >> >> Jeremy Boynes changed: >> >>

Issues in Apache Taglibs 1.2.0-RC1

2013-09-14 Thread Jeremy Boynes
On Aug 7, 2013, at 4:41 AM, sebb wrote: > On 2 August 2013 20:32, Jeremy Boynes wrote: >> A proposed release candidate Apache Taglibs 1.2.0-RC1 is now available for >> voting. >> >> This is release candidate for an implementation of JSTL 1.2 and can be >>

[RESULT] Release Apache Taglibs 1.2.0-RC1

2013-09-14 Thread Jeremy Boynes
On Aug 2, 2013, at 12:32 PM, Jeremy Boynes wrote: > A proposed release candidate Apache Taglibs 1.2.0-RC1 is now available for > voting. > > This is release candidate for an implementation of JSTL 1.2 and can be > obtained from the staging repo at: > https://repository.

Re: Jasper improvements - web resources and TLDs

2013-08-21 Thread Jeremy Boynes
On Aug 12, 2013, at 8:40 AM, Mark Thomas wrote: > On 12/08/2013 16:20, Jeremy Boynes wrote: > > I'm wondering about adding enableWebSockets() and enableJSPs() methods > to Tomcat which would automatically add the relevant SCI to any Context > created via one of the add

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Jeremy Boynes
On Aug 20, 2013, at 7:42 AM, Nick Williams wrote: > > Well, yea. I had figured that part out. :-) I just didn't articulate my > question well enough. > > The first step is obviously loading the class through the WACL through the > unit test (so this has to be a class not already loaded). I as

Re: Code style rules: Line length

2013-08-14 Thread Jeremy Boynes
On Aug 14, 2013, at 3:41 AM, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK w

Re: svn commit: r1513714 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/startup/TldConfig.java webapps/do

2013-08-14 Thread Jeremy Boynes
On Aug 14, 2013, at 12:58 AM, Mark Thomas wrote: > On 14/08/2013 03:20, jboy...@apache.org wrote: >> Author: jboynes >> Date: Wed Aug 14 02:20:02 2013 >> New Revision: 1513714 >> >> URL: http://svn.apache.org/r1513714 >> Log: >> Deprecate TldConfig and TLD-related properties of Context as they h

Back-port JSP/TLD changes to 7.0.x?, was: svn commit: r1513007 ...

2013-08-12 Thread Jeremy Boynes
On Aug 12, 2013, at 12:33 PM, Christopher Schultz wrote: > Jeremy, > > Will you be back-porting any of this to Tomcat 7? Or is the idea that so > many things will be changing that it's unfair to surprise Tomcat 7 users > with these changes? As is, I think this would be too big a change for a 7

Re: svn commit: r1512148 - in /tomcat/trunk: java/org/apache/tomcat/util/descriptor/tld/ test/org/apache/tomcat/util/descriptor/tld/

2013-08-12 Thread Jeremy Boynes
On Aug 12, 2013, at 8:16 AM, Mark Thomas wrote: > On 09/08/2013 07:21, jboy...@apache.org wrote: >> Author: jboynes >> Date: Fri Aug 9 06:21:56 2013 >> New Revision: 1512148 >> >> URL: http://svn.apache.org/r1512148 >> Log: >> Start adding model for loading complete TLDs using Digester. >> This

Re: Jasper improvements - web resources and TLDs

2013-08-12 Thread Jeremy Boynes
On Aug 12, 2013, at 7:46 AM, Mark Thomas wrote: > On 10/08/2013 23:20, Jeremy Boynes wrote: >> On Jul 22, 2013, at 10:10 AM, Mark Thomas wrote: >> >>> On 21/07/2013 18:36, Jeremy Boynes wrote: >>> ... >>>> In the meantime, I'm going to loo

Re: buildbot exception in ASF Buildbot on tomcat-trunk

2013-08-11 Thread Jeremy Boynes
On Aug 10, 2013, at 2:59 PM, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/4807 > > Buildbot URL: http://ci.apache.org/ > > Buildsla

Re: Jasper improvements - web resources and TLDs

2013-08-10 Thread Jeremy Boynes
On Jul 22, 2013, at 10:10 AM, Mark Thomas wrote: > On 21/07/2013 18:36, Jeremy Boynes wrote: > ... >> In the meantime, I'm going to look at refactoring the TLD support as >> described above. > > Nice. See my note about TLD processing in the TOMCAT-NEXT.txt file

Re: svn commit: r1511501 - in /tomcat/trunk: conf/logging.properties java/org/apache/juli/FileHandler.java webapps/docs/changelog.xml

2013-08-10 Thread Jeremy Boynes
On Aug 7, 2013, at 2:14 PM, ma...@apache.org wrote: > Author: markt > Date: Wed Aug 7 21:14:55 2013 > New Revision: 1511501 > > URL: http://svn.apache.org/r1511501 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52092 > Switch to the AsyncLogWriter and OneLineFormatter by default

[taglibs] Examples and doc

2013-08-09 Thread Jeremy Boynes
On Aug 6, 2013, at 10:13 PM, Henri Yandell wrote: > Slowly digging into this. Thus far I've confirmed the source builds :) > > Next up is working out how to deploy the examples. Wondering here if it would be better to release the examples separately as they can be decoupled. IOW, we would expe

Re: Code style rules: Line length

2013-08-08 Thread Jeremy Boynes
On Aug 8, 2013, at 10:50 AM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line

Re: Use (or not) of @SuppressWarnings

2013-08-07 Thread Jeremy Boynes
On Aug 7, 2013, at 12:41 AM, Mark Thomas wrote: > For trunk we have been running a policy of zero warnings in the code. > This has helped to highlight issues as code is edited as any warnings > are immediately clear. Obviously, this depends on what warnings are enabled. > > Currently, we use Ecl

Re: Possibly spurious warning in 8.0.0-RC1: Unknown servlet level "2.3"

2013-08-06 Thread Jeremy Boynes
On Tue, Aug 6, 2013 at 1:06 PM, Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > I just launched my primary webapp in an 8.0.0-RC1 and saw this message: > > Aug 06, 2013 3:48:13 PM org.apache.tomcat.util.descriptor.web.WebXml > setVersion > WARNING: Unknown version string [2.3

Re: svn commit: r1510310 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java

2013-08-04 Thread Jeremy Boynes
On Aug 4, 2013, at 11:55 AM, jboy...@apache.org wrote: > Author: jboynes > Date: Sun Aug 4 18:55:04 2013 > New Revision: 1510310 > > URL: http://svn.apache.org/r1510310 This may also have broken a clean build which I didn't catch as my IDE had copied service-config.txt to the output for me. I'

Re: svn commit: r1510210 - /tomcat/trunk/build.xml

2013-08-04 Thread Jeremy Boynes
On Aug 4, 2013, at 12:27 PM, Mark Thomas wrote: > On 04/08/2013 21:02, Jeremy Boynes wrote: >> On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: >>> Log: >>> Treat javax.servlet.ServletContainerInitializer files as text in source >>> >>>

Re: svn commit: r1510210 - /tomcat/trunk/build.xml

2013-08-04 Thread Jeremy Boynes
On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: > Log: > Treat javax.servlet.ServletContainerInitializer files as text in source > > > + > Would this work to catch all service config files not just SCIs? signature.asc Description: Message signed with OpenPGP using G

Re: svn commit: r1510282 - in /tomcat/trunk: java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappServiceLoader.java test/org/apache/catalina/startup/se

2013-08-04 Thread Jeremy Boynes
On Aug 4, 2013, at 11:32 AM, Mark Thomas wrote: > On 04/08/2013 20:00, jboy...@apache.org wrote: >> Author: jboynes >> Date: Sun Aug 4 18:00:40 2013 >> New Revision: 1510282 >> >> URL: http://svn.apache.org/r1510282 >> Log: >> Tests for WebappServiceLoader (requires EasyMock) > > Please fix th

Re: Using a mock framework for testing?

2013-08-04 Thread Jeremy Boynes
On Jul 31, 2013, at 10:21 AM, Mark Thomas wrote: > On 31/07/2013 18:09, Jeremy Boynes wrote: >> Any objection to adding a dependency on a mocking framework to aid unit >> testing? >> The one I have used most is EasyMock which is Apache License 2.0. > > To save repe

[VOTE] Release Apache Taglibs 1.2.0-RC1

2013-08-02 Thread Jeremy Boynes
A proposed release candidate Apache Taglibs 1.2.0-RC1 is now available for voting. This is release candidate for an implementation of JSTL 1.2 and can be obtained from the staging repo at: https://repository.apache.org/content/repositories/orgapachetomcat-053/ The source distribution can be o

Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-02 Thread Jeremy Boynes
On Aug 1, 2013, at 1:53 PM, Mark Thomas wrote: > [X ] Alpha - go ahead and release as 8.0.0-RC1 alpha Ran JSTL TCK. -- Jeremy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...

Using a mock framework for testing?

2013-07-31 Thread Jeremy Boynes
Any objection to adding a dependency on a mocking framework to aid unit testing? The one I have used most is EasyMock which is Apache License 2.0. Cheers Jeremy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For add

Re: svn commit: r1507870 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappSe

2013-07-31 Thread Jeremy Boynes
On Jul 31, 2013, at 8:08 AM, Jeremy Boynes wrote: > On Jul 31, 2013, at 7:31 AM, Mark Thomas wrote: > >> On 29/07/2013 20:48, Mark Thomas wrote: >>> On 29/07/2013 01:01, jboy...@apache.org wrote: >>>> Author: jboynes >>>> Date: Sun Jul 28 23:01:23 2

Re: svn commit: r1507870 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappSe

2013-07-31 Thread Jeremy Boynes
On Jul 31, 2013, at 7:31 AM, Mark Thomas wrote: > On 29/07/2013 20:48, Mark Thomas wrote: >> On 29/07/2013 01:01, jboy...@apache.org wrote: >>> Author: jboynes >>> Date: Sun Jul 28 23:01:23 2013 >>> New Revision: 1507870 >>> >>> URL: http://svn.apache.org/r1507870 >>> Log: >>> Fix for https://is

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Jeremy Boynes
On Mon, Jul 29, 2013 at 2:08 PM, Mark Thomas wrote: > On 29/07/2013 22:56, Nick Williams wrote: > > > > On Jul 29, 2013, at 3:53 PM, Jeremy Boynes wrote: > > > >> This is what lies under the syntactic sugar, and causes no warnings in > >> javac or IDEA (and

Re: svn commit: r1507870 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappSe

2013-07-29 Thread Jeremy Boynes
On Mon, Jul 29, 2013 at 9:51 AM, Mark Thomas wrote: > On 29/07/2013 01:01, jboy...@apache.org wrote: > > Author: jboynes > > Date: Sun Jul 28 23:01:23 2013 > > New Revision: 1507870 > > > > URL: http://svn.apache.org/r1507870 > > Generally, line lengths should be limited to 80 characters. I know

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Jeremy Boynes
Thomas wrote: > On 29/07/2013 21:04, Nick Williams wrote: > > On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote: > > > >> This flags as a warning for me in IDEA without the suppression. Isn't > this > >> an unchecked cast (Object to List)? > > It is an

Re: svn commit: r1508171 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java

2013-07-29 Thread Jeremy Boynes
This flags as a warning for me in IDEA without the suppression. Isn't this an unchecked cast (Object to List)? On Mon, Jul 29, 2013 at 11:38 AM, wrote: > Author: markt > Date: Mon Jul 29 18:38:08 2013 > New Revision: 1508171 > > URL: http://svn.apache.org/r1508171 > Log: > Remove unnecessary @S

Re: svn commit: r1507874 - /tomcat/trunk/test/org/apache/jasper/servlet/TestJasperInitializer.java

2013-07-29 Thread Jeremy Boynes
On Mon, Jul 29, 2013 at 10:19 AM, Mark Thomas wrote: > > Looking forward to the point where we use an SCI for JSPs, we don't want > to / shouldn't have to do this for every test that uses JSPs. > > addWebapp() is the interface that provides the settings from the default > web.xml and should be ju

Re: Can anyone provide history for something in JspC?

2013-07-22 Thread Jeremy Boynes
On Jul 22, 2013, at 11:22 AM, Mark Thomas wrote: > On 22/07/2013 19:09, Jeremy Boynes wrote: >> This snippet from initClassLoader() >>>// What is this ?? >>>urls.add(new File( >>>clctxt.getRealPath("/")

Can anyone provide history for something in JspC?

2013-07-22 Thread Jeremy Boynes
This snippet from initClassLoader() > // What is this ?? > urls.add(new File( > clctxt.getRealPath("/")).getCanonicalFile().toURI().toURL()); http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?view=markup#l1505 It's in the original import int

Confused on ServletContainerInitializer discovery

2013-07-21 Thread Jeremy Boynes
I'm confused by the spec saying: > Implementations of the ServletContainerInitializer interface will be > discovered by the runtime's service lookup mechanism or a container specific > mechanism that is semantically equivalent to it. In either case, > ServletContainerInitializer services from we

Re: Jasper improvements - web resources and TLDs

2013-07-21 Thread Jeremy Boynes
On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote: > On 08/07/2013 06:38, Jeremy Boynes wrote: >> >> Another area of convergence is in parsing TLDs: currently both >> Catalina and Jasper do it, differently. > > A lot of the code is identical with large comments to keep t

Re: [Bug 55259] Unnecessary work in JspConfig

2013-07-16 Thread Jeremy Boynes
On Jul 16, 2013, at 10:27 AM, Christopher Schultz wrote: > Jeremy, > > On 7/13/13 6:11 PM, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 >> >> Jeremy Boynes changed: >> >> What

Committing, was: [Bug 55259] Unnecessary work in JspConfig

2013-07-13 Thread Jeremy Boynes
On Jul 13, 2013, at 2:43 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 > > --- Comment #2 from Mark Thomas --- > Jeremy, > > Although you were originally granted commit karma due to your taglibs work, > you > have the necessary karma to commit to any

Re: [Bug 55245] Add test cases for JspC

2013-07-12 Thread Jeremy Boynes
On Jul 12, 2013, at 1:46 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55245 > > --- Comment #3 from Mark Thomas --- > It is worth noting that this new test case fails and that this is expected as > it highlights at least one bug (bug 55250) in the refactore

Bugzilla component for Tomcat-Utils?

2013-07-09 Thread Jeremy Boynes
Is it worth adding one for tomcat-util to be distinct from Catalina and Jasper? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Jasper improvements/XML handling

2013-07-08 Thread Jeremy Boynes
On Jul 8, 2013, at 2:32 PM, Mark Thomas wrote: > On 08/07/2013 16:02, Jeremy Boynes wrote: >> On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote: >>> On 08/07/2013 06:38, Jeremy Boynes wrote: >> ... >>> >>>> I'm planning on merging these two patc

Re: Jasper improvements/XML handling

2013-07-08 Thread Jeremy Boynes
On Jul 8, 2013, at 12:23 AM, Mark Thomas wrote: > On 08/07/2013 06:38, Jeremy Boynes wrote: ... > >> I'm planning on merging these two patches and pressing on with a >> converged solution, but probably won't be able to do much until next >> weekend. > &g

Re: Jasper improvements/XML handling

2013-07-07 Thread Jeremy Boynes
On Jun 25, 2013, at 10:44 PM, Jeremy Boynes wrote: > I have been thinking about improvements to Jasper as well around better > support for Servlet 3.0 concepts. One area would be decoupling it from > Tomcat, bootstrapping using an SCI as hinted in ContextConfig. I'd also be &

Re: [taglibs] Site plans

2013-07-06 Thread Jeremy Boynes
On Jul 6, 2013, at 5:32 PM, Henri Yandell wrote: > On Tue, Jul 2, 2013 at 8:43 PM, Jeremy Boynes wrote: > On Jul 2, 2013, at 9:41 AM, Henri Yandell wrote: >>> >>> I wouldn't expect to deploy the site from tags - a site is a live/current >>> thing. >&g

Re: svn commit: r1500062 - bug55198.jsp

2013-07-06 Thread Jeremy Boynes
On Jul 6, 2013, at 1:00 PM, Mark Thomas wrote: > On 05/07/2013 23:10, Jeremy Boynes wrote: >> On Jul 5, 2013, at 9:33 AM, ma...@apache.org wrote: >>> +http://java.sun.com/JSP/Page"; version="2.0"> >>> + >>> + >>> + foo >>>

Re: svn commit: r1500062 - bug55198.jsp

2013-07-05 Thread Jeremy Boynes
On Jul 5, 2013, at 9:33 AM, ma...@apache.org wrote: > +http://java.sun.com/JSP/Page"; version="2.0"> > + > + > + foo > + bar > + > + > + I believe, strictly, can't have a sub-element like . Wouldn't the test case still hold if the was removed?

Re: [taglibs] Site plans

2013-07-02 Thread Jeremy Boynes
On Jul 2, 2013, at 9:41 AM, Henri Yandell wrote: > > I wouldn't expect to deploy the site from tags - a site is a live/current > thing. The core site is a live/current thing, but there is also the documentation/reports etc. that would be associated with a specific tag. IOW, the site could cont

Re: Jasper improvements

2013-06-26 Thread Jeremy Boynes
On Jun 26, 2013, at 12:58 PM, Christopher Schultz wrote: > On 6/26/13 2:57 PM, Jeremy Boynes wrote: >> >> You wrote in the bug that "annotation's don't make sense" - could you >> clarify that? > > Yes: I was thinking that generating classes t

Re: Jasper improvements

2013-06-26 Thread Jeremy Boynes
On Jun 26, 2013, at 12:10 PM, Nick Williams wrote: > > On Jun 26, 2013, at 1:57 PM, Jeremy Boynes wrote: > >> On Jun 26, 2013, at 7:49 AM, Christopher Schultz >> wrote: >> >>> Jeremy, >>> >>> On 6/26/13 1:44 AM, Jeremy Boynes

Re: Jasper improvements

2013-06-26 Thread Jeremy Boynes
On Jun 26, 2013, at 7:49 AM, Christopher Schultz wrote: > Jeremy, > > On 6/26/13 1:44 AM, Jeremy Boynes wrote: >> On Jun 11, 2013, at 1:50 PM, Nick Williams >> wrote: >>> >>> Okay. One of many reasons I ask is that I still have it on my to-do >>&g

Re: [taglibs] Site plans

2013-06-25 Thread Jeremy Boynes
On Jun 25, 2013, at 7:54 AM, Henri Yandell wrote: > Help much appreciated - but do we want all the content of all the modules > to be there? > > It feels to me that the website does not map directly to the codebase. We > want an overall site, and subsites for Standard and for RDC. We don't want

Jasper improvements, was: Timeline for beginning EL 3.0 implementation?

2013-06-25 Thread Jeremy Boynes
On Jun 11, 2013, at 1:50 PM, Nick Williams wrote: > > Okay. One of many reasons I ask is that I still have it on my to-do to make > some improvements on the JSP compiler to support things like 1) precompiling > all JSPs on deploy and 2) a better Ant task. I don't know how much the EL > change

SNAPSHOT of taglibs standard 1.2 updated - call for testing

2013-06-22 Thread Jeremy Boynes
In anticipation of a release of standard 1.2, I have deployed a new version to Apache's snapshot Maven repository: http://repository.apache.org/snapshots/ I have run this version through the TCK and it passes but have not had a chance to test it against real-world applications. I'd like to ma

Re: [Bug 55102] New: Add ability to report time taken to prepare response

2013-06-20 Thread Jeremy Boynes
On Jun 15, 2013, at 10:09 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55102 > Summary: Add ability to report time taken to prepare response > > Created attachment 30438 > --> https://issues.apache.org/bugzilla/attachment.cgi?id=30438&action=edit

Release Taglibs 1.2?

2013-06-15 Thread Jeremy Boynes
After a recent post on taglibs-user a couple of people have pinged me off-list expressing interest in an actual released version. I'd like to go ahead with that if no-one sees any issues. The code is ready, with no non-blocking issues and has previously passed the TCK. I will update my TCK setu

Re: and security constraints

2013-04-22 Thread Jeremy Boynes
On Apr 21, 2013, at 11:37 PM, David Jencks wrote: > On Apr 21, 2013, at 3:56 PM, Jeremy Boynes wrote: > >> On Apr 19, 2013, at 11:04 PM, David Jencks wrote: >>> IMO you have misinterpreted roles in the ee specs. The specs including the >>> servlet spec define

Re: and security constraints

2013-04-21 Thread Jeremy Boynes
On Apr 19, 2013, at 11:04 PM, David Jencks wrote: > IMO you have misinterpreted roles in the ee specs. The specs including the > servlet spec define application roles and base the declarative security > constraints on them. Then you can map strings that bits of the application > like, at leas

Re: Time for Taglibs to be sent to the archive?

2013-02-10 Thread Jeremy Boynes
On Jan 29, 2013, at 11:56 PM, Jeremy Boynes wrote: ... > > My interpretation was that a product must pass the TCK in all its > configurations. In other words, you can't claim compatibility on Java7 unless > you've tested on Java7. If we test on Java7 and pass, we can claim

[taglibs] TCK update

2013-02-02 Thread Jeremy Boynes
On Jan 29, 2013, at 11:56 PM, Jeremy Boynes wrote: > On Jan 28, 2013, at 3:46 AM, Mark Thomas wrote: > On 26/01/2013 21:51, Henri Yandell wrote: ... >> >> I've just checked the latest version of the TCK documentation for JSTL >> 1.2 and while the TCK has been updated

Re: Time for Taglibs to be sent to the archive?

2013-01-29 Thread Jeremy Boynes
On Jan 28, 2013, at 3:46 AM, Mark Thomas wrote: > On 26/01/2013 21:51, Henri Yandell wrote: >> On Fri, Jan 18, 2013 at 8:30 AM, Jeremy Boynes wrote: >>> On Jan 18, 2013, at 1:34 AM, Konstantin Kolinko wrote: >>> >>> There is also an issue with the I18N t

Re: [RESULT] [VOTE] Release Apache Tomcat 7.0.35

2013-01-18 Thread Jeremy Boynes
On Wed, Jan 16, 2013 at 1:41 AM, Mark Thomas wrote: > Votes were as follows: > > +1 (binding): kkolinko, rjung, yoavs, olamy, markt > > No other votes were cast. > > The vote therefore passes. > > I'll publish the binaries and announce later today once the mirrors have > caught up. Given the regr

Re: Time for Taglibs to be sent to the archive?

2013-01-18 Thread Jeremy Boynes
On Jan 18, 2013, at 1:34 AM, Konstantin Kolinko wrote: > Regarding the two taglibs that are not yet in the attic, I have no > interest in "RDC" taglib, but I am interested in JSTL one. +1 > > I think once we make the first release, things should go easier after that. > > A few notes after quic

Re: Time for Taglibs to be sent to the archive?

2012-11-26 Thread Jeremy Boynes
+0 It's perhaps not surprising that there is not much activity as there has been no update to the JSR in many years. The JSTL code in trunk does pass the 1.2 TCK and could be released if someone had the energy to fix the website and rustle up votes. On Oct 13, 2012, at 10:58 AM, Henri Yandell

Taglibs build #2 failed due to Hudson error

2012-03-30 Thread Jeremy Boynes
From the log: https://builds.apache.org/job/taglib-standard/2/consoleText Parsing POMs ERROR: Failed to parse POMs hudson.util.IOException2: remote file operation failed: /home/jenkins/jenkins-slave/workspace/taglib-standard at hudson.remoting.Channel@1c4071a9:ubuntu3 at hudson.FilePath.

[RESULT] Release Apache Taglibs Parent POM 3

2012-03-29 Thread Jeremy Boynes
WIth binding +1's from olamy, fhanik and mturk and my non-binding +1, I call the vote passed and will deploy the staged artefacts. Thanks Jeremy On Mar 29, 2012, at 4:55 AM, Mladen Turk wrote: > +1 > > Signatures and generic content OK > > On 03/26/2012 07:01 AM, Jeremy

Re: Jenkins configuration

2012-03-29 Thread Jeremy Boynes
On Mar 29, 2012, at 8:22 AM, Olivier Lamy wrote: > 2012/3/29 Jeremy Boynes : ... >> However, we are also getting errors about the effective path of parent files >> which I believe is caused because the aggregating pom in trunks is not >> actually the parent of the modules

Re: Jenkins configuration

2012-03-28 Thread Jeremy Boynes
would also remove the aggregator stub trunks. On Mar 26, 2012, at 10:37 PM, Olivier Lamy wrote: > I setup the build on Jenkins long ago. > Do you need some configuration change ? > > -- > Olivier > Le 27 mars 2012 03:38, "Jeremy Boynes" a écrit : > >> Thank

Re: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Jeremy Boynes
My non-binding +1 but one more PMC vote is needed please. Thanks Jeremy On Mar 28, 2012, at 8:35 AM, Filip Hanik (mailing lists) wrote: > > >> -Original Message----- >> From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy >> Boynes >> Sent: Wed

Re: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Jeremy Boynes
Request for more votes please, we only have one binding vote so far. Thanks Jeremy On Mar 27, 2012, at 12:35 PM, Olivier Lamy wrote: > +1 > > 2012/3/26 Jeremy Boynes : >> The proposed 3 release of Apache Taglibs Parent POM is now available for >> voting. >> >&

Re: Jenkins permissions

2012-03-26 Thread Jeremy Boynes
Thanks, request sent to Mladen as per that page. Do we know who set this up? On Mar 26, 2012, at 12:30 PM, Olivier Lamy wrote: > Hello, > See http://wiki.apache.org/general/Jenkins#How_do_I_get_an_account > > > > 2012/3/26 Jeremy Boynes : >> Who controls permission

Jenkins permissions

2012-03-26 Thread Jeremy Boynes
Who controls permissions in Jenkins (builds.a.o)? Please can you grant me build rights for Taglibs-All? Thanks Jeremy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.

[VOTE] Release Apache Taglibs Parent POM 3

2012-03-25 Thread Jeremy Boynes
The proposed 3 release of Apache Taglibs Parent POM is now available for voting. This release addresses issues found during the 1 release process including duplicate LICENSE files and poor site configuration, and updates the copyright date in the NOTICE file from release 2 (withdrawn). The Mave

[WITHDRAWN] Release Apache Taglibs Parent POM 2

2012-03-25 Thread Jeremy Boynes
Withdrawing this to fix date in NOTICE. On Mar 24, 2012, at 8:09 AM, sebb wrote: > On 24 March 2012 14:45, Jeremy Boynes wrote: >> The proposed 2 release of Apache Taglibs Parent POM is now available for >> voting. >> >> This release addresses issues found d

[VOTE] Release Apache Taglibs Parent POM 2

2012-03-24 Thread Jeremy Boynes
The proposed 2 release of Apache Taglibs Parent POM is now available for voting. This release addresses issues found during the 1 release process including duplicate LICENSE files and poor site configuration. The Maven staging repo is: https://repository.apache.org/content/repositories/orgapache

Fwd: Taglibs-All - Build # 15 - Fixed

2012-03-18 Thread Jeremy Boynes
:) Begin forwarded message: > From: Apache Jenkins Server > Subject: Taglibs-All - Build # 15 - Fixed > Date: March 18, 2012 4:07:11 PM PDT > To: jboy...@gmail.com > > The Apache Jenkins build system has built Taglibs-All (build #15) > > Status: Fixed > > Check console output at https://build

Taglibs-all Jenkins build

2012-03-18 Thread Jeremy Boynes
On Mar 18, 2012, at 3:33 PM, Jeremy Boynes wrote: > On Mar 18, 2012, at 10:42 AM, Konstantin Kolinko wrote: > >> 2012/3/18 Jeremy Boynes : >>> Since this release, I've updated the parent pom to move all the site >>> information into the site module. I p

<    1   2   3   >