2013/8/12 Mark Thomas wrote:
>
>
> I'm wondering about adding enableWebSockets() and enableJSPs() methods
> to Tomcat which would automatically add the relevant SCI to any Context
> created via one of the addContext(...) methods. Thoughts?
>
+1
2013/8/20 Nick Williams wrote:
>
> I'm working on implementing bugzilla 55317. It's a pretty important
change (weaving) to a pretty import class (WebappClassLoader), so it
obviously needs some unit tests. However, I need some guidance:
>
> 1) I've never gotten all the existing tests to pass on my m
2013/8/7 Mark Thomas wrote:
>
> On 07/08/2013 06:19, Konstantin Kolinko wrote:
> > 2013/8/6 Mark Thomas :
>
> >> Feel free to make as much or as little use of this:
> >> http://wiki.apache.org/tomcat/ReleaseProcess
> >>
> >> If anything isn't clear, let me know.
> >
> > The following is missing:
>
2013/8/14 Mark Thomas wrote:
>
> Summarising the response to this thread so far:
>
> There is a preference for not strictly enforcing whatever limit is
> selected. Rules need exceptions and committers can exercise judgement.
> It does create a grey area but the majority is OK with that.
>
> There i
2013/8/1 Mark Thomas wrote:
>
> All,
>
> Continuing the roughly monthly release cycle for 7.0.x, it is the start
> of a new month and time for another release.
>
> The open 7.0.x bugs have been fixed so 7.0.x/trunk should be in a
> suitable state for tagging.
>
> I'd like to free up some more time
2013/8/1 Mark Thomas wrote:
>
> The proposed Apache Tomcat 8.0.0 release candidate 1 is now available
> for voting.
>
> Given this is a release candidate I am working on the basis that it is
> equivalent to an alpha. That said:
> - Servlet 3.1 is complete
> - JSP 2.3 is complete
> - EL 3.0 is compl
2013/7/18 Mark Thomas wrote:
>
> I think we are at the point where we could do a 8.0.0-alpha release. The
> specs (Servlet 3.1, JSP 2.3, EL 3.0, WebSocket 1.0) are all implemented.
> There is still work to do to review the EG disucssions that covered
> various edge cases / things not in the spec to
Hi,
I tried to test the different o.a.el.stream.Optional methods.
Again I used one of our tests and modify
it: (o.a.el.stream.TestCollectionOperations.testAverage03())
[].stream().average().orElseGet(()->64)
I received:
javax.el.ELException: Cannot convert 64 of type class java.lang.Long to
2013/7/19 Mark Thomas wrote:
>
> I was pleasantly surprised how little code change was required to get
> this to work. That gives me confidence that the overall architecture is
> correct and that what we are fixing here are effectively corner cases.
>
Great job!
Hi,
While I was playing with collections I decided to change a bit one of our
tests (o.a.el.stream.TestCollectionOperations.testMaxLambda01()) and
instead of
beans.stream().max((x,y)->x.name.compareTo(y.name))
I made it like this:
comparison = v->(x,y)->v(x).compareTo(v(y))
beans.stream().max(
2013/7/18 Mark Thomas wrote:
>
> On 18/07/2013 08:00, Violeta Georgieva wrote:
> > Hi,
> >
> > Let's have a lambda expression:
> >
> > x->y->x-y
> >
> > Let's now assign it and invoke it indirectly:
> >
> > f = x-&
Hi,
Let's have a lambda expression:
x->y->x-y
Let's now assign it and invoke it indirectly:
f = x->y->x-y; f(2)(1)
>From the spec we have:
"If the result of evaluating the function name is a LambdaExpression, the
LambdaExpression is invoked with the supplied arguments. If the result of
evalua
2013/7/17 Mark Thomas wrote:
>
> On 17/07/2013 12:43, Mark Thomas wrote:
> > Violeta Georgieva wrote:
> >
> >> Having the example from the test:
> >> (x->y->x-y)(2)(1)
> >>
> >> We may transform it like this:
> >&g
2013/7/16
>
> Author: markt
> Date: Tue Jul 16 20:01:47 2013
> New Revision: 1503857
>
> URL: http://svn.apache.org/r1503857
> Log:
> Fix handling of nested lambda expressions with method parameters.
>
> Removed:
>
tomcat/trunk/java/org/apache/el/parser/AstLambdaExpressionOrInvocation.java
> Modif
2013/7/16 Mark Thomas wrote:
>
> On 16/07/2013 09:02, Violeta Georgieva wrote:
> > 2013/7/15
>
>
>
> >> +public class AstLambdaExpressionOrInvocation extends SimpleNode {
> >> +
> >> +public AstLambdaExpress
2013/7/15
>
> Author: markt
> Date: Sun Jul 14 21:07:26 2013
> New Revision: 1503056
>
> URL: http://svn.apache.org/r1503056
> Log:
> Start to implement the lambda expression syntax. Very basic expressions
work. I expect further changes to be required for more complex expressions.
> Includes the i
2013/7/11 Mark Thomas wrote:
>
> On 11/07/2013 13:49, Violeta Georgieva wrote:
> > Hi,
> >
> > I have the following question about:
> >
> > 1. Method setValue
> > There is some mismatch in the javadoc. In the method description there
is
> > the foll
2013/7/11 Konstantin Kolinko wrote:
>
> 2013/7/11 Violeta Georgieva :
> > Hi,
> >
> > I have the following question about:
> >
> > 1. Method setValue
> > There is some mismatch in the javadoc. In the method description there
is
> > the following sta
Hi,
I have the following question about:
1. Method setValue
There is some mismatch in the javadoc. In the method description there is
the following statement:
"If the property exists but does not have a setter, then a
PropertyNotFoundException is thrown."
But the throws clause states:
"Propert
2013/7/10 Konstantin Kolinko wrote:
>
> 2013/7/10 Violeta Georgieva :
> > Hi,
> >
> > In the javadoc it is not described that the method throws IAE when the
> > property cannot be coerced into an integer. Moreover it is specified
that
> > the prop
Hi,
In the javadoc it is not described that the method throws IAE when the
property cannot be coerced into an integer. Moreover it is specified that
the property will be ignored by the resolver:
"
property - The index of the element in the list to return the acceptable
type for. Will be coerced i
2013/7/10 Mark Thomas wrote:
>
> No. Firstly because "if" is not exclusive. Secondly because the
> remainder of the returns definition states that the return value is
> undefined if propertyResolved is false.
>
> Another way of looking at it is that there is no language that requires
> a return val
2013/7/10 Mark Thomas wrote:
>
> On 10/07/2013 12:11, violet...@apache.org wrote:
> > Author: violetagg
> > Date: Wed Jul 10 11:11:23 2013
> > New Revision: 1501719
> >
> > URL: http://svn.apache.org/r1501719
> > Log:
> > javax.el.ResourceBundleELResolver:
> > According to javadoc:
> > 1. When crea
2013/7/9 Konstantin Kolinko wrote:
>
> 2013/7/9 :
> > The Buildbot has detected a new failure on builder tomcat-trunk while
building ASF Buildbot.
> > Full details are available at:
> > http://ci.apache.org/builders/tomcat-trunk/builds/4625
> >
> > Buildbot URL: http://ci.apache.org/
> >
> > Buil
2013/7/8 Mark Thomas wrote:
>
> On 08/07/2013 06:38, Jeremy Boynes wrote:
> > On Jun 25, 2013, at 10:44 PM, Jeremy Boynes
> > wrote:
>
> > Jasper's descriptor parser (used for web.xml and TLDs) can only
> > validate DTD-based documents. I opened 55212 about adding it. Such a
> > fix could benefit
2013/7/2 Mark Thomas wrote:
>
> The proposed Apache Tomcat 7.0.42 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.42/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-098
Hi Mark,
2013/6/11 Mark Thomas wrote:
>
> On 11/06/2013 21:29, Nick Williams wrote:
>>
>> I was looking through EE 7 and the changes to trunk in the last six
>> months or so and realized that no work had yet been done to implement
>> EL 3.0. Does anyone know what the anticipated timeline is for
>>
2013/6/20
>
> Author: markt
> Date: Thu Jun 20 10:38:49 2013
> New Revision: 1494915
>
> URL: http://svn.apache.org/r1494915
> Log:
> Servlet 3.1 Implement the new deny-uncovered-http-methods element in
server.xml
>
That's for the xml but what about annotations?
We are processing them when loadin
Hi,
According to Servlet Spec 3.1 final javadoc:
javax.servlet.http.HttpServletRequest.upgrade(Class) throws IOException,
ServletException
javax.servlet.http.HttpServletRequestWrapper.upgrade(Class) throws
IOException, ServletException
In our Servlet APIs these methods throw only IOException.
W
2013/6/14 Mark Thomas wrote:
>
> On 14/06/2013 07:00, Violeta Georgieva wrote:
>>
>>
>> Is that mean that if I have AsyncListener that does some work in
>> onComplete() then I will not be able to use the request and response
>> objects?
>
>
> Yes and n
2013/6/12
>
> Author: markt
> Date: Wed Jun 12 18:31:30 2013
> New Revision: 1492331
>
> URL: http://svn.apache.org/r1492331
> Log:
> With clarification from the EG for Servlet 3.1 section 4.4 finally makes
sense. Implement the necessary restriction and add a test case.
>
I think that we should
2013/6/11
>
> Author: markt
> Date: Tue Jun 11 20:18:10 2013
> New Revision: 1491940
>
> URL: http://svn.apache.org/r1491940
> Log:
> Servlet 3.1 requires an ISE if getRequest() or getResponse() are called
after complete() or dispatch()
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/cor
2013/6/6 Mark Thomas wrote:
>
> The proposed Apache Tomcat 7.0.41 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-073
2013/5/31 Violeta Georgieva wrote:
>
> 2013/5/29 Violeta Georgieva wrote:
> >
> > 2013/5/28 Konstantin Kolinko wrote:
> > >
> > >
> > > I think that your patch is wrong.
> > >
> > > Looking at how ActionCode.ASYNC_DISPATCH is handle
2013/5/29 Violeta Georgieva wrote:
>
> 2013/5/28 Konstantin Kolinko wrote:
> >
> >
> > I think that your patch is wrong.
> >
> > Looking at how ActionCode.ASYNC_DISPATCH is handled in different
> > connector implementations in Tomcat 7, the code is
2013/5/28 Konstantin Kolinko wrote:
>
>
> I think that your patch is wrong.
>
> Looking at how ActionCode.ASYNC_DISPATCH is handled in different
> connector implementations in Tomcat 7, the code is like the following:
>
> if (asyncStateMachine.asyncDispatch()) {
> ((AprE
Hi,
In the AsyncContext.dispatch(path) javadoc we have:
"There can be at most one asynchronous dispatch operation per asynchronous
cycle, which is started by a call to one of the
ServletRequest.startAsync()methods.
Any attempt to perform an additional asynchronous dispatch
operation within the sa
2013/5/25 Mark Thomas wrote:
>
> On 25/05/2013 08:04, Violeta Georgieva wrote:
> > 2013/5/25 Mark Thomas wrote:
> >>
> >> On 24/05/2013 21:58, violet...@apache.org wrote:
> >>> Author: violetagg
> >>> Date: Fri May 24 20:58:10 2013
> >>
2013/5/25 Mark Thomas wrote:
>
> On 24/05/2013 21:58, violet...@apache.org wrote:
> > Author: violetagg
> > Date: Fri May 24 20:58:10 2013
> > New Revision: 1486217
> >
> > URL: http://svn.apache.org/r1486217
> > Log:
> > Temporary disable the test check.
>
> Why?
Because it was passing successful
2013/5/5 Mark Thomas
>
> The proposed Apache Tomcat 7.0.40 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-001/
> Th
2013/4/19 Mark Thomas wrote:
>
> On 19/04/2013 15:49, Mark Thomas wrote:
> > Should the changes described in [1] be applied to the Tomcat wiki?
> > [X] +1 Make it so
> > [ ] 0 No opinion
> > [ ] -1 I object to this proposed change because...
>
+1
Hi Rainer,
2013/4/16 Rainer Jung
>
> Hi Violeta,
>
> On 16.04.2013 22:15, violet...@apache.org wrote:
> > Author: violetagg
> > Date: Tue Apr 16 20:15:28 2013
> > New Revision: 1468594
> >
> > URL: http://svn.apache.org/r1468594
> > Log:
> > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id
2013/4/10 Ralph Plawetzki wrote:
>
> I am looking for the Tomcat 8 sources and can't find them. I searched
> the SVN and googled. The only thing I could find was the doc web page
> for Tomcat 8.
>
> Are the sources for Tomcat 8 already publicly available?
>
http://tomcat.apache.org/svn.html
/trun
2013/3/22 Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.39 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.39/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-015/
2013/3/21 Mark Thomas wrote:
> On 21/03/2013 13:28, Violeta Georgieva wrote:
>> Hi,
>>
>> Test org.apache.catalina.connector.TestMaxConnections FAILED
>>
>> I cannot reproduce this failure neither on Windows nor on MAC.
>>
>> Can somebody help me
Hi,
Test org.apache.catalina.connector.TestMaxConnections FAILED
I cannot reproduce this failure neither on Windows nor on MAC.
Can somebody help me to understand what's happening with this test?
Thanks
Violeta
2013/3/21 :
> The Buildbot has detected a new failure on builder tomcat-7-trunk wh
2013/3/20 Mark Thomas wrote:
> On 20/03/2013 13:55, Violeta Georgieva wrote:
>> Hi,
>>
>> I have a question for the loader that is used in
>> o.a.t.util.scan.StandardJarScanner.scan(ServletContext, ClassLoader,
>> JarScannerCallback, Set) (7.0.x trunk).
>>
Hi,
I have a question for the loader that is used in
o.a.t.util.scan.StandardJarScanner.scan(ServletContext, ClassLoader,
JarScannerCallback, Set) (7.0.x trunk).
Why don't we use the loader that is provided as a method parameter,
but instead of this we are using the thread context class loader?
2013/3/20 Ognjen Blagojevic wrote:
> Hi,
>
> http://tomcat.apache.org/tomcat-7.0-doc/config/http.html
>
> "restrictedUserAgents" -> "The value is a regular expression (using
> java.util.regex) *matching matching* ..."
Thank you for the report.
The fixed documentation will be available with the nex
2013/3/14 Mark Thomas wrote:
> Given the issues reported with the 7.0.38 tag I'm leaning towards
> cancelling the 7.0.38 vote, fixing the known issues and rolling 7.0.39.
>
> In addition to the issues in Bugzilla the only other issue was the
> UEncoder problem Violeta found. (Any chance of a test c
2013/3/13 Mark Thomas wrote:
> On 13/03/2013 18:10, violet...@apache.org wrote:
>> Author: violetagg
>> Date: Wed Mar 13 18:10:45 2013
>> New Revision: 1456068
>>
>> URL: http://svn.apache.org/r1456068
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54684
>> Added 'javax.naming.sp
I found another problem. It appears when running a web application
from an archive (unpackWARs=false)
Mar 14, 2013 12:01:10 AM org.apache.catalina.startup.ContextConfig
processAnnotationsJndi
SEVERE: Unable to process resource element
[jndi:/localhost/test/WEB-INF/classes/test/servlet/servletTestS
2013/3/8 Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.38 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.38/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-002/
2013/2/13 Mark Thomas :
> The proposed Apache Tomcat 7.0.37 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.37/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-227/
> Th
Hi,
I would like to work on this enhancement request [1].
What do you think? Is it Ok to provide implementation for it in Tomcat 7?
Thanks
Violeta
[1] https://issues.apache.org/bugzilla/show_bug.cgi?id=51526
-
To unsubscribe, e
2013/2/5 Konstantin Kolinko
>
> > Could you test on some other XP.
> > I've tested 7.0.36 on Win7/x64 and XPSP3/x86 and everything works fine
> > Tried to restart dozen times at different stages and everything work
> fine.
>
>
I also tested it onWin7/x64 and Win Server 2003/x64 and everything wor
Hi,
2013/1/20 Williams, Nick
> So, will Tomcat 8 be targeted for EE 7, or will it wait until JSP-next
> comes out, even if that takes a good deal longer than EE 7?
>
> Also, I know that a lot depends on the timeline of EE 7, but now that that
> date is approaching, do we have a GENERAL timeframe
Thanks
2013/1/3 Mark Thomas
> On 03/01/2013 14:30, Violeta Georgieva wrote:
>
> > I think that when the filter name is NULL the proper behaviour is to
> return
> > IllegalArgumentException.
> > From other point of view the method's javadoc specifies on
>
> From which git repository? I couldn't find that commit ID in the ASF git
> repo for Tomcat trunk nor the GitHub mirror.
Ok I understood where the missunderstanding is.
That repo (in my github profile) is my own git-to-svn repo and is not a
fork from the one available in github.
Having my own
Hi Mark,
> OK. First question. How did you create your git repo? I am trying to add
> your repo as a remote repo to my own but there are no common ancestors.
> I think I can hack around this but I'd like to understand how it
> happened in the first place.
>
I'm using "git svn".
The last rebase th
forward to your comments.
Regards
Violeta Georgieva
2012/9/11 Mark Thomas
>
>
> Violeta Georgieva wrote:
>
> >It would be very useful if I can provide this as part of the build
> >infrastructure for example.
> >If you can give me a hint from where to start I may try
901 - 961 of 961 matches
Mail list logo