Re: Code style rules: Line length

2013-08-16 Thread Olivier Lamy
On 14 August 2013 20:41, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with tha

Re: Code style rules: Line length

2013-08-16 Thread Konstantin Kolinko
2013/8/14 Mark Thomas : > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with that. > > There is a mix

Re: Code style rules: Line length

2013-08-15 Thread Violeta Georgieva
2013/8/14 Mark Thomas wrote: > > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with that. > > There i

Re: Code style rules: Line length

2013-08-15 Thread Christopher Schultz
Mark, On 8/14/13 6:41 AM, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with t

Re: Code style rules: Line length

2013-08-15 Thread Rainer Jung
On 14.08.2013 12:41, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with that. >

Re: Code style rules: Line length

2013-08-14 Thread Jeremy Boynes
On Aug 14, 2013, at 3:41 AM, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK w

Re: Code style rules: Line length

2013-08-14 Thread Mark Thomas
Summarising the response to this thread so far: There is a preference for not strictly enforcing whatever limit is selected. Rules need exceptions and committers can exercise judgement. It does create a grey area but the majority is OK with that. There is a mix of views on line length but there a

Re: Code style rules: Line length

2013-08-09 Thread Tim Funk
My opinion only (since I've been pretty inactive lately ... only enough time to lurk) I'm a big fan of long method/class names and 80 character width drives me nuts - unless your IDE is a phone - 80 is not very wide. 100 many times is just enough extra space to limit a lot of wrapping. (preferred

Re: Code style rules: Line length

2013-08-08 Thread Jeremy Boynes
On Aug 8, 2013, at 10:50 AM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line

Re: Code style rules: Line length

2013-08-08 Thread Christopher Schultz
Mark, On 8/8/13 1:50 PM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line leng

Re: Code style rules: Line length

2013-08-08 Thread Konstantin Kolinko
2013/8/8 Mark Thomas : > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > Changing @SuppressWarnings had its technical reasons. I do not see much reasons to reconsider code forma

Re: Code style rules: Line length

2013-08-08 Thread Nick Williams
On Aug 8, 2013, at 12:50 PM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line

Code style rules: Line length

2013-08-08 Thread Mark Thomas
Currently, Tomcat has an 'guide' of a maximum of 80 characters for line length. It has been a while since we reviewed this and as we are looking at style rules... As a starting point what do folks think of the following options: Line length: 80 - the current 100 - 120 - Strictness Informal - th