Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-29 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy et al, On 10/25/18 11:54, Rémy Maucherat wrote: > On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> Bump. >> >> I have a full

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-26 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Keiichi, On 10/26/18 01:01, Keiichi Fujino wrote: > Hi Chris! > > Because the argument svc is basically passed the value of > SND_RX_SEQ (1) | Channel.SND_TX_SEQ (2) | MBR_RX_SEQ (4) | > MBR_TX_SEQ (8), so you need to fix the following in start

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Keiichi Fujino
Hi Chris! Because the argument svc is basically passed the value of SND_RX_SEQ (1) | Channel.SND_TX_SEQ (2) | MBR_RX_SEQ (4) | MBR_TX_SEQ (8), so you need to fix the following in start method. == if(Channel.SND_TX_SEQ == svc) -> if (Channel.SND_TX_SEQ == (svc & Channel.SND_TX_SEQ)) == In order

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/25/18 11:54, Rémy Maucherat wrote: > On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 >> >> All, >> >> Bump. >> >> I have a full patch

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Rémy Maucherat
On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > Bump. > > I have a full patch at this point (still without documentation), but > this one includes resolution of the IV issue and also a set

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Bump. I have a full patch at this point (still without documentation), but this one includes resolution of the IV issue and also a set of unit tests which pass. I'd appreciate it if someone could install this into their cluster and see if it

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 10/23/18 10:05, Christopher Schultz wrote: > Can I get a technical review for (a) appropriateness and (b) > technical implementation of the attached cluster interceptor? Let's > assume for a moment that encryption is something worth adding

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Filip, On 10/23/18 12:19, Filip Hanik wrote: > On Tue, Oct 23, 2018 at 7:05 AM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > All, > > Can I get a technical review for (a) appropriateness and (b) > technical implementation of

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-23 Thread Mark Thomas
On 23/10/2018 18:19, Filip Hanik wrote: On Tue, Oct 23, 2018 at 7:05 AM Christopher Schultz < ch...@christopherschultz.net> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Can I get a technical review for (a) appropriateness and (b) technical implementation of the attached

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-23 Thread Filip Hanik
On Tue, Oct 23, 2018 at 7:05 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > Can I get a technical review for (a) appropriateness and (b) technical > implementation of the attached cluster interceptor? Let's assume for

For review: EncryptInterceptor for Cluster/Tribes

2018-10-23 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Can I get a technical review for (a) appropriateness and (b) technical implementation of the attached cluster interceptor? Let's assume for a moment that encryption is something worth adding to clustering and not argue that point. It should