Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Mark Thomas
On 10/02/2021 17:13, Christopher Schultz wrote: > Mark, > > On 2/9/21 16:12, Mark Thomas wrote: >> The hard part >> here is the identification of the webapp as a Java EE app. The only >> reliable way to do this is class scanning and that is slow. > > Why not look at the system id or namespace of

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Christopher Schultz
Mark, On 2/9/21 16:12, Mark Thomas wrote: The hard part here is the identification of the webapp as a Java EE app. The only reliable way to do this is class scanning and that is slow. Why not look at the system id or namespace of WEB-INF/web.xml? Anyone using the legacy Java EE will be using

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Mark Thomas
On 10/02/2021 16:29, Romain Manni-Bucau wrote: > Le mer. 10 févr. 2021 à 17:15, Emmanuel Bourg a écrit : > >> Le 2021-02-10 16:36, Rémy Maucherat a écrit : >> >>> After reading everything, I'd say it's worth adding a second integrated >>> option, and think I'm now swaying towards the runtime

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 17:15, Emmanuel Bourg a écrit : > Le 2021-02-10 16:36, Rémy Maucherat a écrit : > > > After reading everything, I'd say it's worth adding a second integrated > > option, and think I'm now swaying towards the runtime option. The main > > problem would be the detection of

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Emmanuel Bourg
Le 2021-02-10 16:36, Rémy Maucherat a écrit : After reading everything, I'd say it's worth adding a second integrated option, and think I'm now swaying towards the runtime option. The main problem would be the detection of legacy webapps. We could simply mandate using an explicit new

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 16:37, Rémy Maucherat a écrit : > On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways to do

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Rémy Maucherat
On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > Hi all, > > I've been looking at the options to integrate the Java EE to Jakarta EE > migration functionality into Tomcat 10. > > There are essentially two ways to do this: deployment time and runtime. > > The simplest solution to implement is

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Martin Grigorov
On Wed, Feb 10, 2021 at 12:24 PM Mark Thomas wrote: > On 10/02/2021 09:30, Martin Grigorov wrote: > > > > > Believe me it is not that simple. > > Spring Boot Maven/Gradle plugins produce a jar file that contains other > jar > > files inside. Those jar files are not compressed for optimization

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Mark Thomas
On 10/02/2021 09:30, Martin Grigorov wrote: > Believe me it is not that simple. > Spring Boot Maven/Gradle plugins produce a jar file that contains other jar > files inside. Those jar files are not compressed for optimization reasons > and the Jakarta EE migration tool cannot handle that

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Martin Grigorov
Hi Romain, On Wed, Feb 10, 2021 at 10:39 AM Romain Manni-Bucau wrote: > Le mer. 10 févr. 2021 à 09:32, Martin Grigorov a > écrit : > > > Hi, > > > > On Tue, Feb 9, 2021 at 11:12 PM Mark Thomas wrote: > > > > > Hi all, > > > > > > I've been looking at the options to integrate the Java EE to

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Le mer. 10 févr. 2021 à 09:32, Martin Grigorov a écrit : > Hi, > > On Tue, Feb 9, 2021 at 11:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Martin Grigorov
Hi, On Tue, Feb 9, 2021 at 11:12 PM Mark Thomas wrote: > Hi all, > > I've been looking at the options to integrate the Java EE to Jakarta EE > migration functionality into Tomcat 10. > > There are essentially two ways to do this: deployment time and runtime. > > The simplest solution to

Re: Integrating migration tool into Tomcat 10

2021-02-10 Thread Romain Manni-Bucau
Hi, I'd go simple: 1. Add in the tool jar a ClassFileTransformer 2. Make this transformer configurable (packages using "startsWith" which is fast and optimizable - maybe something like

Re: Integrating migration tool into Tomcat 10

2021-02-09 Thread Emmanuel Bourg
Le 2021-02-09 22:12, Mark Thomas a écrit : Thoughts? I think this feature is really desirable. For the Debian packaging this would mean a faster transition to Tomcat 10. There are two issues: 1. How to identify a legacy application? 2. How to convert the application once identified? For

Re: Integrating migration tool into Tomcat 10

2021-02-09 Thread Filip Hanik
On Tue, Feb 9, 2021 at 14:34 Rémy Maucherat wrote: > On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > > > Hi all, > > > > I've been looking at the options to integrate the Java EE to Jakarta EE > > migration functionality into Tomcat 10. > > > > There are essentially two ways to do this:

Re: Integrating migration tool into Tomcat 10

2021-02-09 Thread Rémy Maucherat
On Tue, Feb 9, 2021 at 10:12 PM Mark Thomas wrote: > Hi all, > > I've been looking at the options to integrate the Java EE to Jakarta EE > migration functionality into Tomcat 10. > > There are essentially two ways to do this: deployment time and runtime. > > The simplest solution to implement is

Integrating migration tool into Tomcat 10

2021-02-09 Thread Mark Thomas
Hi all, I've been looking at the options to integrate the Java EE to Jakarta EE migration functionality into Tomcat 10. There are essentially two ways to do this: deployment time and runtime. The simplest solution to implement is probably a separate webapps-legacy directory (or some other name)