Re: Need Guidance

2017-10-02 Thread Coty Sutherland
On Mon, Oct 2, 2017 at 8:27 AM, Amitesh Pathak wrote: > Hi all > I subscribed to the tomcat dev mailing list sometime ago to help me getting > to start contributing, but haven't figured out how to start yet. Hello and welcome! > Can I please get a mentor to guide me

Need Guidance

2017-10-02 Thread Amitesh Pathak
Hi all I subscribed to the tomcat dev mailing list sometime ago to help me getting to start contributing, but haven't figured out how to start yet. Can I please get a mentor to guide me through and help me start developing for the projects. Any help will be really appreciated. Thanks,

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Jeremy Boynes
On Aug 20, 2013, at 7:42 AM, Nick Williams nicho...@nicholaswilliams.net wrote: Well, yea. I had figured that part out. :-) I just didn't articulate my question well enough. The first step is obviously loading the class through the WACL through the unit test (so this has to be a class

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Mark Thomas
On 21/08/2013 01:24, Nick Williams wrote: My backup idea is slightly less clean but, IMO, still more clean than adding ASM as a test-time dependency and trying to figure all of that out. I locally compiled fake weaved versions of the UnweavedClass (with the modified behavior) and then

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 2:58 AM, Mark Thomas wrote: On 21/08/2013 01:24, Nick Williams wrote: My backup idea is slightly less clean but, IMO, still more clean than adding ASM as a test-time dependency and trying to figure all of that out. I locally compiled fake weaved versions of the

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Christopher Schultz
Nick, On 8/20/13 8:24 PM, Nick Williams wrote: I ran in to a roadblock with this idea. Part of the byte code of a class includes the fully-qualified class name. If I create a class, say UnweavedClass, and replace its byte code in my fake transformer with that of another class, the FQCN

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread sebb
On 21 August 2013 14:48, Christopher Schultz ch...@christopherschultz.net wrote: Nick, On 8/20/13 8:24 PM, Nick Williams wrote: I ran in to a roadblock with this idea. Part of the byte code of a class includes the fully-qualified class name. If I create a class, say UnweavedClass, and

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Christopher Schultz
Sebb, On 8/21/13 1:46 PM, sebb wrote: On 21 August 2013 14:48, Christopher Schultz ch...@christopherschultz.net wrote: Nick, On 8/20/13 8:24 PM, Nick Williams wrote: I ran in to a roadblock with this idea. Part of the byte code of a class includes the fully-qualified class name. If I

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 12:46 PM, sebb wrote: On 21 August 2013 14:48, Christopher Schultz ch...@christopherschultz.net wrote: Nick, On 8/20/13 8:24 PM, Nick Williams wrote: I ran in to a roadblock with this idea. Part of the byte code of a class includes the fully-qualified class name. If I

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread sebb
On 21 August 2013 20:21, Christopher Schultz ch...@christopherschultz.net wrote: Sebb, On 8/21/13 1:46 PM, sebb wrote: On 21 August 2013 14:48, Christopher Schultz ch...@christopherschultz.net wrote: Nick, On 8/20/13 8:24 PM, Nick Williams wrote: I ran in to a roadblock with this idea.

Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to pass on my machine. Last time I ran them it

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Mark Thomas
On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Violeta Georgieva
2013/8/20 Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never gotten all the existing tests to pass on my

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Brian Burch
On 20/08/13 14:32, Violeta Georgieva wrote: 2013/8/20 Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1) I've never

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 8:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance:

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Mark, On 8/20/13 9:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it obviously needs some unit tests. However, I need some guidance: 1)

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 10:12 AM, Christopher Schultz wrote: Mark, On 8/20/13 9:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a pretty import class (WebappClassLoader), so it

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 11:15 AM, Nick Williams wrote: On Aug 20, 2013, at 10:12 AM, Christopher Schultz wrote: Mark, On 8/20/13 9:25 AM, Mark Thomas wrote: On 20/08/2013 14:13, Nick Williams wrote: I'm working on implementing bugzilla 55317. It's a pretty important change (weaving) to a

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 1:25 PM, Christopher Schultz wrote: tcnative can be built on Max OS X like this: $ cd $CATALINA_HOME/bin $ tar xzf tomcat-native.tar.gz $ cd tomcat-native-*-src/jni/native $ ./configure --with-apr=/usr/bin/apr-1-config --with-ssl --with-java-home=`/usr/libexec/java_home`

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 1:41 PM, Christopher Schultz wrote: Nick, On 8/20/13 1:25 PM, Christopher Schultz wrote: tcnative can be built on Max OS X like this: $ cd $CATALINA_HOME/bin $ tar xzf tomcat-native.tar.gz $ cd tomcat-native-*-src/jni/native $ ./configure

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Christopher Schultz
Nick, On 8/20/13 1:47 PM, Nick Williams wrote: On Aug 20, 2013, at 12:41 PM, Christopher Schultz wrote: Nick, On 8/20/13 1:25 PM, Christopher Schultz wrote: tcnative can be built on Max OS X like this: $ cd $CATALINA_HOME/bin $ tar xzf tomcat-native.tar.gz $ cd

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Mark Thomas
On 20/08/2013 18:58, Christopher Schultz wrote: In case you want to run the entire test suite but don't want to get APR failures, you can also set -Dexecute.test.apr=false and it will skip all the APR tests. The unit tests are smart enough that even with that set to true, the tests will be

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Mark Thomas
On 20/08/2013 18:47, Nick Williams wrote: My remaining original concern was the best approach for weaving byte code in Tomcat's unit tests, which I detailed in an earlier message. Use the Weaver to completely replace the byte code of the weaved class with the byte code from another class? That

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nicholas Williams
On Tue, Aug 20, 2013 at 1:10 PM, Mark Thomas ma...@apache.org wrote: On 20/08/2013 18:47, Nick Williams wrote: My remaining original concern was the best approach for weaving byte code in Tomcat's unit tests, which I detailed in an earlier message. Use the Weaver to completely replace the

Re: Need guidance for writing unit tests for 55317

2013-08-20 Thread Nick Williams
On Aug 20, 2013, at 1:10 PM, Mark Thomas wrote: On 20/08/2013 18:47, Nick Williams wrote: My remaining original concern was the best approach for weaving byte code in Tomcat's unit tests, which I detailed in an earlier message. Use the Weaver to completely replace the byte code of the