On 10/3/2018 12:05 PM, Mark Thomas wrote:
[4]
https://github.com/apache/tomcat/blob/trunk/test/org/apache/tomcat/util/net/TesterSupport.java#L196
That one I do think makes sense to pull into JrePlatform.
I have moved [4] above in r1842748. I used the existing convention in
the file of
On 03/10/18 19:23, Igal Sapir wrote:
> On 10/3/2018 4:41 AM, Mark Thomas wrote:
[4]
https://github.com/apache/tomcat/blob/trunk/test/org/apache/tomcat/util/net/TesterSupport.java#L196
>> That one I do think makes sense to pull into JrePlatform.
>
> I have moved [4] above in
On 10/3/2018 4:41 AM, Mark Thomas wrote:
On 03/10/18 00:48, Igal Sapir wrote:
Regarding this:
On 10/2/2018 3:54 PM, Igal Sapir wrote:
Rainer pointed out to me the class JrePlatform [1], which has a helper
field called IS_WINDOWS.
I think that it would make sense to add a constant field
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Igal,
On 10/2/18 18:54, Igal Sapir wrote:
> Rainer pointed out to me the class JrePlatform [1], which has a
> helper field called IS_WINDOWS.
>
> I think that it would make sense to add a constant field OS_NAME,
> as well as IS_LINUX and IS_MACOS,
On 03/10/18 00:48, Igal Sapir wrote:
> Regarding this:
>
> On 10/2/2018 3:54 PM, Igal Sapir wrote:
>> Rainer pointed out to me the class JrePlatform [1], which has a helper
>> field called IS_WINDOWS.
>>
>> I think that it would make sense to add a constant field OS_NAME, as
>> well as IS_LINUX
Regarding this:
On 10/2/2018 3:54 PM, Igal Sapir wrote:
Rainer pointed out to me the class JrePlatform [1], which has a helper
field called IS_WINDOWS.
I think that it would make sense to add a constant field OS_NAME, as
well as IS_LINUX and IS_MACOS, and use these fields instead of calling
Rainer pointed out to me the class JrePlatform [1], which has a helper
field called IS_WINDOWS.
I think that it would make sense to add a constant field OS_NAME, as
well as IS_LINUX and IS_MACOS, and use these fields instead of calling
System.getProperty("os.name") in multiple places - some
