Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-13 Thread Mark Thomas
Henri Gomez wrote: > What about using JMeter ? I don't need the sophistication for this test and ab looks to have a smaller overhead. > Also your test should be from a different computer, may be with 2/3 > clients computers against one single server. Thanks for the tip. Time to dig out my old la

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-13 Thread Henri Gomez
What about using JMeter ? Also your test should be from a different computer, may be with 2/3 clients computers against one single server. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTEC

RE: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-12 Thread Bill Barker
> -Original Message- > From: Mark Thomas [mailto:[EMAIL PROTECTED] > Sent: Thursday, January 12, 2006 1:52 PM > To: Tomcat Developers List > Subject: Re: svn commit: r367826 - in > /tomcat/container/tc5.5.x: > catalina/src/share/org/apache/catalina/connector/Res

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-12 Thread Mark Thomas
Remy Maucherat wrote: > I spent some time eliminating all the warnings that my Eclipse was > reporting sometimes in the past, and saw that isSpace was deprecated. > isWhitespace seemed to be a replacement, but is actually different. HTTP > needs to stay with the non character encoded version. Ie, t

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-12 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: Author: markt Date: Tue Jan 10 15:06:22 2006 New Revision: 367826 URL: http://svn.apache.org/viewcvs?rev=367826&view=rev Log: Alternative patch for bug 29214 based on Remy's comments I am merging the latest version of the patch in my tree, but this change is a bit sne

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-11 Thread Costin Manolache
On 1/10/06, Mark Thomas <[EMAIL PROTECTED]> wrote: > Costin Manolache wrote: > > I guess the better solutions are to either deal with this in the > > servlet facade ( i.e. the HttpServletResponse impl ) - or to just > > remove the cached fields from coyote Response. > > > > The second is harder - b

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-11 Thread Mark Thomas
Remy Maucherat wrote: > Mark Thomas wrote: >> I thought about doing it that way but I wanted to catch the difference >> between Content-Length defaulting to -1 and the page developer >> explicitly setting it to -1. It is an edge case I admit but I don't >> see any harm in covering it given where th

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-11 Thread Remy Maucherat
Mark Thomas wrote: I thought about doing it that way but I wanted to catch the difference between Content-Length defaulting to -1 and the page developer explicitly setting it to -1. It is an edge case I admit but I don't see any harm in covering it given where the implementation now sits. I don

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-10 Thread Mark Thomas
Costin Manolache wrote: > I guess the better solutions are to either deal with this in the > servlet facade ( i.e. the HttpServletResponse impl ) - or to just > remove the cached fields from coyote Response. > > The second is harder - but the right one IMO, it's bad to have methods > in Response t

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-10 Thread Mark Thomas
Remy Maucherat wrote: > [EMAIL PROTECTED] wrote: > >> Author: markt >> Date: Tue Jan 10 15:06:22 2006 >> New Revision: 367826 >> >> URL: http://svn.apache.org/viewcvs?rev=367826&view=rev >> Log: >> Alternative patch for bug 29214 based on Remy's comments > > > I didn't have time to look into it

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-10 Thread Costin Manolache
I guess the better solutions are to either deal with this in the servlet facade ( i.e. the HttpServletResponse impl ) - or to just remove the cached fields from coyote Response. The second is harder - but the right one IMO, it's bad to have methods in Response that don't do what people would expec

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-10 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: Author: markt Date: Tue Jan 10 15:06:22 2006 New Revision: 367826 URL: http://svn.apache.org/viewcvs?rev=367826&view=rev Log: Alternative patch for bug 29214 based on Remy's comments I didn't have time to look into it much, but I would have thought using coyoteRespons

svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-10 Thread markt
Author: markt Date: Tue Jan 10 15:06:22 2006 New Revision: 367826 URL: http://svn.apache.org/viewcvs?rev=367826&view=rev Log: Alternative patch for bug 29214 based on Remy's comments Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Response.java tomcat/