Re: svn commit: r1377544 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/systemprops.xml

2012-08-27 Thread Mark Thomas
fha...@apache.org wrote: Author: fhanik Date: Sun Aug 26 23:48:01 2012 New Revision: 1377544 URL: http://svn.apache.org/viewvc?rev=1377544view=rev Log: don't hard code values, no need to https://issues.apache.org/bugzilla/show_bug.cgi?id=53267 -1 for two reasons: 1. Users should have no need

[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-08-27 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community

[Bug 53469] possible bug in Response.normalize(CharChunk cc)

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53469 --- Comment #18 from mgrigorov mgrigo...@apache.org --- (In reply to comment #16) I have fixed the IAE in trunk and 7.0.x. Unfortunately with this fix apps that work only with jsessionid encoded in the url will still break. If JSESSIONID

[Bug 53469] possible bug in Response.normalize(CharChunk cc)

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53469 --- Comment #19 from mgrigorov mgrigo...@apache.org --- I think I found the solution. Wicket can pass always an absolute url to the web container for encoding. Wicket knows the current base url and can make it absolute safely. This way the

[Bug 53783] New: Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 Priority: P2 Bug ID: 53783 Assignee: dev@tomcat.apache.org Summary: Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found Severity:

[Bug 53783] Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 --- Comment #1 from Violeta Georgieva violet...@apache.org --- Created attachment 29284 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29284action=edit Patch proposal -- You are receiving this mail because: You are the assignee

[Bug 53783] Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added OS||All

svn commit: r1377688 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/systemprops.xml

2012-08-27 Thread fhanik
Author: fhanik Date: Mon Aug 27 14:15:36 2012 New Revision: 1377688 URL: http://svn.apache.org/viewvc?rev=1377688view=rev Log: Per http://markmail.org/message/nqnogctvfuyzhtol 1. Already encountered two users that would like to set this value. There is never any need to hard code any value,

svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread fhanik
Author: fhanik Date: Mon Aug 27 14:20:55 2012 New Revision: 1377689 URL: http://svn.apache.org/viewvc?rev=1377689view=rev Log: Per http://markmail.org/message/nqnogctvfuyzhtol 1. Already encountered two users that would like to set this value. There is never any need to hard code any value,

Re: Tagging 7.0.30

2012-08-27 Thread Ralph Plawetzki
Dear Mark, would you mind to take a look at BZ51496? As you pointed out your focus is to get open bugs fixed for 7.0.30. Well, this is not a bug, but an enhancement and to be honest I don’t know if it is planned to consider enhancements for minor releases as well. I proposed a patch. Thank you.

[Bug 51496] NSIS - Warn that duplicate service name will result in install failure

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51496 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com --- -1 for the patch (attachment 29251) It does not check that a service is installed. What it checks is whether the Tomcat Monitor application is configured to auto-launch on

[Bug 53783] Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 --- Comment #3 from Violeta Georgieva violet...@apache.org --- (In reply to comment #2) Does specification allow JAR files that do not have directory entries? 1. The jar tool always creates entries for directories. There are no options

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Mark Thomas
On 27/08/2012 15:20, fha...@apache.org wrote: Author: fhanik Date: Mon Aug 27 14:20:55 2012 New Revision: 1377689 URL: http://svn.apache.org/viewvc?rev=1377689view=rev Log: Per http://markmail.org/message/nqnogctvfuyzhtol 1. Already encountered two users that would like to set this

svn commit: r1377785 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 18:40:09 2012 New Revision: 1377785 URL: http://svn.apache.org/viewvc?rev=1377785view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 Handle case where tool generating JARs does not generate entries for directories. Modified:

svn commit: r1377786 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 18:43:18 2012 New Revision: 1377786 URL: http://svn.apache.org/viewvc?rev=1377786view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 Handle case where tool generating JARs does not generate entries for directories. Patch by Violeta Georgieva.

[Bug 53783] Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 53783] Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53783 --- Comment #5 from Violeta Georgieva violet...@apache.org --- Thanks -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail:

svn commit: r1377794 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ java/org/apache/catalina/util/ test/org/apache/catalina/authenticator/ webapps/docs/config/

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 19:03:04 2012 New Revision: 1377794 URL: http://svn.apache.org/viewvc?rev=1377794view=rev Log: Digest improvements: - disable caching of authenticated user in session by default - track server rather than client nonces - better handling of stale nonce values Added:

svn commit: r1377807 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/ java/org/apache/catalina/util/ test/org/apache/catalina/authenticator/ webapps/docs/ webapps/docs/config/

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 19:43:06 2012 New Revision: 1377807 URL: http://svn.apache.org/viewvc?rev=1377807view=rev Log: Digest improvements: - disable caching of authenticated user in session by default - track server rather than client nonces - better handling of stale nonce values Added:

svn commit: r1377811 - /tomcat/trunk/java/org/apache/catalina/util/ConcurrentMessageDigest.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:01:28 2012 New Revision: 1377811 URL: http://svn.apache.org/viewvc?rev=1377811view=rev Log: Add a MD5 digest method as it is the most commonly used. Modified: tomcat/trunk/java/org/apache/catalina/util/ConcurrentMessageDigest.java Modified:

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Konstantin Kolinko
2012/8/27 Mark Thomas ma...@apache.org: On 27/08/2012 15:20, fha...@apache.org wrote: Author: fhanik Date: Mon Aug 27 14:20:55 2012 New Revision: 1377689 URL: http://svn.apache.org/viewvc?rev=1377689view=rev Log: Per http://markmail.org/message/nqnogctvfuyzhtol 1. Already encountered two

svn commit: r1377824 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:21:21 2012 New Revision: 1377824 URL: http://svn.apache.org/viewvc?rev=1377824view=rev Log: Take advantage of new ConcurrentMessageDigest Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java Modified:

svn commit: r1377826 - in /tomcat/trunk/test/org/apache/catalina/authenticator: TestDigestAuthenticator.java TestNonLoginAndBasicAuthenticator.java TestSSOnonLoginAndBasicAuthenticator.java TestSSOnon

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:23:42 2012 New Revision: 1377826 URL: http://svn.apache.org/viewvc?rev=1377826view=rev Log: Java 7 Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java

svn commit: r1377827 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:24:48 2012 New Revision: 1377827 URL: http://svn.apache.org/viewvc?rev=1377827view=rev Log: Take advantage of new ConcurrentMessageDigest Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.java Modified:

svn commit: r1377831 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/config/systemprops.xml

2012-08-27 Thread kkolinko
Author: kkolinko Date: Mon Aug 27 20:26:34 2012 New Revision: 1377831 URL: http://svn.apache.org/viewvc?rev=1377831view=rev Log: Followup to r1377689 1. Cleanup removed property from systemprops.xml 2. Do not reference inaccessible class in Javadoc (With my setting of JRE=Execution environment

svn commit: r1377835 - /tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:32:19 2012 New Revision: 1377835 URL: http://svn.apache.org/viewvc?rev=1377835view=rev Log: Clean-up - Fix FindBugs NPE warnings - Java 7 - Remove static imports (auto completes are easier without them) Modified:

svn commit: r1377839 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread kkolinko
Author: kkolinko Date: Mon Aug 27 20:38:05 2012 New Revision: 1377839 URL: http://svn.apache.org/viewvc?rev=1377839view=rev Log: Followup to r1377688 Merged revision 1377831 from tomcat/trunk: 1. Do not reference inaccessible class in Javadoc (With my setting of JRE=Execution environment

svn commit: r1377852 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:51:05 2012 New Revision: 1377852 URL: http://svn.apache.org/viewvc?rev=1377852view=rev Log: Better handling of exception Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Modified:

[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #3 from kevin.l.st...@nokia.com --- Created attachment 29286 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29286action=edit Demonstrates the same problem post-fix. Please unzip to obtain the data.bin which causes

[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 kevin.l.st...@nokia.com changed: What|Removed |Added Status|RESOLVED|REOPENED

svn commit: r1377853 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:53:56 2012 New Revision: 1377853 URL: http://svn.apache.org/viewvc?rev=1377853view=rev Log: Improve concurrency of DIGEST auth Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Modified:

svn commit: r1377856 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/util/ConcurrentMessageDigest.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:56:10 2012 New Revision: 1377856 URL: http://svn.apache.org/viewvc?rev=1377856view=rev Log: Add a MD5 digest method as it is the most commonly used. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1377857 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/authenticator/TestDigestAuthenticator.java test/org/apache/catalina/authenticator/TestSSOnonLoginAndDigestAuthenticator.jav

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:57:15 2012 New Revision: 1377857 URL: http://svn.apache.org/viewvc?rev=1377857view=rev Log: Take advantage of new ConcurrentMessageDigest Modified: tomcat/tc7.0.x/trunk/ (props changed)

Re: svn commit: r1377835 - /tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java

2012-08-27 Thread Konstantin Kolinko
2012/8/28 ma...@apache.org: Author: markt Date: Mon Aug 27 20:32:19 2012 New Revision: 1377835 URL: http://svn.apache.org/viewvc?rev=1377835view=rev Log: - Remove static imports (auto completes are easier without them) In Eclipse settings Java - Editor - Content Assist - Favorites My

svn commit: r1377858 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/DigestAuthenticator.java

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 20:58:04 2012 New Revision: 1377858 URL: http://svn.apache.org/viewvc?rev=1377858view=rev Log: Better handling of exception Modified: tomcat/tc7.0.x/trunk/ (props changed)

[Bug 51966] Tomcat does not support ssha hashed passwords in all contexts

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51966 --- Comment #11 from da...@leppik.net --- Unfortunately, just adding salt to hashes doesn't provide much more security these days. Modern password hashing algorithms, such as bcrypt, include the salt as part of the hash. What's more, the

Re: svn commit: r1377835 - /tomcat/trunk/test/org/apache/catalina/websocket/TestWebSocket.java

2012-08-27 Thread Mark Thomas
On 27/08/2012 21:58, Konstantin Kolinko wrote: 2012/8/28 ma...@apache.org: Author: markt Date: Mon Aug 27 20:32:19 2012 New Revision: 1377835 URL: http://svn.apache.org/viewvc?rev=1377835view=rev Log: - Remove static imports (auto completes are easier without them) In Eclipse

svn commit: r1377861 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:04:02 2012 New Revision: 1377861 URL: http://svn.apache.org/viewvc?rev=1377861view=rev Log: Correct section Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1377863 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/DigestAuthenticator.java webapps/docs/changelog.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:05:50 2012 New Revision: 1377863 URL: http://svn.apache.org/viewvc?rev=1377863view=rev Log: Improve concurrency of DIGEST auth Modified: tomcat/tc7.0.x/trunk/ (props changed)

[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #5 from kevin.l.st...@nokia.com --- Note that, not surprisingly, using Java 7's GZIPOutputStream with syncFlush=true resolves the issue. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #6 from Mark Thomas ma...@apache.org --- That is an option for Tomcat 8 (which will require Java 7) but not for Tomcat 7 and earlier. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1377876 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/valves/ java/org/apache/tomcat/util/http/res/ webapps/docs/

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:21:44 2012 New Revision: 1377876 URL: http://svn.apache.org/viewvc?rev=1377876view=rev Log: Further fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 - Use standard text for standard HTTP error codes - Trim Jasper error messages Modified:

svn commit: r1377878 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/authenticator/FormAuthenticator.java java/org/apache/catalina/authenticator/SavedRequest.java webapps/docs/changelo

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:28:04 2012 New Revision: 1377878 URL: http://svn.apache.org/viewvc?rev=1377878view=rev Log: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53584 Ignore path parameters when comparing URIs for FORM authentication. This prevents users being prompted

[Bug 53071] ErrorReportValve ignores message from throwable

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

[Bug 53584] Forms authentication without cookies requires double submission in 6.0.33

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53584 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1377879 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:32:00 2012 New Revision: 1377879 URL: http://svn.apache.org/viewvc?rev=1377879view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1377880 - /tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml

2012-08-27 Thread fhanik
Author: fhanik Date: Mon Aug 27 21:33:49 2012 New Revision: 1377880 URL: http://svn.apache.org/viewvc?rev=1377880view=rev Log: Update documentation to include the new value Modified: tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml Modified:

svn commit: r1377881 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java webapps/docs/changelog.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:34:27 2012 New Revision: 1377881 URL: http://svn.apache.org/viewvc?rev=1377881view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53606 Fix possible NPE when sending pings between cluster nodes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt

[Bug 53606] NullPointerException in TcpPingInterceptor

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53606 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

[Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina|Catalina

svn commit: r1377882 - /tomcat/trunk/webapps/docs/config/listeners.xml

2012-08-27 Thread fhanik
Author: fhanik Date: Mon Aug 27 21:36:15 2012 New Revision: 1377882 URL: http://svn.apache.org/viewvc?rev=1377882view=rev Log: document the new property Modified: tomcat/trunk/webapps/docs/config/listeners.xml Modified: tomcat/trunk/webapps/docs/config/listeners.xml URL:

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
-Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Monday, August 27, 2012 2:09 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe ner.java 2012/8/27 Mark

svn commit: r1377883 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/tribes/group/interceptors/TcpPingInterceptor.java webapps/docs/changelog.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:39:51 2012 New Revision: 1377883 URL: http://svn.apache.org/viewvc?rev=1377883view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53607 To avoid NPE, set TCP PING data to ChannelMessage. Modified: tomcat/tc6.0.x/trunk/STATUS.txt

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Konstantin Kolinko
2012/8/28 Filip Hanik (mailing lists) devli...@hanik.com: There are documentation glitches yet to be fixed: a. systemprops.xml change in trunk was not reverted by this commit. It was reverted in 7.0.x only. [Filip Hanik] I don't see the property in trunk, do you? I took care of that an

[Bug 53607] No message set for PING: TcpPingInterceptor fail with NullPointerException in ChannelData.getDataPackageLength()

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53607 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Mark Thomas
On 27/08/2012 22:37, Filip Hanik (mailing lists) wrote: -Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Monday, August 27, 2012 2:09 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 -

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
-Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Monday, August 27, 2012 3:41 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe ner.java 2012/8/28 Filip

svn commit: r1377884 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java webapps/docs/changelog.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 21:46:29 2012 New Revision: 1377884 URL: http://svn.apache.org/viewvc?rev=1377884view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53513 Fix race condition between the processing of session sync message and transfer complete message. Modified:

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
-Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Monday, August 27, 2012 3:44 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe ner.java On 27/08/2012 22:37, Filip Hanik

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Mark Thomas
On 27/08/2012 22:48, Filip Hanik (mailing lists) wrote: -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Monday, August 27, 2012 3:44 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 -

svn commit: r1377887 - /tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java

2012-08-27 Thread kkolinko
Author: kkolinko Date: Mon Aug 27 22:03:33 2012 New Revision: 1377887 URL: http://svn.apache.org/viewvc?rev=1377887view=rev Log: Remove unneeded handling of FORM auth in RealmBase. The login and error pages are handled via forward, so processing completes before this code is ever reached. The

svn commit: r1377888 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/realm/DataSourceRealm.java java/org/apache/catalina/realm/JDBCRealm.java webapps/docs/changelog.xml webapps/docs/co

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 22:04:52 2012 New Revision: 1377888 URL: http://svn.apache.org/viewvc?rev=1377888view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53047 Allow database realms configured with an all roles mode that is authentication only to not have to define a

Re: Tomcat + j_security_check (JDBCRealm) + salt / jBCrypt

2012-08-27 Thread Christopher Schultz
Salek, On 8/20/12 3:31 PM, Salek Talangi wrote: Hi all, I just started using Tomcat+j_security_check (JDBCRealm) for Form-based Webapp-Login. I read [1] that only a few standard (MD5, SHA-1, MD2?) java.security.MessageDigest methods are supported, which isn't enough in times of (still)

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Konstantin Kolinko
2012/8/28 Mark Thomas ma...@apache.org: On 27/08/2012 22:48, Filip Hanik (mailing lists) wrote: -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Monday, August 27, 2012 3:44 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 -

[Bug 53752] Tomcat restarts with error:java.lang.ArrayIndexOutOfBoundsException: -60

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53752 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Severity|critical

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Mark Thomas
On 27/08/2012 23:08, Konstantin Kolinko wrote: 2012/8/28 Mark Thomas ma...@apache.org: On 27/08/2012 22:48, Filip Hanik (mailing lists) wrote: -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Monday, August 27, 2012 3:44 PM To: Tomcat Developers List Subject:

Re: pooledconnection tccl?

2012-08-27 Thread Christopher Schultz
Filip, On 8/22/12 9:12 AM, Filip Hanik (mailing lists) wrote: I've thought about this, you see if it is using TCCL it will cause a memory leak on app reload as the app wont be unloaded due to the pool holding it. But I think we should make it an option It's always been my position that

[Bug 53513] Race condition / out of order operation in session replication at node startup

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53513 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 53785] New: Modern password hashing for built-in Realms

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53785 Priority: P2 Bug ID: 53785 Assignee: dev@tomcat.apache.org Summary: Modern password hashing for built-in Realms Severity: enhancement Classification: Unclassified OS:

[Bug 53785] Modern password hashing for built-in Realms

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53785 --- Comment #1 from da...@leppik.net --- Should have said under step 3: Bundle BCrypt with Tomcat rather than the other way around. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1377892 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/RealmBase.java webapps/docs/changelog.xml

2012-08-27 Thread kkolinko
Author: kkolinko Date: Mon Aug 27 22:28:43 2012 New Revision: 1377892 URL: http://svn.apache.org/viewvc?rev=1377892view=rev Log: Merged revision 1377887 from tomcat/trunk: Remove unneeded handling of FORM authentication in RealmBase. The login and error pages are handled via forward, so

[Bug 53785] Modern password hashing for built-in Realms

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53785 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 53752] Tomcat restarts with error:java.lang.ArrayIndexOutOfBoundsException: -60

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53752 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

[Bug 42181] parseChunkHeader

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42181 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added CC|

svn commit: r1377900 - in /tomcat/trunk: java/org/apache/coyote/http11/filters/ChunkedInputFilter.java java/org/apache/tomcat/util/buf/HexUtils.java test/org/apache/tomcat/util/buf/TestHexUtils.java

2012-08-27 Thread kkolinko
Author: kkolinko Date: Mon Aug 27 23:04:11 2012 New Revision: 1377900 URL: http://svn.apache.org/viewvc?rev=1377900view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42181 Better handling of edge conditions in chunk header processing. Added:

svn commit: r1377902 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 23:08:08 2012 New Revision: 1377902 URL: http://svn.apache.org/viewvc?rev=1377902view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1377904 - /tomcat/trunk/webapps/docs/config/valve.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 23:08:44 2012 New Revision: 1377904 URL: http://svn.apache.org/viewvc?rev=1377904view=rev Log: Update for new default Modified: tomcat/trunk/webapps/docs/config/valve.xml Modified: tomcat/trunk/webapps/docs/config/valve.xml URL:

svn commit: r1377906 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/config/valve.xml

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 23:09:17 2012 New Revision: 1377906 URL: http://svn.apache.org/viewvc?rev=1377906view=rev Log: Update for new default Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/config/valve.xml Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1377909 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/filters/ChunkedInputFilter.java java/org/apache/tomcat/util/buf/HexUtils.java test/org/apache/tomcat/util/buf/TestHexU

2012-08-27 Thread kkolinko
Author: kkolinko Date: Mon Aug 27 23:11:20 2012 New Revision: 1377909 URL: http://svn.apache.org/viewvc?rev=1377909view=rev Log: Merged revision 1377900 from tomcat/trunk: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42181 Better handling of edge conditions in chunk header processing.

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
-Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Monday, August 27, 2012 3:55 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe ner.java On 27/08/2012 22:48, Filip Hanik

Re: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Mark Thomas
On 28/08/2012 00:16, Filip Hanik (mailing lists) wrote: -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Monday, August 27, 2012 3:55 PM To: Tomcat Developers List Subject: Re: svn commit: r1377689 -

svn commit: r1377912 - /tomcat/tc5.5.x/trunk/STATUS.txt

2012-08-27 Thread markt
Author: markt Date: Mon Aug 27 23:25:01 2012 New Revision: 1377912 URL: http://svn.apache.org/viewvc?rev=1377912view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL:

Re: [Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-08-27 Thread Christopher Schultz
Mark, On 8/27/12 5:36 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Mark Thomas ma...@apache.org changed: What|Removed |Added

Re: [Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-08-27 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/08/2012 00:53, Christopher Schultz wrote: Mark, On 8/27/12 5:36 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Mark Thomas ma...@apache.org changed: What|Removed |Added

svn commit: r1377917 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java

2012-08-27 Thread kkolinko
Author: kkolinko Date: Tue Aug 28 00:04:29 2012 New Revision: 1377917 URL: http://svn.apache.org/viewvc?rev=1377917view=rev Log: Correct fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=53047 Followup to r1377888. The code should have been added to getRoles() method, not getPassword().

Re: svn commit: r1377917 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/realm/DataSourceRealm.java

2012-08-27 Thread Mark Thomas
On 28/08/2012 01:04, kkoli...@apache.org wrote: Author: kkolinko Date: Tue Aug 28 00:04:29 2012 New Revision: 1377917 URL: http://svn.apache.org/viewvc?rev=1377917view=rev Log: Correct fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=53047 Followup to r1377888. The code

svn commit: r1377918 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2012-08-27 Thread kkolinko
Author: kkolinko Date: Tue Aug 28 00:13:14 2012 New Revision: 1377918 URL: http://svn.apache.org/viewvc?rev=1377918view=rev Log: Move to correct section. Realms belong to Catalina, not Jasper. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified:

[Bug 53047] JDBCRealm allRolesMode=authOnly still needs role table

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53047 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|NEW

[Bug 42181] parseChunkHeader

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42181 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|CLOSED

[Bug 42181] ArrayIndexOutOfBoundsException in parseChunkHeader

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42181 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Summary|parseChunkHeader

[Bug 42181] ArrayIndexOutOfBoundsException in parseChunkHeader

2012-08-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42181 --- Comment #4 from Konstantin Kolinko knst.koli...@gmail.com --- Created attachment 29288 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29288action=edit 2012-08-28_tc6_42181.patch Patch for Tomcat 6 -- You are receiving this

svn commit: r1377931 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-27 Thread kkolinko
Author: kkolinko Date: Tue Aug 28 01:03:38 2012 New Revision: 1377931 URL: http://svn.apache.org/viewvc?rev=1377931view=rev Log: proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1377932 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-27 Thread kkolinko
Author: kkolinko Date: Tue Aug 28 01:14:36 2012 New Revision: 1377932 URL: http://svn.apache.org/viewvc?rev=1377932view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r1377933 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-27 Thread kkolinko
Author: kkolinko Date: Tue Aug 28 01:17:56 2012 New Revision: 1377933 URL: http://svn.apache.org/viewvc?rev=1377933view=rev Log: Correction It is already mentioned. I have not noticed. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: Tagging 7.0.30

2012-08-27 Thread Konstantin Kolinko
2012/8/27 Mark Thomas ma...@apache.org: Hi, I have all the open bugs fixed for 7.0.x with the exception of BZ53469 that is pending input from the Servlet EG before a final fix (if any) is applied. I have a few other bits and pieces I want to do before I tag 7.0.30 but (assuming no more

svn commit: r1377940 - /tomcat/trunk/TOMCAT-NEXT.txt

2012-08-27 Thread kkolinko
Author: kkolinko Date: Tue Aug 28 01:50:32 2012 New Revision: 1377940 URL: http://svn.apache.org/viewvc?rev=1377940view=rev Log: Remove fixed issue. Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL:

Re: svn commit: r1372394 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/FormAuthenticator.java java/org/apache/catalina/authenticator/SavedRequest.java

2012-08-27 Thread Konstantin Kolinko
2012/8/13 ma...@apache.org: Author: markt Date: Mon Aug 13 12:29:51 2012 New Revision: 1372394 URL: http://svn.apache.org/viewvc?rev=1372394view=rev Log: Additional fix for http://issues.apache.org/bugzilla/show_bug.cgi?id=53584 Store decoded and original request URI. Restore both. Use

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-08-27 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration.