svn commit: r1711404 - /tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java

2015-10-29 Thread kfujino
Author: kfujino Date: Fri Oct 30 06:25:14 2015 New Revision: 1711404 URL: http://svn.apache.org/viewvc?rev=1711404&view=rev Log: No-functional changes. Remove TODO. Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java

svn commit: r1711403 - /tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java

2015-10-29 Thread kfujino
Author: kfujino Date: Fri Oct 30 06:24:26 2015 New Revision: 1711403 URL: http://svn.apache.org/viewvc?rev=1711403&view=rev Log: No-functional changes. Remove TODO. Modified: tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java

svn commit: r1711402 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java

2015-10-29 Thread kfujino
Author: kfujino Date: Fri Oct 30 06:23:50 2015 New Revision: 1711402 URL: http://svn.apache.org/viewvc?rev=1711402&view=rev Log: No-functional changes. Remove TODO. Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java Modifie

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread Keiichi Fujino
> > [ ] Continue to use RTC for 6.0.x > [X] Switch 6.0.x to CTR > > -- > Keiichi.Fujino >

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2015-10-29 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community integration

[Bug 57799] MessageCreationException: Couldn't create SOAP message with Nio2 connector protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57799 --- Comment #25 from Remy Maucherat --- When I say in the channel read, I mean here for the debug code: org.apache.tomcat.util.net.Nio2Channel.read(Nio2Channel.java:133) -- You are receiving this mail because: You are the assignee for the bu

[Bug 57799] MessageCreationException: Couldn't create SOAP message with Nio2 connector protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57799 --- Comment #24 from Remy Maucherat --- Hum, it's not trunk, it's branch 8 head. Anyway, the SSL thing was just coincidental, never mind. It would be nice in the channel read to capture the previous stack trace (throw and catch an exception, p

[Bug 57799] MessageCreationException: Couldn't create SOAP message with Nio2 connector protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57799 --- Comment #23 from Justin --- (In reply to Remy Maucherat from comment #21) > This could use another trunk retest. Built, ran /trunk@1711357. Client now throws exception connected to non-SSL port too... 2015-10-29 16:44:58,287 exception [T

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread Violeta Georgieva
2015-10-29 0:42 GMT+02:00 Mark Thomas : > > All, > > Many years ago, we switched all release branches to RTC primarily to > address a community problem where we could not agree on the best way > forward for some parts of the code. > > RTC served us well. The disagreements ceased pretty much instant

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 --- Comment #9 from Konstantin Kolinko --- (In reply to comment #8) > It would seem with the default buffer on Linux + localhost ... 1. If I understand correctly, real networks have some quality-of-service mechanisms. A well known one is MTU s

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 --- Comment #8 from Remy Maucherat --- It works for me with the right configuration, but not the default one, so I chose WORKSFORME but I don't mind if someone wants to change it. It would seem with the default buffer on Linux + localhost and

svn commit: r1711315 - in /tomcat/tc8.0.x/trunk: java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ java/org/apache/tomcat/util/net/ webapps/docs/

2015-10-29 Thread remm
Author: remm Date: Thu Oct 29 18:19:58 2015 New Revision: 1711315 URL: http://svn.apache.org/viewvc?rev=1711315&view=rev Log: Cancel pending blocking IO operation following a timeout in the NIO2 connector. Modified: tomcat/tc8.0.x/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.j

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 --- Comment #7 from Christopher Schultz --- It seems like less buffer for NIO makes sense in general, though I agree that changing the default is probably not necessary, here. It might be worth mentioning in the documentation that NIO + slow sp

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 Remy Maucherat changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 --- Comment #5 from Christopher Schultz --- Bufferbloat strikes again. :( Does NIOx have enough control over the underlying socket/connection to reduce buffer sizes so that this problem is minimized? -- You are receiving this mail because: Y

[Bug 57799] MessageCreationException: Couldn't create SOAP message with Nio2 connector protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57799 --- Comment #22 from Remy Maucherat --- Investigating another issue, it seems possible this one is caused by a timeout exception that gets swallowed, followed by a new read attempt. It is not really a Tomcat bug if the theory is correct. In tr

svn commit: r1711305 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

2015-10-29 Thread remm
Author: remm Date: Thu Oct 29 17:07:56 2015 New Revision: 1711305 URL: http://svn.apache.org/viewvc?rev=1711305&view=rev Log: Propagate SSL read timeouts and cancel properly, to be able to cancel the operation if a timeout occurs. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Secure

svn commit: r1711303 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2015-10-29 Thread remm
Author: remm Date: Thu Oct 29 17:01:31 2015 New Revision: 1711303 URL: http://svn.apache.org/viewvc?rev=1711303&view=rev Log: After a timeout using a future, the operation that caused the timeout should be cancelled, otherwise it will still be pending. Found it investigating 58565, and could be

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2015-10-29 Thread Bill Barker
space/apache-commons/daemon/dist/bin/commons-daemon-20151029-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native/dest-20151029/lib -Dcommons-daemon.jar=/srv/gump/public/work

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread Felix Schumacher
Am 28. Oktober 2015 23:42:08 MEZ, schrieb Mark Thomas : >All, > >Many years ago, we switched all release branches to RTC primarily to >address a community problem where we could not agree on the best way >forward for some parts of the code. > >RTC served us well. The disagreements ceased pretty m

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 --- Comment #4 from Dave --- so what do you recommend? our application is accessed by many of our customers via gsm modem. In some cases the speed is lower than 8kb/sec (gprs). Which timeout do i have to change? -- You are receiving this mail

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 --- Comment #3 from Remy Maucherat --- After debugging, it looks like it's a combination of factors. What happens is that the network stack buffers things a lot without blocking. At some point it will block until everything gets flushed. Unfor

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 --- Comment #2 from Dave --- just as a note. i tried it with windows and linux and got the same results/problems. -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 58565] Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 Remy Maucherat changed: What|Removed |Added Severity|major |normal --- Comment #1 from Remy Mauch

Re: Session management

2015-10-29 Thread Christopher Schultz
Roel, On 10/29/15 6:32 AM, Roel Storms wrote: > On Oct 28, 2015 21:01, "Christopher Schultz" > wrote: >> On 10/28/15 12:34 PM, Mark Thomas wrote: >>> On 28/10/2015 13:01, Roel Storms wrote: Hello, I was looking into session management on Tomcat 8.0.29 and found this comm

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread Christopher Schultz
Mark, On 10/28/15 6:42 PM, Mark Thomas wrote: > Many years ago, we switched all release branches to RTC primarily to > address a community problem where we could not agree on the best way > forward for some parts of the code. > > RTC served us well. The disagreements ceased pretty much instantly.

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread Rainer Jung
Am 29.10.2015 um 00:57 schrieb Konstantin Kolinko: 2015-10-29 1:42 GMT+03:00 Mark Thomas : All, Many years ago, we switched all release branches to RTC primarily to address a community problem where we could not agree on the best way forward for some parts of the code. RTC served us well. The

[Bug 58564] Simplify Boolean.parseBoolean(System.getProperty("xxx"), "false") to Boolean.getBoolean("xxx")

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58564 Konstantin Kolinko changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread jean-frederic clere
On 10/28/2015 11:42 PM, Mark Thomas wrote: > [X] Switch 6.0.x to CTR Basically there are so few fixes in 6.0.x that the RTC blocks any move in 6.0.x Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.

[Bug 58565] New: Connection will be closed on slow file download with non blocking http protocol

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58565 Bug ID: 58565 Summary: Connection will be closed on slow file download with non blocking http protocol Product: Tomcat 8 Version: 8.0.28 Hardware: PC OS:

[Bug 58564] New: Simplify Boolean.parseBoolean(System.getProperty("xxx"), "false") to Boolean.getBoolean("xxx")

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58564 Bug ID: 58564 Summary: Simplify Boolean.parseBoolean(System.getProperty("xxx"), "false") to Boolean.getBoolean("xxx") Product: Tomcat 8 Version: trunk

[Bug 58244] two way SSL loses client certificate after a few requests

2015-10-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58244 --- Comment #4 from Petr Brouzda --- We have similar (maybe the same) problem. We run - Tomcat 8.0.24 with APR. - HTTPS APR connector with SSLVerifyClient="require". - on Debian 6 Client is a legacy application with no HTTPS support. So it us

Re: [VOTE] Switch 6.0.x from RTC to CTR

2015-10-29 Thread Mark Thomas
On 28/10/2015 23:27, Rémy Maucherat wrote: > 2015-10-28 23:42 GMT+01:00 Mark Thomas : > >> I would therefore like to propose that we switch the 6.0.x release >> branch from RTC to CTR and am therefore calling a VOTE to make this change. >> >> [ ] Continue to use RTC for 6.0.x >> [X] Switch 6.0.x t

Re: Session management

2015-10-29 Thread Roel Storms
Chris and Mark, On Oct 28, 2015 21:01, "Christopher Schultz" wrote: > Mark, > > On 10/28/15 12:34 PM, Mark Thomas wrote: > > On 28/10/2015 13:01, Roel Storms wrote: > >> Hello, > >> > >> > >> I was looking into session management on Tomcat 8.0.29 and found this > >> comment: > >> > >> In apach

svn commit: r1711192 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/doc/jdbc-pool.xml modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java webapps/docs/changelog

2015-10-29 Thread kfujino
Author: kfujino Date: Thu Oct 29 08:36:22 2015 New Revision: 1711192 URL: http://svn.apache.org/viewvc?rev=1711192&view=rev Log: When creating a QueryStats object, ensure that maxQueries is checked. If maxQueries is a value less than or equal to 0, QueryStats are never created. Modified: tomc

Re: Adding request/session valve to Tomcat

2015-10-29 Thread Milo van der Zee
Hello Chris, Thanks for pointing me to my mistake. I did not check InheritableThreadLocal functionality enough. In my usecase not an issue I think. With 'default' I do not mean 'enabled by default'. I mean that it is available in the classpath like the valves mentioned in https://tomcat.apache.or

svn commit: r1711191 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/doc/jdbc-pool.xml modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java webapps/docs/changelog

2015-10-29 Thread kfujino
Author: kfujino Date: Thu Oct 29 08:33:15 2015 New Revision: 1711191 URL: http://svn.apache.org/viewvc?rev=1711191&view=rev Log: When creating a QueryStats object, ensure that maxQueries is checked. If maxQueries is a value less than or equal to 0, QueryStats are never created. Modified: tomc

svn commit: r1711190 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java

2015-10-29 Thread kfujino
Author: kfujino Date: Thu Oct 29 08:28:57 2015 New Revision: 1711190 URL: http://svn.apache.org/viewvc?rev=1711190&view=rev Log: When creating a QueryStats object, ensure that maxQueries is checked. If maxQueries is a value less than or equal to 0, QueryStats are never created. Modified: tomc

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2015-10-29 Thread Bill Barker
.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20151029-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20151029/lib -Dt