buildbot failure in on tomcat-trunk

2018-11-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3702 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1845520 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/ test/org/apache/catalina/mbeans/ webapps/docs/

2018-11-01 Thread markt
Author: markt Date: Thu Nov 1 23:10:06 2018 New Revision: 1845520 URL: http://svn.apache.org/viewvc?rev=1845520=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62871 Improve MBeans for Endpoint instances (type ThreadPool in JMX) by using explicit declaration of attributes and

[Bug 62871] JMX: ThreadPool.socketProperties is not Serializable

2018-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62871 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1845519 - in /tomcat/trunk: java/org/apache/tomcat/util/net/ test/org/apache/catalina/mbeans/ webapps/docs/

2018-11-01 Thread markt
Author: markt Date: Thu Nov 1 23:03:08 2018 New Revision: 1845519 URL: http://svn.apache.org/viewvc?rev=1845519=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62871 Improve MBeans for Endpoint instances (type ThreadPool in JMX) by using explicit declaration of attributes and

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-11-01 Thread Bill Barker
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181101/bin/openssl -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar -Dexecute.test.apr=false -Dtest.excludePerformance=true

[Bug 62871] JMX: ThreadPool.socketProperties is not Serializable

2018-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62871 --- Comment #1 from Mark Thomas --- 8.0.x is no longer supported. If you made a similar change in 8.5.x I'm fairly sure you'd just hit the next unserializable attribute. Changing visibility is not really the right solution as it just hides

buildbot success in on tomcat-trunk

2018-11-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3701 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1845495 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java

2018-11-01 Thread markt
Author: markt Date: Thu Nov 1 16:14:21 2018 New Revision: 1845495 URL: http://svn.apache.org/viewvc?rev=1845495=rev Log: Force TLS 1.2 if TLS 1.3 is available as JSSE's TLS 1.3 implementation doesn't support Post Handshake Authentication which is required for this test to pass. Modified:

Re: JDK 12 Early Access build 15 is available

2018-11-01 Thread Mark Thomas
On 31/10/2018 08:43, Rory O'Donnell wrote: > Hi Mark, > > Can you send us the JI-number when you get time to log a bug ? I would, but it turns out the root cause is in the Tomcat tests. We are trying to do post-handshake authentication and JDK 11 defaults to TLS v1.3 and the JSSE TLSv1.3

buildbot failure in on tomcat-trunk

2018-11-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3700 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 62873] Tomcat Monitor application will update multi-string values in Windows registry with blank lines

2018-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62873 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1845491 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/HTMLManagerServlet.java webapps/docs/changelog.xml

2018-11-01 Thread markt
Author: markt Date: Thu Nov 1 15:37:22 2018 New Revision: 1845491 URL: http://svn.apache.org/viewvc?rev=1845491=rev Log: Create a little visual separation between the Undeploy button and the other buttons in the Manager application. Patch provided by Łukasz Jąder. Modified:

svn commit: r1845490 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/manager/HTMLManagerServlet.java webapps/docs/changelog.xml

2018-11-01 Thread markt
Author: markt Date: Thu Nov 1 15:36:47 2018 New Revision: 1845490 URL: http://svn.apache.org/viewvc?rev=1845490=rev Log: Create a little visual separation between the Undeploy button and the other buttons in the Manager application. Patch provided by Łukasz Jąder. Modified:

[GitHub] tomcat pull request #130: Add two spaces (nbsp) in front of the Undeploy but...

2018-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/130 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845489 - in /tomcat/trunk: java/org/apache/catalina/manager/HTMLManagerServlet.java webapps/docs/changelog.xml

2018-11-01 Thread markt
Author: markt Date: Thu Nov 1 15:35:46 2018 New Revision: 1845489 URL: http://svn.apache.org/viewvc?rev=1845489=rev Log: Create a little visual separation between the Undeploy button and the other buttons in the Manager application. Patch provided by Łukasz Jąder. This closes #130 Modified:

[GitHub] tomcat issue #130: Add two spaces (nbsp) in front of the Undeploy button

2018-11-01 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/130 I can see what you are trying to do but I'm not sure the change creates enough of a visual separation to make much of a difference. I don't think it will do much to reduce the risk of an

buildbot success in on tomcat-trunk

2018-11-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3699 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Mime types

2018-11-01 Thread Rémy Maucherat
On Thu, Nov 1, 2018 at 2:34 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Why bother even doing that? File-extension mapping is a poor way to > perform file-type detection (in fact, it is NOT file type detection), > but the spec mandates it, so we are stuck. > > But why bother

[Bug 61171] Add port offset attribute (portOffset?) to Server configuration in server.xml

2018-11-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61171 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[GitHub] tomcat issue #125: Provide port offset functionality (BZ-61171)

2018-11-01 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/125 Patch has been applied with a few changes: - portOffset was not cached on the Connector (to align with recent changes to how port is handled) - handle special case port values where the

[GitHub] tomcat pull request #125: Provide port offset functionality (BZ-61171)

2018-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/125 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1845482 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/realm/ j

2018-11-01 Thread markt
Author: markt Date: Thu Nov 1 15:06:53 2018 New Revision: 1845482 URL: http://svn.apache.org/viewvc?rev=1845482=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61171 Add the portOffset attribute to the Server element which is added to the configured shutdown and Connector ports.

buildbot failure in on tomcat-trunk

2018-11-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3698 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: Mime types

2018-11-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/31/18 12:37, Rémy Maucherat wrote: > There are two main contraptions in Tomcat that do (badly ...) > extension to mime type mapping: the shared web.xml and some > hardcoded stuff in startup.Tomcat. It would probably be good to unify

svn commit: r1845475 - in /tomcat/tc7.0.x/trunk: ./ res/scripts/check-mime.pl

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 13:13:41 2018 New Revision: 1845475 URL: http://svn.apache.org/viewvc?rev=1845475=rev Log: - Simplify script description. - Make sure the two lists TOMCAT_ONLY and TOMCAT_KEEP are disjoint. - Do no longer tolerate outdated entries in TOMCAT_ONLY or TOMCAT_KEEP. -

svn commit: r1845474 - /tomcat/tc8.5.x/trunk/

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 13:09:31 2018 New Revision: 1845474 URL: http://svn.apache.org/viewvc?rev=1845474=rev Log: Forgot to commit mergeinfo. Modified: tomcat/tc8.5.x/trunk/ (props changed) Propchange: tomcat/tc8.5.x/trunk/

svn commit: r1845473 - /tomcat/tc8.5.x/trunk/res/scripts/check-mime.pl

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 13:07:22 2018 New Revision: 1845473 URL: http://svn.apache.org/viewvc?rev=1845473=rev Log: - Simplify script description. - Make sure the two lists TOMCAT_ONLY and TOMCAT_KEEP are disjoint. - Do no longer tolerate outdated entries in TOMCAT_ONLY or TOMCAT_KEEP. -

Re: Mime types

2018-11-01 Thread Rainer Jung
Am 31.10.2018 um 20:15 schrieb Konstantin Kolinko: ср, 31 окт. 2018 г. в 19:38, Rémy Maucherat : ... And then all the badly maintained content from web.xml and the Tomcat class can be deleted. Comments ? 1. "badly maintained content from web.xml" Do not call them "bad". AFAIK, Those are

svn commit: r1845472 - /tomcat/trunk/res/scripts/check-mime.pl

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 13:01:40 2018 New Revision: 1845472 URL: http://svn.apache.org/viewvc?rev=1845472=rev Log: Move flac from TOMCAT_ONLY, because it has now shown up in httpd's mime.types but with a different value (audio/x-flac instead of our audio/flac). For now stick to our

svn commit: r1845469 - /tomcat/trunk/res/scripts/check-mime.pl

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 13:00:21 2018 New Revision: 1845469 URL: http://svn.apache.org/viewvc?rev=1845469=rev Log: hqx and m4a no longer needed in TOMCAT_ONLY. The same definitions are now part of httpd's mime.types. Modified: tomcat/trunk/res/scripts/check-mime.pl Modified:

svn commit: r1845465 - /tomcat/trunk/res/scripts/check-mime.pl

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 12:45:44 2018 New Revision: 1845465 URL: http://svn.apache.org/viewvc?rev=1845465=rev Log: Do no longer tolerate outdated entries in TOMCAT_ONLY or TOMCAT_KEEP. Modified: tomcat/trunk/res/scripts/check-mime.pl Modified: tomcat/trunk/res/scripts/check-mime.pl

svn commit: r1845463 - /tomcat/trunk/res/scripts/check-mime.pl

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 12:44:09 2018 New Revision: 1845463 URL: http://svn.apache.org/viewvc?rev=1845463=rev Log: Make sure the two lists TOMCAT_ONLY and TOMCAT_KEEP are disjoint. Modified: tomcat/trunk/res/scripts/check-mime.pl Modified: tomcat/trunk/res/scripts/check-mime.pl URL:

svn commit: r1845462 - /tomcat/trunk/res/scripts/check-mime.pl

2018-11-01 Thread rjung
Author: rjung Date: Thu Nov 1 12:42:40 2018 New Revision: 1845462 URL: http://svn.apache.org/viewvc?rev=1845462=rev Log: Simplify script description. Modified: tomcat/trunk/res/scripts/check-mime.pl Modified: tomcat/trunk/res/scripts/check-mime.pl URL: