Question Regarding McastServiceImpl#setupSocket

2019-05-28 Thread Gurkan Erdogdu
HiIn an McastServiceImpl#setupSocket method, if the user configures the mcastBindAddress, it will use the socket to bind to this address. But, in the code below, it uses the "address" field while creating the socket. Is this correct ? if (mcastBindAddress != null) {  try {     log.i

[tomcat] branch master updated: Enable debug logging in case #4394 failure occurs again

2019-05-28 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 93c5ffc Enable debug logging in case #4394 failur

Re: [tomcat] branch master updated: Add utility Server listener

2019-05-28 Thread Rémy Maucherat
On Tue, May 28, 2019 at 11:04 PM Rémy Maucherat wrote: > On Tue, May 28, 2019 at 10:47 PM Mark Thomas wrote: > >> On 28/05/2019 15:40, r...@apache.org wrote: >> > This is an automated email from the ASF dual-hosted git repository. >> > >> > remm pushed a commit to branch master >> > in repositor

[tomcat] branch master updated: Remove useless method parameters

2019-05-28 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 99e2bb3 Remove useless method parameters 99e2bb3

Re: [tomcat] branch master updated: Add utility Server listener

2019-05-28 Thread Rémy Maucherat
On Tue, May 28, 2019 at 10:47 PM Mark Thomas wrote: > On 28/05/2019 15:40, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: [tomcat] branch master updated: Add utility Server listener

2019-05-28 Thread Mark Thomas
On 28/05/2019 15:40, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

buildbot success in on tomcat-trunk

2019-05-28 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4396 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

[tomcat] branch master updated: Hack to avoid optional listener warn log

2019-05-28 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 364a468 Hack to avoid optional listener warn log

[tomcat] branch master updated: Simplify thread local listener

2019-05-28 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 20b6794 Simplify thread local listener 20b6794 is

Re: [Bug 43548] xml schema for tomcat-users.xml

2019-05-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/28/19 05:06, Mark Thomas wrote: >> Mark, >> >> On 5/23/19 17:09, bugzi...@apache.org wrote: >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=43548 >> >>> --- Comment #11 from Mark Thomas --- Five >>> years on and I changed my mind. I

buildbot failure in on tomcat-trunk

2019-05-28 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4394 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Are we interested in using any the GitHub features?

2019-05-28 Thread Coty Sutherland
Hi, Are we interested in utilizing any of the GitHub integration for Travis CI , Coverity Scan , LGTM , etc? We could at least set them up for testing PRs since we already have the Apac

[tomcat] branch master updated: Add utility Server listener

2019-05-28 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c5fbb15 Add utility Server listener c5fbb15 is de

Re: [tomcat] branch master updated: Sync on socketWrapper like the non async code does

2019-05-28 Thread Rémy Maucherat
On Fri, May 24, 2019 at 10:17 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

[tomcat] 01/03: Expand the coverage and quality of the French translations (remm)

2019-05-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fce0e0c1422fcdb3caeac625616a879c9d5f7d8b Author: Mark Thomas AuthorDate: Tue May 28 12:44:24 2019 +0100 Expand the c

[tomcat] 03/03: More German translations

2019-05-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3c6c210ca722dbe5f096a674456b2833fa8f4660 Author: Mark Thomas AuthorDate: Tue May 28 12:55:22 2019 +0100 More German

[tomcat] 02/03: Expand the coverage and quality of the Simplified Chinese translations.

2019-05-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 76f9008f48e34dff7fa45f92a32c3035d4f1a637 Author: Mark Thomas AuthorDate: Tue May 28 12:48:56 2019 +0100 Expand the c

[tomcat] branch master updated (003e071 -> 3c6c210)

2019-05-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 003e071 Add default instance manager factory method new fce0e0c Expand the coverage and quality of the French t

Re: [Bug 43548] xml schema for tomcat-users.xml

2019-05-28 Thread Mark Thomas
> Mark, > > On 5/23/19 17:09, bugzi...@apache.org wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=43548 > >> --- Comment #11 from Mark Thomas --- Five years >> on and I changed my mind. I've added this to 7.0.x for 7.0.95 >> onwards. > > Looking at this bug, I can see a link to the XS