[Bug 65443] Allow subclassing CorsFilter

2021-07-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443 --- Comment #2 from ekkelenk...@gmail.com --- Just created a pull request: https://github.com/apache/tomcat/pull/432 -- You are receiving this mail because: You are the assignee for the bug.

[GitHub] [tomcat] ekkelenkamp opened a new pull request #432: Allow subclassing CorsFilter getAllowedOrigins() and isAnyOriginAllow…

2021-07-09 Thread GitBox
ekkelenkamp opened a new pull request #432: URL: https://github.com/apache/tomcat/pull/432 I would like to be able to subclass the CorsFilter clases to be able to provide a custom list of allowed origins, instead of configure them from the init parameters. This will allow providing the

[Bug 65443] Allow subclassing CorsFilter

2021-07-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443 --- Comment #1 from Christopher Schultz --- Sounds like a perfect opportunity for you to supply a patch (attached here) or a pull-request via GitHub. I would support its inclusion into Tomcat. -- You are receiving this mail because: You are

[Bug 65443] New: Allow subclassing CorsFilter

2021-07-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65443 Bug ID: 65443 Summary: Allow subclassing CorsFilter Product: Tomcat 9 Version: unspecified Hardware: PC OS: All Status: NEW Severity: enhancement

buildbot success in on tomcat-10.0.x

2021-07-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-10.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-10.0.x/builds/91 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

Re: https://bz.apache.org/bugzilla/show_bug.cgi?id=55707 in tomcat

2021-07-09 Thread Rainer Jung
Hi Jean-Frederic, how do you make sure, that your tests actually land in the correct SSLHost? You are using the same server certificate, so a check on the client side might not be easy. I would find a test more convincing, if the three TLS hosts would use three different certificates and you

[tomcat] branch 8.5.x updated: Possible fix for intermittent unit test failure

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 47653e6 Possible fix for intermittent unit test

[tomcat] branch 9.0.x updated: Possible fix for intermittent unit test failure

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new eb87e9d Possible fix for intermittent unit test

[tomcat] branch 10.0.x updated: Possible fix for intermittent unit test failure

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new d36f85b Possible fix for intermittent unit test

buildbot failure in on tomcat-10.0.x

2021-07-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-10.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-10.0.x/builds/90 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

Re: https://bz.apache.org/bugzilla/show_bug.cgi?id=55707 in tomcat

2021-07-09 Thread jean-frederic clere
On 09/07/2021 15:15, Christopher Schultz wrote: Jean-Ferderic, On 7/9/21 07:55, jean-frederic clere wrote: On 09/07/2021 12:38, Mark Thomas wrote: On 09/07/2021 11:08, jean-frederic clere wrote: Hi, I think we need the same fix in tomcat or I missed something? If we need it I will work on

[tomcat] branch 8.5.x updated: Fix Ant download for Travis build

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 1903946 Fix Ant download for Travis build 1903946

[tomcat] branch 9.0.x updated: Fix Ant download for Travis build

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6f01c78 Fix Ant download for Travis build 6f01c78

[tomcat] branch 10.0.x updated: Fix Ant download for Travis build

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 59fca08 Fix Ant download for Travis build

[tomcat] branch main updated: Fix Ant download for Travis build

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 4c53b97 Fix Ant download for Travis build 4c53b97

Re: https://bz.apache.org/bugzilla/show_bug.cgi?id=55707 in tomcat

2021-07-09 Thread Christopher Schultz
Jean-Ferderic, On 7/9/21 07:55, jean-frederic clere wrote: On 09/07/2021 12:38, Mark Thomas wrote: On 09/07/2021 11:08, jean-frederic clere wrote: Hi, I think we need the same fix in tomcat or I missed something? If we need it I will work on it next week ;-) To clarify, you mean checking

[GitHub] [tomcat] markt-asf commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-07-09 Thread GitBox
markt-asf commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-877146000 Security concerns only arise with untrusted apps. Untrusted apps have to run under a SecurityManager else they have access to reflection and can do pretty much whatever they

[tomcat] 01/02: Remove the completed TODO (it was for an i18n string in the exception)

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1b728785484e2baf9c42b2efdb882547f90fde88 Author: Mark Thomas AuthorDate: Fri Jul 9 12:02:46 2021 +0100 Remove the

[tomcat] 02/02: Check requirements of functional interface rather than annotation

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0827d1ce4200ad030a9c3496349b240fefeb53a7 Author: Mark Thomas AuthorDate: Fri Jul 9 13:07:14 2021 +0100 Check

[tomcat] branch main updated (cd6be41 -> 0827d1c)

2021-07-09 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from cd6be41 Slightly more interesting test case new 1b72878 Remove the completed TODO (it was for an i18n string in

Re: https://bz.apache.org/bugzilla/show_bug.cgi?id=55707 in tomcat

2021-07-09 Thread jean-frederic clere
On 09/07/2021 12:38, Mark Thomas wrote: On 09/07/2021 11:08, jean-frederic clere wrote: Hi, I think we need the same fix in tomcat or I missed something? If we need it I will work on it next week ;-) To clarify, you mean checking Tomcat can (and implementing if it can't) the ability to

[GitHub] [tomcat] cklein05 edited a comment on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-07-09 Thread GitBox
cklein05 edited a comment on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-877095921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-07-09 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-877110440 In its default configuration it does. You can configure it for byte array as well, I know. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-07-09 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-877097848 > Sun's standard LDAP provider returns Strings only) ...no. I use byte arrays with this all the time. -- This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2021-07-09 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-877095921 Okay, let's make some decisions (Bob Ross? _Here's a class, and it has a friend..._) Since there's no public `setFoo()` method in `GenericPrincipal` (attributes are only

Re: [tomcat] 03/03: Add support for coercing LambdaExpression to any functional interface

2021-07-09 Thread Mark Thomas
On 09/07/2021 11:40, Konstantin Kolinko wrote: пт, 9 июл. 2021 г. в 12:19, Mark Thomas : On 09/07/2021 09:58, Konstantin Kolinko wrote: Thanks Konstantin. This is good feedback. [...] I wonder how Java itself (a java compiler) deals with coercion of lambdas to interfaces. Either it

Re: [tomcat] 03/03: Add support for coercing LambdaExpression to any functional interface

2021-07-09 Thread Konstantin Kolinko
пт, 9 июл. 2021 г. в 12:19, Mark Thomas : > > On 09/07/2021 09:58, Konstantin Kolinko wrote: > > Thanks Konstantin. This is good feedback. > > [...] > > > I wonder how Java itself (a java compiler) deals with coercion of > > lambdas to interfaces. Either it generates calls to some helper API, > >

Re: https://bz.apache.org/bugzilla/show_bug.cgi?id=55707 in tomcat

2021-07-09 Thread Mark Thomas
On 09/07/2021 11:08, jean-frederic clere wrote: Hi, I think we need the same fix in tomcat or I missed something? If we need it I will work on it next week ;-) To clarify, you mean checking Tomcat can (and implementing if it can't) the ability to configure supported SSL protocols per

https://bz.apache.org/bugzilla/show_bug.cgi?id=55707 in tomcat

2021-07-09 Thread jean-frederic clere
Hi, I think we need the same fix in tomcat or I missed something? If we need it I will work on it next week ;-) -- Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

Re: [tomcat] 03/03: Add support for coercing LambdaExpression to any functional interface

2021-07-09 Thread Mark Thomas
On 09/07/2021 09:58, Konstantin Kolinko wrote: Thanks Konstantin. This is good feedback. пт, 9 июл. 2021 г. в 00:07, Mark Thomas : Add support for coercing LambdaExpression to any functional interface The implementation for this turned out to be a lot simpler than I initially

Re: [tomcat] 03/03: Add support for coercing LambdaExpression to any functional interface

2021-07-09 Thread Konstantin Kolinko
пт, 9 июл. 2021 г. в 00:07, Mark Thomas : > > On 08/07/2021 22:05, ma...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > markt pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > commit