Re: Announcing releases of tomcat native

2007-05-23 Thread Mladen Turk
Yoav Shapira wrote: Hi, On 5/22/07, William L. Thomson Jr. [EMAIL PROTECTED] wrote: If possible when new versions of Tomcat native be announced on list? Seems Tomcat 6.0.13 requires 1.1.10. First I became aware of it, was when user reported the problem. Granted I should have discovered it

Re: Announcing releases of tomcat native

2007-05-23 Thread Mladen Turk
William L. Thomson Jr. wrote: On Wed, 2007-05-23 at 13:19 +0200, Mladen Turk wrote: For 6.0.13 the required version is 1.1.8 and recommended is 1.1.10 and that is clearly printed whenever Tomcat is started. I'm not sure what more is needed. According to the bug report, it required 1.1.10

Automatic detection of CPU/JVM for Win32/Win64

2007-05-24 Thread Mladen Turk
Hi, I've committed to the trunk the modified service.bat that automatically detects the host CPU (x86, amd64, ia64) and whether the JVM is 64 bit or not. So it automatically picks tomcat6.exe, amd64/tomcat6.exe depending on the above rules. However it requires that the .zip distro contains

Re: mod_jk build: threading detection broken

2007-05-30 Thread Mladen Turk
Rainer Jung wrote: I suggest, that we build against httpd 2.x always thread-safe, at least unless the existing flag -enable-prefork is used and document this behaviour. +1 Regards, Mladen. - To unsubscribe, e-mail:

Re: svn commit: r544137 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

2007-06-04 Thread Mladen Turk
Jean-Frederic wrote: On Mon, 2007-06-04 at 12:08 +, [EMAIL PROTECTED] wrote: Author: mturk Date: Mon Jun 4 05:08:33 2007 New Revision: 544137 URL: http://svn.apache.org/viewvc?view=revrev=544137 Log: Add simple URI normalizer that can deal with things like %252e%252e. This is mostly

Re: svn commit: r544137 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

2007-06-04 Thread Mladen Turk
William A. Rowe, Jr. wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Mon Jun 4 05:08:33 2007 New Revision: 544137 URL: http://svn.apache.org/viewvc?view=revrev=544137 Log: Add simple URI normalizer that can deal with things like %252e%252e. This is mostly copy/paste from the IIS module

Re: svn commit: r544137 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

2007-06-06 Thread Mladen Turk
Mark Thomas wrote: Did I mention that uri is *not* decoded twice? You did and I still don't agree. The root cause of CVE-2007-1860 was a double decoding. Once in httpd/mod_jk and once in Tomcat. Why do you don't agree? Please provide a use case and confirm your statements are legitimate.

Re: svn commit: r544137 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

2007-06-06 Thread Mladen Turk
Remy Maucherat wrote: Mark Thomas wrote: As I see it, we have two options: a) Prevent Tomcat from decoding the uri a second time at step 7 above b) Re-encode the uri in mod_jk between steps 5 and 6 I think: - it's the proxy which should have options for adapting to what the proxied server

Re: svn commit: r544137 - /tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c

2007-06-07 Thread Mladen Turk
Mark Thomas wrote: Single ajp13 worker jkMount /jsp-examples/* worker1 A simple 'hello world' html file was created at (directories created where required): appBase/jsp-examples/%2e%2e/servlets-examples/index.html Test 1: Tomcat only

Re: svn commit: r546531 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_global.h common/jk_url.c common/jk_url.h common/list.mk.in

2007-06-12 Thread Mladen Turk
Jean-Frederic wrote: Add ForwardURIProxy to the URl handling option. common/jk_url.c is just a porting of the routines from proxy_util.c (Apache httpd). After quite a few discussions, I think this should be the only mode available for URI handling, as the two others are broken. Comments ?

Re: svn commit: r546531 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_global.h common/jk_url.c common/jk_url.h common/list.mk.in

2007-06-13 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: Why? Let's stop a bit and test things before. Jean-Frédéric proposes implementing the same behavior as mod_proxy, so I don't see how this can be a bad thing. First of all I didn't said it's a bad thing or anything like that. We need the same behavior

Re: JK3 roadmap?

2007-06-27 Thread Mladen Turk
jean-frederic clere wrote: I have noted that nothing has happened in tomcat/connectors/trunk/jk3. Nearly 2 months without real road map nor clear specifications, what is wrong? I don't think anything is wrong. We are waiting for the list of requirements, and any suggestion from yours or

Re: svn commit: r550789 - /tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

2007-06-28 Thread Mladen Turk
Remy Maucherat wrote: Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Tue Jun 26 05:28:00 2007 New Revision: 550789 URL: http://svn.apache.org/viewvc?view=revrev=550789 Log: Do not pass session id if it is zero length. For now only log those attempts. We should consider

Re: svn commit: r551809 - /tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

2007-06-29 Thread Mladen Turk
jean-frederic clere wrote: /* We checked for space !! */ -strncpy((char *)msg-buf + msg-len, param, len + 1); /* including \0 */ +memcpy(msg-buf + msg-len, param, len + 1); /* including \0 */ Why do you remove the (char *)? Cause memcpy uses void* so no need for

Re: Feature request /Discussion: JK loadbalancer improvements for high load

2007-07-05 Thread Mladen Turk
Yefym Dmukh wrote: Actually the following was happening: the LB sends requests and gets the session sticky, continuously sending the upcoming requests to the same cluster node. At the certain period of time the JVM started the major garbage collection (full gc) and spent, mentioned above, 20

Re: Feature request /Discussion: JK loadbalancer improvements for high load

2007-07-05 Thread Mladen Turk
Yefym Dmukh wrote: Actually the following was happening: the LB sends requests and gets the session sticky, continuously sending the upcoming requests to the same cluster node. At the certain period of time the JVM started the major garbage collection (full gc) and spent, mentioned above, 20

Re: Feature request /Discussion: JK loadbalancer improvements for high load

2007-07-05 Thread Mladen Turk
Yefym Dmukh wrote: You have oxymoron here. With session stickiness you are willingly tear down the load balancer correctness because you don't wish/can have session replication. Generally you are right, but the ideal world is not the reality: we use apache my faces implementation of jsf where

Re: Removing the examples (JSP/servlet) in TC Binaries

2007-07-09 Thread Mladen Turk
jean-frederic clere wrote: Hi, The examples (servlet and JSP) have caused a list of security issues. I think we should remove them from the Tomcat binary packages (6.0 and 5.x at least). Any comments? If the examples are broken, then we have serious problems, either with examples or with

Re: Tomcat supporting PHP

2007-07-16 Thread Mladen Turk
Joe Nathan wrote: Henri Gomez wrote: Do you want a 100% Java PHP engine or just a simple native to Java bridge ? I mean PHP scripts are processed as JSP are handled inside Tomcat without installing any other things as built-in features. Imagine if Tomcat can handle JSP, PHP, even ASP

Re: Tagging JK 1.2.24

2007-07-27 Thread Mladen Turk
+1 Rainer Jung wrote: Hi, we had exactly 10 downloads of our quality check tarball since the announcement yesterday. Three of the testers reported back positively (one of them via direct mail), no reports were negative. Since I received already a lot of positive feedback from the preceding

Re: [VOTE] Releasing Tomcat Connectors 1.2.24

2007-07-27 Thread Mladen Turk
Apache Tomcat Connectors 1.2.24 is: [x] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Regards, Mladen

Serious regression in JK 1.2.24

2007-08-02 Thread Mladen Turk
Hi, We have a problem with 1.2.24 that luckily is not security leak, but it is security related. The problem is that 401 from Tomcat without body (a standard HTTP_UNAUTHORIZED) is treated as 401, meaning that Apache is returning 401 page instead passing 401 to the client. I already patched the

Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml

2007-08-02 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I don't full yunderstand this fix. From your other mail i though it's a regression, but the code in this region is the same at least since 1.2.18 (more than a year). So I have the impression, that this is not a regression. You can try 1.2.23 (it works). 1.2.24

Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml

2007-08-02 Thread Mladen Turk
Rainer Jung wrote: OK, I'll go into it. I think I would propose a slightly different patch, but I'll investigate, why 23 and 24 are different. The reason why I started to pose querstions is, that I found it a little strange to make an exception for exactly one status code. My impression is:

Re: svn commit: r562090 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c

2007-08-02 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: rjung Date: Thu Aug 2 05:10:48 2007 New Revision: 562090 URL: http://svn.apache.org/viewvc?view=revrev=562090 Log: Revert the quickfix r562022. It looks like we found the real problem with r562085. Perfect. The fix makes login working once again. Regards,

Re: mod_jk 1.2.24 withdrawal?

2007-08-02 Thread Mladen Turk
for nsapi on which platform. I think the nsapi and general platforms considerations should not be done before 1.2.25, but everything else looks OK to me. Regards, Rainer Mladen Turk wrote: [EMAIL PROTECTED] wrote: Author: rjung Date: Thu Aug 2 05:10:48 2007 New Revision: 562090 URL: http

Re: [VOTE] Releasing Tomcat Connectors 1.2.25

2007-08-07 Thread Mladen Turk
Rainer Jung wrote: Apache Tomcat Connectors 1.2.25 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are

Re: svn commit: r571006 - /tomcat/connectors/trunk/ajp/

2007-08-29 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: markt Date: Wed Aug 29 18:14:11 2007 New Revision: 571006 URL: http://svn.apache.org/viewvc?rev=571006view=rev Log: Remove source for mod_proxy_ajp that moved to httpd some time ago. Why the hell did you do that? You could copy it to some sandbox or

Re: svn commit: r571006 - /tomcat/connectors/trunk/ajp/

2007-08-30 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: You could copy it to some sandbox or something, since there is lots of usable code in there like console mode httpd API client for testing modules, etc. It's trivial to svn cp -r 571005 https://svn.apache.org/repos/asf/tomcat/connectors/trunk/ajp

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Match header names exactly against pre defined constants. p += 6; -if (memcmp(p, CHARSET, 7) == 0) +if (strcmp(p, CHARSET) == 0) Someone would say that this is over engineering :) memcmp *is always* faster

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Mladen Turk wrote: [EMAIL PROTECTED] wrote: Match header names exactly against pre defined constants. p += 6; -if (memcmp(p, CHARSET, 7) == 0) +if (strcmp(p, CHARSET) == 0) Someone would say that this is over engineering :) memcmp

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Rainer Jung wrote: No problem, better safe than sorry. Right. It seems I always forget the ingenuity of the users that wish to extent the http spec :) However, I think that we can still use the memcmp with xxx\0. That would still be faster then figuring out the EOL with strcmp? Regards,

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Rainer Jung wrote: Yes Mladen, I know. But we never really use len :) I know, that we can do it with memcmp, but then you, me or someone else has to add a couple of if(len=...) before each memcmp(). Go ahead if you like to. Look, we have a local header[16] on which we copy toupper, and

Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

2007-08-30 Thread Mladen Turk
Rainer Jung wrote: +/* Always do memcmp including the final \0-termination character. + */ switch (header[0]) { case 'A': -if (memcmp(p, CCEPT, 5) == 0) { +if (memcmp(p, CCEPT, 6) == 0) { Right, but like said this should be a if

Re: Connectors cleanup

2007-09-03 Thread Mladen Turk
Mark Thomas wrote: Hi, Following on from my previous over eager attempt to clean up the duplicate code in connectors I would like to propose the following - remove connectors/trunk/ajp/CHANGES - remove connectors/trunk/ajp/proxy - move connectors/trunk/ajp/ajplib to connectors/trunk/ajplib

Draft for September 2007 Board report

2007-09-03 Thread Mladen Turk
of the current code inside Tomcat 6 trunk, and the majority of developers have agreed to put the trunk into the sandbox. Community - After last quarter's new committers and PMC members, there were no changes the committership nor PMC membership this time. Mladen Turk was elected as new

Re: svn commit: r572181 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp12_worker.c jk_ajp_common.c jk_jni_worker.c jk_status.c

2007-09-03 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: rjung Date: Sun Sep 2 15:50:40 2007 New Revision: 572181 URL: http://svn.apache.org/viewvc?rev=572181view=rev Log: - Document return codes of the service() method for all worker types (lb still missing). Below is for jk_ajp_common.c: - Document return codes

Re: svn commit: r572181 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp12_worker.c jk_ajp_common.c jk_jni_worker.c jk_status.c

2007-09-03 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I'm fine with rolling back and committing in steps. No need to do that. Let's just take more care in the future. It'll be much easier to follow the commits thought. Regards, Mladen - To

Re: Connectors cleanup

2007-09-03 Thread Mladen Turk
Mark Thomas wrote: Mladen Turk wrote: I propose we create connectors/sanbox and move the trunk/ajp/* code in there. ajp/proxy code can be removed of course. Could we just move it to tomcat/sandbox as that already exists? We need connectors/sandbox anyway, so IMHO it's a good initial reason

Re: [VOTE] Make released versions RTC

2007-09-06 Thread Mladen Turk
Henri Gomez wrote: Well what's the consensus on Java projects, like Xerces, Xalan or Lucene ? It doesn't mater how other project do things. It's irrelevant. We had CTR policy till now and it was working. Now we have a new situation with different developers POVs, and cause of that, this

Re: [VOTE] Make released versions RTC

2007-09-06 Thread Mladen Turk
Yoav Shapira wrote: Hi, On 9/6/07, Mladen Turk [EMAIL PROTECTED] wrote: Do we need it? Yes, if we wish to survive as a project. It's pain in the ass, I know, but IMHO it's also the only way to get some sense in this chaos. I disagree. I think the current CTR policy has worked just fine

Re: [VOTE] Make released versions RTC

2007-09-06 Thread Mladen Turk
Remy Maucherat wrote: To give an idea, tis could mean: - API changing patches (any protected or above signature change) - code changes in the critical path (for example, code which gets executed on each HTTP request) Fine. - any other commit for which a committer asks for the RTC procedure

Re: Old CVS repository of Tomcat

2007-09-07 Thread Mladen Turk
Beat Fluri wrote: Hi, As a member of the Software Engineering group of the University Zurich, Switzerland, I'm investigating the evolution of software systems. For this, I'd like to use Tomcat as a case study. Unfortunately, our tools are limited to CVS and not yet fully adapted to

Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.xml

2007-09-14 Thread Mladen Turk
Bill Barker wrote: Now, I'd prefer that TC is just the Servlet/JSP container that it is meant to be, and not try to add on proprietary features. But that is just me ;). You are not the only one ;) Seems we have lost the clear vision of the project somewhere in the flame wars. It has

Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk: java/org/apache/naming/resources/FileDirContext.java webapps/docs/changelog.xml

2007-09-15 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: Mladen Turk wrote: This simply has to stop. taking trunk away, this turn of events is expected. I wish everyone would have thought of that before we got caught up in the personal, and not what is important, trunk debate. I did, as well others did (I hope

Re: Review model take 2

2007-09-19 Thread Mladen Turk
+1 as well. Seems we have come to some sort of conclusion. (At least the proposal holds the majority of votes) I'll left this tread for a day or two and then create an official proposal draft we can vote on. If thats accepted, I'll create needed documents like STATUS, ROADMAP containing that

Re: Tomcat Export Notification Requirements

2007-09-26 Thread Mladen Turk
William A. Rowe, Jr. wrote: Hey folks, as you provide the bindings to the JSSE, even though you don't ship the JSSE .jars - we still need Tomcat in compliance with the federal export notification policies. I know you did some work on this in the past, but please see

Re: Tomcat Export Notification Requirements

2007-09-26 Thread Mladen Turk
William A. Rowe, Jr. wrote: it's sort of a closed loop problem. Update the info, allow the usual one hour after updating from minotaur to sync, and then shoot out the notice referencing the list of notices sent :) Can we get an example email that needs to be send and an email address? The

Re: Tomcat Export Notification Requirements

2007-09-26 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: William A. Rowe, Jr. wrote: it's sort of a closed loop problem. Update the info, allow the usual one hour after updating from minotaur to sync, and then shoot out the notice referencing the list of notices sent :) Can we get an example email

Re: mod_jk 1.2.25, JkEnvVar evaluated too many times

2007-10-23 Thread Mladen Turk
Ian Ward Comfort wrote: (I've heard this list is a good place to discuss mod_jk code; please redirect me and accept my apologies if it is not.) No, this is correct place :) containers. By adding some additional instrumentation to the code, I can see that each AJP packet is constructed

Re: tcnative-1 and windows vista pro 32 bits

2007-10-26 Thread Mladen Turk
Henri Gomez wrote: Here is the dump You should know by now that apache mailing doesn't allow large attachments, zip files, etc... :) Put a link somewhere Regards, Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For

Re: VirtualHost inheritance (was Re: [Bug 43753] ...)

2007-11-02 Thread Mladen Turk
Ian Ward Comfort wrote: I don't know if this is intended behavior, or a bug in mod_jk, or even a bug in Apache, but something seems amiss. Thoughts? Your patch won't work. The real problem is in the initialization for vhosts where when there is *any* Jk directive the create_jk_config is

Re: VirtualHost inheritance (was Re: [Bug 43753] ...)

2007-11-02 Thread Mladen Turk
Ian Ward Comfort wrote: clone_jk_config is bogus, and doesn't behave like it should (copy only the basic data and no mounts) Was this function introduced since 1.2.25? Yes, I was talking about trunk not 1.2.25 Regards, Mladen

Re: [VOTE] Release build 6.0.15

2007-11-06 Thread Mladen Turk
According to the release process, the 6.0.15 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Thumbs up for Linux, win32 and win64! Regards, Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

Re: svn commit: r593943 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

2007-11-11 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: rjung Date: Sun Nov 11 11:22:23 2007 New Revision: 593943 URL: http://svn.apache.org/viewvc?rev=593943view=rev Log: Undo revision 593927. This produced a mem leak for vhosts with private JkMounts. No idea why. Because uw_map is now allocated *only* if

Re: svn commit: r593943 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

2007-11-12 Thread Mladen Turk
Rainer Jung wrote: P.S.: I hope the other changes are fine with you? They look OK, but I'll double check, just in case ;) Cheers, Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: svn commit: r596747 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-11-20 Thread Mladen Turk
Mladen Turk wrote: Rainer Jung wrote: But I'm open. If we remove the const, we also need to remove it for the log_fmt (got as compiler warning also there, but don't have the line number at hand). Which would you prefer? Do you see a problem with the const, like wrong compiler optimization

Re: svn commit: r596761 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/tomcat/util/net/ res/

2007-11-20 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: jim Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=596761r1=596760r2=596761view=diff

Re: Tomcat Monitor Configuration

2007-11-20 Thread Mladen Turk
RafaQuiM wrote: Hello, I'm having problems using the TomcatMonitor (tomcat4w.exe) when trying to access a WinXp net file from a Servlet due to the console uses the SYTEM user (user.name property) as credentials. Does anybody know how to configure tomcatMonitor in order to use the logged user?

Re: Publishing process for JARs for Maven Central

2011-12-16 Thread Mladen Turk
On 12/16/2011 08:56 PM, Mark Thomas wrote: All, I know option 1 works ... Does anyone else have any requirements / views that would suggest one approach is better than the other? If it ain't broken don't fix it. Regards -- ^TM

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-18 Thread Mladen Turk
On 12/17/2011 09:24 PM, Antonio Petrelli wrote: As requested here is a proposal to move to Maven. I simply cannot understand why some folks have almost religious fascination with Maven. I know many projects that have move from Ant to Maven and are now either switched back or gone to some

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread Mladen Turk
On 12/19/2011 06:12 PM, Pid wrote: On 18/12/2011 08:37, Mladen Turk wrote: On 12/17/2011 09:24 PM, Antonio Petrelli wrote: As requested here is a proposal to move to Maven. I simply cannot understand why some folks have almost religious fascination with Maven. I know many projects

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread Mladen Turk
On 12/19/2011 07:04 PM, Henri Gomez wrote: Exactly. Since any change would require a learning curve and it seems we don't have that many (read none) maven experts in the house, Gradle could be equally considered, given that it seems more advanced in customization. I know well Maven but Olivier

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread Mladen Turk
On 12/19/2011 07:47 PM, David Jencks wrote: Are you reading the thread? I mentioned dec 17 that geronimo has been maintaining a script for 2+ years that pulls tomcat source out of tomcat svn and puts it in an appropriately structured maven mutli-project build and we've been re-releasing quite

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread Mladen Turk
On 12/19/2011 08:58 PM, Romain Manni-Bucau wrote: There is a big part of tomcat which doesn't need maven because it doesn't need to be standard (the installers are a great example). Installer is just ant exec task with some filtering for getting the versions correctly. We have multiple

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread Mladen Turk
On 12/19/2011 09:13 PM, Romain Manni-Bucau wrote: I don't know if it is because i used more maven than ant but when i checked out tomcat the first time i wondered where was modules (corresponding to jars). OK, this is the first thing I can agree with you. But It has nothing to do with toolkit

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-19 Thread Mladen Turk
On 12/19/2011 09:13 PM, Romain Manni-Bucau wrote: because developers can't know both? Since it seems you are familiar with maven, what is your opinion about maven ant tasks? Seems to me it offers full power of Ant, almost seamless transition, with the option to use maven deploy and

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-21 Thread Mladen Turk
On 12/21/2011 09:34 PM, Olivier Lamy wrote: Hello, I have started some stuff here: https://github.com/olamy/tomcat70. We must at least create 7.1.x branch for such a crucial change. Otherwise no one will be able to apply custom patches to the exiting code base. BTW, Oliver, it looks really

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-21 Thread Mladen Turk
On 12/21/2011 10:24 PM, Mark Thomas wrote: On 21/12/2011 21:21, Mladen Turk wrote: On 12/21/2011 09:34 PM, Olivier Lamy wrote: Hello, I have started some stuff here: https://github.com/olamy/tomcat70. We must at least create 7.1.x branch for such a crucial change. I'm not sure we need

Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)

2011-12-21 Thread Mladen Turk
On 12/21/2011 11:01 PM, Mark Thomas wrote: On 21/12/2011 21:57, Mladen Turk wrote: In essence no packages will be able to change the version unless he rewrites the .spec or debian files from scratch thought. Ouch. That is argument for only doing this in trunk, if we do it at all. Right. Up

Re: WebSocket progress report

2012-01-25 Thread Mladen Turk
On 01/24/2012 10:15 PM, Mark Thomas wrote: I have made some further headway with this and the latest patch is on people.a.o [1]. How that relates to Servlet spec 3.1? Regards -- ^TM - To unsubscribe, e-mail:

Re: SPDY support

2012-02-15 Thread Mladen Turk
On 02/15/2012 04:53 AM, Costin Manolache wrote: Uploaded another take. For non-SSL ( JIO, and apr without ssl ) - SPDY just kicks in on all connections, this is just a short-cut for testing. I could also define a SpdyProtocol and set it directly on the connector - but seems too much overhead

Re: [VOTE] Release Apache Tomcat 7.0.26

2012-02-18 Thread Mladen Turk
On 02/17/2012 09:00 PM, Mark Thomas wrote: The proposed 7.0.26 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.26 Stable Looks good ... nothing much to say :) Regards -- ^TM - To

Re: svn commit: r1291760 - in /tomcat/native/branches/1.1.x: native/src/address.c xdocs/miscellaneous/changelog.xml

2012-02-21 Thread Mladen Turk
On 02/21/2012 03:06 PM, Konstantin Kolinko wrote: 2012/2/21mt...@apache.org: @@ -58,6 +70,13 @@ TCN_IMPLEMENT_CALL(jlong, Address, info) sl = sa; } } +if (sp) { +/* Set the provided scope id + * APR lack the api for setting this directly so lets

Re: svn commit: r1291760 - in /tomcat/native/branches/1.1.x: native/src/address.c xdocs/miscellaneous/changelog.xml

2012-02-21 Thread Mladen Turk
On 02/21/2012 03:06 PM, Konstantin Kolinko wrote: 2012/2/21mt...@apache.org: I wonder when this change will be ported to native/trunk. (Just wondering. No real interest though). We currently have only 1.x release which is from this branch. Trunk will be 2.x and will require apr-2.x I plan to

Release Tomcat Native 1.1.23

2012-02-21 Thread Mladen Turk
Hi, We have couple of bugs fixed and its been quite a while since 1.1.22. There is also few trivial bugs and patches in BZ which I plan to solve. I volunteer as RM for 1.1.23. Objections, comments? Regards -- ^TM - To

Re: Release Tomcat Native 1.1.23

2012-02-21 Thread Mladen Turk
On 02/21/2012 09:56 PM, Costin Manolache wrote: On Tue, Feb 21, 2012 at 12:51 PM, Rainer Jungrainer.j...@kippdata.dewrote: On 21.02.2012 21:30, Costin Manolache wrote: Is this going to be from head ? How can I get the NPN ( sslext.c ) included ? Mladen is aiming for 1.1.23, so he will be

Re: Release Tomcat Native 1.1.23

2012-02-21 Thread Mladen Turk
On 02/22/2012 06:17 AM, Costin Manolache wrote: Mladen: please let me know if you want to further review the change or should I merge it to the branch. Well I personally would not merge that into 1.1.x branch. It would be a bit weird to have 1.1.22 as is, and 1.1.23 with whole bunch of new

Re: svn commit: r1292127 - /tomcat/native/trunk/native/src/sslext.c

2012-02-22 Thread Mladen Turk
On 02/22/2012 05:52 AM, cos...@apache.org wrote: Author: costin + if (len TCN_BUFFER_SZ) { + return -1; + } Suppose that the len is presumed to always be shorter then 8K. char * requestedTicket = apr_pcalloc(tcssl-pool, len); suppose this can be be just

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Mladen Turk
On 02/22/2012 03:54 PM, Costin Manolache wrote: On Tue, Feb 21, 2012 at 11:11 PM, Mladen Turkmt...@apache.org wrote: Well I personally would not merge that into 1.1.x branch. It would be a bit weird to have 1.1.22 as is, and 1.1.23 with whole bunch of new features and API's. That's not why

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Mladen Turk
On 02/22/2012 05:47 PM, Costin Manolache wrote: On Wed, Feb 22, 2012 at 8:13 AM, Mladen Turkmt...@apache.org wrote: One thing I would appreciate help with: I would like to have an option to statically link openssl and apr into the tc-native .so - I mean use openssl.a, apr.a. You mean for

Re: Release Tomcat Native 1.1.23

2012-02-22 Thread Mladen Turk
On 02/22/2012 07:22 PM, Costin Manolache wrote: On Wed, Feb 22, 2012 at 9:12 AM, Mladen Turkmt...@apache.org wrote: However, not sure why you wish to do that. Many distros already provide tomcat-native so there's no real point for doing that, especially since we should not distribute unix

Re: svn commit: r1292891 - /tomcat/trunk/bin/daemon.sh

2012-02-23 Thread Mladen Turk
On 02/23/2012 08:00 PM, Konstantin Kolinko wrote: 2012/2/23ma...@apache.org: Maybe: while [ -n $1 ] (though both variants should work work) Some solaris shells misbehave on -n. do - case $o in + case $o=1 in What the above line is about? Was it supposed to be: case $1 in

Re: Release Tomcat Native 1.1.23

2012-02-23 Thread Mladen Turk
On 02/22/2012 07:22 PM, Costin Manolache wrote: On Wed, Feb 22, 2012 at 9:12 AM, Mladen Turkmt...@apache.org wrote: I'm trying to provide a way for people to build libtcnative-2.so so it can be installed on those systems along with the existing apr, openssl and libtcnative-1, without

Re: Native components builds on Gump

2012-02-24 Thread Mladen Turk
On 02/24/2012 10:07 AM, Konstantin Kolinko wrote: Hi! Thanks to Stefan Bodewig work to resolve issue with expat configuration on Gump, APR now builds successfully there, after failing for more than 1 year. So projects that depend on APR and/or HTTPD now have a chance to be built, after being

Re: Release Tomcat Native 1.1.23

2012-02-24 Thread Mladen Turk
On 02/24/2012 11:12 AM, Henri Gomez wrote: I just notice this 'release' Did you release a source tarball ? Nope, will tag later today or over the weekend (depends on weather conditions :) Cheers -- ^TM - To unsubscribe,

Re: svn commit: r1293119 - in /tomcat/native/branches/1.1.x: native/configure.in native/include/ssl_private.h native/src/sslutils.c xdocs/miscellaneous/changelog.xml

2012-02-24 Thread Mladen Turk
On 02/24/2012 06:31 PM, Felix Schumacher wrote: Am Freitag, den 24.02.2012, 07:43 + schrieb mt...@apache.org: +AC_ARG_ENABLE(ocsp, +[AS_HELP_STRING([--enable-openssl],[Turn on OpenSSL OCSP verification support])], I think the help string should read --enable-ocsp. Right. Good catch!

tomcat-native 1.1.23 test run r1293352

2012-02-24 Thread Mladen Turk
Hi, I have made available soon to be 1.1.23 release at http://people.apache.org/~mturk/native/r1293352/ So please test before I make tag. Notice -- There is one change in distribution layout. There is no more binaries/win32/ with individual files. Instead there is

Re: tomcat-native 1.1.23 test run r1293352

2012-02-24 Thread Mladen Turk
On 02/24/2012 07:15 PM, Mladen Turk wrote: Hi, I have made available soon to be 1.1.23 release at http://people.apache.org/~mturk/native/r1293352/ Please use: http://people.apache.org/~mturk/native/r1293383/ Inside binaries there is now win32-bin.zip and win32-ocsp.zip with the latest

Re: tomcat-native 1.1.23 test run r1293352

2012-02-26 Thread Mladen Turk
On 02/26/2012 03:39 PM, Rainer Jung wrote: On 24.02.2012 20:33, Mladen Turk wrote: On 02/24/2012 07:15 PM, Mladen Turk wrote: Hi, I have made available soon to be 1.1.23 release at http://people.apache.org/~mturk/native/r1293352/ Please use: http://people.apache.org/~mturk/native/r1293383

Re: tomcat-native 1.1.23 test run r1293352

2012-02-26 Thread Mladen Turk
On 02/26/2012 04:19 PM, Rainer Jung wrote: Hi Mladen, On 24.02.2012 20:33, Mladen Turk wrote: On 02/24/2012 07:15 PM, Mladen Turk wrote: Hi, I have made available soon to be 1.1.23 release at http://people.apache.org/~mturk/native/r1293352/ Please use: http://people.apache.org/~mturk

Re: tomcat-native 1.1.23 test run r1293352

2012-02-27 Thread Mladen Turk
On 02/24/2012 08:33 PM, Mladen Turk wrote: Please use: http://people.apache.org/~mturk/native/r1293383/ Inside binaries there is now win32-bin.zip and win32-ocsp.zip with the latest having OCSP compiled in (still experimental) The versions in r1293352 had OCSP compiled in so not for production

Re: svn commit: r1293202 - /tomcat/native/branches/1.1.x/jnirelease.sh

2012-02-27 Thread Mladen Turk
On 02/26/2012 04:58 PM, Rainer Jung wrote: On 24.02.2012 13:09, mt...@apache.org wrote: JKJNISVN=$SVNBASE/${JKJNIEXT} if [ x$JKJNIEXT = xtrunk ]; then - JKJNIVER=`svn info ${JKJNISVN} | awk '$1 == Revision: {print $2}'` -elif [ $USE_BRANCH -eq 1 ]; then - JKJNIBRANCH=${JKJNIEXT} -

Re: svn commit: r1294273 - /tomcat/native/branches/1.1.x/README.txt

2012-02-27 Thread Mladen Turk
On 02/27/2012 08:19 PM, Konstantin Kolinko wrote: 2012/2/27mt...@apache.org: Author: mturk Date: Mon Feb 27 18:56:02 2012 New Revision: 1294273 URL: http://svn.apache.org/viewvc?rev=1294273view=rev Log: Make some sense out of README. Removed ASL header and added Crypto notice Why are you

[VOTE] Release Apache Tomcat Native 1.1.23

2012-02-28 Thread Mladen Turk
Version 1.1.23 is both bugfix release with couple of additional features that does not change ABI (namely OCSP and pkcs12 support). The proposed release artefacts can be found at [1], and the build was done using tag [2]. Please vote. The vote will be open for at least 72 hours. Apache Tomcat

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-28 Thread Mladen Turk
On 02/27/2012 12:33 AM, Jeremy Boynes wrote: OK. Artefacts re-staged at https://repository.apache.org/content/repositories/orgapachetomcat-084/ +1 Signatures and content OK. Although not sure why you have LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt with the same content (well,

Re: [VOTE] Release Apache Taglibs Parent POM 1

2012-02-28 Thread Mladen Turk
On 02/28/2012 08:57 PM, sebb wrote: On 28 February 2012 16:43, Mladen Turkmt...@apache.org wrote: Although not sure why you have LICENSE and LICENSE.txt as well as NOTICE and NOTICE.txt with the same content That is probably caused by the Apache POM, which tries to be helpful by adding the

[RESULT] Was: [VOTE] Release Apache Tomcat Native 1.1.23

2012-03-02 Thread Mladen Turk
With my implicit +1 we 4 +1's (Henri, Filip, Jean-Frederic and I) and no other votes. I declare vote as passed. On 02/28/2012 03:39 PM, Mladen Turk wrote: Version 1.1.23 is both bugfix release with couple of additional features that does not change ABI (namely OCSP and pkcs12 support

[ANN] Apache Tomcat Native 1.1.23 released

2012-03-02 Thread Mladen Turk
The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.1.23 stable. Please refer to the change log for the list of changes: http://tomcat.apache.org/native-doc/miscellaneous/changelog.html Downloads: http://tomcat.apache.org/download-native.cgi Please allow up to

Re: svn commit: r1296630 - in /tomcat/jk/trunk: native/common/jk_util.c xdocs/miscellaneous/changelog.xml

2012-03-03 Thread Mladen Turk
On 03/03/2012 03:41 PM, rj...@apache.org wrote: Author: rjung Date: Sat Mar 3 14:41:12 2012 New Revision: 1296630 URL: http://svn.apache.org/viewvc?rev=1296630view=rev Log: BZ 52793: Fix default value of forwarded worker activation state. Think we've been holding 1.2.33 for a quite time. I

<    4   5   6   7   8   9   10   11   12   >