Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 16/02/2021 15:28, Rémy Maucherat wrote:
> On Tue, Feb 16, 2021 at 3:54 PM  wrote:
> 
>> The Buildbot has detected a new failure on builder tomcat-trunk while
>> building tomcat. Full details are available at:
>> https://ci.apache.org/builders/tomcat-trunk/builds/5682
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: asf946_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
>> triggered this build
>> Build Source Stamp: [branch master]
>> 01ceebb8e2aeaad7eea97982900928a3dbaf3056
>> Blamelist: remm 
>>
>> BUILD FAILED: failed compile_1
>>
> 
> A certificate has expired.
> https://ci.apache.org/projects/tomcat/tomcat10/logs/5682/TEST-org.apache.tomcat.util.net.TestSSLHostConfigCompat.NIO.txt

I'll update them. Hopefully later today.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Tue, Feb 16, 2021 at 3:54 PM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/5682
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf946_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch master]
> 01ceebb8e2aeaad7eea97982900928a3dbaf3056
> Blamelist: remm 
>
> BUILD FAILED: failed compile_1
>

A certificate has expired.
https://ci.apache.org/projects/tomcat/tomcat10/logs/5682/TEST-org.apache.tomcat.util.net.TestSSLHostConfigCompat.NIO.txt

Rémy


>
> Sincerely,
>  -The Buildbot
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 27/01/2021 09:05, Konstantin Kolinko wrote:
> ср, 27 янв. 2021 г. в 11:14, Mark Thomas :
>>
>> On 27/01/2021 07:52, Mark Thomas wrote:
>>> On 27/01/2021 04:51, build...@apache.org wrote:



 BUILD FAILED: failed compile
>>>
>>> This is because the CI system uses NSIS 2.something to work around an
>>> incompatibility with NSIS 3 and wine. That was a while ago. I guess it
>>> is worth checking if the issue still exists as a first step in deciding
>>> how to handle this.
>>
>> Woot! I don't see the issue locally. I'll get the CI system updated.
>> This also opens up the option of building releases on Linux.
> 
> FYI:
> I added the "Unicode true" command to the .nsi file as NSIS 3.05
> deprecated support for ANSI. [1]
> When I build with the current version (3.06.1), it prints a warning
> unless that line is added.
> 
> Looking at their changelog [1], it says that starting with the next
> version (3.07) the default value for "Unicode" command will be changed
> to be true, so that explicit Unicode command will not be needed. So
> one option is to remove the "Unicode" line and just ignore the
> warning.

Thanks for the background. That is very helpful.

The CI system is currently on Ubuntu 18.04 LTS but testing shows that
the latest version of wine-stable available for 18.04.LTS and the latest
NSIS 3 are compatible. I have been able to build the installer on the CI
box and use it to install a working Tomcat instance on a local Windows VM.

I am going to go ahead and remove the hack that kept the CI system using
NSIS 2.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Konstantin Kolinko]

ср, 27 янв. 2021 г. в 11:14, Mark Thomas :
>
> On 27/01/2021 07:52, Mark Thomas wrote:
> > On 27/01/2021 04:51, build...@apache.org wrote:
> >> The Buildbot has detected a new failure on builder tomcat-trunk while 
> >> building tomcat. Full details are available at:
> >> https://ci.apache.org/builders/tomcat-trunk/builds/5651
> >>
> >> Buildbot URL: https://ci.apache.org/
> >>
> >> Buildslave for this Build: asf946_ubuntu
> >>
> >> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> >> triggered this build
> >> Build Source Stamp: [branch master] 
> >> 654e01edd2c884af8456be08466f830ab9163dec
> >> Blamelist: Konstantin Kolinko 
> >>
> >> BUILD FAILED: failed compile
> >
> > This is because the CI system uses NSIS 2.something to work around an
> > incompatibility with NSIS 3 and wine. That was a while ago. I guess it
> > is worth checking if the issue still exists as a first step in deciding
> > how to handle this.
>
> Woot! I don't see the issue locally. I'll get the CI system updated.
> This also opens up the option of building releases on Linux.


FYI:
I added the "Unicode true" command to the .nsi file as NSIS 3.05
deprecated support for ANSI. [1]
When I build with the current version (3.06.1), it prints a warning
unless that line is added.

Looking at their changelog [1], it says that starting with the next
version (3.07) the default value for "Unicode" command will be changed
to be true, so that explicit Unicode command will not be needed. So
one option is to remove the "Unicode" line and just ignore the
warning.


[1] Changelog for NSIS:
https://nsis.sourceforge.io/Docs/AppendixF.html

Best regards,
Konstantin Kolinko.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 27/01/2021 07:52, Mark Thomas wrote:
> On 27/01/2021 04:51, build...@apache.org wrote:
>> The Buildbot has detected a new failure on builder tomcat-trunk while 
>> building tomcat. Full details are available at:
>> https://ci.apache.org/builders/tomcat-trunk/builds/5651
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: asf946_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
>> triggered this build
>> Build Source Stamp: [branch master] 654e01edd2c884af8456be08466f830ab9163dec
>> Blamelist: Konstantin Kolinko 
>>
>> BUILD FAILED: failed compile
> 
> This is because the CI system uses NSIS 2.something to work around an
> incompatibility with NSIS 3 and wine. That was a while ago. I guess it
> is worth checking if the issue still exists as a first step in deciding
> how to handle this.

Woot! I don't see the issue locally. I'll get the CI system updated.
This also opens up the option of building releases on Linux.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 27/01/2021 04:51, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/5651
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 654e01edd2c884af8456be08466f830ab9163dec
> Blamelist: Konstantin Kolinko 
> 
> BUILD FAILED: failed compile

This is because the CI system uses NSIS 2.something to work around an
incompatibility with NSIS 3 and wine. That was a while ago. I guess it
is worth checking if the issue still exists as a first step in deciding
how to handle this.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 04/12/2020 08:52, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/5579
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 418986821ddc0859023571a62086f0bd675e9227
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed compile

Looks like my recent changes for TLS attributes triggered this.
Investigating...

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 11/11/2020 09:11, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/5549
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 20edb410286fdfe141dc0178f361493d4f3ca72c
> Blamelist: Martin Tzvetanov Grigorov 
> 
> BUILD FAILED: failed compile_1

This is the TestWebSocketFrameClient.testConnectToRootEndpoint test again.

I've made a little progress with this over the last day or so. What I
know so far:
- The first WebSocket request is processed
- The second is sent to the server (on a new connection)
- The acceptor on the server accepts the new connection
- The new connection is added to the Selector and a key issued
- A short time later the Selector has no keys
- The connection is never selected with a valid attachment

This suggests a something closing the socket or (less likely) a Selector
bug.

There appears to be a timing aspect to the failure. Adding and removing
debug logging is impacting my ability to recreate the failure. I am able
to trigger the issue ~20% of the time on a full NIO test run. I am
currently working on trying to recreate the issue more reliably and on
shorter test runs.

At the moment, it feels like I am making some progress so I plan to keep
working on this rather than tagging 10.0.x etc. I don't want to delay
the tags too long so my current thinking is keep working on this bug for
today and tag tomorrow. Any (lack of) progress may change that view.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 26/05/2020 13:00, Rémy Maucherat wrote:
> On Tue, May 26, 2020 at 1:25 PM Mark Thomas  > wrote:
> 



> The ASF's Nexus instance was upgraded over the weekend. This looks like
> an issue related to the upgrade.
> 
> I haven't dug into what is going on.
> 
> 
> Trying to access manually, it doesn't seem really up.
> 
> Speaking of upgrades, it would be nice to run the package update on
> asf946_ubuntu to get Java 8_251 (or 252), so that I can switch Tomcat 10
> to simply use the ALPN TLS API.

It isn't quite that simple (or I'd do it).

The build slaves are managed under Puppet so info needs to:

- create a package for the new version of Java
- update the build slaves to use it

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Tue, May 26, 2020 at 1:25 PM Mark Thomas  wrote:

> On 26/05/2020 12:22, build...@apache.org wrote:
> > The Buildbot has detected a new failure on builder tomcat-trunk while
> building tomcat. Full details are available at:
> > https://ci.apache.org/builders/tomcat-trunk/builds/5196
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: asf946_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> > Build Source Stamp: [branch master]
> 7e52e77653fc0ea1f409ea949a462e581a2b3776
> > Blamelist: Mark Thomas 
> >
> > BUILD FAILED: failed shell_11
>
> Deploying the snapshot failed.
>
> The ASF's Nexus instance was upgraded over the weekend. This looks like
> an issue related to the upgrade.
>
> I haven't dug into what is going on.
>

Trying to access manually, it doesn't seem really up.

Speaking of upgrades, it would be nice to run the package update on
asf946_ubuntu to get Java 8_251 (or 252), so that I can switch Tomcat 10 to
simply use the ALPN TLS API.

Rémy

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 26/05/2020 12:22, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/5196
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 7e52e77653fc0ea1f409ea949a462e581a2b3776
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed shell_11

Deploying the snapshot failed.

The ASF's Nexus instance was upgraded over the weekend. This looks like
an issue related to the upgrade.

I haven't dug into what is going on.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Fri, Mar 20, 2020 at 11:39 AM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/5040
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf946_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch master]
> a6a0abcfb1bf71f527804ce872d68d2f3c231cf9
> Blamelist: remm 
>
> BUILD FAILED: failed compile_1
>

First time I see that:

Testcase: testWriteTimeoutClientContainer took -34.636 sec
FAILED
Time out was [-35156] ms
junit.framework.AssertionFailedError: Time out was [-35156] ms
at
org.apache.tomcat.websocket.TestWsWebSocketContainer.doTestWriteTimeoutClient(TestWsWebSocketContainer.java:371)
at
org.apache.tomcat.websocket.TestWsWebSocketContainer.testWriteTimeoutClientContainer(TestWsWebSocketContainer.java:303)

This test ran fast ! So I think the oddity made that timeout test fail.

Rémy



>
> Sincerely,
>  -The Buildbot
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 10/02/2020 19:45, Rémy Maucherat wrote:
> On Mon, Feb 10, 2020 at 6:15 PM  > wrote:
> 
> The Buildbot has detected a new failure on builder tomcat-trunk
> while building tomcat. Full details are available at:
>     https://ci.apache.org/builders/tomcat-trunk/builds/4929
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named
> 'on-tomcat-commit' triggered this build
> Build Source Stamp: [branch master]
> eac3c266c525b975d1fbc776a81f9dcea2cb5b0e
> Blamelist: Markus Lottmann  >
> 
> BUILD FAILED: failed compile_1
> 
> 
> A HTTP/2 failure, it's been a long while ...
> https://ci.apache.org/projects/tomcat/tomcat10/logs/4929/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO.txt
> vs
> https://ci.apache.org/projects/tomcat/tomcat10/logs/4929/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO2.txt
> 
> I would say the abuse closed the stream after apparently seeing two 1
> byte body frames. Odd. Just a guess at this point.

Good guess. Looks consistent with the trace and the test configuration.

I did occasionally see repeated 1-byte data frames on the same stream
running this test. It all depends on timing (see the long comment in the
middle of the test).

I'll disabled the small data frame protection for that test as well.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Mon, Feb 10, 2020 at 6:15 PM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4929
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf946_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch master]
> eac3c266c525b975d1fbc776a81f9dcea2cb5b0e
> Blamelist: Markus Lottmann 
>
> BUILD FAILED: failed compile_1
>

A HTTP/2 failure, it's been a long while ...
https://ci.apache.org/projects/tomcat/tomcat10/logs/4929/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO.txt
vs
https://ci.apache.org/projects/tomcat/tomcat10/logs/4929/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO2.txt

I would say the abuse closed the stream after apparently seeing two 1 byte
body frames. Odd. Just a guess at this point.

Rémy


>
> Sincerely,
>  -The Buildbot
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: buildbot failure in on tomcat-trunk

[Michael Osipov]

Am 2019-11-09 um 02:24 schrieb Konstantin Kolinko:

сб, 9 нояб. 2019 г. в 02:32, Michael Osipov :


Am 2019-11-09 um 00:19 schrieb build...@apache.org:

The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
  https://ci.apache.org/builders/tomcat-trunk/builds/4713

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 69602cb1ef0dc3aa2188a1b3be9fa3a1440cd1b1
Blamelist: Michael Osipov 


Folks,

is there a way to access the build directory on that node or retrigger
the build?
The failure looks pretty epheremal to me, but want to make sure.


http://tomcat.apache.org/ci.html#Buildbot
https://ci.apache.org/projects/tomcat/tomcat9/logs/4713/


Thank you, I was looking for this file.


The failing test is org.apache.coyote.http2.TestHttp2InitialConnection
# testMultipleHostHeaders[0]
# testNoHostHeader[0]


expected:<...r-[content-length]-[[1131]

...

but was:<...r-[content-length]-[[766]


The expected size of the page is hardcoded in the test, and your
change saved 365 bytes.

See the following line in TestHttp2InitialConnection.
int len = 1073 + serverInfoLength + statusHeaderLength * 2;


Confirmed on two different OSes and JVMs here.

Again,

thank you!


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Konstantin Kolinko]

сб, 9 нояб. 2019 г. в 02:32, Michael Osipov :
>
> Am 2019-11-09 um 00:19 schrieb build...@apache.org:
> > The Buildbot has detected a new failure on builder tomcat-trunk while 
> > building tomcat. Full details are available at:
> >  https://ci.apache.org/builders/tomcat-trunk/builds/4713
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: asf946_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> > triggered this build
> > Build Source Stamp: [branch master] 69602cb1ef0dc3aa2188a1b3be9fa3a1440cd1b1
> > Blamelist: Michael Osipov 
>
> Folks,
>
> is there a way to access the build directory on that node or retrigger
> the build?
> The failure looks pretty epheremal to me, but want to make sure.

http://tomcat.apache.org/ci.html#Buildbot
https://ci.apache.org/projects/tomcat/tomcat9/logs/4713/

The failing test is org.apache.coyote.http2.TestHttp2InitialConnection
# testMultipleHostHeaders[0]
# testNoHostHeader[0]

> expected:<...r-[content-length]-[[1131]
...
> but was:<...r-[content-length]-[[766]

The expected size of the page is hardcoded in the test, and your
change saved 365 bytes.

See the following line in TestHttp2InitialConnection.
int len = 1073 + serverInfoLength + statusHeaderLength * 2;

.Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Michael Osipov]

Am 2019-11-09 um 00:19 schrieb build...@apache.org:

The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
 https://ci.apache.org/builders/tomcat-trunk/builds/4713

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 69602cb1ef0dc3aa2188a1b3be9fa3a1440cd1b1
Blamelist: Michael Osipov 


Folks,

is there a way to access the build directory on that node or retrigger 
the build?

The failure looks pretty epheremal to me, but want to make sure.

Michael

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 04/11/2019 15:44, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4698
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 066e254674dcceaf18311d31cc579488bf7ce827
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed compile_1

>From the logs:

Testcase: testBasicLoginSessionTimeout took -14.092 sec

Tests taking negative time...  I think this failure is safe to ignore.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 15/10/2019 15:02, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4672
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] a80693f3d4f9c2628f9f1c978f65af9bef8ce04e
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed compile_1

Sorry. I think this is me. The new async tests ran perfectly in my IDE
and on the command line but it looks like there is a timing issue. I'm
looking into it.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 24/09/2019 17:36, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4625
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 709978183d763b27009b0d02908ae1eda50308dd
> Blamelist: Mark Thomas ,remm 
> 
> BUILD FAILED: failed compile_1

This is back now I have reverted the incorrect that just changed the
timing enough to reduce the chances of this.

Still working on a proper fix.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 01/08/2019 21:39, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4526
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] bb0befeebe18a9b8ff50e686a3d06e84ccdfb108
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed compile_1

This has been caused by the changes to o.a.t.u.codec.binary.Base64

It looks like I'm going to need to dig into the RFC to figure out what
the root cause is.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 29/05/2019 16:20, Rémy Maucherat wrote:
> On Wed, May 29, 2019 at 4:54 PM  > wrote:
> 
> The Buildbot has detected a new failure on builder tomcat-trunk
> while building tomcat. Full details are available at:
>     https://ci.apache.org/builders/tomcat-trunk/builds/4401
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named
> 'on-tomcat-commit' triggered this build
> Build Source Stamp: [branch master]
> 339b40bc07bdba9ded565929b9a3448c5a78f015
> Blamelist: remm mailto:r...@apache.org>>
> 
> BUILD FAILED: failed compile_1
> 
> 
> This is apparently the return of the fake window update timeout (in a
> different way, since it wasn't happening here before).

I've figured out what is going on here. Looking at thread 21 the
following sequence of events occurs:

- allocated 1 byte from the connection window (total allocation = 1)
- notified
- allocated 1 byte from the connection window (total allocation = 2)
- write 2 bytes (total allocation = 0)
- notified
- timeout since allocation is currently zero.

What should happen is:
- allocated 1 byte from the connection window (total allocation = 1)
- notified
- write 1 byte (total allocation = 0)
- allocated 1 byte from the connection window (total allocation = 1)
- notified
- write 1 bytes (total allocation = 0)

I haven't figured out how to fix this yet.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Wed, May 29, 2019 at 4:54 PM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4401
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch master]
> 339b40bc07bdba9ded565929b9a3448c5a78f015
> Blamelist: remm 
>
> BUILD FAILED: failed compile_1
>

This is apparently the return of the fake window update timeout (in a
different way, since it wasn't happening here before).

From
https://ci.apache.org/projects/tomcat/tomcat9/logs/4401/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO.txt

29-May-2019 14:36:14.863 FINE [http-nio-127.0.0.1-auto-2-exec-2]
org.apache.coyote.http2.Http2UpgradeHandler.incrementWindowSize Connection
[1], Stream [21] released from backlog
29-May-2019 14:36:14.863 FINE [http-nio-127.0.0.1-auto-2-exec-4]
org.apache.coyote.http2.Http2AsyncUpgradeHandler.writeBody Connection [1],
Stream [19], Data length [1]
29-May-2019 14:36:14.863 FINE [http-nio-127.0.0.1-auto-2-exec-2]
org.apache.coyote.http2.Http2UpgradeHandler.incrementWindowSize Connection
[1], Stream [21], notify() called to release StreamOutputBuffer
29-May-2019 14:36:14.863 FINE [http-nio-127.0.0.1-auto-2-exec-3]
org.apache.coyote.http2.Http2UpgradeHandler.reserveWindowSize Connection
[1], Stream [21], Timeout waiting for allocation

Rémy

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 10/05/2019 10:55, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4324

Hmmm. Looks like my analysis was off. Investigating now...

Mark


> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 229b2a169505672ef288204ed59cb6e2723e595c
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed compile_1
> 
> Sincerely,
>  -The Buildbot
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Thu, Apr 18, 2019 at 10:28 AM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4230
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch master]
> 96042f7e195ef00a685e202256053b3d426c2e1b
> Blamelist: remm 
>
> BUILD FAILED: failed compile_1
>

https://ci.apache.org/projects/tomcat/tomcat9/logs/4230/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.APR.txt
Odd JVM start error. It doesn't look like a crash while running. Hardware
issue ?

Rémy

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Wed, Mar 27, 2019 at 11:42 AM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4165
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch master]
> 950b940c6abdc1b674278c59c6bd6672a23120ea
> Blamelist: remm 
>
> BUILD FAILED: failed compile_1
>

https://ci.apache.org/projects/tomcat/tomcat9/logs/4165/TEST-org.apache.coyote.http2.TestAsync.NIO2.txt
I haven't seen this failure scenario before, the content is ok, but the
last closing frame was a connection error rather than the end of stream.
Maybe a race on close of some sort.

Rémy


>
> Sincerely,
>  -The Buildbot
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: buildbot failure in on tomcat-trunk

[Igal Sapir]

Is there a known issue with BuildBot?

[concat] Testsuites with failed tests: [concat] 
TEST-org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt 



I don't believe that my commit, adding an ant target [1], is related.

8.5 also failed, but with another unit test:

[concat] Testsuites with failed tests: [concat] 
TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt


Thanks,

Igal

[1] https://github.com/apache/tomcat/commit/8a2f41bed80a


On 3/15/2019 2:01 PM, build...@apache.org wrote:

The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
 https://ci.apache.org/builders/tomcat-trunk/builds/4143

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 8a2f41bed80a96bd6d711594ea8b6b7f0f1451da
Blamelist: Igal Sapir 

BUILD FAILED: failed compile_1

Sincerely,
  -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 14/03/2019 14:06, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/4135
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch master] 8a1d9a05327c498d498716d205f0b63f64c3d64a
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed compile_1

The new charset cache code is missing a number of aliases. I need to
re-work the unit tests.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 14/12/2018 17:52, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3923
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1848959
> Blamelist: markt
> 
> BUILD FAILED: failed compile_1

Ah.

That will be the content-length header I just added.

Working on the fixes now...

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 13/12/2018 00:01, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3900
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1848810
> Blamelist: markt
> 
> BUILD FAILED: failed compile_1

These are not the failures I'm looking for.

One JVM crash (no idea why) and one HTTP/2 failure. I've increased the
margins allowed for strange timing behaviour for the HTTP/2 test but
unless I am missing something it is mighty unusual.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 12/12/2018 20:27, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3891
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1848789
> Blamelist: markt
> 
> BUILD FAILED: failed compile_1

Just my luck. Not the failure I was trying to trigger. This one is:

Testcase: testEmptyWindow[10: expandConnectionFirst[false],
connectionUnlimited[true], streamUnlimited[false],
useNonContainerThreadForWrite[true],largeInitialWindow[false]] took
0.537 sec
FAILED
expected:<262144> but was:<229376>
junit.framework.AssertionFailedError: expected:<262144> but was:<229376>
at org.apache.coyote.http2.TestAsync.testEmptyWindow(TestAsync.java:202)

Nothing else helpful I can see in the logs.

The response is exactly one data block short. Looking...

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Thu, Nov 8, 2018 at 11:57 AM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3719
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1846118
> Blamelist: remm
>
> BUILD FAILED: failed compile_1
>
> One of my last minute changes to include the backgound process monitor
probably broke something. I'll fix it shortly.

Rémy

Re: buildbot failure in on tomcat-trunk

[Igal Sapir]

It's the same test case that failed yesterday:

   [concat] Testsuites with failed tests:
   [concat] TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt

Igal


On Tue, Oct 23, 2018 at 10:37 PM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3679
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1844723
> Blamelist: isapir
>
> BUILD FAILED: failed compile_1
>
> Sincerely,
>  -The Buildbot
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: buildbot failure in on tomcat-trunk

[Igal Sapir]

Rainer,

On Tue, Oct 23, 2018 at 1:03 AM Rainer Jung  wrote:

> Am 23.10.2018 um 07:08 schrieb Igal Sapir:
> > I am able to build locally on that same revision.
> >
> > Any ideas?
>
> You can see the reason by looking at the link included in the mail:
>
> https://ci.apache.org/builders/tomcat-trunk/builds/3677
>
> On that page there's a red entry for "compile_1" and a link to its
> "stdio" (output text):
>

I got to the link above, but I didn't see the link to the below until you
pointed it out, thanks.


>
>
> https://ci.apache.org/builders/tomcat-trunk/builds/3677/steps/compile_1/logs/stdio
>
> That large output shows at the end, that running the tests failed for
> TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt
>
> Running the tests is part of the build bot compile_1 step.
>

Understood.  I only modified the documentation so I tested with `ant
build-docs` and `ant clean deploy`.  It makes sense though.


> I always forget where to find the detailed per test run output files.
> But I vaguely remember, that this specific test (TestCoyoteOutputStream
> for NIO2) sometimes fails for yet to be determined reasons.
>

There is a suggestion to search for "ERROR" in the logs, but there is a
test case that produces a log entry with "MUST_ERROR", which is a false
positive.  I wonder if we can change that?

[junit] Exception in thread "testBug54928"
java.lang.IllegalStateException: Calling [asyncComplete()] is not
valid for a request with Async state [MUST_ERROR]



> And the following build again succeeded.
>

Is there a way to trigger a new build without a commit, or should I try a
"dummy" commit to trigger a build if I suspect that there was an
intermittent problem with a test case?

Thank you,

Igal



> Regards,
>
> Rainer
>
>
> > On Mon, Oct 22, 2018 at 9:51 PM  wrote:
> >
> >> The Buildbot has detected a new failure on builder tomcat-trunk while
> >> building . Full details are available at:
> >>  https://ci.apache.org/builders/tomcat-trunk/builds/3677
> >>
> >> Buildbot URL: https://ci.apache.org/
> >>
> >> Buildslave for this Build: silvanus_ubuntu
> >>
> >> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> >> triggered this build
> >> Build Source Stamp: [branch tomcat/trunk] 1844615
> >> Blamelist: isapir
> >>
> >> BUILD FAILED: failed compile_1
> >>
> >> Sincerely,
> >>   -The Buildbot
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: buildbot failure in on tomcat-trunk

[Rainer Jung]

Am 23.10.2018 um 07:08 schrieb Igal Sapir:

I am able to build locally on that same revision.

Any ideas?


You can see the reason by looking at the link included in the mail:

https://ci.apache.org/builders/tomcat-trunk/builds/3677

On that page there's a red entry for "compile_1" and a link to its 
"stdio" (output text):


https://ci.apache.org/builders/tomcat-trunk/builds/3677/steps/compile_1/logs/stdio

That large output shows at the end, that running the tests failed for 
TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt


Running the tests is part of the build bot compile_1 step.

I always forget where to find the detailed per test run output files. 
But I vaguely remember, that this specific test (TestCoyoteOutputStream 
for NIO2) sometimes fails for yet to be determined reasons.


And the following build again succeeded.

Regards,

Rainer



On Mon, Oct 22, 2018 at 9:51 PM  wrote:


The Buildbot has detected a new failure on builder tomcat-trunk while
building . Full details are available at:
 https://ci.apache.org/builders/tomcat-trunk/builds/3677

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1844615
Blamelist: isapir

BUILD FAILED: failed compile_1

Sincerely,
  -The Buildbot


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Igal Sapir]

I am able to build locally on that same revision.

Any ideas?

Igal

On Mon, Oct 22, 2018 at 9:51 PM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3677
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1844615
> Blamelist: isapir
>
> BUILD FAILED: failed compile_1
>
> Sincerely,
>  -The Buildbot
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 21 June 2018 16:42:35 BST, Gav  wrote:
>done ;)

Thanks. I appreciate you going that extra mile for the project.

Mark


>
>On Thu, Jun 21, 2018 at 4:37 PM, Mark Thomas  wrote:
>
>> On 21 June 2018 15:31:52 BST, Emmanuel Bourg 
>wrote:
>> >Le 21/06/2018 à 16:25, Rémy Maucherat a écrit :
>> >
>> >> Is the Ant of the build platform upgradeable already ?
>> >
>> >I thought so [1] but it seems there is still an issue.
>> >
>> >Emmanuel Bourg
>> >
>> >[1] https://issues.apache.org/jira/browse/INFRA-16673
>> >
>>
>>-
>> >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> >For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>> I haven't switched the building script over to the updated Ant 1.9
>install
>> yet. I'll be able to do that in an hour or so unless someone beats me
>to it.
>>
>> Mark
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Gav]

done ;)

On Thu, Jun 21, 2018 at 4:37 PM, Mark Thomas  wrote:

> On 21 June 2018 15:31:52 BST, Emmanuel Bourg  wrote:
> >Le 21/06/2018 à 16:25, Rémy Maucherat a écrit :
> >
> >> Is the Ant of the build platform upgradeable already ?
> >
> >I thought so [1] but it seems there is still an issue.
> >
> >Emmanuel Bourg
> >
> >[1] https://issues.apache.org/jira/browse/INFRA-16673
> >
> >-
> >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> I haven't switched the building script over to the updated Ant 1.9 install
> yet. I'll be able to do that in an hour or so unless someone beats me to it.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Gav...

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 21 June 2018 15:31:52 BST, Emmanuel Bourg  wrote:
>Le 21/06/2018 à 16:25, Rémy Maucherat a écrit :
>
>> Is the Ant of the build platform upgradeable already ?
>
>I thought so [1] but it seems there is still an issue.
>
>Emmanuel Bourg
>
>[1] https://issues.apache.org/jira/browse/INFRA-16673
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org

I haven't switched the building script over to the updated Ant 1.9 install yet. 
I'll be able to do that in an hour or so unless someone beats me to it.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Emmanuel Bourg]

Le 21/06/2018 à 16:25, Rémy Maucherat a écrit :

> Is the Ant of the build platform upgradeable already ?

I thought so [1] but it seems there is still an issue.

Emmanuel Bourg

[1] https://issues.apache.org/jira/browse/INFRA-16673

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

On Thu, Jun 21, 2018 at 4:18 PM  wrote:

> The Buildbot has detected a new failure on builder tomcat-trunk while
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3383
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1834020
> Blamelist: ebourg
>
> BUILD FAILED: failed compile
>

I had to immediately upgrade my Ant too. Is the Ant of the build platform
upgradeable already ?

Rémy

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 21/06/18 13:35, Gav wrote:
> I'll add 1.9.11 and ensure previous version remains also.

Tx Gav.

I'll wait until 1.9.11 is in place and then switch the Tomcat builds to
use the latest 1.9.x release (Gav mentioned on HipChat that he'd set up
an additional symlink to point to the latest 1.9.x version).

Mark


> 
> Gav...
> 
> On Thu, Jun 21, 2018 at 1:31 PM, Mark Thomas  wrote:
> 
>> On 21/06/18 13:14, Gav wrote:
>>> Wierd, it passed on the same machine only 2 hours earlier:--
>>>
>>> https://ci.apache.org/builders/tomcat-trunk/builds/3378
>>>
>>> as an FYI
>>>
>>> gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant
>>> -version
>>> Apache Ant(TM) version 1.10.3 compiled on March 24 2018
>>> gmcdonald@silvanus:~$ ant -version
>>> Apache Ant(TM) version 1.9.6 compiled on July 8 2015
>>>
>>> Your build points to
>>>
>>> ANT_HOME=/home/buildslave/slave/tools/ant/current
>>>
>>> but should be
>>>
>>> ANT_HOME=/home/buildslave/slave/tools/ant/latest
>>
>> Hmm.
>>
>> We are going to need to be careful with this. The older Tomcat branches
>> need to build on old Java versions so we need to look at Ant / Java
>> version compatibility as well.
>>
>> /me heads off to check the Ant docs for minimum Java versions
>>
>> Mark
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 21/06/18 13:31, Mark Thomas wrote:
> On 21/06/18 13:14, Gav wrote:
>> Wierd, it passed on the same machine only 2 hours earlier:--
>>
>> https://ci.apache.org/builders/tomcat-trunk/builds/3378
>>
>> as an FYI
>>
>> gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant
>> -version
>> Apache Ant(TM) version 1.10.3 compiled on March 24 2018
>> gmcdonald@silvanus:~$ ant -version
>> Apache Ant(TM) version 1.9.6 compiled on July 8 2015
>>
>> Your build points to
>>
>> ANT_HOME=/home/buildslave/slave/tools/ant/current
>>
>> but should be
>>
>> ANT_HOME=/home/buildslave/slave/tools/ant/latest
> 
> Hmm.
> 
> We are going to need to be careful with this. The older Tomcat branches
> need to build on old Java versions so we need to look at Ant / Java
> version compatibility as well.
> 
> /me heads off to check the Ant docs for minimum Java versions

That was easier than I expected:
The 1.9.x releases require Java5 at runtime and 1.10.x requires Java8 at
runtime.

I'll switch us to the latest 1.9.x for all builds. Easier if we use the
same version throughout.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Emmanuel Bourg]

Le 21/06/2018 à 14:31, Mark Thomas a écrit :

> We are going to need to be careful with this. The older Tomcat branches
> need to build on old Java versions so we need to look at Ant / Java
> version compatibility as well.
> 
> /me heads off to check the Ant docs for minimum Java versions

Ant 1.9.x preserves the Java 5 compatibility. The required JDK only
changed with the 1.10.x line to Java 8.

I suggest sticking to Ant 1.9.x for all supported Tomcat versions until
Tomcat 8.5 is EOLed.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Gav]

I'll add 1.9.11 and ensure previous version remains also.

Gav...

On Thu, Jun 21, 2018 at 1:31 PM, Mark Thomas  wrote:

> On 21/06/18 13:14, Gav wrote:
> > Wierd, it passed on the same machine only 2 hours earlier:--
> >
> > https://ci.apache.org/builders/tomcat-trunk/builds/3378
> >
> > as an FYI
> >
> > gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant
> > -version
> > Apache Ant(TM) version 1.10.3 compiled on March 24 2018
> > gmcdonald@silvanus:~$ ant -version
> > Apache Ant(TM) version 1.9.6 compiled on July 8 2015
> >
> > Your build points to
> >
> > ANT_HOME=/home/buildslave/slave/tools/ant/current
> >
> > but should be
> >
> > ANT_HOME=/home/buildslave/slave/tools/ant/latest
>
> Hmm.
>
> We are going to need to be careful with this. The older Tomcat branches
> need to build on old Java versions so we need to look at Ant / Java
> version compatibility as well.
>
> /me heads off to check the Ant docs for minimum Java versions
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Gav...

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 21/06/18 13:14, Gav wrote:
> Wierd, it passed on the same machine only 2 hours earlier:--
> 
> https://ci.apache.org/builders/tomcat-trunk/builds/3378
> 
> as an FYI
> 
> gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant
> -version
> Apache Ant(TM) version 1.10.3 compiled on March 24 2018
> gmcdonald@silvanus:~$ ant -version
> Apache Ant(TM) version 1.9.6 compiled on July 8 2015
> 
> Your build points to
> 
> ANT_HOME=/home/buildslave/slave/tools/ant/current
> 
> but should be
> 
> ANT_HOME=/home/buildslave/slave/tools/ant/latest

Hmm.

We are going to need to be careful with this. The older Tomcat branches
need to build on old Java versions so we need to look at Ant / Java
version compatibility as well.

/me heads off to check the Ant docs for minimum Java versions

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Emmanuel Bourg]

Le 21/06/2018 à 14:14, Gav a écrit :
> Wierd, it passed on the same machine only 2 hours earlier:--
> 
> https://ci.apache.org/builders/tomcat-trunk/builds/3378

This build fetched r1833989, but the issue is with r1833994 which used
an Ant feature requiring at least the version 1.9.8.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Emmanuel Bourg]

Le 21/06/2018 à 14:00, Mark Thomas a écrit :

> Infra ticket.

Ok: https://issues.apache.org/jira/browse/INFRA-16673


> And please revert the change until it is updated so the CI system
> continues to work.

Done in r1834001

Thank you for the guidance.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Gav]

Wierd, it passed on the same machine only 2 hours earlier:--

https://ci.apache.org/builders/tomcat-trunk/builds/3378

as an FYI

gmcdonald@silvanus:~$ /home/buildslave/slave/tools/ant/latest/bin/ant
-version
Apache Ant(TM) version 1.10.3 compiled on March 24 2018
gmcdonald@silvanus:~$ ant -version
Apache Ant(TM) version 1.9.6 compiled on July 8 2015

Your build points to

ANT_HOME=/home/buildslave/slave/tools/ant/current

but should be

ANT_HOME=/home/buildslave/slave/tools/ant/latest


If you change that in your config file then it might pick up the 1.10
version better
Which doesnt explain how it has been passing all this time unless you have
just
added changes today that are Ant 1.9 incompatible.

https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/tomcat.conf

HTH

Gav...

On Thu, Jun 21, 2018 at 12:46 PM, Emmanuel Bourg  wrote:

> Le 21/06/2018 à 13:01, build...@apache.org a écrit :
> > The Buildbot has detected a new failure on builder tomcat-trunk while
> building . Full details are available at:
> > https://ci.apache.org/builders/tomcat-trunk/builds/3379
>
> It looks like Ant needs an upgrade on the builders. Is there a way to
> configure the version of Ant used to build Tomcat, or should I open an
> Infra ticket to get it updated?
>
> Emmanuel Bourg
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Gav...

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 21/06/18 12:46, Emmanuel Bourg wrote:
> Le 21/06/2018 à 13:01, build...@apache.org a écrit :
>> The Buildbot has detected a new failure on builder tomcat-trunk while 
>> building . Full details are available at:
>> https://ci.apache.org/builders/tomcat-trunk/builds/3379
> 
> It looks like Ant needs an upgrade on the builders. Is there a way to
> configure the version of Ant used to build Tomcat, or should I open an
> Infra ticket to get it updated?

Infra ticket.

And please revert the change until it is updated so the CI system
continues to work.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Emmanuel Bourg]

Le 21/06/2018 à 13:01, build...@apache.org a écrit :
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3379

It looks like Ant needs an upgrade on the builders. Is there a way to
configure the version of Ant used to build Tomcat, or should I open an
Infra ticket to get it updated?

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Konstantin Kolinko]

2018-05-05 19:38 GMT+03:00  :
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3241
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1830989
> Blamelist: kkolinko
>
> BUILD FAILED: failed compile_1

This is odd.
Failed test class:
TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt

Testsuite: org.apache.catalina.connector.TestCoyoteOutputStream
Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.197 sec

Failed test case:

Testcase: testNonBlockingWriteTwiceBlockingWriteNoneNonContainerThread
took 0.149 sec
Caused an ERROR
missing CR
java.io.IOException: missing CR
at sun.net.www.http.ChunkedInputStream.processRaw(ChunkedInputStream.java:405)
at 
sun.net.www.http.ChunkedInputStream.readAheadBlocking(ChunkedInputStream.java:572)
at sun.net.www.http.ChunkedInputStream.readAhead(ChunkedInputStream.java:609)
at sun.net.www.http.ChunkedInputStream.read(ChunkedInputStream.java:696)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at 
sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:3393)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
at java.io.FilterInputStream.read(FilterInputStream.java:107)
at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:705)
at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:663)
at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:657)
at 
org.apache.catalina.connector.TestCoyoteOutputStream.doNonBlockingTest(TestCoyoteOutputStream.java:145)
at 
org.apache.catalina.connector.TestCoyoteOutputStream.testNonBlockingWriteTwiceBlockingWriteNoneNonContainerThread(TestCoyoteOutputStream.java:87)

All other tests are OK.


https://ci.apache.org/projects/tomcat/tomcat9/logs/1830989/TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Konstantin Kolinko]

2018-02-07 0:20 GMT+03:00  :
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/3031
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: silvanus_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1823392
> Blamelist: markt
>
> BUILD FAILED: failed compile_1

Failed test:

https://ci.apache.org/projects/tomcat/tomcat9/logs/1823392/TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt

Testcase: testNonBlockingWriteOnceBlockingWriteOnceNonContainerThread
took 0.234 sec
Caused an ERROR
Bogus chunk size
java.io.IOException: Bogus chunk size
at sun.net.www.http.ChunkedInputStream.processRaw(ChunkedInputStream.java:319)
at 
sun.net.www.http.ChunkedInputStream.readAheadBlocking(ChunkedInputStream.java:572)
at sun.net.www.http.ChunkedInputStream.readAhead(ChunkedInputStream.java:609)
at sun.net.www.http.ChunkedInputStream.read(ChunkedInputStream.java:696)
at java.io.FilterInputStream.read(FilterInputStream.java:133)
at 
sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(HttpURLConnection.java:3393)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:246)
at java.io.BufferedInputStream.read1(BufferedInputStream.java:286)
at java.io.BufferedInputStream.read(BufferedInputStream.java:345)
at java.io.FilterInputStream.read(FilterInputStream.java:107)
at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:696)
at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:654)
at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:648)
at 
org.apache.catalina.connector.TestCoyoteOutputStream.doNonBlockingTest(TestCoyoteOutputStream.java:145)
at 
org.apache.catalina.connector.TestCoyoteOutputStream.testNonBlockingWriteOnceBlockingWriteOnceNonContainerThread(TestCoyoteOutputStream.java:97)




Good news: it is not the test that was fixed in r1823392.
(r1823392 did not break things).

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 15/01/18 22:46, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/2966
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1821202
> Blamelist: markt
> 
> BUILD FAILED: failed compile_1

Hmm. Looks like my AbstractChunk changes have broken things.
Investigating now.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 20/04/17 12:59, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/2328
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1792043
> Blamelist: markt
> 
> BUILD FAILED: failed shell_8

This is me trying to get snapshots deployed to the ASF Maven snaphsot
repo with every build.

The current problem is that the Maven Ant tasks we need aren't on the
build slave.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 09/03/17 00:03, Mark Thomas wrote:
> On 08/03/17 22:56, build...@apache.org wrote:
>> The Buildbot has detected a new failure on builder tomcat-trunk while 
>> building . Full details are available at:
>> https://ci.apache.org/builders/tomcat-trunk/builds/2165
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: bb_1604_test_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
>> triggered this build
>> Build Source Stamp: [branch tomcat/trunk] 1786089
>> Blamelist: markt
>>
>> BUILD FAILED: failed compile
> 
> wine + NSIS appears to be less broken on 1604 but still not working. I
> plan on looking at this some more tomorrow.

I wasn't able to make any progress with this. My solution was to
refactor the build so it is easy to switch to NSIS 2.51 for the CI systems.

trunk builds are green again and I'll beback-porting the necessary
changes to 8.5.x and 8.0.x shortly.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 08/03/17 22:56, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/2165
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: bb_1604_test_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1786089
> Blamelist: markt
> 
> BUILD FAILED: failed compile

wine + NSIS appears to be less broken on 1604 but still not working. I
plan on looking at this some more tomorrow.

Mark


> 
> Sincerely,
>  -The Buildbot
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 03/01/2017 17:11, Rémy Maucherat wrote:
> 2017-01-03 17:57 GMT+01:00 Mark Thomas :
> 
>> On 03/01/2017 16:23, build...@apache.org wrote:
>>> The Buildbot has detected a new failure on builder tomcat-trunk while
>> building . Full details are available at:
>>> https://ci.apache.org/builders/tomcat-trunk/builds/2004
>>>
>>> Buildbot URL: https://ci.apache.org/
>>>
>>> Buildslave for this Build: silvanus_ubuntu
>>>
>>> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
>> triggered this build
>>> Build Source Stamp: [branch tomcat/trunk] 1777147
>>> Blamelist: markt
>>>
>>> BUILD FAILED: failed compile_1
>>
>> Odd. The tests timed out. It could be random but my refactoring earlier
>> today has to be a suspect root cause.
>>
>> I'll run the complete test suite locally and see what results I get.
>>
> It was only a simple NPE, fixed now.

Thanks. I just found the same problem and was mulling over whether to
add the null check or restore the code that always created the writer.

Adding the null check works for me.

Thanks for the fix.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Rémy Maucherat]

2017-01-03 17:57 GMT+01:00 Mark Thomas :

> On 03/01/2017 16:23, build...@apache.org wrote:
> > The Buildbot has detected a new failure on builder tomcat-trunk while
> building . Full details are available at:
> > https://ci.apache.org/builders/tomcat-trunk/builds/2004
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: silvanus_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
> triggered this build
> > Build Source Stamp: [branch tomcat/trunk] 1777147
> > Blamelist: markt
> >
> > BUILD FAILED: failed compile_1
>
> Odd. The tests timed out. It could be random but my refactoring earlier
> today has to be a suspect root cause.
>
> I'll run the complete test suite locally and see what results I get.
>
> It was only a simple NPE, fixed now.

Rémy

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 03/01/2017 16:23, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/2004
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1777147
> Blamelist: markt
> 
> BUILD FAILED: failed compile_1

Odd. The tests timed out. It could be random but my refactoring earlier
today has to be a suspect root cause.

I'll run the complete test suite locally and see what results I get.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-trunk

[Mark Thomas]

On 11/03/2016 17:07, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-trunk/builds/1180
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/trunk] 1734592
> Blamelist: markt
> 
> BUILD FAILED: failed compile_1

Strange. This was triggered by the ImportHandler changes I just made. I
need to look into what is going wrong here.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org