Re: TOMEE-2334 merge PR

Yes, of course. That would be great. Thank you. Br, Mitja J. Kotnik pon., 31. dec. 2018 23:25 je oseba Jean-Louis Monteiro < jlmonte...@tomitribe.com> napisala: > Hi and welcome, > > I had a look and it seems to be very good. > I'm happy to merge it for you and we can iterate again on it if

Hello

Happy New year everyone. I'm just starting here. I have been working with Java for some time and would like to contribute. Please let me know if I can be of any help. Best, Rodrigo Graciano -- Rodrigo Graciano rodrigolgraci...@gmail.com

Re: TOMEE-2334 merge PR

Hi and welcome, I had a look and it seems to be very good. I'm happy to merge it for you and we can iterate again on it if needed. What do you think? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Dec 31, 2018 at 9:12 PM Mitja Jeseničnik Kotnik

[GitHub] tomee pull request #336: TOMEE-2436 Get code coverage report from JaCoCo

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/336 ---

TOMEE-2334 merge PR

Hello, I've managed to create the example for MP-JWT-Principal (Jira: https://issues.apache.org/jira/browse/TOMEE-2334) and I've sent a PR ( https://github.com/apache/tomee/pull/339). I'll appreciate some feedback on how to improve. Best regards and happy New Year to everyone! *Mitja J.

[GitHub] tomee pull request #339: TOMEE-2334 MP-jwt-principal example

GitHub user cotnic opened a pull request: https://github.com/apache/tomee/pull/339 TOMEE-2334 MP-jwt-principal example Implemented the MP-jwt for principal injection example. Also included the usage of MP-rest-client for testing. You can merge this pull request into a Git

[GitHub] tomee pull request #324: TOMEE-2399 add README.adoc for simple-remote-tomcat...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/324 ---

Re: Code coverage

I agree with this approach. That is definitely where I can see the value for us at this time. Thanks Jon -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Dec 31, 2018 at 6:14 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > I can certainly

Re: Code coverage

I can certainly get some numbers and push the report somewhere. At the moment, I was seeing it as a tool for checking where there might be gaps when I'm writing tests, rather than something I'd necessarily put on every build, but if others see value in doing that, I wouldn't be opposed to it. Jon

Re: Code coverage

Hey Jon, Yes I did see the PR. Thanks for it. Do you have any figures? What are we looking at with the ability to have the coverage information? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Dec 31, 2018 at 4:21 PM Jonathan Gallimore <

Re: Microprofile release train

Thanks Bruno for looking after it. There is something broken. We need to see where it comes from -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Mon, Dec 31, 2018 at 2:03 PM Bruno Baptista wrote: > This improves a bit after updating the TestNG version to

[GitHub] tomee issue #337: Added new example cdi qualifier

Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/337 Thanks for the PR! ---

[GitHub] tomee pull request #337: Added new example cdi qualifier

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/337 ---

[GitHub] tomee pull request #338: Use correct line separator when checking call resul...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/338 ---

[GitHub] tomee issue #338: Use correct line separator when checking call result.

Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/338 That's awesome, thank you! ---

[GitHub] tomee pull request #338: Use correct line separator when checking call resul...

GitHub user doychin opened a pull request: https://github.com/apache/tomee/pull/338 Use correct line separator when checking call result. Fix for issue https://issues.apache.org/jira/browse/TOMEE-2437 You can merge this pull request into a Git repository by running: $ git

[GitHub] tomee pull request #337: Added new example cdi qualifier

GitHub user cassunde opened a pull request: https://github.com/apache/tomee/pull/337 Added new example cdi qualifier You can merge this pull request into a Git repository by running: $ git pull https://github.com/cassunde/tomee master Alternatively you can review and apply

Re: MicroProfile Samples

Merged! Thanks Ivan, and Happy New Year! Jon On Mon, Dec 31, 2018 at 1:40 PM Ivan St. Ivanov wrote: > Thank you Ivan and Bruno! :) > > I was finally able to do my own "contribution for the holidays" :) > > Cheers, > Ivan > > On Mon, Dec 31, 2018 at 2:43 PM Bruno Baptista wrote: > > > Great! >

[GitHub] tomee pull request #333: TOMEE-2333 MicroProfile JWT Example for mp.jwt.veri...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/333 ---

Code coverage

Hey folks I started to have a play with some code coverage reports. Here's a basic start: https://github.com/apache/tomee/pull/336, which uses jacoco on openejb-core if -Pcoverage is specified. There are some test issues which I'll dig into, but it may be easier to put those in a different

[GitHub] tomee pull request #336: TOMEE-2436 Get code coverage report from JaCoCo

GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/336 TOMEE-2436 Get code coverage report from JaCoCo This starts this task off, introducing the plugin at the root level under pluginManagement, and using it in a `coverage` profile on openejb-core.

Re: [TOMEE-2435] New Pull Request

Merged! Happy new year to you and everyone in the community too. Jon On Mon, Dec 31, 2018 at 2:39 PM Gurkan Erdogdu wrote: > Hello Jon > I have created new pull request. Could you please check, > https://github.com/apache/tomee/pull/334 > > Happy New Year! > > Regards. > Gurkan > > > On Mon,

[GitHub] tomee issue #324: TOMEE-2399 add README.adoc for simple-remote-tomcatusers.

Github user puneethps commented on the issue: https://github.com/apache/tomee/pull/324 Hi, can someone review and merge this or give feedback on how to improve the documentation? ---

[GitHub] tomee issue #329: Example Project - Kotlin, CDI, JAX-RS

Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/329 Please register and send us an email to dev@tomee.apache.org. We would love to hear from you over there! ---

[GitHub] tomee pull request #335: Fixed a few issues related to closing of resources

GitHub user martinfmi opened a pull request: https://github.com/apache/tomee/pull/335 Fixed a few issues related to closing of resources Fixed a few issues related to closing of resources uncovered from SonarQube Signed-off-by: Martin Toshev You can merge this pull

[GitHub] tomee pull request #334: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/334 ---

Re: [TOMEE-2435] New Pull Request

Hello Jon I have created new pull request. Could you please check, https://github.com/apache/tomee/pull/334 Happy New Year! Regards. Gurkan On Mon, Dec 31, 2018 at 5:11 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Awesome, thanks. I'm ok with this change: > > -

[GitHub] tomee pull request #334: (TOMEE-2435) Simplify the Code in org.apache.openej...

GitHub user gerdogdu opened a pull request: https://github.com/apache/tomee/pull/334 (TOMEE-2435) Simplify the Code in org.apache.openejb.OpenEjbContainer$Provider New patch. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] tomee issue #333: TOMEE-2333 MicroProfile JWT Example for mp.jwt.verify.publ...

Github user ivannov commented on the issue: https://github.com/apache/tomee/pull/333 Nice catch @brunobat :smile: ---

[GitHub] tomee issue #332: (TOMEE-2435) Simplify the Code in org.apache.openejb.OpenE...

Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/332 Happy for you to do that, but your last push to this branch looked fine to merge. ---

[GitHub] tomee issue #332: (TOMEE-2435) Simplify the Code in org.apache.openejb.OpenE...

Github user gerdogdu commented on the issue: https://github.com/apache/tomee/pull/332 I will close this pull request and create another. ---

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user gerdogdu closed the pull request at: https://github.com/apache/tomee/pull/332 ---

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user gerdogdu commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244588094 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import java.net.MalformedURLException;

Re: [TOMEE-2435] New Pull Request

Awesome, thanks. I'm ok with this change: -moduleLocations.removeIf(file -> !match((String) modules, file)); - +for (final Iterator i = moduleLocations.iterator(); i.hasNext(); ) { +final File file = i.next(); +if

Re: [TOMEE-2435] New Pull Request

Hi Jon I will update my patch to update wildcard import, loop and diamond <> operator. Regards Gurkan On Mon, Dec 31, 2018 at 2:38 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Is there any particular reason for flipping the imports to wildcards? We > tend to import the

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user jgallimore commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244586465 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user gerdogdu commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244585692 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import java.net.MalformedURLException;

Re: MicroProfile Samples

Thank you Ivan and Bruno! :) I was finally able to do my own "contribution for the holidays" :) Cheers, Ivan On Mon, Dec 31, 2018 at 2:43 PM Bruno Baptista wrote: > Great! > > Thanks Ivan, will review it now. > > Cheers > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 31/12/18

Re: Microprofile release train

This improves a bit after updating the TestNG version to 6.9.9 and adding Hamcrest: [INFO] Results: [INFO] [ERROR] Failures: [ERROR] CircuitBreakerTest>Arquillian.run:138->testCircuitInitialSuccessDefaultSuccessThreshold:292 serviceA should throw an Exception in

Re: MicroProfile Samples

Great! Thanks Ivan, will review it now. Cheers Bruno Baptista https://twitter.com/brunobat_ On 31/12/18 11:43, Ivan St. Ivanov wrote: Hi folks! I created a PR (https://github.com/apache/tomee/pull/333) for this issue: https://jira.apache.org/jira/browse/TOMEE-2333 Cheers and happy and

Re: MicroProfile Samples

This is a great contribution Ivan, this was a missing feature that was recently added in TomEE. Thank you for that! On Mon, Dec 31, 2018 at 10:08 AM Ivan St. Ivanov wrote: > Hi folks! > > I created a PR (https://github.com/apache/tomee/pull/333) for this issue: >

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244580685 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import java.net.MalformedURLException;

Re: Microprofile release train

Hi Folks, I've also updated the MP FT version to 1.1.3, the same as the new Safeguard. The Injection of the Executor service doesn't work. Also, The TCK seems to pass all the tests when executed in the standalone library, but on the TomEE TCK it doesn't. Also, the Demo apps we have, they

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user gerdogdu commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244579276 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import java.net.MalformedURLException;

Re: MicroProfile Samples

Hi folks! I created a PR (https://github.com/apache/tomee/pull/333) for this issue: https://jira.apache.org/jira/browse/TOMEE-2333 Cheers and happy and successful new year everyone! Ivan On Mon, Dec 10, 2018 at 3:10 PM Roberto Cortez wrote: > Hi Lucas, > > I’ve assigned the issue to you. Let

[GitHub] tomee pull request #333: TOMEE-2333 MicroProfile JWT Example for mp.jwt.veri...

GitHub user ivannov opened a pull request: https://github.com/apache/tomee/pull/333 TOMEE-2333 MicroProfile JWT Example for mp.jwt.verify.publickey configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivannov/tomee

Re: [TOMEE-2435] New Pull Request

Is there any particular reason for flipping the imports to wildcards? We tend to import the individual classes elsewhere in the codebase. My personal preference would be to leave those as individual imports. It doesn't make the import list that much longer, and I find its clearer what is being

Re: [TOMEE-2435] New Pull Request

Hi Gurkan, Thanks for the PR. I left some notes on it. Cheers Bruno Baptista https://twitter.com/brunobat_ On 31/12/18 09:09, Gurkan Erdogdu wrote: Hi I have created a PR (https://github.com/apache/tomee/pull/332) for (TOMEE-2435) Simplify the Code in

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244574001 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -221,12 +218,13 @@ private static Logger logger() { // don't

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user brunobat commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244574174 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -71,57 +50,74 @@ import java.net.MalformedURLException;

Re: MicroProfile Integration in Plus and Plume

Hi, I tested with the last TomEE Plus snapshot which had MP in it and #304 below. Apart from having to add a line to exclusions.list for one item, it seems to work fine. Without the exclusions.list entry, I get the following because @Provider is being used in our class (think this could be

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/332#discussion_r244575326 --- Diff: container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java --- @@ -221,12 +218,13 @@ private static Logger logger() { //

Re: [TOMEE-2435] New Pull Request

Yep, I'll take a look. Thanks for the PR. Jon On Mon, Dec 31, 2018 at 9:10 AM Gurkan Erdogdu wrote: > Hi > I have created a PR (https://github.com/apache/tomee/pull/332) for > (TOMEE-2435) > Simplify the Code in org.apache.openejb.OpenEjbContainer$Provider >

[TOMEE-2435] New Pull Request

Hi I have created a PR (https://github.com/apache/tomee/pull/332) for (TOMEE-2435) Simplify the Code in org.apache.openejb.OpenEjbContainer$Provider If anybody can check and merge, it is appreciated :) Regards. Gurkan

[GitHub] tomee pull request #332: (TOMEE-2435) Simplify the Code in org.apache.openej...

GitHub user gerdogdu opened a pull request: https://github.com/apache/tomee/pull/332 (TOMEE-2435) Simplify the Code in org.apache.openejb.OpenEjbContainer (TOMEE-2435) Simplify the Code in org.apache.openejb.OpenEjbContainer You can merge this pull request into a Git repository by