Re: TOMEE-1399 Potential NPE

2020-07-11 Thread David Salter
Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em sex., 10 de jul. de 2020 às 14:01, David Salter escreveu: Hi, I've been going through open Jira issues and found TOMEE-1399. and just submitted a PR for this. Basically, this is to move an if

TOMEE-1399 Potential NPE

2020-07-10 Thread David Salter
if this is OK? Thanks, David. -- David Salter

Re: Question about Spring Integration Example

2020-07-09 Thread David Salter
.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em qui., 9 de jul. de 2020 às 16:02, David Salter escreveu: Interesting. I can see the example in there, but the example isn't in master I've also found that the example was deleted in 2012. Very confusing ! co

Re: Question about Spring Integration Example

2020-07-09 Thread David Salter
java Twitter: http://twitter.com/danieldiasjava Em qui., 9 de jul. de 2020 às 15:55, Daniel Dias Dos Santos < daniel.dias.analist...@gmail.com> escreveu: Hello @David Salter, have a PR for this -> https://github.com/apache/tomee/pull/670. But I don't know, if the example is still valid

Question about Spring Integration Example

2020-07-09 Thread David Salter
/siteexamples-trunk/spring-integration/ I'm not sure why the example is not in git any more, but it does look pretty old.  So should we try and bring this into git, or should we retire this page and remove it from the site ? Ta. Dave. -- David Salter

TOMEE-1417 Fix

2020-07-07 Thread David Salter
someone take a look and merge if its OK? Cheers, Dave. -- David Salter

New PR - References to SVN on Securing A Web Service page

2020-07-06 Thread David Salter
meone take a look and merge if this looks ok? Thanks, Dave. -- David Salter

Re: Welcome Daniel Dias Dos Santos as TomEE committer!

2020-06-26 Thread David Salter
Congratulations Daniel. You deserve this after all the hard work you’ve put in. Well deserved :)David.  On Thu, 25 Jun 2020 23:46:46 +0100 David Blevins wrote Dear community, Please share your thanks to Daniel Dias Dos Santos who has been invited by the

Re: Jakarta EE 8 Support

2019-10-22 Thread David Salter
t; > > We'll get you started with some test failures to look at. Failures come > in > > a few different forms - some are setup issues, and others are genuine > > implementation issues. We have some EJB failures that would be great to > get > > you started and I c

Re: Jakarta EE 8 Support

2019-10-22 Thread David Salter
ementation issues. We have some EJB failures that would be great to get > you started and I can guide you through. > > Jon > > On Tue, Oct 22, 2019 at 12:28 PM David Salter > wrote: > > > > > > > > > > > Hi all,Do we have a roadmap on what

Re: Jakarta EE 8 Support

2019-10-22 Thread David Salter
at. Failures come in a few different forms - some are setup issues, and others are genuine implementation issues. We have some EJB failures that would be great to get you started and I can guide you through. Jon On Tue, Oct 22, 2019 at 12:28 PM David Salter wrote: > > > > >

Jakarta EE 8 Support

2019-10-22 Thread David Salter
Hi all,Do we have a roadmap on what needs to be done to become Jakarta EE8 compliant?For example, are there any specific Jira tickets etc.Apologies if this has been discussed before, but I’d love to help us move in this direction where possible. ThanksDavid. 

Re: [VOTE] Release Apache TomEE 8.0.0 (take 3)

2019-09-14 Thread David Salter
+1 from me. Tried it on some of my apps that work on 8M3. Mainly JPA/JAX-RS/MP. David. On Fri, 13 Sep 2019 13:49:42 +0100 Jonathan Gallimore wrote > Hi All, > > Here's a third attempt at roll of a TomEE 8.0.0. Please can you take a > careful look, review, test and provide

Re: New Issue / PR For JMS Documentation

2019-09-07 Thread David Salter
ttps://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em sáb, 7 de set de 2019 às 08:45, David Salter escreveu: > Sorry - typo on the url. Its actually > http://tomee.apache.org/tomee-8.0/docs/jms-resources-and-mdb-cont

Re: New Issue / PR For JMS Documentation

2019-09-07 Thread David Salter
Sorry - typo on the url. Its actually http://tomee.apache.org/tomee-8.0/docs/jms-resources-and-mdb-container.html that is fixed by the PR. David. On Sat, 07 Sep 2019 11:55:54 +0100 David Salter wrote > Hi, > > I've just created a new issue > (https://issues.apa

New Issue / PR For JMS Documentation

2019-09-07 Thread David Salter
Hi, I've just created a new issue (https://issues.apache.org/jira/browse/TOMEE-2667) that addresses the formatting on http://tomee.apache.org/tomee-8.0/docs/activemqresourceadapter-config.html where the table at the end of the page isn't displayed correctly. I've created a PR for this as

Re: [VOTE] Release javaee-api 8.0-2

2019-09-07 Thread David Salter
+1 from me. David. On Fri, 06 Sep 2019 09:42:06 +0100 Jean-Louis MONTEIRO wrote > Hi, > > Here we go. Here is an updated API jar. > > There will be some more iteration to get the jar fully Jakarta EE 8 > compliant. > See ticket

Re: Merge PRs ?

2019-09-05 Thread David Salter
Wow. That was quick. Thanks Jon :) > On 5 Sep 2019, at 12:23, Jonathan Gallimore > wrote: > > Hi David > > Thanks for the nudge! I've merged those. Thanks for the PRs! > > Jon > > On Thu, Sep 5, 2019 at 12:21 PM David Salter > wrote: > >> Hi,

Merge PRs ?

2019-09-05 Thread David Salter
Hi, I’ve got a couple of PRs that have been outstanding for a few weeks. Can anybody merge these for me, or let me know if they need changes? https://github.com/apache/tomee/pull/530 https://github.com/apache/tomee/pull/531

Re: New committer Cesar Hernandez

2019-09-05 Thread David Salter
Congratulations Cesar. Well deserved :) On Thu, 5 Sep 2019 at 08:53, Jean-Louis Monteiro wrote: > The Project Management Committee (PMC) for Apache TomEE has invited Cesar > to > become a committer and we are pleased to announce that he has accepted. > > Cesar started contributing about a year

PR for TOMEE-1395

2019-08-05 Thread David Salter
Hi, I’ve noticed that TOMEE-1395 has an old patch against it that hasn’t been merged. This is in the simple-mdb-with-descriptor example. As this is an old patch, I’ve created a PR that will fix the package name. https://github.com/apache/tomee/pull/531

Re: JKS Keystore ?

2019-08-05 Thread David Salter
son why that would be an issue. > Can you send a PR if you haven't already? > > Cheers > > Jon > > On Mon, Aug 5, 2019 at 1:52 PM David Salter > wrote: > >> Hi, >> >> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 < >>

Re: JKS Keystore ?

2019-08-05 Thread David Salter
> Cheers > > Jon > > On Mon, Aug 5, 2019 at 1:52 PM David Salter > wrote: > >> Hi, >> >> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 < >> https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of >

JKS Keystore ?

2019-08-05 Thread David Salter
Hi, I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 which is to make one of the samples work on Java 11. I’ve got a fix for this on Java 11 by specifying the keystore type as JKS. Is this ok for this example given that its a

Closed Issues in Jira

2019-07-10 Thread David Salter
Hi, I’ve just closed the following issues in Jira as they’ve all had PRs submitted against them that have been merged. I think there are still a few more issues that need to be closed, but I’ll look at that tomorrow. Thanks, David. 2540 - TomEE 8.0.0-M3 compatibility with Java 2437 -

Re: Web Site Deploy

2019-07-09 Thread David Salter
> On Mon, Jul 8, 2019 at 6:29 PM David Salter > wrote: > > > Hi Jon, > > > > That looks fantastic. Can you promote it to the main site ? > > > > Thanks > > > > David. > > > > On Mon, 8 Jul 2019 at 17:07, Jonathan Gallimore < > &

Re: Web Site Deploy

2019-07-08 Thread David Salter
the website generator project > > about an hour ago. The commit is still sending(!). I'll shout when its > done. > > > > Jon > > > > On Sun, Jul 7, 2019 at 3:53 PM David Salter > > wrote: > > > >> Thanks Jon, > >> > >>

Re: Web Site Deploy

2019-07-07 Thread David Salter
on the site, so do shout if things aren't > showing up. > > Jon > > On Thu, Jun 27, 2019 at 12:55 PM David Salter > wrote: > >> Hi all, >> >> I’ve just noticed that a PR I made has been merged in ( >> https://github.com/apache/tomee/commit/14a8179

Re: Translate to portuguese to applicationexception example

2019-07-07 Thread David Salter
Hi Daniel, Thanks again :). These changes look good to me. Can one of the committers please move this Pull Request forwards. Thanks, David. > On 2 Jul 2019, at 21:32, Daniel Dias Dos Santos > wrote: > > The PR is open for the ticket: https://github.com/apache/tomee/pull/501 > > Please

Re: Translate to portuguese to applicationcomposer-jaxws-cdi example

2019-07-07 Thread David Salter
Hi Daniel, These changes look great to me. Thanks for all the pull requests :) Can one of the committers please move this Pull Request forwards. Thanks. David. > On 4 Jul 2019, at 04:42, Daniel Dias Dos Santos > wrote: > > The PR is open for the ticket:

Re: Translate to portuguese async-methods example

2019-07-07 Thread David Salter
Thanks Daniel, These changes look good to me. Can one of the committers please move this PR forwards. Thanks, David. > On 6 Jul 2019, at 05:55, Daniel Dias Dos Santos > wrote: > > The PR is open for the ticket: https://github.com/apache/tomee/pull/503 > > Please review . > > thanks . >

Re: Translate to portuguese: examples/async-postconstruct

2019-07-07 Thread David Salter
Hi Daniel, These changes look good to me. Can one of the committers please move this forwards. Thanks. David. > On 6 Jul 2019, at 17:31, Daniel Dias Dos Santos > wrote: > > The PR is open for the ticket: https://github.com/apache/tomee/pull/504 > > Please review . > > thanks . > -- > >

Re: Translate to portuguese the example bval-evaluation-redeployment

2019-07-07 Thread David Salter
Hi Daniel, Thanks for the PR. I’ve reviewed your changes and they look good. Can one of the committers please move this forwards ? Thanks. David. > On 7 Jul 2019, at 05:34, Daniel Dias Dos Santos > wrote: > > The PR is open for the ticket: https://github.com/apache/tomee/pull/505 > >

Re: Update DeltaSpike Examples

2019-07-02 Thread David Salter
el Dias dos Santos* > Java Developer > SouJava & JCP Member > GitHub: https://github.com/Daniel-Dos > Linkedin: www.linkedin.com/in/danieldiasjava > Twitter: http://twitter.com/danieldiasjava > > > Em seg, 1 de jul de 2019 às 15:55, David Salter > > escreveu: >

Re: Update DeltaSpike Examples

2019-07-01 Thread David Salter
Hi, I’ve just submitted a PR for this change. https://github.com/apache/tomee/pull/500 <https://github.com/apache/tomee/pull/500> Can someone take a look and check if this is ok? Thanks. David. > On 1 Jul 2019, at 16:56, David Salter wrote: > > Hi, > > I’ve just cre

Update DeltaSpike Examples

2019-07-01 Thread David Salter
Hi, I’ve just created a Jira to update the versions of DeltaSpike used in the examples: https://issues.apache.org/jira/browse/TOMEE-2555 At present, there are 4 deltaspike examples, using the following versions of DeltaSpike:

Re: mp-custom-healthcheck example review

2019-06-28 Thread David Salter
Lol. Sounds like someone has already done what we’re talking about :) David. On Fri, 28 Jun 2019 at 18:53, Cesar Hernandez wrote: > Disregard my previous email, looking more closely to the code it seems the > example include a mock version of the real endpoint > >

Re: mp-custom-healthcheck example review

2019-06-28 Thread David Salter
Hi Cesar, That sounds a sensible approach to me. It would make the test more predictable and less likely to fail due to external situations. I think writing an included “simple” weather service that just returns 200 or 40x would improve the sample. Thanks David. On Fri, 28 Jun 2019 at 18:47,

Re: New Issue and PR

2019-06-27 Thread David Salter
> Java Developer > SouJava & JCP Member > GitHub: https://github.com/Daniel-Dos > Linkedin: www.linkedin.com/in/danieldiasjava > Twitter: http://twitter.com/danieldiasjava > > > Em qui, 27 de jun de 2019 às 11:43, David Salter > escreveu: > >> Hi, >>

New Issue and PR

2019-06-27 Thread David Salter
Hi, I’ve just created a new issue and PR to fix some typos on the MP Config example readme. Could someone take a look and see of these are ok? https://issues.apache.org/jira/browse/TOMEE-2552 https://github.com/apache/tomee/pull/497

Jira Issues

2019-06-27 Thread David Salter
Hi, I’ve been going through Jira and there are a few issues that are already merged but not closed. Is it worthwhile me going through these issues and closing them, or does one of the committers need to do that ? Thanks. David.

Web Site Deploy

2019-06-27 Thread David Salter
Hi all, I’ve just noticed that a PR I made has been merged in (https://github.com/apache/tomee/commit/14a8179961bbbc26274654591616ecdd410d18a9 ), but the web site hasn’t been updated. I think last time this

Re: How can I help?

2019-06-03 Thread David Salter
Hi Dawid, and thanks for wanting to contribute to TomEE :) There is an example currently using JWT and BV at https://tomee.apache.org/tomee-8.0/examples/mp-jwt-bean-validation.html So I would guess the best thing to do

Re: Assign Jira Task

2019-06-03 Thread David Salter
0-M3 as opposed to the SNAPSHOT? > > Cheers > > Jon > > On Sat, Jun 1, 2019 at 2:47 PM David Salter > wrote: > >> Hi, >> >> I’ve just submitted a PR for TOMEE-2484 >> >> https://github.com/apache/tomee/pull/478 < >> https://githu

Re: Assign Jira Task

2019-06-01 Thread David Salter
an-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Fri, May 31, 2019 at 5:42 PM David Salter > wrote: > >> Hi all, >> >> I’ve started looking at: >> >> https://issues.apache.org/jira/browse/TOMEE-248

Re: Breaking example rules

2019-05-31 Thread David Salter
Thanks Jon :) On Fri, 31 May 2019 at 20:36, Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Looks good to me, I've merged it! Thanks David! > > Jon > > On Fri, 31 May 2019, 16:54 David Salter, > wrote: > > > Thanks Jonathan :) > > > &g

Assign Jira Task

2019-05-31 Thread David Salter
Hi all, I’ve started looking at: https://issues.apache.org/jira/browse/TOMEE-2484 Can someone assign the task to me in Jira please? Thanks. David.

Re: Breaking example rules

2019-05-31 Thread David Salter
n Fri, May 31, 2019 at 4:46 PM David Salter > wrote: > >> Hi, >> >> I’ve created a JIRA for the parent pom in the mp-opentracing-traced >> project. >> >> https://issues.apache.org/jira/browse/TOMEE-2537 < >> https://issues.apache.org/jira/

Re: Breaking example rules

2019-05-31 Thread David Salter
Hi, I’ve created a JIRA for the parent pom in the mp-opentracing-traced project. https://issues.apache.org/jira/browse/TOMEE-2537 Can someone assign this to me and I’ll get the PR submitted. Thanks. David. > On 27 May 2019, at 19:18, David

Re: Breaking example rules

2019-05-27 Thread David Salter
Hi Jean-Louis, I’m a fan of the simple samples and this is one of the things I love about TomEE. Do you have more details on which samples aren’t self contained? I’d be happy to help do some refactoring to make them easier to understand. Thanks David. On Mon, 27 May 2019 at 14:24, Jean-Louis

Re: New Issue and PR

2019-05-27 Thread David Salter
04, David Blevins wrote: > >> On May 26, 2019, at 3:53 AM, David Salter >> wrote: >> >> Thanks. That makes sense. >> >> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll >> create issues and PRs for :) > > That sounds

New Issue and PR

2019-05-26 Thread David Salter
Hi, I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252) about the Active MQ Resource Adapter config page not rendering correctly. I’ve created a PR for this on GitHub at: https://github.com/apache/tomee/pull/472 Can someone assign the issue to me and take a

Re: New Issue and PR

2019-05-26 Thread David Salter
k to get them unstuck and synching properly. > > Not sure I'll get to it today, but I'll see if I can push on it again > tomorrow. > > > -- > David Blevins > http://twitter.com/dblevins > http://www.tomitribe.com > >> On May 25, 2019, at 7:25 AM, David Salte

Re: New Issue and PR

2019-05-25 Thread David Salter
ou, David! Merged and I'm republishing the website now. >> >> >> -- >> David Blevins >> http://twitter.com/dblevins >> http://www.tomitribe.com >> >>> On May 24, 2019, at 8:56 AM, David Salter >>> wrote: >>> >>> Hi,

New Issue and PR

2019-05-24 Thread David Salter
Hi, I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252 ) about the Active MQ Resource Adapter config page not rendering correctly. I’ve created a PR for this on GitHub at:

New Issue and PR

2019-04-20 Thread David Salter
Hi, I’ve just created an issue in Jira regarding incorrect formatting on the Spring and Open EJB documentation page. https://issues.apache.org/jira/browse/TOMEE-2512 I’ve submitted a PR to resolve this:

Re: New Issue

2019-04-16 Thread David Salter
gt; > Hi David, > > TOMEE-2511 is now assigned to you. > Thanks in advance for your contribution and feel free to update/question > about it via this email thread. > > El mar., 16 abr. 2019 a las 10:12, David Salter > () escribió: > >> Hi, >> >> I’ve just

New Issue

2019-04-16 Thread David Salter
Hi, I’ve just created an issue (https://issues.apache.org/jira/browse/TOMEE-2511 ). Can this please be assigned to me (davidmsalter in Jira) as I have a fix for it. Thanks. Dave.

Display Documentation before committing

2019-04-15 Thread David Salter
Hi, I’ve found a few changes that could be made to the documentation. I’ll create a Jira issue for these, but what’s the best way of previewing documentation locally to check it all looks ok before committing it ? Ta. Dave.

Re: [VOTE] OpenEJB 4.7.0/TomEE 1.7.0 (staging-1039)

2014-08-11 Thread David Salter
For what its worth, +1 from me. I've tested 1.7.0 on some of my apps and they all work as expected. Dave. On 11 Aug, 2014,at 10:59 AM, Thiago Veronezi thi...@veronezi.org wrote: +1 Thanks Andy! []s, Thiago. On Sun, Aug 10, 2014 at 5:20 PM, Romain Manni-Bucau rmannibu...@gmail.com      

CMS diff: Simple MDB

2014-07-10 Thread David Salter
Clone URL (Committers only): https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://tomee.apache.org/examples-trunk%2Fsimple-mdb%2FREADME.md David Salter Index: trunk/content/examples-trunk/simple-mdb/README.md

Re: CMS diff: Deployments

2014-07-09 Thread David Salter
Hi. It's a pleasure. Should I add a comment onto the Jira issue linking back here, or is that not necessary? Thanks David. On 9 Jul 2014, at 18:27, Jean-Louis Monteiro jlmonte...@tomitribe.com wrote: Thank you very much David. Andy is quite busy at the moment with the release. Hope I

Re: CMS diff: Deployments

2014-07-09 Thread David Salter
it solved by you. Thanks you very much again. It should go to tomee.apache.org soon. Jean-Louis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jul 9, 2014 at 12:40 PM, David Salter davidmsal...@icloud.com wrote: Hi. It's a pleasure

Re: Refcard?

2013-06-14 Thread David Salter
That's really good. I can see that being very useful. Dave, On 14 Jun 2013, at 17:18, Romain Manni-Bucau rmannibu...@gmail.com wrote: Hi Try to write a kind of refcard for tomee: http://tomee.apache.org/refcard/refcard.html Wdyt? I put the project used for the generation in

OPENEJB-1294

2013-05-10 Thread David Salter
Hi, I've just submitted a patch to JIRA for OPENEJB-1294 that validates classes with the @StatefulTimeout annotation on them. The validation issues a warning if a non @Stateless bean (@Stateful, @Singleton, @ManagedBean, @MessageDriven) has a @StatefulTimeout annotation on it. Hope this is

Bean Validation Test in wrong package

2013-04-18 Thread David Salter
Hi, I've been looking at the Bean Validation Example (tomee/trunk/examples/bean-validation-design-by-contract) and noticed that the test for it is in the default package rather than org.superbiz.designbycontract. I've created a JIRA for this (TOMEE-898) and attached a patch to it that fixes

OPENEJB-1306 - EJB's cannot be declared final

2013-04-02 Thread David Salter
Hi, I'm working on a patch for OPENEJB-1306 which I've almost got complete. I just wanted to verify that the issue is that EJB3 beans, i.e. those annotated with @Singleton, @Stateless or @Stateful cannot be declared as final. Thanks, Dave.

Issues editing TomEE Maven Plugin page

2013-03-27 Thread David Salter
Hi, I'm trying to make a few edits to the Maven Plugin Page (http://tomee.apache.org/tomee-maven-plugin.html), but when I press the edit button on the page, the HTML that can be edited isn't the complete HTML for the page. The HTML seems to start at the Required Parameters section and doesn't

CMS diff: Source Code

2013-03-25 Thread David Salter
Clone URL (Committers only): https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://tomee.apache.org/dev%2Fsource-code.mdtext David Salter Index: trunk/content/dev/source-code.mdtext === --- trunk/content/dev/source