Re: Github Pull Requests

2018-12-11 Thread Richard Monson-Haefel
Thanks, Roberto! On Mon, Dec 10, 2018 at 6:48 PM Roberto Cortez wrote: > Hi folks, > > I’ve done some cleanup on Github PR’s: > > - Closed PR’s already merged. > - Closed PR’s that don’t make sense anymore. > - Merged ready to go code. > > Probably, some of the old PR’s need another set of

Re: Github pull requests?

2014-10-09 Thread Andy Gumbrecht
Hi John, https://issues.apache.org/jira/browse/INFRA-8374 So hopefully within a few days. Andy. On 08/10/2014 16:45, John D. Ament wrote: Here's hoping that one day the TomEE moves to Git. On Wed, Oct 8, 2014 at 10:31 AM, Tommy Tynjä to...@diabol.se wrote: Your pull request will most

Re: Github pull requests?

2014-10-08 Thread Tommy Tynjä
Your pull request will most likely be ignored. I've tried that approach as well but since TomEE has not moved over from svn to git, it doesn't make sense yet. I've used the git svn mirror to check out the code and keep it updated. When submitting contributions I've created a corresponding svn

Re: Github pull requests?

2014-10-08 Thread John D. Ament
Here's hoping that one day the TomEE moves to Git. On Wed, Oct 8, 2014 at 10:31 AM, Tommy Tynjä to...@diabol.se wrote: Your pull request will most likely be ignored. I've tried that approach as well but since TomEE has not moved over from svn to git, it doesn't make sense yet. I've used the

Re: Github pull requests?

2014-09-29 Thread Chris Christo
Can anyone confirm please? Chris Christo { github.com/christchristo } On 18 Sep 2014, at 15:18, Chris Christo _...@mail.com wrote: On that note, will my pull request be ignored for now? Shall I re submit with a linked JIRA? On 28 Aug 2014, at 15:42, Andy Gumbrecht andy...@gmx.de wrote:

Re: Github pull requests?

2014-08-27 Thread Chris Christo
I submitted a pull request, just wondering if anyone will pick this up? Its only a readme, but was testing the waters to see if anyone is actively handling pull requests, before I submit something more substantial. Chris Christo { twitter.com/christokios } { github.com/christokios } On 25 Aug

Re: Github pull requests?

2014-08-27 Thread helio frota
Its only a readme, but was testing the waters to see if anyone is actively handling pull requests, before I submit something more substantial. Chris Christo +1 On Wed, Aug 27, 2014 at 11:22 AM, Chris Christo _...@mail.com wrote: I submitted a pull request, just wondering if anyone will

Re: Github pull requests?

2014-08-27 Thread Romain Manni-Bucau
did you linked it to a jira? otherwise I think we don't have any notification Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-27 17:06 GMT+02:00 helio frota

Re: Github pull requests?

2014-08-27 Thread Thiago Veronezi
Yeah... It looks like the github notifications need to be approved to be published in the dev list. []s, Thiago. On Wed, Aug 27, 2014 at 11:26 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: just got the notification. Well not linking it to a jira means it will not be linked to a release

Github pull requests?

2014-08-25 Thread Chris Christo
Hey, you guys accept pull requests at https://github.com/apache/tomee? Chris Christo { twitter.com/christokios } { github.com/christokios }

Re: Github pull requests?

2014-08-25 Thread Romain Manni-Bucau
Hi it should be wired now Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-25 13:48 GMT+02:00 Chris Christo _...@mail.com: Hey, you guys accept pull requests at

Re: Github pull requests?

2014-08-25 Thread Romain Manni-Bucau
cause our main repo is not github and nobody was using github so README.adoc was not that useful ;) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-25 13:55 GMT+02:00