Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

Hey Cesar, Thanks, I'll review and merge for you if ok. You are correct, we currently rely on the TCKs only for MP-JWT. This is the bare minimum and ideally we should add our own tests in the mp-jwt module because the TCKs can't test everything. -- Jean-Louis Monteiro

Re: MPJWT @RolesAllowed is been applied with a all or nothing policy - TOMEE-2357

The PR for this ticket is ready for review. PR: https://github.com/apache/tomee/pull/275 Ticket: https://issues.apache.org/jira/browse/TOMEE-2357 The fix for this issue is in the module `/mp-jwt`, I didn't find any test package on this module. Is this on purpose because we have the module

[GitHub] tomee pull request #275: TOMEE-2357 - Fixed issue and updated test on exampl...

GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee/pull/275 TOMEE-2357 - Fixed issue and updated test on example application. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on the issue: https://github.com/apache/tomee/pull/262 @pzygielo Once three persons are reviewing that PR that means at least two persons need to set green. The best scenario will be if all of then approve. ---

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on the issue: https://github.com/apache/tomee/pull/262 @otaviojava oh, I see. I thought it was full green light for merge. ---

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on the issue: https://github.com/apache/tomee/pull/262 @pzygielo Hey. That means, beyond your suggestions, there is anything else. All of your suggestions are important, I just don't have anything else to help on this. Sorry for the

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on the issue: https://github.com/apache/tomee/pull/262 > otaviojava approved these changes 7 minutes ago :disappointed: ---

Re: Arquillian test cannot be run in parallel

Adding the build.log. El jue., 13 dic. 2018 a las 14:54, Bruno Baptista () escribió: > Thanks César. > > Some tests seem that have hanged but they don't provide feedback and ate > just waiting for some condition. They can be like that for up to 5min. > > I think you forgot the attachment :) > >

Re: Arquillian test cannot be run in parallel

Thanks César. Some tests seem that have hanged but they don't provide feedback and ate just waiting for some condition. They can be like that for up to 5min. I think you forgot the attachment :) Bruno Baptista https://twitter.com/brunobat_ On 13/12/18 20:38, César Hernández Mendoza wrote:

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r241553800 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java --- @@ -111,6 +132,12 @@ public boolean accept(final

Re: Arquillian test cannot be run in parallel

Hi Bruno I follow the instruction you shared in this thread on my mac. mvn -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true > -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false > clean install -T1C Worked fine and it looks around 3 min in my box: [INFO]

[GitHub] tomee pull request #262: TOMEE-2337 - Code cleanup openejb container loader

Github user otaviojava commented on a diff in the pull request: https://github.com/apache/tomee/pull/262#discussion_r241549359 --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/BasicURLClassPath.java --- @@ -111,6 +132,12 @@ public boolean accept(final

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user pzygielo commented on the issue: https://github.com/apache/tomee/pull/262 :+1: for `<>` changes ---

[GitHub] tomee issue #262: TOMEE-2337 - Code cleanup openejb container loader

Github user cicekhayri commented on the issue: https://github.com/apache/tomee/pull/262 Hej everyone, got some comments on the JavaDocs I did and It's sounds that it's really bad and wonder if you guys also thinks that.. and wonder if I just delete the JavaDocs and just commit the

Re: Is TomEE ready to ship for Santa? - Conducting pre-xmas releases: 7.0.6, 7.1.1, 8.0.0-M2

+1, just ping me if you need some help. LieGrue, strub > Am 13.12.2018 um 17:57 schrieb Jonathan Gallimore > : > > There's some stuff I need to finish backporting, but I'm generally in > favour. We have a Johnzon vote in progress, and could do with an OWB > release for the 7.0.x and 7.1.x

Re: Arquillian test cannot be run in parallel

Thanks César! Bruno Baptista https://twitter.com/brunobat_ On 13/12/18 17:15, César Hernández Mendoza wrote: Hi Bruno, I can test on Mac. El jue., 13 dic. 2018 a las 10:16, Bruno Baptista () escribió: Hi All, I've updated almost all the microprofile tests to run in parallel with 1C:

Re: Arquillian test cannot be run in parallel

Hi Bruno, I can test on Mac. El jue., 13 dic. 2018 a las 10:16, Bruno Baptista () escribió: > Hi All, > > I've updated almost all the microprofile tests to run in parallel with > 1C: https://github.com/apache/tomee/pull/268 > > They seem to work ok on my machine. > > We were getting JVM crashes

Re: Is TomEE ready to ship for Santa? - Conducting pre-xmas releases: 7.0.6, 7.1.1, 8.0.0-M2

There's some stuff I need to finish backporting, but I'm generally in favour. We have a Johnzon vote in progress, and could do with an OWB release for the 7.0.x and 7.1.x branches. Jon On Thu, Dec 13, 2018 at 12:16 PM Wiesner, Martin < martin.wies...@hs-heilbronn.de> wrote: > Hey guys, > >

Re: Arquillian test cannot be run in parallel

Thanks Jose! This is a lengthy operation. One to leave it running while dinning. To take you less time please do: 1. Full build without tests: mvn -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false clean install

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Thanks @Roberto, I pull the latest master that include your fix and yes, now is working like a charm. I have one question, Yesterday I tried to move the: true from profile arquillian-tomee-embedded into arquillian-tomee-remote and that didn't work. By looking at your fix, Why we need to

Re: [DISCUSS] 1.x EOL

My view is still the same. I'm still willing to patch and release from 1.7.x. At the stage, I don't think we could consider getting it working with Java 11, and I wouldn't actively develop this branch, but I'd be willing to apply fixes and patches to it where possible. Jon On Thu, Dec 13, 2018

Re: Arquillian test cannot be run in parallel

Hi Bruno, I can give it a try on a Windows (facepalm) machine later on. =) Best Regards, José Henrique Ventura. Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Thursday, December 13, 2018 4:16 PM, Bruno Baptista wrote: > Hi All, > > I've updated almost all the

Re: Arquillian test cannot be run in parallel

Hi All, I've updated almost all the microprofile tests to run in parallel with 1C: https://github.com/apache/tomee/pull/268 They seem to work ok on my machine. We were getting JVM crashes due to the way we were redirecting the output of the remote processes. Now we use: final

Java EE Security API for EE 8

Hi folks, I’ve created https://jira.apache.org/jira/browse/TOMEE-2365 to implement the Java EE Security API that came up in EE 8. We are missing this spec implementation, and until we have it we cannot even say we are EE 8 compatible. I plan to

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Hi César, Just fixed the issue. The sample was running with TomEE Embedded which doesn’t ship with MP impls by default. The JWT library was being added manually. When I added the Config API it started failing with ClassNotFound. I’ve removed TomEE Embedded and now it only uses TomEE Remote to

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Yes, I need help. I pull lates master that includes the latest fixes from Otavio [1] but still the mp-rest-jwt is failing with the same exception I shared in the previous email. [1] [image: image.png] El jue., 13 dic. 2018 a las 4:11, Jean-Louis Monteiro (< jlmonte...@tomitribe.com>) escribió:

Re: TOMEE-2339 Describe Workflow for Contribution

Sounds good and now that you mention it, I think your PR [1] can also include a PR Review workflow, especially because TomEE has this Apache Mirror variable that other Github project doesn't have and make the PR review workflow slightly different. [1]

Re: AW: Re: OWASP Dependency Checking?

+1 to add it with both report and build failed. As you may already saw in other threads, timing it becomes important when it dramatically increase build time. When you create the JIRA, I would recommend to add the before/after measurement. El jue., 13 dic. 2018 a las 8:32, Daniel Cunha ()

Re: Move to Gitbox?

I’ve just remembered about this: How about other repos not part of the main tomee one but sitting in the project that are on SVN? https://svn.apache.org/repos/asf/tomee/ I would like to at least have the javaee-api project moved to Git as well. What

Re: TomEE Downloads Page

sure. I'll do that. :) Em qui, 13 de dez de 2018 às 11:42, Roberto Cortez escreveu: > Created https://jira.apache.org/jira/browse/TOMEE-2364 < > https://jira.apache.org/jira/browse/TOMEE-2364> > > I think we should come up with some prototypes before doing the > implementation so we can

Re: TOMEE-2361 - Improve main README file

Done to César. > On 13 Dec 2018, at 14:35, Daniel Cunha wrote: > > Ops, ok Cesar, go for it. > > I can work on Download page area. > > Em qui, 13 de dez de 2018 às 11:33, Daniel Cunha > escreveu: > >> Hey Roberto, >> >> I can pick up it. >> Please, assign the ticket to me. >> >> Em qui,

Re: TomEE Downloads Page

Created https://jira.apache.org/jira/browse/TOMEE-2364 I think we should come up with some prototypes before doing the implementation so we can discuss. Thanks! > On 13 Dec 2018, at 14:36, Daniel Cunha wrote: > > Assign it to me. > I'll work

Re: TomEE Downloads Page

Assign it to me. I'll work on it. Thanks! :) Em qui, 13 de dez de 2018 às 10:04, Roberto Cortez escreveu: > Hi folks, > > Before going in and create a JIRA for this, I would to get some feedback. > > When I look into this page: > http://tomee.apache.org/download-ng.html < >

Re: TOMEE-2361 - Improve main README file

Ops, ok Cesar, go for it. I can work on Download page area. Em qui, 13 de dez de 2018 às 11:33, Daniel Cunha escreveu: > Hey Roberto, > > I can pick up it. > Please, assign the ticket to me. > > Em qui, 13 de dez de 2018 às 09:41, Roberto Cortez > escreveu: > >> Hi folks, >> >> Maybe you have

Re: TOMEE-2361 - Improve main README file

Hey Roberto, I can pick up it. Please, assign the ticket to me. Em qui, 13 de dez de 2018 às 09:41, Roberto Cortez escreveu: > Hi folks, > > Maybe you have missed this from another thread. I’ve created a JIRA to > improve our frontend README information on Github: >

Re: TOMEE-2361 - Improve main README file

I can take that one. Please assign to me. On Thu, Dec 13, 2018 at 6:41 AM Roberto Cortez wrote: > Hi folks, > > Maybe you have missed this from another thread. I’ve created a JIRA to > improve our frontend README information on Github: > https://jira.apache.org/jira/browse/TOMEE-2361 < >

Re: AW: Re: OWASP Dependency Checking?

Hi Richard, that sounds really cool! just +1 to have it! Go for it! Em qui, 13 de dez de 2018 às 07:45, Richard Zowalla escreveu: > Hey Daniel & Rest, > > thanks for your replies. > > The OWASP Java version (as Maven Plugin) is capable of (a) reporting > vulnerabilities and (b) failing the

Re: More Community Website section improvements [TOMEE-2317]

Thanks much Martin! On Thu, Dec 13, 2018 at 2:01 AM Wiesner, Martin < martin.wies...@hs-heilbronn.de> wrote: > Hi César, > > I just marked this issue as resolved per PR 11. Thanks for your input and > work on this. > > Best > Martin > — > https://twitter.com/mawiesne > > Am 13.12.2018 um 07:22

Re: How can I help

Prakash, I can't recommend highly enough the link that Cesar provided. Please start here ... it will help you establish expectations as well as give you confidence to move forward and ASK QUESTIONS! Here it is again: http://tomee.apache.org/community/index.html Richard On Tue, Dec 11, 2018 at

Re: [DISCUSS] 1.x EOL

Hi folks, I’m sorry for digging back this old thread. I think we never ended up making a decision on this, and a year and a half as passed since we discussed this. So, I would like to bring to the table again the discussion around supporting TomEE 1.x and EOL. Cheers, Roberto > On 30 Jun

TomEE Downloads Page

Hi folks, Before going in and create a JIRA for this, I would to get some feedback. When I look into this page: http://tomee.apache.org/download-ng.html I found it super confusing. A lot of different binaries to download, multiple versions, etc. I

Re: TOMEE-2339 Describe Workflow for Contribution

Hi Cesar, thanks for your feedback. A visual diagram would be great but I don't have a good idea at the moment how to realize it - and keep it up to date when text changes. Besides, there is more information to be added, for example from this post from David:

Re: Is TomEE ready to ship for Santa? - Conducting pre-xmas releases: 7.0.6, 7.1.1, 8.0.0-M2

Hello, Huge +1, especially if that includes official Java 11 support. Think about this : Java 12 will be RTM in January, would be a shame if no TomEE+ release wouldn't even support Java 11 before... (and yes, we need it for TomEE+ 7.0.6, we're targeting 7.1.x next year, that's life..) Kind

Re: Is TomEE ready to ship for Santa? - Conducting pre-xmas releases: 7.0.6, 7.1.1, 8.0.0-M2

+1 On Thu, Dec 13, 2018, 10:37 Roberto Cortez Hi Martin, > > Yes, my idea was to push for another Milestone release once we stabilise > the build. > > Cheers, > Roberto > > > On 13 Dec 2018, at 12:16, Wiesner, Martin < > martin.wies...@hs-heilbronn.de> wrote: > > > > Hey guys, > > > > Richard

TOMEE-2361 - Improve main README file

Hi folks, Maybe you have missed this from another thread. I’ve created a JIRA to improve our frontend README information on Github: https://jira.apache.org/jira/browse/TOMEE-2361 Is anyone available to pick that up? Cheers, Roberto

Re: Is TomEE ready to ship for Santa? - Conducting pre-xmas releases: 7.0.6, 7.1.1, 8.0.0-M2

Hi Martin, Yes, my idea was to push for another Milestone release once we stabilise the build. Cheers, Roberto > On 13 Dec 2018, at 12:16, Wiesner, Martin > wrote: > > Hey guys, > > Richard (Z, @rzo1) and me are having some coffee in the office and are > discussing several ideas. One them

Re: Adds getModuleId method as a fallback when getJarLocation is null at

That is from container. [INFO] [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ openejb-junit --- [INFO] Installing /home/otaviojava/Environment/code/workspace-tomitribe-support/tomee/container/openejb-junit/target/openejb-junit-8.0.0-SNAPSHOT.jar to

Re: Adds getModuleId method as a fallback when getJarLocation is null at

Running a build here too. If stuff breaks, we can revert it. Cheers Jon On Thu, Dec 13, 2018 at 11:36 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Ah ok, I was running a build first. > So Should I leave it? > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro >

Is TomEE ready to ship for Santa? - Conducting pre-xmas releases: 7.0.6, 7.1.1, 8.0.0-M2

Hey guys, Richard (Z, @rzo1) and me are having some coffee in the office and are discussing several ideas. One them is that we’d like to propose that TomEE project kicks out a pre-xmas release for 7.1.1 and/or 7.0.6, and even more interesting: a 8.0.0-M2 milestone preview. The rationale

Re: Adds getModuleId method as a fallback when getJarLocation is null at

Ah ok, I was running a build first. So Should I leave it? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Dec 13, 2018 at 12:10 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Looks like that was a popular one :) > > On Thu, Dec 13, 2018

Re: Adds getModuleId method as a fallback when getJarLocation is null at

Looks like that was a popular one :) On Thu, Dec 13, 2018 at 11:09 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Awesome, thank you! Merged. > > Jon > > On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < > osant...@tomitribe.com> wrote: > >> It PR adds the

Re: Adds getModuleId method as a fallback when getJarLocation is null at

Awesome, thank you! Merged. Jon On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < osant...@tomitribe.com> wrote: > It PR adds the getModuleId method as a fallback when getJarLocation is null > at CmpJpaConversion, this way it keeps the desired behavior and fixes the > when the

[GitHub] tomee pull request #274: Adds getModuleId method as a fallback when getJarLo...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/274 ---

Re: Adds getModuleId method as a fallback when getJarLocation is null at

I was looking at it. I'll check it out and give it a try and a full build. Thanks -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Dec 13, 2018 at 11:56 AM Otávio Gonçalves de Santana < osant...@tomitribe.com> wrote: > It PR adds the getModuleId method

Adds getModuleId method as a fallback when getJarLocation is null at

It PR adds the getModuleId method as a fallback when getJarLocation is null at CmpJpaConversion, this way it keeps the desired behavior and fixes the when the getJarLocation is null such as the CheckMissingClassTest. https://github.com/apache/tomee/pull/274

[GitHub] tomee pull request #274: Adds getModuleId method as a fallback when getJarLo...

GitHub user otaviojava opened a pull request: https://github.com/apache/tomee/pull/274 Adds getModuleId method as a fallback when getJarLocation is null at … It PR adds the getModuleId method as a fallback when getJarLocation is null at CmpJpaConversion, this way it keeps the

(TOMEE-2362) Upgrade SL4J to mitigate CVE-2018-8088

Hi Richard, Martin I saw this come in on JIRA - we don't ship the slf4j-ext module so presumably TomEE itself doesn't have this vulnerability "out-of-box". Am I correct in thinking we'd need to update the slf4j-api and slf4j-jdk14 jars, so if someone wanted to add the slf4j-ext module to a TomEE

Re: Move to Gitbox?

Ticket filed. https://issues.apache.org/jira/browse/INFRA-17417 I believe its basically automated - the git-wip remote will become a gitbox remote. I'll ask about the PRs. Jon On Thu, Dec 13, 2018 at 10:06 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Do you know how smooth it

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

Hey Cesar, I have fixed a compilation issue after the MP work has been merged. Lemme know if you need some help with this and I'm happy to help -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Dec 13, 2018 at 7:10 AM César Hernández Mendoza <

Re: OWASP Dependency Checking?

No issue for me. Sounds like a good idea and a valuable contribution -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Dec 13, 2018 at 10:10 AM Richard Zowalla wrote: > Hey, > > any objectives against automatic checking of known, publicly disclosed >

Re: Move to Gitbox?

Looks like we have good support for this, so I'll get this started. Jon On Tue, Dec 11, 2018 at 11:44 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Hi Folks > > It appears that the git-wip service is going to be retired, and the > repositories are going to be migrated over to

Re: TOMEE-2234 BMP finder issue

Yes, I'll get that backported! Cheers Jon On Thu, Dec 13, 2018 at 8:52 AM Wiesner, Martin < martin.wies...@hs-heilbronn.de> wrote: > Hi Jon, > > TOMEE-2234 has originally been reported as a bug for 1.7.3 and 7.0.5. > Thus, I think it should be fixed at least at on both 7.x branches. Could >

OWASP Dependency Checking?

Hey, any objectives against automatic checking of known, publicly disclosed dependency vulnerabilities in the Maven build process (e.g. via a profile). I was thinking about introducing OWASP dependency checking (see https://www.owasp.org/index.php/OWASP_Dependency_Check) in the TomEE

Re: TOMEE-2234 BMP finder issue

Hi Jon, TOMEE-2234 has originally been reported as a bug for 1.7.3 and 7.0.5. Thus, I think it should be fixed at least at on both 7.x branches. Could you merge a backport of these changes to 1.7.x, 7.0.x and/or 7.1.x maintenance branches? If conducted it will compatible with the original

Re: More Community Website section improvements [TOMEE-2317]

Hi César, I just marked this issue as resolved per PR 11. Thanks for your input and work on this. Best Martin — https://twitter.com/mawiesne > Am 13.12.2018 um 07:22 schrieb César Hernández Mendoza : > > Hi, > The PR is now part of master, but the JIRA ticket is