[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108172#comment-16108172 ] ASF GitHub Bot commented on TWILL-240: -- Github user maochf commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-07-31 Thread maochf
Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r130491020 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java --- @@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context) { }

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107647#comment-16107647 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107645#comment-16107645 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107646#comment-16107646 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[jira] [Commented] (TWILL-240) Improve EventHandler to handle more application lifecycle events

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107644#comment-16107644 ] ASF GitHub Bot commented on TWILL-240: -- Github user chtyim commented on a diff in the

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-07-31 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r130407371 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -135,6 +135,9 @@ private final Map> environm

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-07-31 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r130406951 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java --- @@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context) { }

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-07-31 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r130407224 --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java --- @@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context) { }

[GitHub] twill pull request #58: [TWILL-240] EventHandler Improvement

2017-07-31 Thread chtyim
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r130407739 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -205,8 +208,9 @@ private RunningContainers createR

[jira] [Commented] (TWILL-147) Allow using external Kafka server for log collection

2017-07-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107620#comment-16107620 ] ASF GitHub Bot commented on TWILL-147: -- Github user chtyim commented on the issue:

[GitHub] twill issue #57: (TWILL-147) Allow using external Kafka server for log colle...

2017-07-31 Thread chtyim
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/57 One quick question, does Kafka 0.10 client works with older version of Kafka server? Also, ideally we should separate out all these Kafka related dependencies in a separate twill module, otherw