Re: ModalWindow and wicket 10

2023-11-14 Thread Sven Meier
Hi Korbinian, I won't have time to work on Wicket topics in the foreseeable future. Sven On 14.11.23 11:39, Korbinian Bachl wrote: My apologies for asking, did you have any time for having a look at it yet? If not, do you need any help with it? - Ursprüngliche Mail - Von: "

Re: ModalWindow and wicket 10

2023-10-20 Thread Sven Meier
Hi, I thought we already moved the old implementation to wicket-stuff, but apparently I forgot to do it actually. For explanation: the old ModalWindow is riddled with JS and dynamically generated HTML markup which we didn't want to maintain any more. Sven On 20.10.23 11:22, Korbinian

Re: [DISCUSSION] LocalDate*Time*TextField modification

2023-09-22 Thread Sven Meier
LocalD*TextField has the purpose to offer some convenience constructors and implementing ITextFormatProvider, If you allow people to use a custom converter, this class loses its purpose. Sven On 22.09.23 04:47, Maxim Solodovnik wrote: On Wed, 13 Sept 2023 at 05:13, Sven Meier wrote: Hi

Re: [DISCUSSION] LocalDate*Time*TextField modification

2023-09-12 Thread Sven Meier
Hi Maxim, it will be hard to make that suitable for different projects with different requirements: In Arabic sometimes dates are written in Latin digits, so we can't call #withDecimalStyle in general. We could add other constructors with IConverter argument, but then Local*TextField

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-15 Thread Sven Meier
+1 please release 9.13.0 Thanks Sven On 14.04.23 21:13, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.13.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72

Re: Time for Wicket M1?

2023-02-08 Thread Sven Meier
I've removed queuing on branch https://github.com/apache/wicket/tree/remove-queuing Still ready to be merged. We agreed to remove it from Wicket 10, didn't we? Sven On 08.02.23 12:54, Ernesto Reinaldo Barreiro wrote: No idea. There was some effort (by Sven) to remove component queueing...

Re: [VOTE] Release Apache Wicket 9.12.0

2022-10-12 Thread Sven Meier
+1 release 9.12.0 Many thanks Sven On 11.10.22 19:06, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.12.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72

Re: Time for 9.12.0?

2022-09-13 Thread Sven Meier
+1 Sven On 13.09.22 20:16, Martijn Dashorst wrote: No objection from me! Martijn On 13 Sep 2022, at 13:14, Andrea Del Bene wrote: Looks like we have enough material to promote a new release. WDYT? -- Andrea Del Bene. Apache Wicket committer.

Re: [VOTE] Release Apache Wicket 9.11.0

2022-07-07 Thread Sven Meier
+1 yes, release Tested build, sha256 and some examples. Many thanks Sven On 06.07.22 20:27, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.11.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the

Re: New release?

2022-07-05 Thread Sven Meier
Hi Andrea, WICKET-6993 needs some discussion, because it changes the format so much. I'd say we start a rollout with the current fixes now. Regard Sven Am 4. Juli 2022 18:00:46 MESZ schrieb Andrea Del Bene : >Hi, > >I think it's time to rollout ver 9.11.0. I see we have a WICKET-6993 nut I

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-05 Thread Sven Meier
+1 Sven On 05.04.22 16:47, Tobias Soloschenko wrote: +1 kind regards Tobias Am 05.04.2022 um 12:42 schrieb Thomas Heigl : +1 Ran our CI build and repeated stress tests on our staging environment. On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene wrote: This is a vote to release Apache

Re: [VOTE] Release Apache Wicket 9.9.0

2022-03-27 Thread Sven Meier
+1 release Sven On 27.03.22 14:58, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.9.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ]

Re: [VOTE] Release Apache Wicket 9.8.0

2022-02-03 Thread Sven Meier
+1 to release Tested build, checksum and a few examples. Sven On 03.02.22 18:46, Ernesto Reinaldo Barreiro wrote: +1 I have tested our application with around 650 selenium tests and all seem to be ok. On Thu, Feb 3, 2022 at 8:28 AM Andrea Del Bene wrote: This is a vote to release Apache

Re: [VOTE] Release Apache Wicket 8.14.0

2022-02-02 Thread Sven Meier
+1 yes, release Checked build and checksums Thanks Sven On 29.01.22 17:00, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.14.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives.

Re: Use non-final dependencies in master branch ?!

2021-12-22 Thread Sven Meier
+1 for merging Sven On 22.12.21 09:53, Martin Grigorov wrote: Hi, What do you think about merging - https://github.com/apache/wicket/pull/486 - use commons-fileupload2 2.0-SNAPSHOT - https://github.com/apache/wicket/pull/487 - use Spring 6.0.0-M1 (Java 17!) This way only wicket-cdi (Weld &

Re: [VOTE] Release Apache Wicket 9.7.0

2021-11-30 Thread Sven Meier
+1 tested signature, build and some random examples. Many thanks Sven On 30.11.21 05:58, Maxim Solodovnik wrote: +1 tested: - signatures - build from sources - wicketstuff build - wicketstuff examples On Sat, 27 Nov 2021 at 22:52, Andrea Del Bene wrote: This is a vote to release Apache

Re: [VOTE] Release Apache Wicket 9.6.0

2021-10-31 Thread Sven Meier
Hi, +1 release Apache Wicket 9.6.0 Reviewed checksum, build and a few examples. Many thanks Sven On 29.10.21 22:24, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.6.0 Please download the source distributions found in our staging area linked below. I have included the

Re: A solution to hide page id with mounted pages?

2021-10-29 Thread Sven Meier
too complex to be fully stateless with Wicket's current support for stateless ajax. -t On Fri, Oct 29, 2021 at 3:59 PM Sven Meier wrote: Hi Thomas, >and only page parameters are used for state if your pages are stateless, no pageid will appear anyways - so why bother with a custom map

Re: A solution to hide page id with mounted pages?

2021-10-29 Thread Sven Meier
Hi Thomas, >and only page parameters are used for state if your pages are stateless, no pageid will appear anyways - so why bother with a custom mapper? Sven On 29.10.21 15:17, Thomas Heigl wrote: Hi Andrea, I have been using NoPageIdMapper mapper for many years in all of my projects. It

Re: [VOTE] Release Apache Wicket 9.5.0

2021-09-07 Thread Sven Meier
+1 to release Many thanks Sven On 07.09.21 12:17, Andrea Del Bene wrote: Sure!! On Tue, Sep 7, 2021 at 11:37 AM Martin Grigorov wrote: + 1 to release! Tested: - local build - test various examples - test an app that I use for tranings In the announcement we should emphasize on two

Re: [VOTE] Buildbot config - SVN or Git ?

2021-08-17 Thread Sven Meier
+1 git Am 17. August 2021 09:26:54 MESZ schrieb Andrea Del Bene : >+1 for Git > >On Tue, Aug 17, 2021 at 8:52 AM Maxim Solodovnik >wrote: > >> +1 for git >> >> On Tue, 17 Aug 2021 at 13:44, Martin Grigorov >> wrote: >> >> > +1 for Git >> > >> > On Tue, Aug 17, 2021 at 9:43 AM Martin Grigorov

Re: [VOTE] Release Apache Wicket 8.13.0

2021-07-08 Thread Sven Meier
[X] Yes, release Apache Wicket 8.13.0 Many thanks Sven On 07.07.21 23:07, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.13.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This

Re: [VOTE] Release Apache Wicket 9.4.0

2021-07-03 Thread Sven Meier
+1 Tested some examples and hash. Many thanks Sven On 03.07.21 19:43, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.4.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This

Re: Wicket 10 ideas

2021-06-03 Thread Sven Meier
ain this extra complexity and add more on top of it Thanks Andrew On Thu, Jun 3, 2021 at 8:09 AM Sven Meier wrote: Hi Ernesto, if you want to do some tests: https://github.com/apache/wicket/tree/remove-queuing Have fun Sven On 02.06.21 12:04, Ernesto Reinaldo Barreiro wrote: Hi, I alre

Re: Wicket 10 ideas

2021-06-03 Thread Sven Meier
Hi Ernesto, if you want to do some tests: https://github.com/apache/wicket/tree/remove-queuing Have fun Sven On 02.06.21 12:04, Ernesto Reinaldo Barreiro wrote: Hi, I already removed queuing on an experimental branch, and it was quite simple. Nice. We have the master branch of our

Re: @jakarta.inject.Inject + not required

2021-06-02 Thread Sven Meier
Hi, I wasn't aware that Optional actually isn't serializable: https://stackoverflow.com/questions/24547673/why-java-util-optional-is-not-serializable-how-to-serialize-the-object-with-suc#24564612 "The JSR-335 EG felt fairly strongly that Optional should not be on any more than needed to

Re: Wicket 10 ideas

2021-06-02 Thread Sven Meier
Hi, I already removed queuing on an experimental branch, and it was quite simple. Regards Sven On 02.06.21 08:36, Ernesto Reinaldo Barreiro wrote: Hi, On Wed, Jun 2, 2021 at 9:14 AM Martin Grigorov wrote: On Tue, Jun 1, 2021 at 10:51 PM Ernesto Reinaldo Barreiro < reier...@gmail.com>

Re: Wicket 10 ideas

2021-04-23 Thread Sven Meier
a proper refactoring of the internal classes, which resulted in a code bloat for class MarkupContainer. So +2 for me. On Fri, Apr 23, 2021 at 11:48 AM Martin Grigorov wrote: On Fri, Apr 23, 2021 at 11:58 AM Sven Meier wrote: x) remove/rework enclosures and component queueing. Wow! I've

Re: Wicket 10 ideas

2021-04-23 Thread Sven Meier
x) remove/rework enclosures and component queueing. Have fun Sven On 02.04.21 13:58, Martin Grigorov wrote: Hi, Now since we have 9.3.0 released is it time to start thinking/working on Wicket 10 ? Here are few ideas what to break :-) 1) Move to Servlet 5.x, i.e. jakarta.servlet.** 2) Use

Re: [VOTE] Release Apache Wicket 7.18.0

2021-04-05 Thread Sven Meier
+1 release Apache WIcket 7.18.0 Checked hashes and build. Thanks Sven On 02.04.21 23:04, Andrea Del Bene wrote: This is a vote to release Apache Wicket 7.18.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source

Re: [VOTE] Release Apache Wicket 8.12.0

2021-04-01 Thread Sven Meier
[x] Yes, release Apache Wicket 8.12.0 Tested build and checksums. Thanks Sven On 01.04.21 14:58, Sebastien Briquet wrote: [x] Yes, release Apache Wicket 8.12.0 Tested on Wicket jQuery UI

Re: [VOTE] Release Apache Wicket 9.3.0

2021-03-26 Thread Sven Meier
[X] Yes, release Apache Wicket 9.3.0 Checked sha checksums and examples. Thanks Sven On 25.03.21 21:24, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.3.0 Please download the source distributions found in our staging area linked below. I have included the signatures for

Re: [VOTE] Release Apache Wicket 8.11.0

2020-11-20 Thread Sven Meier
+1 for release Tested signature and our main application. Thanks Sven On 20.11.20 21:35, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.11.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source

Re: [ANNOUNCE] Apache Wicket 9.2.0 released

2020-11-19 Thread Sven Meier
Many thanks Andrea! Sven On 19.11.20 22:46, Andrea Del Bene wrote: The Apache Wicket PMC is proud to announce Apache Wicket 9.2.0! Apache Wicket is an open source Java component oriented web application framework that powers thousands of web applications and web sites for governments, stores,

Re: [VOTE] Release Apache Wicket 9.2.0

2020-11-17 Thread Sven Meier
+1 to release 9.2.0 Tested build, checksums and various examples Thanks Sven On 15.11.20 23:18, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.2.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the

Re: [VOTE] Release Apache Wicket 9.2.0

2020-11-16 Thread Sven Meier
Hi, I've added a section flush-before-detach to the migration guide, for those needing some context to evaluate the important 9.2.0 changes: https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+9.0#MigrationtoWicket9.0-Flushanddetach(andasynchronouspageserialization) Have

Re: Inconsistency in deprecation

2020-11-14 Thread Sven Meier
WebSocketAwareCsrfPreventionRequestCycleListener has to be deprecated too. Sven On 14.11.20 16:50, Andrea Del Bene wrote: I don't know why deprecation has been applied that way, but recently I've answered a question on StackOverflow about unit testing with CSFR:

Re: [wicket] 01/01: WICKET-6847 onEndRequest before flush

2020-11-11 Thread Sven Meier
commit 15a6cedfb8b855c004b2ece201d9eac063ef770e Author: Sven Meier AuthorDate: Fri Nov 6 18:36:16 2020 +0100 WICKET-6847 onEndRequest before flush allows RequestPageStore to check for stateful pages --- pom.xml | 12 .../src

new release 9.2.0 ?

2020-10-28 Thread Sven Meier
Hi all, wicket-9.x got some important fixes, so we should release a 9.2.0 soon. WDYT? Sven

Re: including a reference to original work

2020-10-28 Thread Sven Meier
> I always have problems understanding what you mean by this. "Have fun in whatever you're doing" - preferably coding with Wicket :P Sven On 28.10.20 11:57, Ernesto Reinaldo Barreiro wrote: On Wed, Oct 28, 2020 at 1:45 PM Sven Meier wrote: Sure. Ok. It has gone a

Re: including a reference to original work

2020-10-28 Thread Sven Meier
Sure. It has gone a long way from the original idea to what is today. Have fun Sven On 28.10.20 11:20, Ernesto Reinaldo Barreiro wrote: Hi, I'm having a look at AjaxDownloadBehavior I would like to include a reference in javadoc to original work motivating the idea.

Re: [VOTE] Release Apache Wicket 9.1.0 TAKE 2

2020-10-11 Thread Sven Meier
g. Thomas On Fri, Oct 9, 2020 at 3:38 PM Sven Meier wrote: Thanks! We could argue whether your tests were valid then anyways :P IMHO filtering/decorating of header resources is an advanced topic, so I doubt many people are affect by these changes. I'll take a look at migration guide. Hav

Re: [VOTE] Release Apache Wicket 9.1.0 TAKE 2

2020-10-09 Thread Sven Meier
Thanks! We could argue whether your tests were valid then anyways :P IMHO filtering/decorating of header resources is an advanced topic, so I doubt many people are affect by these changes. I'll take a look at migration guide. Have fun Sven On 09.10.20 15:18, Thomas Heigl wrote: Hi Sven,

Re: [VOTE] Release Apache Wicket 9.1.0 TAKE 2

2020-10-09 Thread Sven Meier
Hi Thomas, so you where running your tests without a ResourceAggregator? Could you show us how you called #setHeaderResponseDecorator() previously? Thanks Sven On 09.10.20 14:30, Thomas Heigl wrote: All my unit tests failed with the new release: java.lang.IllegalStateException: no resource

Re: [VOTE] Release Apache Wicket 8.10.0

2020-10-04 Thread Sven Meier
+1 tested examples and zip signature Sven On 03.10.20 19:02, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.10.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Sven Meier
I'll try to re-build wicketstuff using 9.1.0 and try again On Sat, 3 Oct 2020 at 16:59, Sven Meier wrote: The CSP example works fine. Do you have Wicket 9.0 and 9.1 on your classpath? Sven On 03.10.20 08:13, Maxim Solodovnik wrote: Hello Sven, I was aware of this JIRA and have double

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Sven Meier
` and `getCspSettings().enforce(this);` was called On Sat, 3 Oct 2020 at 13:10, Sven Meier wrote: Hi, could be https://issues.apache.org/jira/browse/WICKET-6821 Do you configure your CSP in #init()? Sven Am 3. Oktober 2020 06:18:21 MESZ schrieb Maxim Solodovnik < solomax...@gmail.com>:

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Sven Meier
Hi, could be https://issues.apache.org/jira/browse/WICKET-6821 Do you configure your CSP in #init()? Sven Am 3. Oktober 2020 06:18:21 MESZ schrieb Maxim Solodovnik : >sorry for double posting, > >here are the first results: CSPNonceHeaderResponseDecorator was set up, >but >breakpoint in

Re: AbstractUpgradeFilter#processRequestCycle

2020-09-23 Thread Sven Meier
Thanks. Sven On 23.09.20 10:57, Martin Grigorov wrote: Hi Sven, On Wed, Sep 23, 2020 at 12:42 AM Sven Meier wrote: Hi all, anyone know why in AbstractUpgradeFilter we check HttpServletResponse#isCommitted(): https://github.com/apache/wicket/blob/78b7cf6612b167997f810bf89065f5755ae155a8

AbstractUpgradeFilter#processRequestCycle

2020-09-22 Thread Sven Meier
Hi all, anyone know why in AbstractUpgradeFilter we check HttpServletResponse#isCommitted():

Re: How to support multiple AbstractTransformerBehavior per component, if at all?

2020-08-31 Thread Sven Meier
Hi Thorsten, changed implementation is simply reversing the order of how behaviours are called per component the solution I was able to came up with: reverse the order of #afterRender() only! This way callbacks to behaviors are 'nested', i.e. the first behavior has the first *and* last

Re: [wicket] 01/01: WICKET-6821 disabled CSP

2020-08-28 Thread Sven Meier
to branch WICKET-6821-disable-CSP >> in repository https://gitbox.apache.org/repos/asf/wicket.git >> >> commit f1f95dd92e6c559cf5243fdf59e1ec20821df2c0 >> Author: Sven Meier >> AuthorDate: Thu Aug 27 19:49:18 2020 +0200 >> >> WICKET-6821 disabled CSP >&

Re: Wicket 9.0.0 AsynchronousPageStore Potential Memory Leak

2020-07-22 Thread Sven Meier
Hi Todd, has this problem been reported before? It seems that problem have been lurking there forever. What I'm wondering: If saving of any page to the delegate fails, all further page saving can no longer be asynchronous, isn't it? The runnable's thread will just stop and all following

Re: [VOTE] Release Apache Wicket 7.17.0

2020-07-18 Thread Sven Meier
+1 tested signature and some examples. Thanks Sven On 18.07.20 20:04, Maxim Solodovnik wrote: +1 tested: - signatures - build from sources (-Pbuildbot) - wicketstuff build - random wicketstuff examples On Fri, 17 Jul 2020 at 04:38, Andrea Del Bene wrote: This is a vote to release Apache

Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-13 Thread Sven Meier
+1 tested examples and checked sha. Regarding the FilePageStore NullPointerException: It seems UserDefinedFileAttributeView is not available on Os X. IMHO we can fix this later. Best regards Sven On 13.07.20 10:00, Martijn Dashorst wrote: -0 I am unable to build the tar.gz on my mac

Re: [VOTE] Release Apache Wicket 8.9.0

2020-07-13 Thread Sven Meier
+1 checked some examples and sha Sven On 11.07.20 19:10, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.9.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72

Re: Make ComponentRenderer implement AutoCloseable?

2020-05-24 Thread Sven Meier
Hi Thorsten, ComponentRender#destroy() destroys the application, there's not much more to it. In most cases you will want to reuse the application for performance reasons. A specific application can even be used as constructor argument, which might be the main web application that you don't

Re: Stable behavior ids

2020-05-15 Thread Sven Meier
Op ma 11 mei 2020 17:56 schreef Sven Meier : Hi Edmond, I agree that we should get rid of BehaviorIdList, it's probably the most inefficient implementation. But I'm against complicating matters even more with an additional method - at least until we know how the implementation will be improved

Re: Stable behavior ids

2020-05-11 Thread Sven Meier
before the 9 release, even though it has been the way it currently is since somewhere in 7.x. To me it feels like a loose end in the API and this is preventing me from improving the code that implements this API. Best regards, Emond Op do 7 mei 2020 22:19 schreef Sven Meier : Hi Emond, I'm

Re: Stable behavior ids

2020-05-07 Thread Sven Meier
in my implementation. I'm trying to keep things as close to what it already was, but without having to store the additional BehaviorIdList. Emond On Thu, May 7, 2020 at 1:13 PM Sven Meier wrote: Hi, we have a test for stateless behaviors

Re: Stable behavior ids

2020-05-07 Thread Sven Meier
Hi, we have a test for stateless behaviors: org.apache.wicket.ajax.markup.html.form.StatelessAjaxSubmitLinkTest We should just make sure it still works. Have fun Sven On 07.05.20 12:13, Andrea Del Bene wrote: On 07/05/20 10:37, Emond Papegaaij wrote: Hi Martin, I know what these id's

Re: Time to release 9.0.0 ?

2020-04-30 Thread Sven Meier
+1 we have to cut it somewhere Sven On 30.04.20 11:57, Andrea Del Bene wrote: +1 to release. The current state of 9.x is very stable and IMHO it shouldn't be delayed for major developments or refactoring. On 30/04/20 10:04, Tobias Soloschenko wrote: +1 - lets release kind regards Tobias

Re: [VOTE] Release Apache Wicket 8.8.0

2020-04-23 Thread Sven Meier
+1 Tested some examples. Thanks Sven On 22.04.20 17:33, Andrea Del Bene wrote: +1 Tested user guide examples. On 4/19/20 9:12 PM, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.8.0 Please download the source distributions found in our staging area linked below. I have

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 3

2020-04-05 Thread Sven Meier
If it's too much hassle with these manual steps, just do another vote. That's not a big problem for me. Thanks Sven On 05.04.20 20:00, Andrea Del Bene wrote: Sorry folks but I've wrongly  executed the "revert" script instead of "promote release" :-(. Unfortunately I've realized this mistake

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 3

2020-04-02 Thread Sven Meier
+1 release Sven On 02.04.20 11:43, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.0.0-M5 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ]

Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 2

2020-04-01 Thread Sven Meier
+1 release Built and tested examples. Thanks Sven On 31.03.20 20:56, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.0.0-M5 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This

Re: Is it time for release?

2020-03-31 Thread Sven Meier
Hi Maxim, I'd say all changes are complete :). Have fun Sven On 30.03.20 08:23, Maxim Solodovnik wrote: Hello All, Are there any incomplete tasks yet? Shall we start new VOTE? :))) On Mon, 9 Mar 2020 at 16:56, Ernesto Reinaldo Barreiro wrote: Hahaha... as always Martin is too fast :-)

Re: [wicket] branch master updated: WICKET-6563 add CachingPageStore

2020-03-27 Thread Sven Meier
: Sven Meier AuthorDate: Fri Mar 27 10:13:13 2020 +0100 WICKET-6563 add CachingPageStore --- .../apache/wicket/DefaultPageManagerProvider.java | 9 +- .../apache/wicket/pageStore/CachingPageStore.java | 109 + .../wicket/pageStore/InSessionPageStore.java | 82

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-27 Thread Sven Meier
as expected will continue testing On Wed, 25 Mar 2020 at 01:12, Sven Meier wrote: Hi, ok, let's give it a try! All hidden elements (hidden form fields or placeholders) are hidden via "hidden" attribute now. Have fun Sven On 24.03.20 08:15, Emond Papegaaij wrote: Hi all, If you want t

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-24 Thread Sven Meier
eck :) I'm currently using latest wicket SNAPSHOT at master so most probably will provide some feedback :) On Fri, 20 Mar 2020 at 19:51, Martin Grigorov wrote: In this case I am fine to go with 'hidden'. We can introduce wicket-core.css later if needed. On Fri, Mar 20, 2020 at 1:44 PM Sven Me

Re: PriorityHeaderItem.wrap should be static?

2020-03-23 Thread Sven Meier
Hi Rob, it's part of the IWrappedHeaderItem interface, no way to make that static :/. Just use the constructor and you're good to go. Have fun Sven On 23.03.20 15:09, Rob Audenaerde wrote: Hi all, I learned about PriorityHeaderItem, very useful! However, I think the wrap() method

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-18 Thread Sven Meier
nimum as possible :) On Tue, 17 Mar 2020 at 18:56, Sven Meier wrote: Hi Maxim, what is difficult about that? Actually it is recommended to have it in your normalize.css (formerly reset.css). Here one without !important: https://github.com/necolas/normalize.css/blob/master/normalize.css

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-17 Thread Sven Meier
m/apache/wicket/blob/10d10a92dda2e5834508f52d7807fe361f20fbea/wicket-core/src/main/java/org/apache/wicket/Component.java#L2370 On Thu, Mar 12, 2020 at 4:35 PM Sven Meier wrote: Hi all, I've looked at all responses and most arguments in favor of a "core.css" boil down to: > `hidden` attribute doesn't

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-17 Thread Sven Meier
/Component.java#L2370 On Thu, Mar 12, 2020 at 4:35 PM Sven Meier wrote: Hi all, I've looked at all responses and most arguments in favor of a "core.css" boil down to: > `hidden` attribute doesn't work (even `display: flex` breaks it) > Using the hidden attribute puts th

CSS marker red

2020-03-13 Thread Sven Meier
https://gitbox.apache.org/repos/asf/wicket.git The following commit(s) were added to refs/heads/master by this push: new 6ff1084 WICKET-6727 align css marker with other css classes 6ff1084 is described below commit 6ff10841d5dca741a43c0c2637a6d5ec7845dba2 Author: Sven Meier AuthorDate: Fri

Re: CSPRequestCycleListener headers

2020-03-12 Thread Sven Meier
of how CSP values interact across requests. For example, for js you can use strict-dynamic, but this doesn't apply to CSS, which breaks CSS loaded via js. Best regards, Emond On Thu, Mar 12, 2020 at 12:28 PM Sven Meier wrote: Hi Emond, it seems to me the CSPRequestCycleListener might add CSP headers

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-12 Thread Sven Meier
Hi all, I've looked at all responses and most arguments in favor of a "core.css" boil down to: > `hidden` attribute doesn't work (even `display: flex` breaks it) > Using the hidden attribute puts the responsibility with the developer > where this should be on the framework. The hidden

CSPRequestCycleListener headers

2020-03-12 Thread Sven Meier
Hi Emond, it seems to me the CSPRequestCycleListener might add CSP headers prematurely. What if a request comes in for one page and another page is rendered in response? The listener will already add the headers when the request handler is resolved for the former page. What if the page

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Sven Meier
Hi, I don't care about the method name, so I reverted it to #getCspSettings(). AFAIKS the documentation stays valid in that case? Have fun Sven On 12.03.20 09:42, Emond Papegaaij wrote: Hi, Agreed, but first, the documentation needs to be updated with the new API. I like most of the

WICKET-6725 styling of hidden elements: no vote yet

2020-02-25 Thread Sven Meier
Hi all, we have a disagreement on how to style hidden elements in Wicket 9.x. Due to the new CSP support we can no longer use inline styling to hide elements. WICKET-6725 introduces new CSS classes and a file wicket-core.css. I don't think this is a good approach: - it adds a CSS file that

Re: Form submit via Javascript and event handlers

2020-02-06 Thread Sven Meier
Fine by me. Sven On 05.02.20 22:22, Emond Papegaaij wrote: This is what I have in mind: https://github.com/apache/wicket/commit/b54938053a5bda2f4577966779d580e828f16e47 I think this is better than the old situation because this triggers any submit handlers on the form (or any parent element

Re: [jira] [Created] (WICKET-6745) CSP: inline JS in server and clienttime response filters

2020-02-04 Thread Sven Meier
Hi, >What about deprecating the current filters and writing a new one that >just adds the Server-Timing header? +1 to deprecate the current ones. Sven On 04.02.20 21:48, Emond Papegaaij wrote: Hi Martin, I like the idea of the 'Server-Timing' headers. I didn't know this feature yet.

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
(see https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden). If developer/user does override he or she could take care of this by himself. If the only style in core css is this wicket--hidden the whole css is, probably unnecessary. ср, 15 янв. 2020 г. в 10:38, Sven Meier : Hi Edmond, the

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
ot sure we need a CSS file at all, just to contain "display: none". Thanks Sven On 15.01.20 18:52, Martin Grigorov wrote: On Wed, Jan 15, 2020, 19:29 Sven Meier wrote: I disagree, "hidden" has the perfect semantic for what we're doing with placeholders or other s. H

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden ). If developer/user does override he or she could take care of this by himself. If the only style in core css is this wicket--hidden the whole css is, probably unnecessary. ср, 15 янв. 2020 г. в 10:38, Sven Meier : Hi Edmo

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
ing for the form submit handling markup needs to go there as well. I also found some other places with inline styling, like FormComponentFeedbackBorder. We need to decide what to do with those as well. Best regards, Emond On Tue, Jan 14, 2020 at 7:19 PM Sven Meier wrote: Hi Maxim, an empty d

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Sven Meier
ll. I also found some other places with inline styling, like FormComponentFeedbackBorder. We need to decide what to do with those as well. Best regards, Emond On Tue, Jan 14, 2020 at 7:19 PM Sven Meier wrote: Hi Maxim, an empty div with hidden inputs does not take any space. Try it with wicket-e

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Sven Meier
Hi Maxim, great idea with the header contributor, that's much better! Thanks Sven On 14.01.20 16:23, Maxim Solodovnik wrote: For example it can be added as `Application.get().getHeaderContributorListeners()` On Tue, 14 Jan 2020 at 16:03, Maxim Solodovnik wrote: `!important` is not the

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Sven Meier
den. For example, the styling for the form submit handling markup needs to go there as well. I also found some other places with inline styling, like FormComponentFeedbackBorder. We need to decide what to do with those as well. Best regards, Emond On Tue, Jan 14, 2020 at 7:19 PM Sven Meier

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Sven Meier
den attribute might work instead of `display: none` >The latter also hides all descendants [1], so I guess it should be >preferable > >[1] https://developer.mozilla.org/en-US/docs/Web/CSS/display > >On Wed, 15 Jan 2020 at 00:01, Sven Meier wrote: > >> Hi, >> &g

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-14 Thread Sven Meier
Hi, do we really need this CSS? AFAIK the 'hidden' markup from Form and Component placeholders do not need any styling actually, they look fine without it. We should add a CSS class to the markup of course, but leave its styling to each project. Cases in wicket-examples (UploadProgressBar,

Re: ChainingModel.getChainedModel in 9

2020-01-07 Thread Sven Meier
Hi Edmond, no objections from me. While you're at it, could you take care of the Javadoc? It still mentions IChainingModel. Thanks Sven On 06.01.20 20:39, Emond Papegaaij wrote: Hi all, With the Wicket 9 release coming closer, I decided to give our code base a try. Most of the

Re: [VOTE] Release Apache Wicket 9.0.0-M4 TAKE 2

2020-01-06 Thread Sven Meier
+1 built and tested various examples The SRI demo works fine here on Windows and Ubuntu. I'll try to add a dynamic hash calculation to the example. Thanks Sven On 06.01.20 08:17, Martin Grigorov wrote: +1 to release! Tested local build and various Wicket Examples. Great work with CSP and

Re: [VOTE] Release Apache Wicket 8.7.0

2020-01-06 Thread Sven Meier
+1 built and tested various examples Thanks Sven On 03.01.20 20:39, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.7.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote

Re: [VOTE] Release Apache Wicket 7.16.0

2020-01-06 Thread Sven Meier
+1 built and tested various examples Thanks Sven On 04.01.20 15:51, Andrea Del Bene wrote: This is a vote to release Apache Wicket 7.16.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote

Re: Support for disabling of page versioning

2020-01-04 Thread Sven Meier
or without providing a custom "MountedMapper" which feels too difficult for me. Kind regards, Jan Am 04.01.20 um 17:46 schrieb Sven Meier: Hi Jan, >Given a table which displays the state of laboratory orders, >When an order is canceled via a click on an AJAX button, &g

Re: Support for disabling of page versioning

2020-01-04 Thread Sven Meier
Hi Jan, >Given a table which displays the state of laboratory orders, >When an order is canceled via a click on an AJAX button, >And the page is reloaded via Ctrl + R, >Then the order is again displayed with status "open". the page is re-rendered on each reload. So there's no reason why the

Re: UCT -> UTC, here we go again...

2019-11-23 Thread Sven Meier
Hi Andrea, confirmed! Sven On 23.11.19 18:57, Andrea Del Bene wrote: Hi, I've just found that with the last OpenJDK 11.0.5 taken from AdoptOpenJDK I'm not able to build master branch as the following test fails: [ERROR] Failures: [ERROR]

Re: modal

2019-11-20 Thread Sven Meier
;> #popup.open .popup__outer { >> display: flex; >> justify-content: center; >> flex-direction: column; >> min-height: 100%; >> margin-bottom: 50px; /* fix issue with chrome control bar */ >> } >> #popup.open #popup__close { &

Re: New release cycle.

2019-11-20 Thread Sven Meier
, 8:58 PM Andrew Kondratev >> wrote: >> >>> Hi! >>> >>> Please let me know if you need further assistance with WICKET-6703 >>> <https://issues.apache.org/jira/browse/WICKET-6703> or WICKET-3404 >>> <https://issues.apache.or

  1   2   3   4   5   6   7   >