Re: Make ComponentRenderer implement AutoCloseable?

2020-05-24 Thread Sven Meier
Hi Thorsten, ComponentRender#destroy() destroys the application, there's not much more to it. In most cases you will want to reuse the application for performance reasons. A specific application can even be used as constructor argument, which might be the main web application that you don't

Re: [VOTE] Release Apache Wicket 8.9.0

2020-07-12 Thread Sven Meier
+1 checked some examples and sha Sven On 11.07.20 19:10, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.9.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72

Re: [VOTE] Release Apache Wicket 9.0.0

2020-07-13 Thread Sven Meier
+1 tested examples and checked sha. Regarding the FilePageStore NullPointerException: It seems UserDefinedFileAttributeView is not available on Os X. IMHO we can fix this later. Best regards Sven On 13.07.20 10:00, Martijn Dashorst wrote: -0 I am unable to build the tar.gz on my mac (Mojave

Re: [VOTE] Release Apache Wicket 7.17.0

2020-07-18 Thread Sven Meier
+1 tested signature and some examples. Thanks Sven On 18.07.20 20:04, Maxim Solodovnik wrote: +1 tested: - signatures - build from sources (-Pbuildbot) - wicketstuff build - random wicketstuff examples On Fri, 17 Jul 2020 at 04:38, Andrea Del Bene wrote: This is a vote to release Apache

Re: Wicket 9.0.0 AsynchronousPageStore Potential Memory Leak

2020-07-22 Thread Sven Meier
Hi Todd, has this problem been reported before? It seems that problem have been lurking there forever. What I'm wondering: If saving of any page to the delegate fails, all further page saving can no longer be asynchronous, isn't it? The runnable's thread will just stop and all following pages

Re: [wicket] 01/01: WICKET-6821 disabled CSP

2020-08-28 Thread Sven Meier
d a commit to branch WICKET-6821-disable-CSP >> in repository https://gitbox.apache.org/repos/asf/wicket.git >> >> commit f1f95dd92e6c559cf5243fdf59e1ec20821df2c0 >> Author: Sven Meier >> AuthorDate: Thu Aug 27 19:49:18 2020 +0200 >> >> WICKET-6821 disabled

Re: How to support multiple AbstractTransformerBehavior per component, if at all?

2020-08-31 Thread Sven Meier
Hi Thorsten, changed implementation is simply reversing the order of how behaviours are called per component the solution I was able to came up with: reverse the order of #afterRender() only! This way callbacks to behaviors are 'nested', i.e. the first behavior has the first *and* last word

AbstractUpgradeFilter#processRequestCycle

2020-09-22 Thread Sven Meier
Hi all, anyone know why in AbstractUpgradeFilter we check HttpServletResponse#isCommitted(): https://github.com/apache/wicket/blob/78b7cf6612b167997f810bf89065f5755ae155a8/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/AbstractUpgradeFilter.jav

Re: AbstractUpgradeFilter#processRequestCycle

2020-09-23 Thread Sven Meier
Thanks. Sven On 23.09.20 10:57, Martin Grigorov wrote: Hi Sven, On Wed, Sep 23, 2020 at 12:42 AM Sven Meier wrote: Hi all, anyone know why in AbstractUpgradeFilter we check HttpServletResponse#isCommitted(): https://github.com/apache/wicket/blob/78b7cf6612b167997f810bf89065f5755ae155a8

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-02 Thread Sven Meier
Hi, could be https://issues.apache.org/jira/browse/WICKET-6821 Do you configure your CSP in #init()? Sven Am 3. Oktober 2020 06:18:21 MESZ schrieb Maxim Solodovnik : >sorry for double posting, > >here are the first results: CSPNonceHeaderResponseDecorator was set up, >but >breakpoint in it's

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Sven Meier
`getCspSettings().enforce(this);` was called On Sat, 3 Oct 2020 at 13:10, Sven Meier wrote: Hi, could be https://issues.apache.org/jira/browse/WICKET-6821 Do you configure your CSP in #init()? Sven Am 3. Oktober 2020 06:18:21 MESZ schrieb Maxim Solodovnik < solomax...@gmail.com>: sor

Re: [VOTE] Release Apache Wicket 9.1.0

2020-10-03 Thread Sven Meier
4.jar I'll try to re-build wicketstuff using 9.1.0 and try again On Sat, 3 Oct 2020 at 16:59, Sven Meier wrote: The CSP example works fine. Do you have Wicket 9.0 and 9.1 on your classpath? Sven On 03.10.20 08:13, Maxim Solodovnik wrote: Hello Sven, I was aware of this JIRA and h

Re: [VOTE] Release Apache Wicket 8.10.0

2020-10-04 Thread Sven Meier
+1 tested examples and zip signature Sven On 03.10.20 19:02, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.10.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for

Re: [VOTE] Release Apache Wicket 9.1.0 TAKE 2

2020-10-09 Thread Sven Meier
Hi Thomas, so you where running your tests without a ResourceAggregator? Could you show us how you called #setHeaderResponseDecorator() previously? Thanks Sven On 09.10.20 14:30, Thomas Heigl wrote: All my unit tests failed with the new release: java.lang.IllegalStateException: no resource

Re: [VOTE] Release Apache Wicket 9.1.0 TAKE 2

2020-10-09 Thread Sven Meier
Thanks! We could argue whether your tests were valid then anyways :P IMHO filtering/decorating of header resources is an advanced topic, so I doubt many people are affect by these changes. I'll take a look at migration guide. Have fun Sven On 09.10.20 15:18, Thomas Heigl wrote: Hi Sven, M

Re: [VOTE] Release Apache Wicket 9.1.0 TAKE 2

2020-10-11 Thread Sven Meier
r releasing. Thomas On Fri, Oct 9, 2020 at 3:38 PM Sven Meier wrote: Thanks! We could argue whether your tests were valid then anyways :P IMHO filtering/decorating of header resources is an advanced topic, so I doubt many people are affect by these changes. I'll take a look at migrat

Re: including a reference to original work

2020-10-28 Thread Sven Meier
Sure. It has gone a long way from the original idea to what is today. Have fun Sven On 28.10.20 11:20, Ernesto Reinaldo Barreiro wrote: Hi, I'm having a look at AjaxDownloadBehavior I would like to include a reference in javadoc to original work motivating the idea. https://cwiki.apache.o

Re: including a reference to original work

2020-10-28 Thread Sven Meier
> I always have problems understanding what you mean by this. "Have fun in whatever you're doing" - preferably coding with Wicket :P Sven On 28.10.20 11:57, Ernesto Reinaldo Barreiro wrote: On Wed, Oct 28, 2020 at 1:45 PM Sven Meier wrote: Sure. Ok. It has gone a

new release 9.2.0 ?

2020-10-28 Thread Sven Meier
Hi all, wicket-9.x got some important fixes, so we should release a 9.2.0 soon. WDYT? Sven

Re: [wicket] 01/01: WICKET-6847 onEndRequest before flush

2020-11-11 Thread Sven Meier
t.git commit 15a6cedfb8b855c004b2ece201d9eac063ef770e Author: Sven Meier AuthorDate: Fri Nov 6 18:36:16 2020 +0100 WICKET-6847 onEndRequest before flush allows RequestPageStore to check for stateful pages --- pom.xml | 12 ..

Re: Inconsistency in deprecation

2020-11-14 Thread Sven Meier
WebSocketAwareCsrfPreventionRequestCycleListener has to be deprecated too. Sven On 14.11.20 16:50, Andrea Del Bene wrote: I don't know why deprecation has been applied that way, but recently I've answered a question on StackOverflow about unit testing with CSFR: https://stackoverflow.com/que

Re: [VOTE] Release Apache Wicket 9.2.0

2020-11-16 Thread Sven Meier
Hi, I've added a section flush-before-detach to the migration guide, for those needing some context to evaluate the important 9.2.0 changes: https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+9.0#MigrationtoWicket9.0-Flushanddetach(andasynchronouspageserialization) Have fu

Re: [VOTE] Release Apache Wicket 9.2.0

2020-11-17 Thread Sven Meier
+1 to release 9.2.0 Tested build, checksums and various examples Thanks Sven On 15.11.20 23:18, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.2.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the s

Re: [ANNOUNCE] Apache Wicket 9.2.0 released

2020-11-19 Thread Sven Meier
Many thanks Andrea! Sven On 19.11.20 22:46, Andrea Del Bene wrote: The Apache Wicket PMC is proud to announce Apache Wicket 9.2.0! Apache Wicket is an open source Java component oriented web application framework that powers thousands of web applications and web sites for governments, stores,

Re: [VOTE] Release Apache Wicket 8.11.0

2020-11-20 Thread Sven Meier
+1 for release Tested signature and our main application. Thanks Sven On 20.11.20 21:35, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.11.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source

Re: [VOTE] Release Apache Wicket 9.3.0

2021-03-26 Thread Sven Meier
[X] Yes, release Apache Wicket 9.3.0 Checked sha checksums and examples. Thanks Sven On 25.03.21 21:24, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.3.0 Please download the source distributions found in our staging area linked below. I have included the signatures for bo

Re: [VOTE] Release Apache Wicket 8.12.0

2021-04-01 Thread Sven Meier
[x] Yes, release Apache Wicket 8.12.0 Tested build and checksums. Thanks Sven On 01.04.21 14:58, Sebastien Briquet wrote: [x] Yes, release Apache Wicket 8.12.0 Tested on Wicket jQuery UI

Re: [VOTE] Release Apache Wicket 7.18.0

2021-04-05 Thread Sven Meier
+1 release Apache WIcket 7.18.0 Checked hashes and build. Thanks Sven On 02.04.21 23:04, Andrea Del Bene wrote: This is a vote to release Apache Wicket 7.18.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source a

Re: Wicket 10 ideas

2021-04-23 Thread Sven Meier
x) remove/rework enclosures and component queueing. Have fun Sven On 02.04.21 13:58, Martin Grigorov wrote: Hi, Now since we have 9.3.0 released is it time to start thinking/working on Wicket 10 ? Here are few ideas what to break :-) 1) Move to Servlet 5.x, i.e. jakarta.servlet.** 2) Use @I

Re: Wicket 10 ideas

2021-04-23 Thread Sven Meier
without a proper refactoring of the internal classes, which resulted in a code bloat for class MarkupContainer. So +2 for me. On Fri, Apr 23, 2021 at 11:48 AM Martin Grigorov wrote: On Fri, Apr 23, 2021 at 11:58 AM Sven Meier wrote: x) remove/rework enclosures and component queueing.

Re: GitHub notifications to a special mailing list (was: How do I unsubscribe from wicket, please?)

2021-05-31 Thread Sven Meier
+1 Sven On 31.05.21 17:25, Martin Grigorov wrote: Hi, Some people complain that there is too much email traffic on dev@ due to the GitHub notifications. What do you think about creating a new mailing list, e.g. github@w.a.o ? This could be easily done via .asf.yaml Any objections ? Regards,

Re: Wicket 10 ideas

2021-06-02 Thread Sven Meier
Hi, I already removed queuing on an experimental branch, and it was quite simple. Regards Sven On 02.06.21 08:36, Ernesto Reinaldo Barreiro wrote: Hi, On Wed, Jun 2, 2021 at 9:14 AM Martin Grigorov wrote: On Tue, Jun 1, 2021 at 10:51 PM Ernesto Reinaldo Barreiro < reier...@gmail.com> w

Re: @jakarta.inject.Inject + not required

2021-06-02 Thread Sven Meier
Hi, I wasn't aware that Optional actually isn't serializable: https://stackoverflow.com/questions/24547673/why-java-util-optional-is-not-serializable-how-to-serialize-the-object-with-suc#24564612 "The JSR-335 EG felt fairly strongly that Optional should not be on any more than needed to suppor

Re: Wicket 10 ideas

2021-06-03 Thread Sven Meier
Hi Ernesto, if you want to do some tests: https://github.com/apache/wicket/tree/remove-queuing Have fun Sven On 02.06.21 12:04, Ernesto Reinaldo Barreiro wrote: Hi, I already removed queuing on an experimental branch, and it was quite simple. Nice. We have the master branch of our appl

Re: Wicket 10 ideas

2021-06-03 Thread Sven Meier
ner cases and no one wants to maintain this extra complexity and add more on top of it Thanks Andrew On Thu, Jun 3, 2021 at 8:09 AM Sven Meier wrote: Hi Ernesto, if you want to do some tests: https://github.com/apache/wicket/tree/remove-queuing Have fun Sven On 02.06.21 12:04, Ernesto Rein

Re: [VOTE] Release Apache Wicket 9.4.0

2021-07-03 Thread Sven Meier
+1 Tested some examples and hash. Many thanks Sven On 03.07.21 19:43, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.4.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote

Re: [VOTE] Release Apache Wicket 8.13.0

2021-07-08 Thread Sven Meier
[X] Yes, release Apache Wicket 8.13.0 Many thanks Sven On 07.07.21 23:07, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.13.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This v

Re: [VOTE] Buildbot config - SVN or Git ?

2021-08-17 Thread Sven Meier
+1 git Am 17. August 2021 09:26:54 MESZ schrieb Andrea Del Bene : >+1 for Git > >On Tue, Aug 17, 2021 at 8:52 AM Maxim Solodovnik >wrote: > >> +1 for git >> >> On Tue, 17 Aug 2021 at 13:44, Martin Grigorov >> wrote: >> >> > +1 for Git >> > >> > On Tue, Aug 17, 2021 at 9:43 AM Martin Grigorov >>

Re: [VOTE] Release Apache Wicket 9.5.0

2021-09-07 Thread Sven Meier
+1 to release Many thanks Sven On 07.09.21 12:17, Andrea Del Bene wrote: Sure!! On Tue, Sep 7, 2021 at 11:37 AM Martin Grigorov wrote: + 1 to release! Tested: - local build - test various examples - test an app that I use for tranings In the announcement we should emphasize on two things

Re: A solution to hide page id with mounted pages?

2021-10-29 Thread Sven Meier
Hi Thomas, >and only page parameters are used for state if your pages are stateless, no pageid will appear anyways - so why bother with a custom mapper? Sven On 29.10.21 15:17, Thomas Heigl wrote: Hi Andrea, I have been using NoPageIdMapper mapper for many years in all of my projects. It

Re: A solution to hide page id with mounted pages?

2021-10-29 Thread Sven Meier
much too complex to be fully stateless with Wicket's current support for stateless ajax. -t On Fri, Oct 29, 2021 at 3:59 PM Sven Meier wrote: Hi Thomas, >and only page parameters are used for state if your pages are stateless, no pageid will appear anyways - so why bother with a

Re: [VOTE] Release Apache Wicket 9.6.0

2021-10-31 Thread Sven Meier
Hi, +1 release Apache Wicket 9.6.0 Reviewed checksum, build and a few examples. Many thanks Sven On 29.10.21 22:24, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.6.0 Please download the source distributions found in our staging area linked below. I have included the sign

Re: [VOTE] Release Apache Wicket 9.7.0

2021-11-30 Thread Sven Meier
+1 tested signature, build and some random examples. Many thanks Sven On 30.11.21 05:58, Maxim Solodovnik wrote: +1 tested: - signatures - build from sources - wicketstuff build - wicketstuff examples On Sat, 27 Nov 2021 at 22:52, Andrea Del Bene wrote: This is a vote to release Apache Wi

Re: Use non-final dependencies in master branch ?!

2021-12-22 Thread Sven Meier
+1 for merging Sven On 22.12.21 09:53, Martin Grigorov wrote: Hi, What do you think about merging - https://github.com/apache/wicket/pull/486 - use commons-fileupload2 2.0-SNAPSHOT - https://github.com/apache/wicket/pull/487 - use Spring 6.0.0-M1 (Java 17!) This way only wicket-cdi (Weld & c

Re: [VOTE] Release Apache Wicket 8.14.0

2022-02-02 Thread Sven Meier
+1 yes, release Checked build and checksums Thanks Sven On 29.01.22 17:00, Andrea Del Bene wrote: This is a vote to release Apache Wicket 8.14.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This

Re: [VOTE] Release Apache Wicket 9.8.0

2022-02-03 Thread Sven Meier
+1 to release Tested build, checksum and a few examples. Sven On 03.02.22 18:46, Ernesto Reinaldo Barreiro wrote: +1 I have tested our application with around 650 selenium tests and all seem to be ok. On Thu, Feb 3, 2022 at 8:28 AM Andrea Del Bene wrote: This is a vote to release Apache W

Re: [VOTE] Release Apache Wicket 9.9.0

2022-03-27 Thread Sven Meier
+1 release Sven On 27.03.22 14:58, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.9.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ] Yes,

Re: [VOTE] Release Apache Wicket 9.9.1

2022-04-05 Thread Sven Meier
+1 Sven On 05.04.22 16:47, Tobias Soloschenko wrote: +1 kind regards Tobias Am 05.04.2022 um 12:42 schrieb Thomas Heigl : +1 Ran our CI build and repeated stress tests on our staging environment. On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene wrote: This is a vote to release Apache

Re: New release?

2022-07-05 Thread Sven Meier
Hi Andrea, WICKET-6993 needs some discussion, because it changes the format so much. I'd say we start a rollout with the current fixes now. Regard Sven Am 4. Juli 2022 18:00:46 MESZ schrieb Andrea Del Bene : >Hi, > >I think it's time to rollout ver 9.11.0. I see we have a WICKET-6993 nut I >don

Re: [VOTE] Release Apache Wicket 9.11.0

2022-07-07 Thread Sven Meier
+1 yes, release Tested build, sha256 and some examples. Many thanks Sven On 06.07.22 20:27, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.11.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the sour

Re: Time for 9.12.0?

2022-09-13 Thread Sven Meier
+1 Sven On 13.09.22 20:16, Martijn Dashorst wrote: No objection from me! Martijn On 13 Sep 2022, at 13:14, Andrea Del Bene wrote: Looks like we have enough material to promote a new release. WDYT? -- Andrea Del Bene. Apache Wicket committer.

Re: [VOTE] Release Apache Wicket 9.12.0

2022-10-12 Thread Sven Meier
+1 release 9.12.0 Many thanks Sven On 11.10.22 19:06, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.12.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hou

Re: Time for Wicket M1?

2023-02-08 Thread Sven Meier
I've removed queuing on branch https://github.com/apache/wicket/tree/remove-queuing Still ready to be merged. We agreed to remove it from Wicket 10, didn't we? Sven On 08.02.23 12:54, Ernesto Reinaldo Barreiro wrote: No idea. There was some effort (by Sven) to remove component queueing... No

Re: [VOTE] Release Apache Wicket 9.13.0

2023-04-15 Thread Sven Meier
+1 please release 9.13.0 Thanks Sven On 14.04.23 21:13, Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.13.0 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72

Re: [DISCUSSION] LocalDate*Time*TextField modification

2023-09-12 Thread Sven Meier
Hi Maxim, it will be hard to make that suitable for different projects with different requirements: In Arabic sometimes dates are written in Latin digits, so we can't call #withDecimalStyle in general. We could add other constructors with IConverter argument, but then Local*TextField wouldn'

Re: [DISCUSSION] LocalDate*Time*TextField modification

2023-09-22 Thread Sven Meier
LocalD*TextField has the purpose to offer some convenience constructors and implementing ITextFormatProvider, If you allow people to use a custom converter, this class loses its purpose. Sven On 22.09.23 04:47, Maxim Solodovnik wrote: On Wed, 13 Sept 2023 at 05:13, Sven Meier wrote: Hi

Re: ModalWindow and wicket 10

2023-10-20 Thread Sven Meier
Hi, I thought we already moved the old implementation to wicket-stuff, but apparently I forgot to do it actually. For explanation: the old ModalWindow is riddled with JS and dynamically generated HTML markup which we didn't want to maintain any more. Sven On 20.10.23 11:22, Korbinian Bach

Re: ModalWindow and wicket 10

2023-11-14 Thread Sven Meier
Hi Korbinian, I won't have time to work on Wicket topics in the foreseeable future. Sven On 14.11.23 11:39, Korbinian Bachl wrote: My apologies for asking, did you have any time for having a look at it yet? If not, do you need any help with it? - Ursprüngliche Mail - Von:

Re: Roadmap for Wicket 6

2011-08-30 Thread Sven Meier
#. rework Wicket components: ModalWindow, Wizard and Trees #. try to boil down Wicket core to its essentials (e.g. without most components) Sven On 08/30/2011 12:12 AM, Martijn Dashorst wrote: > In order to start discussing what will constitute Wicket Next and > where we want to take our beloved

Re: [vote] check wicket 1.5.0 artifacts

2011-09-05 Thread Sven Meier
+1 On 09/05/2011 02:24 PM, Martijn Dashorst wrote: > +1 > > On Sun, Sep 4, 2011 at 7:15 PM, Pedro Santos wrote: >> +1 >> >> 2011/9/4 jcgarciam >> >>> +1 >>> >>> On Sun, Sep 4, 2011 at 6:01 AM, Peter Ertl-3 [via Apache Wicket] < >>> ml-node+3788932-1962192371-65...@n4.nabble.com> wrote: >>>

AW: [vote] release wicket 1.5.3

2011-11-11 Thread Sven Meier
+1 Sven -Ursprüngliche Nachricht- Von: Igor Vaynberg [mailto:igor.vaynb...@gmail.com] Gesendet: Donnerstag, 10. November 2011 17:42 An: dev@wicket.apache.org Betreff: Re: [vote] release wicket 1.5.3 +1 -igor On Wed, Nov 9, 2011 at 12:14 PM, Igor Vaynberg wrote: > This vote is to rel

AW: Wicket 6 development

2011-11-16 Thread Sven Meier
+1 (I'd love to take a look at the new jquery stuff.) Sven -Ursprüngliche Nachricht- Von: Martin Grigorov [mailto:mgrigo...@apache.org] Gesendet: Mittwoch, 16. November 2011 10:01 An: dev@wicket.apache.org Betreff: Re: Wicket 6 development +1 I have quite some progress with JQuery-fyi

Re: Request for help: simple GitHub test

2011-12-11 Thread Sven Meier
Pull requested. Sven On 12/11/2011 02:35 AM, Jeremy Thomerson wrote: If anybody here has ten minutes available to help me test some GitHub features, please see [1] and complete the first batch of steps. Basically, fork that repo, add a commit or two, and then create a pull request for me. I'

Re: Roadmap for Wicket 6.0

2011-12-21 Thread Sven Meier
011 00:14, schrieb Gabriel Landon: I would love to have a refactor of the Treegrid (see https://issues.apache.org/jira/browse/WICKET-1600 WICKET-1600 ) implemented with the http://code.google.com/p/wicket-tree/ wicket-tree implementation Sven Meier has done. It would be very nice to use a TreeProvi

Re: Re: Roadmap for Wicket 6.0

2011-12-29 Thread Sven Meier
Hi Jeremy, > Thoughts about moving your tree to wicket-extensions yes, ultimately the new implementation from wicket-tree will be part of wicket-extensions. IMHO it's just a matter of timing, so this rework doesn't delay the next Wicket release and we get enough feedback on the new implement

Re: Roadmap for Wicket 6.0

2011-12-29 Thread Sven Meier
If so I'll start working on WICKET-4240 next week. Sven On 12/29/2011 06:49 PM, Igor Vaynberg wrote: imho we should put it into wicket 6. wicket 7 will be far off... -igor On Thu, Dec 29, 2011 at 9:21 AM, Sven Meier wrote: Hi Jeremy, Thoughts about moving your tree to wicket-exten

Re: Please welcome Emond Papegaaij as a committer for Wicket

2011-12-30 Thread Sven Meier
Welcome :) Sven On 12/30/2011 04:26 PM, Emond Papegaaij wrote: Thank you all for the confidence you have in my work! I'm really proud to be a member of the Wicket team and am looking forward to get some real work done. I've already pushed some patches for a few tickets, broke most testcases and

Re: Ajax event named "href"

2012-01-03 Thread Sven Meier
Seems superfluous, thus +1 for removing crufty code. Sven Am 03.01.2012 17:06, schrieb Igor Vaynberg: seems like a leftover from the time past. +1 to remove. -igor On Tue, Jan 3, 2012 at 7:27 AM, Martin Grigorov wrote: Hi, What is the use case for supporting the special event name "href" i

Re: Opinion about the change proposed in WICKET-4326 ?

2012-01-09 Thread Sven Meier
There are a few places where the active or next requestHandler is looked up by type. This could be: T RequestCycle#resolveHandler(Class) This would result in a little more typing though, e.g. for Ajax: RequestCycle.get().resolveHandler(IAjaxRequestHandler.class) Sven On 01/09/2012 06:22 P

Re: [vote] release wicket 1.5.4

2012-01-11 Thread Sven Meier
+1 Am 10.01.2012 20:03, schrieb Igor Vaynberg: This vote is to release wicket 1.5.4 Branch http://git-wip-us.apache.org/repos/asf/wicket/?p=wicket.git;a=shortlog;h=refs/heads/build/wicket-1.5.4 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.4/dist/ Maven repo https://repository.apac

Re: [vote] release wicket 1.5.4 take 3

2012-01-20 Thread Sven Meier
+1 On 01/19/2012 06:04 PM, Jeremy Thomerson wrote: +1 On Thu, Jan 19, 2012 at 11:47 AM, Igor Vaynbergwrote: +1 -igor On Tue, Jan 17, 2012 at 8:34 PM, Igor Vaynberg wrote: This vote is to release wicket 1.5.4 take 3 Branch http://git-wip-us.apache.org/repos/asf/wicket/?p=wicket.git;a=sho

Re: Design of StringValue toOptionalXYZ() and toXYZ(defaultValue)

2012-01-30 Thread Sven Meier
I don't know the reason for this. Let's change it for 1.5.x too. Sven Am 30.01.2012 13:35, schrieb Martin Grigorov: Hi devs, At https://issues.apache.org/jira/browse/WICKET-4356 the reporter asks a reasonable question: why toXyz(default) throws a FormatException instead of returning the defaul

Re: Deprecate Component#onMarkupAttached() ?

2012-01-31 Thread Sven Meier
+1 same here Sven On 01/31/2012 06:18 PM, Igor Vaynberg wrote: +1 to deprecate in 1.5.x and remove in 6.0 -igor On Tue, Jan 31, 2012 at 8:44 AM, Martin Grigorov wrote: Hi, To solve https://issues.apache.org/jira/browse/WICKET-4361 I moved the call to Component#internalOnMarkupAttached() fr

Re: DropDownChoice Issue

2012-02-14 Thread Sven Meier
Do you want to force the user to re-select a choice? Try resetting the model object to null after the search: choice.setDefaultModelObject(null); Sven Am 14.02.2012 06:17, schrieb mukesh kumar: Hi, I am really helpless of my this issue. I have a DropDownChoice. and first time, w

Re: modal dialog and nesting of forms.

2012-02-17 Thread Sven Meier
imho simpler to put a form inside modal's panel and call it a day IMHO the modalwindow-form requirement is weird. It's counter-intuitive and inelegant - just look at all the html elements created in modal window's js. It breaks encapsulation: Why should I put the modal window into a form, when

IPageParametersEncoder

2012-02-22 Thread Sven Meier
Anybody knows the reason why IPageParametersEncoder's methods are asymetrical: Url encodePageParameters(PageParameters pageParameters); PageParameters decodePageParameters(Request request); Shouldn't that be: Url encodePageParameters(PageParameters pageParameters); PageParamete

Re: Wicket 6.0 status

2012-02-22 Thread Sven Meier
Hi Martin, >new Tree impl I'll still have to do minor cleanups and javadoc, but no api changes. >WICKET-3927 I think this one can be closed. Agreed. >WICKET-2128 I agree that ${label} should be used IIRC the reason for using ${input} is that the label isn't necessarily set on the component.

Re: IPageParametersEncoder

2012-02-23 Thread Sven Meier
s in IPageParametersEncoder#encodePageParameters(). On Thu, Feb 23, 2012 at 8:07 AM, Sven Meier wrote: Anybody knows the reason why IPageParametersEncoder's methods are asymetrical: Url encodePageParameters(PageParameters pageParameters); PageParameters decodePageParameters(Request request);

UrlEncoder and at-sign @

2012-02-23 Thread Sven Meier
Hi all, apparently UrlEncoder doesn't encode the at-sign @, line #189: dontNeedEncoding.set('@'); The comment copied from java.net.URLEncoder states however: As a last note, Intenet Explorer does not encode the "@" character which is clearly not unreserved according t

Re: UrlEncoder and at-sign @

2012-03-07 Thread Sven Meier
by handling the request in a custom wicket resource. Sven On 03/07/2012 08:26 PM, Dan Retzlaff wrote: Sven, did you resolve this? I encountered a related issue with ":" in path segments, but "@" seems to work in the tests I did. https://issues.apache.org/jira/browse/WICKE

Re: [vote] release wicket 1.5.5

2012-03-07 Thread Sven Meier
Tested examples and our current application ... +1 Sven On 03/07/2012 05:42 PM, Peter Ertl wrote: +1 Am 07.03.2012 um 17:27 schrieb Igor Vaynberg: +1 -igor On Mon, Mar 5, 2012 at 9:42 AM, Igor Vaynberg wrote: This vote is to release wicket 1.5.5 Branch http://git-wip-us.apache.org/repos

Re: Release Wicket 6.0 milestone1 ?

2012-03-20 Thread Sven Meier
I had a lot of request recently whether to wait for Wicket 6 instead of migrating to 1.5.x. Seems there are a lot of projects still running on 1.4.x, so I'm all in favor of a milestone soon. Hopefully this will bring people to speed with their upgrade plans. Sven On 03/20/2012 09:39 AM, Emond

Re: Release Wicket 6.0 milestone1 ?

2012-03-21 Thread Sven Meier
+1 Sven On 03/21/2012 04:46 PM, Juergen Donnerstag wrote: +1 Juergen On Wed, Mar 21, 2012 at 11:57 AM, Emond Papegaaij wrote: +1 for release, +1 for beta On Tuesday 20 March 2012 12:21:38 Igor Vaynberg wrote: +1 for release, +0 for beta vs milestone. -igor On Tue, Mar 20, 2012 at 10:59

Re: [Vote] Release Apache Wicket 6.0.0-beta1

2012-03-26 Thread Sven Meier
+1 On 03/25/2012 04:31 PM, Martin Grigorov wrote: +1 tested wicket-examples and the quickstart archetype On Fri, Mar 23, 2012 at 2:33 PM, Martin Grigorov wrote: This vote is to release wicket 6.0.0-beta1. This is the first release of 6.x branch and its purpose is to get more feedback from th

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-29 Thread Sven Meier
ket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d7e0d884 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d7e0d884 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d7e0d884 Branch: refs/heads/wicket-1.5.x Commit: d7e0d8845dd509110e48ba965f0e11a3aae6a1f5 Parents

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-29 Thread Sven Meier
icket/tree/d7e0d884 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d7e0d884 Branch: refs/heads/wicket-1.5.x Commit: d7e0d8845dd509110e48ba965f0e11a3aae6a1f5 Parents: c6c45a5 Author: Sven Meier Authored: Thu Mar 29 18:43:07 2012 +0200 Committer: Sven Meier Committed: Thu Mar 29 18:43:

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-30 Thread Sven Meier
y session). I'm not sure if these ids get stored in memory after the render (I dont know wicket internals well enough to tell) or stored in the page store. If they do, its a big memory leak. At the very least its spews out huge amounts of data in the debug logging. Cheers, Jesse O

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-30 Thread Sven Meier
7e0d884 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d7e0d884 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d7e0d884 Branch: refs/heads/wicket-1.5.x Commit: d7e0d8845dd509110e48ba965f0e11a3aae6a1f5 Parents: c6c45a5 Author: Sven Meier Authored: Thu Mar 29 18:43:07 2012 +0200 Com

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-30 Thread Sven Meier
Javascript ids are session unique anyway - just prefixed with the component id in non-deployment config. Sven On 03/30/2012 04:11 PM, Juergen Donnerstag wrote: On Fri, Mar 30, 2012 at 3:57 PM, Sven Meier wrote: Hi Juergen and Jesse, I've debugged WicketLinkTagHandler and everything w

Re: git commit: WICKET-4484 do not change tag id when resolving component

2012-03-30 Thread Sven Meier
pId in the output. Perhaps Juergen misunderstood me too? IMHO it would be great to have an example which demonstrates the problem Juergen has pointed to. I still don't get why there's a problem. Sven On 03/30/2012 04:46 PM, Martin Grigorov wrote: On Fri, Mar 30, 2012 at 4:33 P

Re: wicket 6.0 and automatic model detachment

2012-04-06 Thread Sven Meier
The listener won't be set in IFrameworkSettings by default, right? IMHO it's better located in extensions then. Sven On 04/07/2012 01:37 AM, James Carman wrote: Add the listener to core and if folks want to use it they can. You could have a component instantiation listener add the detach liste

Re: wicket 6.0 and automatic model detachment

2012-04-08 Thread Sven Meier
doubt many people will go out looking for something like this since most of them wont even know that its possible to do this. -igor On Fri, Apr 6, 2012 at 11:28 PM, Sven Meier wrote: The listener won't be set in IFrameworkSettings by default, right? IMHO it's better located in extensi

Re: Number formats in numeric converters

2012-04-20 Thread Sven Meier
Hi Martin, IMHO we shouldn't touch grouping in display of numbers (e.g. in labels), so -1 for changing it globally. BTW if somebody registered his own converter for numbers, he would again have to take care of grouping by himself. Instead we could 3) Skip converters and do formatting of val

Re: Number formats in numeric converters

2012-04-20 Thread Sven Meier
mean overriding getModelValue() and convertInput() and do formatting and parsing independent of converters. Sven On 04/20/2012 05:41 PM, Martin Grigorov wrote: Hi Sven, On Fri, Apr 20, 2012 at 6:32 PM, Sven Meier wrote: Hi Martin, IMHO we shouldn't touch grouping in display of numbers

Re: Number formats in numeric converters

2012-04-20 Thread Sven Meier
BTW I didn't say I prefer the solution without converters ;). I just wanted to offer alternatives to the global grouping change. Sven On 04/20/2012 06:32 PM, Sven Meier wrote: ((AbstractDecimalConverter)converter).getNumberFormat(getLocale()).setGroupingUsed(false); will set the fl

Re: Number formats in numeric converters

2012-04-22 Thread Sven Meier
Hi Christoph, >It wouldn't be a no-op if you stored the modified NumberFormat in the cache: this would change the grouping for all numberformats cloned in succession by the converter, wouldn't it? This is the same as changing the grouping globally. Sven On 04/22/2012 05:58 PM, Christoph Le

Re: Carl-Eric Menzel is now part of the Wicket team!

2012-04-26 Thread Sven Meier
Welcome Carl-Eric :) On 04/26/2012 11:55 AM, Martijn Dashorst wrote: Carl-Eric Menzel has been invited to join the Wicket team. Please welcome Carl-Eric! Martijn Dashorst

Re: [Vote] Release Apache Wicket 1.5.6 (build 2)

2012-04-30 Thread Sven Meier
+1 for 1.5.6 Sven On 04/30/2012 10:05 PM, Martin Grigorov wrote: Can someone of the Wicket devs verify the problem and cancel the release? Or +1 it otherwise ... P.S. I'm on vacation without IDEs around :-) On Sun, Apr 29, 2012 at 1:34 PM, Sebastien wrote: https://issues.apache.org/jira/bro

Re: wicket-4533 please review

2012-05-05 Thread Sven Meier
We're probably talking about WICKET-453*2*, IMHO it can still be improved for the next 6.0 beta. Sven On 05/05/2012 07:00 PM, Emond Papegaaij wrote: The ticket you mentioned is already fixed in 6.0. I fixed it right after filing it. Best regards Emond Op 5 mei 2012 14:16 schreef "Peter Ertl"

Re: Wicket 1.5.7 release this week ?

2012-05-29 Thread Sven Meier
+1 for 1.5.7 Sven On 05/28/2012 11:59 AM, Martin Grigorov wrote: Hi, We've found a quite serious problem in DiskDataStore internals - https://issues.apache.org/jira/browse/WICKET-4572. In case the disk space per http session is exhausted it may lead to Wicket returning the wrong page instance

<    1   2   3   4   5   6   7   8   >