Hi Kernel team,
Please review and merge the changes please.
https://wso2.org/jira/browse/CARBON-14861
thanks
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
Hi Pradeep,
you have introduced a new API in your patch , please remove that as it is
incorrect to do API changes with a patch. But when you provide a pull
request to 4.3.0 you can do any API changes.
Thanks,
Shameera.
On Thu, Jul 10, 2014 at 3:47 PM, Pradeep Fernando prad...@wso2.com wrote:
Hi,
will attach the patch again. However, encountered some registry test
failures in patch0009/registry.core without my patch.
thanks
On Thu, Jul 10, 2014 at 4:46 PM, Shameera Rathnayaka shame...@wso2.com
wrote:
Hi Pradeep,
you have introduced a new API in your patch , please remove that
Hi Shameera,
Attached the new patch with modifications. Ran tests. No new test failures,
AFAIU.
thanks,.
On Thu, Jul 10, 2014 at 5:12 PM, Pradeep Fernando prad...@wso2.com wrote:
Hi,
will attach the patch again. However, encountered some registry test
failures in patch0009/registry.core
Hi Pradeep,
Which jdk version you are using to buile the kernel? if it is 1.7 then you
probably hit with registry test failures.
I will apply the new patch.
Thanks,
Shameera
On Thu, Jul 10, 2014 at 5:22 PM, Pradeep Fernando prad...@wso2.com wrote:
Hi Shameera,
Attached the new patch with
Hi Pradeep,
Please send the pull request to https://github.com/wso2-dev/carbon4-kernel
, this is the carbon 4 kernel development branch.
Regards,
Shameera.
On Thu, Jul 10, 2014 at 5:24 PM, Shameera Rathnayaka shame...@wso2.com
wrote:
Hi Pradeep,
Which jdk version you are using to buile the
I did sent a pull request. What is the commit version of the patch
On Thu, Jul 10, 2014 at 7:17 PM, Shameera Rathnayaka shame...@wso2.com
wrote:
Hi Pradeep,
Please send the pull request to https://github.com/wso2-dev/carbon4-kernel
, this is the carbon 4 kernel development branch.
yes you have, but for master repository[1] which we don't apply patches. We
will merge dev repo[2] to master once dev branch come to a stable state.
Therefore you need to provide pull request to wso2-dev repo :)
[1] https://github.com/wso2/carbon4-kernel
[2]
