[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4545: CI broken

2023-01-18 Thread GitBox
jongyoul commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1080757497 ## zeppelin-zengine/pom.xml: ## @@ -304,10 +304,6 @@ - Review Comment: Yeah, this kind of step is too hard to debug by IDE, but, unfortu

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken

2023-01-18 Thread GitBox
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073665797 ## zeppelin-zengine/pom.xml: ## @@ -304,10 +304,6 @@ - Review Comment: It took me a long time to figure out that this execution breaks the

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken

2023-01-18 Thread GitBox
Reamer commented on code in PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073656877 ## python/src/test/java/org/apache/zeppelin/python/IPythonInterpreterTest.java: ## @@ -434,9 +434,6 @@ public void run() { InterpreterResult result = interpr

[GitHub] [zeppelin] Reamer commented on pull request #4545: CI broken

2023-01-18 Thread GitBox
Reamer commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387192701 > I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`, and

[GitHub] [zeppelin] jongyoul commented on pull request #4545: CI broken

2023-01-18 Thread GitBox
jongyoul commented on PR #4545: URL: https://github.com/apache/zeppelin/pull/4545#issuecomment-1387164198 I think it's good but I just have one question. Is there any critical reason that we changed `test` to `verify`? It looks similar and `verify` is running after `test` and `package`, and