Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
@xixikaikai sure, we are using keycloak in production
---
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2552
waiting is over but `pac4j` introduced a few regressions that needs to be
fixed to have the documented process working...
I'm looking into, slowly, but if you wanna take over feel free to go
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
actually a more detailed description is available here:
https://github.com/apache/zeppelin/pull/2552/files
---
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
I think the link is broken.
here: https://github.com/apache/zeppelin/pull/2373/files
---
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
ping, probably this is good to merge
---
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2552
Hi thanks for getting back into this, unfortunately even if
https://github.com/pac4j/pac4j/pull/975 got merged we do not have yet a release
of pac4j out in public repositories that will enable
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
@felixcheung I think that docs improvements have sense in this case only on
top of #2552 , could post-pone them?
---
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
> should we consider returning/displaying more than just the principal name?
now the name field is configurable via `shiro.ini`, basically you can
return different values in that fi
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2552
sorry @felixcheung misunderstood your comment, should be fixed now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2552
yes, the original code I think is the result of a few iterations.
This is the blocking pop-up:
https://github.com/apache/zeppelin/blob/6bd6c70881e8515a5b0679e5a8d6c235cfb1adf6/zeppelin
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2552
WIP: [ZEPPELIN-2881] Fix OIDC logout
### What is this PR for?
Fixing logout mechanism for OIDC.
Initial documentation for configuring OIDC in Zeppelin.
### What type of PR
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2551
this is possible since this PR from @volumeint to bujiio:
https://github.com/bujiio/buji-pac4j/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
Hi @SarunasG , actually I'm facing the very same situation here ...
I haven't had enough time to dig deeper, but it looks like that 'logout`
action is not triggering the REST call to do
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
Hi @SarunasG , yes I'm using Zeppelin with Keycloak from what I can see the
only missing bit in your configuration is:
```
/** = oidcSecurityFilter
```
---
If your project is set up
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
@1ambda
travis link:
https://travis-ci.org/nokia/zeppelin/builds/256876805
I think that tests are not really "stable", I mean, they are time and
context dependent.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
I agree that this has got a really low priority, but could I kindly ask for
review to keep this into master since it does not break anything and just add
some added flexibility to the build
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
added a small section under the mentioned `Md` file @1ambda
please let me know if anything else is needed
---
If your project is set up for it, you can reply to this email and have your
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
@1ambda haven't found any specific section in docs mentioning settings in
maven profiles... could you point me to a section that could be improved with
this additions?
---
If your project
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
should I do anything else to get this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
B,T,W, it is incredibly annoying for contributors to have to "baby-sit"
travis to get a green CI here :-S
---
If your project is set up for it, you can reply to this email and have
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
rebased on top of master, removed a typo and removed `downloadRoot`
parameter that turns out to be `deprecated`
---
If your project is set up for it, you can reply to this email and have your
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
yes, :-) done! @felixcheung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
yes of course @felixcheung , basically I'm exposing through maven
properties the ability for users to customize where to download from certain
packets that are normally downloaded from very
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
I think this issue is addressed
https://github.com/apache/zeppelin/pull/2463 I'm not sure if having a switch
for prod and dev is good BTW
---
If your project is set up for it, you can
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
ok, now also CI is happy :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2373
[ZEPPELIN-2598] Securing Zeppelin with OpenID Connect
### What is this PR for?
Integrating Open ID connect login into Zeppelin leveraging Shiro(already
present) and Pac4J( that needs
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
@Leemoonsoo @felixcheung @1ambda
I have had to rebase on master again after a week of no updates.
Please tell me what to do to on this to get it merged or why this is not
going
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2373
[ZEPPELIN-2598] Securing Zeppelin with OpenID Connect
### What is this PR for?
Integrating Open ID connect login into Zeppelin leveraging Shiro(already
present) and Pac4J( that needs
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
@necosta checked again but it works for me and on CI ... I have had this
problem once try to fetch and pull and see if this solves
---
If your project is set up for it, you can reply
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
I sincerely think that this implementation is enough to unlock the usage of
pac4j, buji (due to the rest of updates sent there).
I think that the name parsing can be refactored later
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2397
`try-with-resources` is used only for `InputStream` here.
there is nothing on outputstream.
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2397
to be 100% sure to close properly the stream the `close` method should be
called within a `finally` statement of a `try`
---
If your project is set up for it, you can reply to this email
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
do this minimal and cleaned up version needs anything else to be worked out
in order to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2383
do this need anything else to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
@1ambda To be honest I'm not such an expert and I'm just integrating from a
technical POV a solution that other experts in team found.
I will love to have such documentation too, but I
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2383
Since R is under spark we need to enable it differently AFAICS
now it is enabled at least in one test (where all other interpreters are
compiled).
Travis is happy I close and re-open
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2383
[ZEPPELIN-2606] Fix compilation with R interpreter enabled
### What is this PR for?
`mvn -DskipTests clean package -Pr` fails
### What type of PR is it?
Bug Fix
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2383
good point, so I added it to the list, I think it fits the scope of this PR
(let see what travis says)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2383
`INTERPRETERS` is surprisingly an exclusion list @zjffdu
https://github.com/apache/zeppelin/blob/master/.travis.yml#L40
---
If your project is set up for it, you can reply to this email
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2373
@1ambda potentially yes
@khalidhuseynov thanks for pointing out a public server I can test! I will
go through later on
B.t.w. I realized that the MVP to get this working is just
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2383
yes a full compilation with all interpreters available should be included
in CI build IMO
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2383
[ZEPPELIN-2606] Fix compilation with R interpreter enabled
### What is this PR for?
`mvn -DskipTests clean package -Pr` fails
### What type of PR is it?
Bug Fix
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2373
[ZEPPELIN-2598] Securing Zeppelin with OpenID Connect
### What is this PR for?
Integrating Open ID connect login into Zeppelin leveraging Shiro(already
present) and Pac4J( that needs
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2349
Since npm registry name can be changed arbitrarily it's worth to add a
configuration key for the hard-coded `"/npm/-/"`
---
If your project is set up for it, you can reply to
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
I reverted back modifications to concurrency management since it looks like
they result in Ui response instability, I'm not sure why this happens, I
believe that we can conclude with a clean PR
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
@Leemoonsoo sounds good :-) I'll do that tomorrow!
and I will follow up with this PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
@Leemoonsoo I can reproduce the error locally running on Chrome (i.e. the
current encoding of the test doesn't work for me out of the box with chrome),
should I separate these modifications
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
am I supposed to do anything else?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
I have had to fix some escaping problems to make travis happy, and it also
required some retries
anyhow travis is now happy:
https://travis-ci.org/nokia/zeppelin/builds/230331180
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2322
Looking at the code it looks quite harmful also the pattern used
[here](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2322
[ZEPPELIN-2502] RemoteInterpreterServer hang forever during shutdown
### What is this PR for?
There is the chance to have a RemoteServerInterpreter hang forever during
shutdown
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2183
Sure. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2183
[ZEPPELIN-2309] Backport maven and npm repo config to 0.7
### What is this PR for?
Backport configuration settings for maven central and npm repository to 0.7.
### What type of PR
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Please go on! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Done, let see the result!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it
happens that Npm Registry isn't
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
no luck again :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
@Leemoonsoo
rebased.
Unfortunately again failures on CI, this is on Jenkins side I guess
https://builds.apache.org/job/zeppelin-pull-request/580/console
this is spurious since travis
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it
happens that Npm Registry isn't
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
probably you have a problem on Jenkins, Travis is currently building
without errors:
https://travis-ci.org/nokia/zeppelin
still this PR is marked as Failed...
---
If your project
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it
happens that Npm Registry isn't
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
@AhyoungRyu rebased on top of current *master*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Thanks a lot! appreciated this welcoming environment! (I was aiming to
become committer number 200 also )
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
Thanks for the feedback @1ambda , travis should be configured properly now,
I will try to dig into but it looks tests spuriously fail, anyhow any help on
getting the right direction is highly
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2150
failures looks unrelated ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
updated also commit message here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2150
[ZEPPELIN-2278] Env variable to configure Npm registry
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it
happens that Npm Registry isn't
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Yep, opened Jira issue and linked accordingly on PR title.
https://issues.apache.org/jira/browse/ZEPPELIN-2277
@Leemoonsoo thanks!
---
If your project is set up for it, you can
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
I believe this is ready to merge.
Please let me know if I need to do anything more.
cc. @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
added even the row in the configuration table, thanks a lot for your
patience!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
@Leemoonsoo thanks a lot for the hints, this simplify a lot and even CI is
happy.
I already squashed commits since now this PR looks in a good shape, but
feel free to ask/argue about
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
@Leemoonsoo thanks a lot for your comments, I hope to have targeted all of
them, not sure how it works here, I will squash commits at the end of the
process if you agree.
b.t.w
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
ok, I don't know exactly how to proceed on debugging this :-S, the problem
is with dependency loading in python interpreter...
---
If your project is set up for it, you can reply to this email
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2093
Not sure how to debug the CI failure,
https://travis-ci.org/andreaTP/zeppelin/jobs/207318026
help needed please :-) sorry I'm new in this codebase.
---
If your project is set up for it, you
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2093
Env variable to configure maven central repo
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it
happens that Maven Central isn't directly
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2091
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2091
I reopen this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2091
Env variable to configure maven central repo
### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it
happens that Maven Central isn't directly
99 matches
Mail list logo
