Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1362
@vensant thank you for contributing improvement!
With GUI changes, in my experience, adding simple screenshots to the PR
itself (drag'n'drop to description) before\after usually helps
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1351
Looks great to me, thank you for taking care @Peilin-Yang !
Merging if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1360
LGTM.
> Is there breaking changes for older versions? Yes
Do we have a change-log or something where we can keep track of breaking
changes to highlight them in the rele
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1357
@vipul1409 thank you, it sounds interesting! Could you please let know, if
it is ready for review?
@Leemoonsoo @corneadoug do you guys see any downsides\side-effects for such
change
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1363
Go it! It would be really nice to have such defaults for numbers, that make
them sort numerically.
As for letting user change it - it sounds good, am it looks like the main
use case
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1347
LGTM. Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1363
So cool - this should solve sorting issue for numeric columns! Thank you
@Peilin-Yang!
One question - do you guys think it could be possible to detect numeric
columns automatically using
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Looks great, @onkarshedge! I posted a few comments above.
\cc @khalidhuseynov for extra back-end code review and @corneadoug for
front-end one
---
If your project is set up for it, you can
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1283
@beriaanirudh thank you for prompt fixes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1242
Thank you @cloverhearts !
Looks good to me, merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1352
Looks great to me! Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1354
Overall looks great to me, thank you @corneadoug for taking care! Few minor
comments above.
\cc @AhyoungRyu for review
---
If your project is set up for it, you can reply to this email and have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1352
Got it, makes perfect sense!
Do you think we should add a comment in there, explaining that
compatibility is the reason for such decoding? I feel like this might help
future contributors
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
@mfelgamal Thank you! Please let me look into CI and get back to you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1242
Thank you for your patience!
Looks good to me, except minor style issue above?
As soon as it is addressed - I think we should be good to merge it to
master.
---
If your project is set
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1343
There actually are tests, but we do not have CI profiles with both Python2
and Python3 yet. I think, I will take a look into creating one soon.
Though @felixcheung is right
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge thank you, that is good to know :)
Could you also please update PR description according to your plans? I.e in
case you decide to pursue suggested architecture - what would
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge so you say it's not published on Maven Central?
According to ipfs/java-ipfs-api#1 there is an option fetch it from
`https://jitpack.io`. Can you please add new repository
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1343
Thank you @agoodm for taking care, looks great to me.
I think it sets an excellent example of Python version compatibility.
Will merge to master if there is no further discussion
Github user bzz closed the pull request at:
https://github.com/apache/zeppelin/pull/1344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1333
@zjffdu thank you for fixing it!
After the review we better merge this to both, _master_ and _branch-0.6_
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1336
Looks great to me.
@corneadoug please, merge it to both _master_ and _branch-0.6_ as fix
version is 0.6.2 for it.
---
If your project is set up for it, you can reply to this email and have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1342
Great fix @cloverhearts and very nice PR description ð
Let's merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
> If you are expecting to code the entire DHT from scratch, it's too tough
for me
That is not an expectation here of course.
Let's think about alternatives - another
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1344
\cc @anthonycorbacho @Leemoonsoo @jongyoul for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1344
ZEPPELIN-1164: backport new Shiro realm to 0.6 branch
Just a backport of #1173
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
> It seems that your builder enforces the usage of Scala 2.11
@mfelgamal you are right, `.travis.yml` contains Scala 2.11 as well as
scala 2.10 profiles.
In this case, could you ple
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@AhyoungRyu great initiative, but while making this changes, you have to
think also about CI use case of zeppelin build as well.
I.e so far `/.spark-dist/` is under cache on TravisCI which
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1343
Looks great to me, thank you for taking care @agoodm !
Merging to master if there is no further discussion.
[CI
failure](https://s3.amazonaws.com/archive.travis-ci.org/jobs
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1242
Great work @cloverhearts ! Few minor comments above.
Also, looks like CI is failing, and if you could post here the reason -
other people could help determining if that is relevant to your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1194
I do not think that node\npm version update are relevant - I was under
impression that it's all about dependency version update.
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Before proceed with review - I have noticed that CI is failing.
@mfelgamal could you please take a look and make sure that there are no
Beam-related failures? Thanks!
So far
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Thank you for addressing the feedback promptly! Please let me take another
pass on it and get back to you here.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
Thank you for your explanation, what's your progress on refactoring current
impelemtation?
Let me try to re-visit points 1-5. Also, let's make sure that behavior of
BittorentRepo
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1334
Thank you for contributing @mfelgamal ! Apache Beam interpreter is a
valuable contribution many people are looking for.
There are few things that need to be done before we can merge it though
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
Thank you for your patience, @echarles
AFAIK CDDL 1.1 that jersey2 is distributed under belongs to ASF [Category B
license list](http://www.apache.org/legal/resolved.html#category-b) so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1301
@jongyoul do you want to take of docs update that @zjffdu mention in this
PR as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1311
CI is green now, so merging it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Thank you for your patience @mwkang !
Sorry for the late notice, but could you please take a look and make sure
that code conforms the project styleguilde?
Will merge to master asap
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1330
Thank you for fixing it @mwkang
CI failure looks somehow relevant, you can not reproduce it locally?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1257
CI fails on web-app \w networking issue :\ which is not relevant here
```
Could not transfer artifact org.codehaus.plexus:plexus-io:pom:2.1.3 from/to
central (https
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
CI is still red :\ Could you please post here the reason?
Other than that, looks good to me, merging to master if there is no further
discussion
---
If your project is set up for it, you
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1257
Thank you @astroshim !
Merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1254
Great! Merging to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1254
@khalidhuseynov CI is green and changes looks great to me, modulo one
naming case noted above.
Please let me know if you want to address that one as well. After that I
will be happy to mered
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1254
Thank you for friendly ping. Will review and get back to you ASAP
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1331
Looks great to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1329
Looks great to me, thank you @agoodm!
Will merge to master later today, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1329
Thank you for prompt and thoughtful comparison @agoodm !
> the choice of default format will matter in terms of backwards
compatibility as the change should be seamless for us
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1329
@agoodm thank you for improving matplotlib integration!
Please correct me, but right now PR does 2 things:
- add PNG support, as well as SVG
- switches default to PNG
I see
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1316
Both, version and terms of service (to avoid liability) sounds as a good
ideas to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1277
Shall we close this guy then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
@astroshim great! Small suggestion above. And what is with CI here? May be
it's worth to `git rebase master` and force push?
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1321
Looks great to me @minahlee !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Thanks! In my experience, if in case of CI failure PR author posts the
failure result from logs - that speeds us review a lot!
CI fails now on Spark 1.6 Scala 2.10 and Scala 2.11 profiles
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1254
@khalidhuseynov `git rebase master` to re-trigger CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1318
Docs looks great to me, thank you @astroshim !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1304
@corneadoug thank you for explaining!
So we are talking about WS API to fetch full notebook state from the
history by it's revision? Wich on client-side looks like
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
This looks like an issue fixed in master 10h ago:
```
[31m- should provide onclick method *** FAILED ***[0m
[31m The code passed to eventually never returned normally. Attempted 1
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1320
@minahlee I think we also need to set appropriate "fix for" versions in
JIRA before merging #1278 otherwise it will be very hard for you, as release
manager to figure out changelog and at
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1301
Thank you for explanation! Makes sense.
Looks great to me.
May be it's worth to `git rebase master` as CI seems to be recently fixed.
---
If your project is set up for it, you can
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1257
@astroshim your changes look awesome to me!
There is one more improvement on Java side noted above, other than that -
looks good to merge.
---
If your project is set up for it, you can
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1193
Looks great to me, modulo the timeout logging issue noted about.
@astroshim plz ping when it's addressed and I'll be happy to merge it.
---
If your project is set up for it, you can reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Got it. Let's may be change PR title to WIP or even may be close it for now
but keep the branch and create a dedicated JIRA issue and link this work there?
It's a bigger effort that we
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1311
Thank you for prompt review!
Merging _to master_ if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1265
@jongyoul this looks very interesting! Could you plz help me to understand
- does this changes mean for Zeepelin to run a new separate interpreter process
for every user and schedulle only his jobs
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Ok, good to know, let me look into that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1218
@cloverhearts ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1148
@minahlee do you think we should close it for now or rename it to WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1105
@khalidhuseynov 1 week ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1304
To avoid the confusion, could you guys quickly bring me up to speed with,
what `API needs to be fixed to send Revision ID` means in this context?
As far as I understood, we are talking
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1303
@agura thank you for taking care!
CI fails on 2 profiles for Spark 1.5 and 1.6 with
```
#1.6
[INFO] Zeppelin: Display system apis .. FAILURE [
15.213 s
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1266
> Yeah right, I should've done that. It was my bad. Let me re-trigger CI
then :)
No worries! A lot of people do not do this and ask no excuses. So let's
just show them what excellence me
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1307
Looks great to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1240
Looks great to me!
Thank you @prasadwagle for taking care.
Merging to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1308
CI is green, so merging as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1308
Looks good to me.
@khalidhuseynov fix for version is not set in JIRA (neither it is assigned
yet) - merging only to master, in case there is no further discussion
---
If your project is set
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@mwkang thank you for prompt addressing reviews!
If you re-trigger CI more (close this PR) - does the same issue
persists every time?
---
If your project is set up for it, you can reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
Do you want to do that on the client-side, right in the browser?
I see what you mean - our existing impor function indeed fetches from URL
and parse JSON right in the browser, but I do
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1266
@AhyoungRyu it's better to post CI failure to help getting feedback faster
AND search existing JIRA issues, to see if that is something know or being
addressed elsewhere.
Here is an example
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/932
@echarles thank you for taking care!
Please give me some time to try it out and make another pass on it and I'll
get back to you here.
---
If your project is set up for it, you can reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1293
`LOG.debug` sounds like a great idea to me to avoid filling up the logs in
default configuration.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1282
All build failures are in zeppelin-web, while NPM dependency installation
```
INFO] bower@1.7.2 node_modules/bower
[INFO] ââââââ¬Ã¢â⬠semver-utils@1.1.1
[ERROR] npm
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1276
Yes, I think it's better to close this and resolve the JIRA issue. And then
create a new one for Helium App and post a link it here. This work will still
be accessible so people who are interested
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1276
@rockiey I have just updated the comment above.
What I would suggest is - please take a look at [Helium
framework](https://github.com/apache/zeppelin/tree/master/zeppelin-interpreter/src/main
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1276
@rockiey thank you for contributing!
Highcharts is a great library, but I belive it will be hard to include it
as a dependency to ASF project.
If highchart gets included to project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1275
Thank you @minahlee for prompt review!
CI fails on spark 1.6 profile, same as master, and #1263 handled under
[ZEPPELIN-1286](https://issues.apache.org/jira/browse/ZEPPELIN-1286
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1260
Let's merge if there is no further discussion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1231
@onkarshedge thank you for drawing very nice diagram.
Let me be very clear - you did a great job and quite possible that it is
me, as a mentor who under communicate the expectations about
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1218
Shall we close this one now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
Sounds good! Let's rebase on master and make CI happy again first? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/928
@rawkintrevo you did titanic job, struggling with CI here.. but now, after
Spark 2.0 and Scala 2.11 support got merged CI fails even on *master*
Would it make sense to take a break until 0.6.1
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
ping @onkarshedge
Could you please follow
https://github.com/apache/zeppelin/pull/989#issuecomment-230972882 and update
this PR
---
If your project is set up for it, you can reply
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1275
Ready to be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1273
Tried locally and renaming notebook works now as expected.
Looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1270
Looks great to me, thank you @praagarw
Merging to only to master, if there is no further discussion
Or do you think we should also apply this to upcoming 0.6.1 as well?
---
If your
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1258
Looks great to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1263
CI failure
```
Results :
Failed tests:
ZeppelinSparkClusterTest.sparkRTest:116 expected:<[[1] 3]> but
was:<[Error in getSparkSession(): SparkSession not in
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1267
Sounds great! Apparently CI failure has been addressed in #1259 as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
201 - 300 of 535 matches
Mail list logo
