[GitHub] zeppelin issue #1911: [ZEPPELIN-1972] Preserve context classloader

2017-02-09 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1911 @DrIgor I agree with you. It's very easily broken. But on the other hands, I will make a new PR for changing `ClassloaderInterpreter` because another interpreter will fails with same issue

[GitHub] zeppelin issue #1992: ZEPPELIN-2083: default interpreter list should honour ...

2017-02-09 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1992 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1999: [MINOR][ZEPPELIN-2090] Remove "zeppelin.interpreters" ...

2017-02-09 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1999 Looks nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2001: ZEPPELIN-2057 Extract InterpreterSetting functi...

2017-02-09 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/2001 ZEPPELIN-2057 Extract InterpreterSetting functions from InterpreterFactory ### What is this PR for? Reducing size of InterpreterFactory and divide some functions from InterpreterFactory

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

2017-02-07 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1976 @cloverhearts Can you check it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Created] (ZEPPELIN-2057) Extract InterpreterSetting functions from InterpreterFactory

2017-02-04 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-2057: -- Summary: Extract InterpreterSetting functions from InterpreterFactory Key: ZEPPELIN-2057 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2057 Project

[jira] [Created] (ZEPPELIN-2056) Restructuring InterpreterFactory

2017-02-04 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-2056: -- Summary: Restructuring InterpreterFactory Key: ZEPPELIN-2056 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2056 Project: Zeppelin Issue Type

[GitHub] zeppelin issue #1970: ZEPPELIN-2045. Pass interpreter properties with "spark...

2017-02-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1970 I didn't find a history for it but your code snippet tells us no spark properties doesn't affect anymore in current spark. LGTM --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1970: ZEPPELIN-2045. Pass interpreter properties with "spark...

2017-02-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1970 That's intended behavior because Zeppelin wants to pass some other properties not starting "spark.". I didn't remembers exactly, but some properties should be passed with different pre

[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl

2017-02-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1946 @DrIgor The last failures looks related to this PR. Can you check it? - https://api.travis-ci.org/jobs/197657609/log.txt?deansi=true --- If your project is set up for it, you can reply

Re: [VOTE] Release Apache Zeppelin 0.7.0 (RC4)

2017-02-04 Thread Jongyoul Lee
t; >>> > > > > >>> > > The release archives (tgz), signature, and checksums are here > > >>> > > > > https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.7.0-rc4/ > > >>> > > > > >>> > > The release candidate consists of the following source > distribution > > >>> > > archive > > >>> > > zeppelin-0.7.0.tgz > > >>> > > > > >>> > > In addition, the following supplementary binary distributions are > > >>> > provided > > >>> > > for user convenience at the same location > > >>> > > zeppelin-0.7.0-bin-all.tgz > > >>> > > zeppelin-0.7.0-bin-netinst.tgz > > >>> > > > > >>> > > The maven artifacts are here > > >>> > > > > >>> > https://repository.apache.org/content/repositories/orgapache > > >>> zeppelin-1027 > > >>> > > > > >>> > > You can find the KEYS file here: > > >>> > > https://dist.apache.org/repos/dist/release/zeppelin/KEYS > > >>> > > > > >>> > > Release notes available at > > >>> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > >>> > > version=12336544=12316221 > > >>> > > > > >>> > > Vote will be open for next 72 hours (close at 01:00 5/Feb PST). > > >>> > > > > >>> > > [ ] +1 approve > > >>> > > [ ] 0 no opinion > > >>> > > [ ] -1 disapprove (and reason why) > > >>> > > > > >>> > > > >>> > > > >>> > > > >>> > > >>> -- > > >>> Taejun Kim > > >>> > > >>> Data Mining Lab. > > >>> School of Electrical and Computer Engineering > > >>> University of Seoul > > >>> > > >>> > > >>> > > >> > > > > > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net

[GitHub] zeppelin issue #1968: [ZEPPELIN-1551] Remove the "default" text against inte...

2017-02-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1968 LGTM. merging if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1929: [ZEPPELIN-1997] Added derbylog in .gitignore

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1929 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1961: [ZEPPELIN-1934] maven-assembly-plugin fails make-assem...

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1961 Thanks. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1929: [ZEPPELIN-1997] Added derbylog in .gitignore

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1929 Is there any update? :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1911: [ZEPPELIN-1972] Preserve context classloader

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1911 Is there any update on it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1945: [ZEPPELIN-2003] Remove PostgresqlInterpreter

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1945 @AhyoungRyu Please check the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1961: [ZEPPELIN-1934] maven-assembly-plugin fails make-assem...

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1961 Cool. Can you tell me how to test it by myself? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1946 I merged #1937. Can you rebase it onto master and make CI green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Created] (ZEPPELIN-2041) Introduce a new abstraction layer for managing and launching interpreters

2017-02-01 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-2041: -- Summary: Introduce a new abstraction layer for managing and launching interpreters Key: ZEPPELIN-2041 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2041

[jira] [Created] (ZEPPELIN-2040) ClusterManager to support launching interpreter in a cluster

2017-02-01 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-2040: -- Summary: ClusterManager to support launching interpreter in a cluster Key: ZEPPELIN-2040 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2040 Project

[GitHub] zeppelin issue #1937: Search for interpreter-settings in several jars in fol...

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1937 I'll merge this PR and will make a new PR to handle with Jeff's worries which are reasonable and should be maintained. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1944: [HOTFIX][MINOR] Change the scope of httpclient to runt...

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1944 If you remove that dependency, I think you cannot compile zeppelin-server test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1957: Branch 0.6 Groovy Interpreter

2017-02-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1957 If you contribute code based on master, we will review and merge it into master and branch-0.7 if necessary. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #1945: [ZEPPELIN-2003] Remove PostgresqlInterpreter

2017-01-31 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1945 I made a link. @AhyoungRyu Can you verify the doc? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.getAllRes...

2017-01-29 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1958 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1954: [ZEPPELIN-525] Test failing in zeppelin-interpreter

2017-01-29 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1954 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDri...

2017-01-29 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1959 Good plan :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1957: Branch 0.6 Groovy Interpreter

2017-01-29 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1957 Thanks for contributing new Groovy interpreter but we didn't manage the branch-0.6 anymore. Can you rebase your contribution onto current master? --- If your project is set up for it, you can

[GitHub] zeppelin issue #1947: [HOTFIX][ZEPPELIN-2013] Exceeded size of logs makes CI...

2017-01-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1947 Will merge it onto master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1945: [ZEPPELIN-2003] Remove PostgresqlInterpreter

2017-01-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1945 @felixcheung Sounds like a good idea! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1944: [HOTFIX][MINOR] Change the scope of httpclient to runt...

2017-01-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1944 My command only includes `/Users/jl/.m2/repository/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar` which is different from `org.apache.httpclient`. Can you show me your

[GitHub] zeppelin pull request #1947: [HOTFIX][ZEPPELIN-2013] Exceeded size of logs m...

2017-01-25 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1947 [HOTFIX][ZEPPELIN-2013] Exceeded size of logs makes CI failed ### What is this PR for? avoiding failure of CI due to exceeded limit of log size. https://s3.amazonaws.com/archive.travis

[jira] [Created] (ZEPPELIN-2013) Exceeded logs fails CI

2017-01-25 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-2013: -- Summary: Exceeded logs fails CI Key: ZEPPELIN-2013 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2013 Project: Zeppelin Issue Type: Sub-task

[GitHub] zeppelin issue #1944: [HOTFIX][MINOR] Change the scope of httpclient to runt...

2017-01-25 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1944 Yes, Sure. But when IntelliJ runs ZeppelinServer in debug mode, actual command is what I mentioned before which doesn't include any httpclient libraries but include zeppelin-{zengine,interpreter

[GitHub] zeppelin issue #1911: [ZEPPELIN-1972] Preserve context classloader

2017-01-24 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1911 Got it. How about wrapping it like `new ClassloaderInterpreter(new IgniteInterpreter(props))`? It's the same logic that RemoteInterpreter want to work. You should change this line https

[GitHub] zeppelin issue #1937: Search for interpreter-settings in several jars in fol...

2017-01-24 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1937 @DrIgor I know, I just ask you for making R-related PR on top of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1945: [ZEPPELIN-2003] Remove PostgresqlInterpreter

2017-01-24 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1945 [ZEPPELIN-2003] Remove PostgresqlInterpreter ### What is this PR for? We don't have to maintain PostgresqlInterpreter because JDBCInterpreter covers all functions of PostgresqlInterpreter

[GitHub] zeppelin issue #1942: [ZEPPELIN-1982] When using the 'Select * ...' statemen...

2017-01-24 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1942 @zjffdu Can you also verify it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1944: [HOTFIX][MINOR] Change the scope of httpclient to runt...

2017-01-24 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1944 @Leemoonsoo Since initializing Helium, helium tried to load httpclient but it couldn't do and error occurs like this ``` Caused by: java.lang.NoClassDefFoundError: org/apache/http

[GitHub] zeppelin pull request #1944: [HOTFIX][MINOR] Change the scope of httpclient ...

2017-01-24 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1944 [HOTFIX][MINOR] Change the scope of httpclient to runtime from test ### What is this PR for? When IDE runs ZeppelinServer in debugging mode, it doesn't load httpclient because its scope

[GitHub] zeppelin issue #1914: [ZEPPELIN-1983] Feedback about success/failure when in...

2017-01-24 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1914 Will merge it into master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1937: Search for interpreter-settings in several jars in fol...

2017-01-24 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1937 @DrIgor Did you test this PR with `-Pr` profile? this PR looks good to me but we need to test it. I think you can test it by running Zeppelin with r profile. How about you? --- If your project

[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...

2017-01-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich Can you rebase it onto current master? Recently, we fixed some flaky tests including your case. It would make your CI green --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1911: [ZEPPELIN-1972] Preserve context classloader

2017-01-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1911 Concerning `ClassloaderInterpreter`, you can find it https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/ClassloaderInterpreter.java

[GitHub] zeppelin issue #1911: [ZEPPELIN-1972] Preserve context classloader

2017-01-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1911 It actually wrap and conserve classloader for interpreter. I think you just change this line https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin

Re: [VOTE] Release Apache Zeppelin 0.7.0 (RC3)

2017-01-23 Thread Jongyoul Lee
t/release/zeppelin/KEYS > > Release notes available at > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12336544=12316221 > > Vote will be open for next 72 hours (close at 22:00 26/Jan PST). > > [ ] +1 approve > [ ] 0 no opinion > [ ] -1 disapprove (and reason why) > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net

[GitHub] zeppelin issue #1864: [ZEPPELIN-1921] missing close in closeAndRemoveInterpr...

2017-01-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1864 Will merge it into master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: [DISCUSS] Remove PostgresqlInterpreter

2017-01-23 Thread Jongyoul Lee
I created https://issues.apache.org/jira/browse/ZEPPELIN-2003 On Mon, Jan 23, 2017 at 10:56 PM, Jongyoul Lee <jongy...@gmail.com> wrote: > Thanks for replying it. I'll make a PR for doing it. > > On Mon, Jan 23, 2017 at 4:09 PM, Prabhjyot Singh < > prabhjyotsi...@apach

[jira] [Created] (ZEPPELIN-2003) Remove PostgresqlInterpreter

2017-01-23 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-2003: -- Summary: Remove PostgresqlInterpreter Key: ZEPPELIN-2003 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2003 Project: Zeppelin Issue Type: Task

Re: [DISCUSS] Remove PostgresqlInterpreter

2017-01-23 Thread Jongyoul Lee
Thanks for replying it. I'll make a PR for doing it. On Mon, Jan 23, 2017 at 4:09 PM, Prabhjyot Singh <prabhjyotsi...@apache.org> wrote: > +1. > > Yes, agreed I too think its overhead, and all the features can be achieved > via JDBCInterpreter. > > On 23 January 201

[GitHub] zeppelin issue #1919: [ZEPPELIN-1986] Fix flaky test: Increase WelcomePageSu...

2017-01-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1919 @Leemoonsoo Actually, in this case, I also don't have any better idea than what you do :-) Just worried about becoming more rare flaky test. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1932: [ZEPPELIN-2000] Run paragraph on enter when select dyn...

2017-01-23 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1932 LGTM. @minahlee Can you merge it asap and make a new rc, too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: R interpreter

2017-01-23 Thread Jongyoul Lee
a bit weird but because zeppelin-zrinterpreter.jar doesn't have to include interpreter-setting.json inside it, it's ok to have all interpreter-setting.json in zeppelin-spark.jar. I'm willing to review your new PR though. :-) Regards, Jongyoul On Mon, Jan 23, 2017 at 7:26 PM, Igor Drozdov <igor_d

[DISCUSS] Remove PostgresqlInterpreter

2017-01-22 Thread Jongyoul Lee
. But, now, JDBCInterpreter include all functions of PostgresqlInterpreter and provide better functions. How do you guys think of it? If it's accepted, 0.8.0 won't have PostgresqlInterpreter anymore. Regards, Jongyoul Lee -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net

[GitHub] zeppelin issue #1919: [ZEPPELIN-1986] Fix flaky test: Increase WelcomePageSu...

2017-01-22 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1919 @Leemoonsoo I think to prolong timeout would be realistic solution but same error may occurs when travis is under resources starvation. Can we handle it? --- If your project is set up

[GitHub] zeppelin issue #1896: implementation test case for connect to exists interpr...

2017-01-20 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1896 I've missed it. I thought it was flaky tests. Got it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1916: [WIP] [ZEPPELIN-1986] WelcomePageSuite test fail

2017-01-20 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1916 I see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1918: Remove multple artifactId - hadoop-common

2017-01-20 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1918 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: R interpreter

2017-01-20 Thread Jongyoul Lee
eter is never loaded! > > > > Could anyone confirm that R interpreter does not work for now? Or it > > is my local misconfiguration? > > > > Thank you, > > Igor Drozdov > > > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net

[GitHub] zeppelin issue #1896: implementation test case for connect to exists interpr...

2017-01-20 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1896 LGTM. will merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1916: [WIP] [ZEPPELIN-1986] WelcomePageSuite test fail

2017-01-20 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1916 Is it ok to remove it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1914: [ZEPPELIN-1983] Feedback about success/failure when in...

2017-01-20 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1914 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: [Discuss] Move some interpreters out of zeppelin project

2017-01-20 Thread Jongyoul Lee
ke new release. > > Please help comment on these 4 questions and feel free to add any things > that I miss. > > > [1] https://lists.apache.org/thread.html/69f606409790d7ba11422e8c6df941 > a75c5dfae0aca63eccf2f840bf@%3Cusers.zeppelin.apache.org%3E > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net

[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...

2017-01-20 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1886 There is a flaky test in the result: ``` WelcomePageSuite ``` Never mind the result. that test is being fixed now. LGTM --- If your project is set up for it, you can

Re: Unstable travis CI recently

2017-01-20 Thread Jongyoul Lee
I can change some fields and types but cannot convert all tickets to sub-task. I'll change them manually. On Thu, Jan 19, 2017 at 4:20 PM, Jeff Zhang <zjf...@gmail.com> wrote: > Hi Jongyoul, > > Could you move all these tickets under this umbrella ticket ? > > You can do bu

Re: Unstable travis CI recently

2017-01-18 Thread Jongyoul Lee
Thanks Jeff, I made a new PR for handling this issue. https://issues.apache.org/jira/browse/ZEPPELIN-1981 On Thu, Jan 19, 2017 at 9:47 AM, Jianfeng (Jeff) Zhang < jzh...@hortonworks.com> wrote: > +1 > > Best Regard, > Jeff Zhang > > > > > > On 1/1

[jira] [Created] (ZEPPELIN-1981) Fix all flaky tests

2017-01-18 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-1981: -- Summary: Fix all flaky tests Key: ZEPPELIN-1981 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1981 Project: Zeppelin Issue Type: Task

[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...

2017-01-18 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1902 @1ambda Can you review this PR deeply? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Unstable travis CI recently

2017-01-18 Thread Jongyoul Lee
> > > Fixing the flaky test may take some time and may not easy for some > test > > > but > > > > I think it is worth to do that. And it is better for these people > who > > > > familiar with that particular test case to fix it. What do you guys > > > think ? > > > > Thanks > > > > > > > -- > > > Taejun Kim > > > > > > Data Mining Lab. > > > School of Electrical and Computer Engineering > > > University of Seoul > > > > > > -- > Taejun Kim > > Data Mining Lab. > School of Electrical and Computer Engineering > University of Seoul > > > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net

[GitHub] zeppelin issue #1864: [ZEPPELIN-1921] missing close in closeAndRemoveInterpr...

2017-01-18 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1864 @cloverhearts the failed test looks related this patch. Can you check it? ``` Failed tests: NoteInterpreterLoaderTest.testNoteInterpreterCloseForAll:192 null

[GitHub] zeppelin issue #1911: [ZEPPELIN-1972] Preserve context classloader

2017-01-18 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1911 LGMT. I have a question. Is there any related issue to SparkInterpreter? Can you take a look into it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin issue #1910: ZEPPELIN-1977. spark 2.1 uses a more recent commons-la...

2017-01-18 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1910 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1846: ZEPPELIN-1770. Restart only the client user's interpre...

2017-01-14 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1846 LGTM, merging if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1895: [ZEPPELIN-1961] Improve stability of sync when get fai...

2017-01-14 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1895 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1898: [ZEPPELIN-1963] set cron job executor to current user ...

2017-01-14 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1898 I'm not sure the code but idea looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1891: [ZEPPELIN-1941] Fix cron job with release resource opt...

2017-01-14 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1891 LGTM, I saw your description and it makes sense to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1842: [ZEPPELIN-1619] Load js package as a plugin visualizat...

2017-01-14 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1842 Good job! @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1890: [BUILD] Update release script

2017-01-13 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1890 Good!! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1890: [BUILD] Update release script

2017-01-12 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1890 @minahlee I think `-Pr` doesn't mean anything because users cannot run R interpreter since `-Psparkr` is enabled. How about removing `-Pr` in a script? --- If your project is set up for it, you

[GitHub] zeppelin issue #1891: [ZEPPELIN-1941] Fix cron job with release resource opt...

2017-01-12 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1891 Does this PR resolve flaky test that current master encounters? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin issue #1891: [ZEPPELIN-1941] Fix cron job with release resource opt...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1891 Thanks for the contribution. Can you make a test case for it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1889 Let's merge it now. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1840: [ZEPPELIN-1730, 1587] add spark impersonation through ...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1840 Merged it into master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1747: [MINOR] Remove unused import. Naming convention.

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1747 LGTM. Merging if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1883: Bump up version to 0.8.0-SNAPSHOT

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1883 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1882: [MINOR] Small Selenium test fixes

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1882 Merged it into master and branch-0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1884: [ZEPPELIN-1936] Fix user impersonation setting propaga...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1884 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1883: Bump up version to 0.8.0-SNAPSHOT

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1883 @minahlee You need to change `helium-dev`, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #725: Added CSV and Tableau export functionality

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/725 It looks unmanaged now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1886 @astroshim Could you please review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1846: ZEPPELIN-1770. Restart only the client user's interpre...

2017-01-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1846 Tests LGTM. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1871: ZEPPELIN-1862 Move packages related Helium into a new ...

2017-01-10 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1871 Will merge it if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1872: [ZEPPELIN-1922] Exclude jackson-core and jackson-datab...

2017-01-09 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1872 You don't have to make two PRs for adopting multiple branches. We can merge it into several branches with one commit if there's no conflict. Can you please close this PR? --- If your project

[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task

2017-01-09 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1875 @1ambda Does it reduce the build time of web module? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1838: [ZEPPELIN-1832] Fixed a bug in zombie process when Zep...

2017-01-09 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1838 @cloverhearts The last travis doesn't look related error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1871: ZEPPELIN-1862 Move packages related Helium into a new ...

2017-01-08 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1871 @Leemoonsoo @AhyoungRyu @soralee Can you review this PR? you just build it with `-Phelium-dev` and run clock example. --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #1796: ZEPPELIN-1852. Use multiple InterpreterResult for disp...

2017-01-08 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1796 CI is green. Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1845: [ZEPPELIN-1906] Use multiple InterpreterResult for dis...

2017-01-08 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1845 @astroshim Can you also review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1808: [ZEPPELIN-1843] Error on invoking the REST API to run ...

2017-01-08 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1808 Will merge it if there's no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

<    4   5   6   7   8   9   10   11   12   13   >