date:20190116

[GitHub] D01B commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

2019-01-16 Thread GitBox

D01B commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button 
"stop notebook execution"
URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248267618
 
 

 ##
 File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java
 ##
 @@ -86,6 +86,7 @@
 
   /** transient fields 
**/
   private transient boolean loaded = false;
+  private transient boolean executionAborted = false;
 
 Review comment:
   oh, it's non-volatile object. It doesnt looks like thread safe code. 
   You should use volatile w synchronized or something like 
java.util.concurrent.atomic.AtomicBoolean.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] D01B commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox

D01B commented on issue #3205: [ZEPPELIN-3814] Add apply button to table 
settings
URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-454770146
 
 
   @felixcheung could you merge changes or give some feedback??


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

2019-01-16 Thread GitBox

Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add 
button "stop notebook execution"
URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248331260
 
 

 ##
 File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java
 ##
 @@ -86,6 +86,7 @@
 
   /** transient fields 
**/
   private transient boolean loaded = false;
+  private transient boolean executionAborted = false;
 
 Review comment:
   i fixed it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox

felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add 
apply button to table settings
URL: https://github.com/apache/zeppelin/pull/3205#discussion_r248539269
 
 

 ##
 File path: 
zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html
 ##
 @@ -17,6 +17,12 @@
 Table Options
 

+ 
+   
 
 Review comment:
   hmm, I guess either is ok :)
   
   so I'm wondering with this behavior change, would it be easy to forget to 
"apply"? would it be possible to pop a tooltip when anything is changed to 
direct user to click "apply all"?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung edited a comment on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox

felixcheung edited a comment on issue #3205: [ZEPPELIN-3814] Add apply button 
to table settings
URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-455042779
 
 
   hey sorry about missing this. I'm going to check this PR now if you'd like 
to see my comment (here 
https://github.com/apache/zeppelin/pull/3205#discussion_r248539269).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox

felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table 
settings
URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-455042779
 
 
   hey sorry about missing this. I'm going to check this PR now if you'd like 
to see my comment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zjffdu commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

2019-01-16 Thread GitBox

zjffdu commented on a change in pull request #3281: [ZEPPELIN-3943] - Add 
button "stop notebook execution"
URL: https://github.com/apache/zeppelin/pull/3281#discussion_r248515673
 
 

 ##
 File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
 ##
 @@ -340,27 +344,67 @@ public void runAllParagraphs(String noteId,
   return;
 }
 
-note.setRunning(true);
-try {
-  for (Map raw : paragraphs) {
-String paragraphId = (String) raw.get("id");
-if (paragraphId == null) {
-  continue;
-}
-String text = (String) raw.get("paragraph");
-String title = (String) raw.get("title");
-Map params = (Map) raw.get("params");
-Map config = (Map) raw.get("config");
-
-if (!runParagraph(noteId, paragraphId, title, text, params, config, 
false, true,
-context, callback)) {
-  // stop execution when one paragraph fails.
-  break;
+synchronized (note) {
+  if (note.isRunning()) {
+LOGGER.warn("Can't run note because it already is running");
+return;
+  }
+  note.setRunning(true);
+}
+
+noteExecutor.execute(() -> {
+  try {
+for (Map raw : paragraphs) {
+  String paragraphId = (String) raw.get("id");
+  if (paragraphId == null) {
+continue;
+  }
+  String text = (String) raw.get("paragraph");
+  String title = (String) raw.get("title");
+  Map params = (Map) raw.get("params");
+  Map config = (Map) raw.get("config");
+
+  if (note.isExecutionAborted() || !runParagraph(noteId, paragraphId, 
title, text,
+  params, config, false, true, context, callback)) {
+// stop execution when one paragraph fails.
+break;
 
 Review comment:
   I think this is duplicated with Note#runAll


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue

2019-01-16 Thread GitBox

fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue
URL: https://github.com/apache/zeppelin/pull/3264#issuecomment-455042924
 
 
   > is there js test we could add?
   
   I agree, just will take more time to write the test framework for this bug. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung commented on a change in pull request #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

2019-01-16 Thread GitBox

felixcheung commented on a change in pull request #3254: [ZEPPELIN-3575] Add 
'Copy Column Name' to table visualisation-table 
URL: https://github.com/apache/zeppelin/pull/3254#discussion_r248538413
 
 

 ##
 File path: zeppelin-web/src/app/visualization/builtins/visualization-table.js
 ##
 @@ -256,6 +256,15 @@ export default class TableVisualization extends 
Visualization {
 return this.context.col.colDef.type === TableColumnType.DATE;
   },
 },
+{
+  title: 'Copy Column Name',
+  action: function() {
+self.copyStringToClipboard(this.context.col.displayName);
+  },
+  active: function() {
+self.copyStringToClipboard(this.context.col.displayName);
 
 Review comment:
   wait, shouldn't this be true?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

2019-01-16 Thread GitBox

felixcheung commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to 
table visualisation-table 
URL: https://github.com/apache/zeppelin/pull/3254#issuecomment-455041822
 
 
   @fred521 please consider contributing ;)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

2019-01-16 Thread GitBox

felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table 
settings
URL: https://github.com/apache/zeppelin/pull/3205#issuecomment-455043397
 
 
   could you also update the images in the PR description to reflect the final 
visual (these gets linked to in the commit later) 
https://github.com/apache/zeppelin/pull/3205#issue-223576707


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[VOTE] Release Apache Zeppelin 0.8.1 (RC1)

2019-01-16 Thread Jeff Zhang

Hi folks,

I propose the following RC to be released for the Apache Zeppelin
0.8.1 release.


The commit id is c46f55f1d81df944fd1b69a7ccb68d0647294543 :

https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=commit;h=c46f55f1d81df944fd1b69a7ccb68d0647294543


This corresponds to the tag: v0.8.1-rc1 :
*https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/tags/v0.8.1-rc1
*


The release archives (tgz), signature, and checksums are here
*https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/
*

The release candidate consists of the following source distribution archive
zeppelin-0.8.1.tgz

In addition, the following supplementary binary distributions are provided
for user convenience at the same location
zeppelin-0.8.1-bin-all.tgz


The maven artifacts are here
https://repository.apache.org/content/repositories/orgapachezeppelin-1269/org/apache/zeppelin/
You can find the KEYS file here:

https://dist.apache.org/repos/dist/release/zeppelin/KEYS

Release notes available at
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343240==12316221
Vote will be open for next 72 hours (close at 7pm 19/Jan PDT).

[ ] +1 approve
[ ] 0 no opinion
[ ] -1 disapprove (and reason why)

Re: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

2019-01-16 Thread Jeff Zhang

I will start with my +1

Jeff Zhang  于2019年1月17日周四 上午11:28写道：

> Hi folks,
>
> I propose the following RC to be released for the Apache Zeppelin
> 0.8.1 release.
>
>
> The commit id is c46f55f1d81df944fd1b69a7ccb68d0647294543 :
>
> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=commit;h=c46f55f1d81df944fd1b69a7ccb68d0647294543
>
>
> This corresponds to the tag: v0.8.1-rc1 : 
> *https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/tags/v0.8.1-rc1
>  
> *
>
>
> The release archives (tgz), signature, and checksums are here 
> *https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/ 
> *
>
> The release candidate consists of the following source distribution archive
> zeppelin-0.8.1.tgz
>
> In addition, the following supplementary binary distributions are provided
> for user convenience at the same location
> zeppelin-0.8.1-bin-all.tgz
>
>
> The maven artifacts are here 
> https://repository.apache.org/content/repositories/orgapachezeppelin-1269/org/apache/zeppelin/
> You can find the KEYS file here:
>
> https://dist.apache.org/repos/dist/release/zeppelin/KEYS
>
> Release notes available at 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343240==12316221
> Vote will be open for next 72 hours (close at 7pm 19/Jan PDT).
>
> [ ] +1 approve
> [ ] 0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
>

-- 
Best Regards

Jeff Zhang

Re: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

2019-01-16 Thread Miquel Angel Andreu Febrer

+1

El jue., 17 ene. 2019 6:40, Jeff Zhang  escribió:

> I will start with my +1
>
> Jeff Zhang  于2019年1月17日周四 上午11:28写道：
>
> > Hi folks,
> >
> > I propose the following RC to be released for the Apache Zeppelin
> > 0.8.1 release.
> >
> >
> > The commit id is c46f55f1d81df944fd1b69a7ccb68d0647294543 :
> >
> >
> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=commit;h=c46f55f1d81df944fd1b69a7ccb68d0647294543
> >
> >
> > This corresponds to the tag: v0.8.1-rc1 : *
> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/tags/v0.8.1-rc1
> <
> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/tags/v0.8.1-rc1
> >*
> >
> >
> > The release archives (tgz), signature, and checksums are here *
> https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/ <
> https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/>*
> >
> > The release candidate consists of the following source distribution
> archive
> > zeppelin-0.8.1.tgz
> >
> > In addition, the following supplementary binary distributions are
> provided
> > for user convenience at the same location
> > zeppelin-0.8.1-bin-all.tgz
> >
> >
> > The maven artifacts are here
> https://repository.apache.org/content/repositories/orgapachezeppelin-1269/org/apache/zeppelin/
> > You can find the KEYS file here:
> >
> > https://dist.apache.org/repos/dist/release/zeppelin/KEYS
> >
> > Release notes available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343240==12316221
> > Vote will be open for next 72 hours (close at 7pm 19/Jan PDT).
> >
> > [ ] +1 approve
> > [ ] 0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> >
> >
>
> --
> Best Regards
>
> Jeff Zhang
>

[jira] [Created] (ZEPPELIN-3952) Don't use tmp local maven repo in publish_release.sh

2019-01-16 Thread Jeff Zhang (JIRA)

Jeff Zhang created ZEPPELIN-3952:


 Summary: Don't use tmp local maven repo in publish_release.sh
 Key: ZEPPELIN-3952
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3952
 Project: Zeppelin
  Issue Type: Bug
Reporter: Jeff Zhang


It would takes very long time to download dependencies if we use local maven 
repo. We should still use the default local maven repo to save time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

RE: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

2019-01-16 Thread Gowda Tp, Thimme (Nokia - IN/Bangalore)

+1

-Original Message-
From: Xun Liu  
Sent: Thursday, January 17, 2019 12:27 PM
To: dev@zeppelin.apache.org
Cc: users 
Subject: Re: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

+1

> 在 2019年1月17日，下午2:50，Miquel Angel Andreu Febrer 
>  写道：
> 
> +1
> 
> El jue., 17 ene. 2019 6:40, Jeff Zhang  > escribió:
> 
>> I will start with my +1
>> 
>> Jeff Zhang  于2019年1月17日周四 上午11:28写道：
>> 
>>> Hi folks,
>>> 
>>> I propose the following RC to be released for the Apache Zeppelin
>>> 0.8.1 release.
>>> 
>>> 
>>> The commit id is c46f55f1d81df944fd1b69a7ccb68d0647294543 :
>>> 
>>> 
>> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=commit;h=c46f55f
>> 1d81df944fd1b69a7ccb68d0647294543
>>> 
>>> 
>>> This corresponds to the tag: v0.8.1-rc1 : *
>> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/
>> tags/v0.8.1-rc1
>> <
>> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/
>> tags/v0.8.1-rc1 
>> > /tags/v0.8.1-rc1>
>>> *
>>> 
>>> 
>>> The release archives (tgz), signature, and checksums are here *
>> https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/ 
>>  
>> < https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/ 
>> 
>> >*
>>> 
>>> The release candidate consists of the following source distribution
>> archive
>>> zeppelin-0.8.1.tgz
>>> 
>>> In addition, the following supplementary binary distributions are
>> provided
>>> for user convenience at the same location zeppelin-0.8.1-bin-all.tgz
>>> 
>>> 
>>> The maven artifacts are here
>> https://repository.apache.org/content/repositories/orgapachezeppelin-
>> 1269/org/apache/zeppelin/
>>> You can find the KEYS file here:
>>> 
>>> https://dist.apache.org/repos/dist/release/zeppelin/KEYS
>>> 
>>> Release notes available at
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=123432
>> 40==12316221
>>> Vote will be open for next 72 hours (close at 7pm 19/Jan PDT).
>>> 
>>> [ ] +1 approve
>>> [ ] 0 no opinion
>>> [ ] -1 disapprove (and reason why)
>>> 
>>> 
>>> 
>> 
>> --
>> Best Regards
>> 
>> Jeff Zhang

[GitHub] D01B commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

D01B commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in 
ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-455056224
 
 
   I think you should try to use ZEPPELIN_CLASSPATH_OVERRIDES instead of 
ZEPPELIN_CLASSPATH(on your own risk) As @zjffdu said, additional jars in base 
classpath may caused jar conflicts and troubles in runtime.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

2019-01-16 Thread Xun Liu

+1

> 在 2019年1月17日，下午2:50，Miquel Angel Andreu Febrer  
> 写道：
> 
> +1
> 
> El jue., 17 ene. 2019 6:40, Jeff Zhang  > escribió:
> 
>> I will start with my +1
>> 
>> Jeff Zhang  于2019年1月17日周四 上午11:28写道：
>> 
>>> Hi folks,
>>> 
>>> I propose the following RC to be released for the Apache Zeppelin
>>> 0.8.1 release.
>>> 
>>> 
>>> The commit id is c46f55f1d81df944fd1b69a7ccb68d0647294543 :
>>> 
>>> 
>> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=commit;h=c46f55f1d81df944fd1b69a7ccb68d0647294543
>>> 
>>> 
>>> This corresponds to the tag: v0.8.1-rc1 : *
>> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/tags/v0.8.1-rc1
>> <
>> https://gitbox.apache.org/repos/asf?p=zeppelin.git;a=shortlog;h=refs/tags/v0.8.1-rc1
>>  
>> 
>>> *
>>> 
>>> 
>>> The release archives (tgz), signature, and checksums are here *
>> https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/ 
>>  <
>> https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.1-rc1/ 
>> >*
>>> 
>>> The release candidate consists of the following source distribution
>> archive
>>> zeppelin-0.8.1.tgz
>>> 
>>> In addition, the following supplementary binary distributions are
>> provided
>>> for user convenience at the same location
>>> zeppelin-0.8.1-bin-all.tgz
>>> 
>>> 
>>> The maven artifacts are here
>> https://repository.apache.org/content/repositories/orgapachezeppelin-1269/org/apache/zeppelin/
>>> You can find the KEYS file here:
>>> 
>>> https://dist.apache.org/repos/dist/release/zeppelin/KEYS
>>> 
>>> Release notes available at
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12343240==12316221
>>> Vote will be open for next 72 hours (close at 7pm 19/Jan PDT).
>>> 
>>> [ ] +1 approve
>>> [ ] 0 no opinion
>>> [ ] -1 disapprove (and reason why)
>>> 
>>> 
>>> 
>> 
>> --
>> Best Regards
>> 
>> Jeff Zhang

[jira] [Created] (ZEPPELIN-3951) Enable IPython in Docker

2019-01-16 Thread Jeff Zhang (JIRA)

Jeff Zhang created ZEPPELIN-3951:


 Summary: Enable IPython in Docker
 Key: ZEPPELIN-3951
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3951
 Project: Zeppelin
  Issue Type: Bug
Reporter: Jeff Zhang


IPythonInterpreter require some additional libraries installed, it is not 
available in zeppelin docker, this ticket is trying to enable it via installing 
the necessary libraries in zeppelin docker



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-16 Thread GitBox

ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin 
on Kubernetes
URL: https://github.com/apache/zeppelin/pull/3240#discussion_r248565818
 
 

 ##
 File path: 
zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java
 ##
 @@ -0,0 +1,157 @@
+/*
 
 Review comment:
   The Issue with fabric8 library related to kubectl apply or delete of 
resources using a single API is working with 
[#1300](https://github.com/fabric8io/kubernetes-client/pull/1300) which is 
merged to master branch.
   When it is available in the next release of fabric8io/kubernetes-client we 
can integrate the same. Using the above fix from fabric8 the change has been 
validated in the master branch of 
[zep-k8sctl](https://github.com/ajaygk95/zep-k8sctl).
   Can you please let us know if we create new JIRA issues so that we follow up 
or we will follow some different procedure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

2019-01-16 Thread GitBox

ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin 
on Kubernetes
URL: https://github.com/apache/zeppelin/pull/3240#discussion_r248567845
 
 

 ##
 File path: 
zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java
 ##
 @@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.interpreter.launcher;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.gson.Gson;
+import java.util.ArrayList;
+import java.util.Arrays;
+
+import org.apache.commons.exec.*;
+import org.apache.commons.io.IOUtils;
+
+import java.io.*;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Kubectl {
+  private final Logger LOGGER = LoggerFactory.getLogger(Kubectl.class);
+  private final String kubectlCmd;
+  private final Gson gson = new Gson();
+  private String namespace;
+
+  public Kubectl(String kubectlCmd) {
+this.kubectlCmd = kubectlCmd;
+  }
+
+  /**
+   * Override namespace. Otherwise use namespace provided in schema
+   * @param namespace
+   */
+  public void setNamespace(String namespace) {
+this.namespace = namespace;
+  }
+
+  public String getNamespace() {
+return namespace;
+  }
+
+  public String apply(String spec) throws IOException {
+return execAndGet(new String[]{"apply", "-f", "-"}, spec);
 
 Review comment:
   `kubectl apply -f` does not work if there is a `generateName` in the 
interpreter spec yaml. Its better to use `kubectl create -f` if resources are 
being created. Please find the discussion 
[here](https://github.com/kubernetes/kubernetes/issues/44501#issuecomment-294255660).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zjffdu commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

zjffdu commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in 
ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-454718216
 
 
   @mcapuccini Plugin use separate ClassLoader which is different from that of 
ZeppelinServer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in 
ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-454701698
 
 
   @zjffdu Indeed, adding to Hadoop Jar to `CLASSPATH` caused conflicts in my 
environment, but adding them to `ZEPPELIN_CLASSPATH` seem to work good 
(https://github.com/mcapuccini/spark-tensorflow/blob/master/Dockerfile). Ins't 
`$ZEPPELIN_HOME/plugins/NotebookRepo/FileSystemNotebookRepo` added to the 
`ZEPPELIN_CLASSPATH` ultimately? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add 
HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-454701698
 
 
   @zjffdu Indeed, adding Hadoop JARs to `CLASSPATH` caused conflicts in my 
environment, but adding them to `ZEPPELIN_CLASSPATH` seems to work good 
(https://github.com/mcapuccini/spark-tensorflow/blob/master/Dockerfile). Ins't 
`$ZEPPELIN_HOME/plugins/NotebookRepo/FileSystemNotebookRepo` added to the 
`ZEPPELIN_CLASSPATH` ultimately? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add 
HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-454701698
 
 
   @zjffdu Indeed, adding to Hadoop JARs to `CLASSPATH` caused conflicts in my 
environment, but adding them to `ZEPPELIN_CLASSPATH` seems to work good 
(https://github.com/mcapuccini/spark-tensorflow/blob/master/Dockerfile). Ins't 
`$ZEPPELIN_HOME/plugins/NotebookRepo/FileSystemNotebookRepo` added to the 
`ZEPPELIN_CLASSPATH` ultimately? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung merged pull request #3282: [ZEPPELIN-3944] Update Dockerfiles of spark_standalone and spark_yarn_cluster

2019-01-16 Thread GitBox

felixcheung merged pull request #3282: [ZEPPELIN-3944] Update Dockerfiles of 
spark_standalone and spark_yarn_cluster
URL: https://github.com/apache/zeppelin/pull/3282
 
 
   

As this is a foreign pull request (from a fork), the diff has been
sent to your commit mailing list, comm...@zeppelin.apache.org


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in 
ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-454695679
 
 
   Hi @felixcheung. I've tried to set `CLASSPATH=$CLASSPATH:$HADOOP_CLASSPATH` 
before running `bin/zeppelin.sh`, but that causes Zeppelin to crash (I was 
getting errors like "class not found"). Setting `ZEPPELIN_CLASSPATH` worked 
just fine for me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zjffdu commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

zjffdu commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in 
ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-454698946
 
 
   Just copy my comment in jira here.
   
   
   > It is risky to put hadoop libraries on the CLASSPATH of zeppelin server. 
Because it may cause jar conflicts. For notebook storage, we use plugin for 
NotebookRepo in zeppelin 0.9, you can put extra dependencies in the plugin 
folder. Hadoop NotebookRepo is located in 
$ZEPPELIN_HOME/plugins/NotebookRepo/FileSystemNotebookRepo
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

2019-01-16 Thread GitBox

mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add 
HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin
URL: https://github.com/apache/zeppelin/pull/3283#issuecomment-454701698
 
 
   @zjffdu Indeed, adding to Hadoop JARs to `CLASSPATH` caused conflicts in my 
environment, but adding them to `ZEPPELIN_CLASSPATH` seem to work good 
(https://github.com/mcapuccini/spark-tensorflow/blob/master/Dockerfile). Ins't 
`$ZEPPELIN_HOME/plugins/NotebookRepo/FileSystemNotebookRepo` added to the 
`ZEPPELIN_CLASSPATH` ultimately? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] D01B commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

[GitHub] D01B commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

[GitHub] Savalek commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

[GitHub] felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings

[GitHub] felixcheung edited a comment on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

[GitHub] felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

[GitHub] zjffdu commented on a change in pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"

[GitHub] fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue

[GitHub] felixcheung commented on a change in pull request #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

[GitHub] felixcheung commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

[GitHub] felixcheung commented on issue #3205: [ZEPPELIN-3814] Add apply button to table settings

[VOTE] Release Apache Zeppelin 0.8.1 (RC1)

Re: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

Re: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

[jira] [Created] (ZEPPELIN-3952) Don't use tmp local maven repo in publish_release.sh

RE: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

[GitHub] D01B commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

Re: [VOTE] Release Apache Zeppelin 0.8.1 (RC1)

[jira] [Created] (ZEPPELIN-3951) Enable IPython in Docker

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

[GitHub] ajaygk95 commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes

[GitHub] zjffdu commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

[GitHub] mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

[GitHub] mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

[GitHub] mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

[GitHub] felixcheung merged pull request #3282: [ZEPPELIN-3944] Update Dockerfiles of spark_standalone and spark_yarn_cluster

[GitHub] mcapuccini commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

[GitHub] zjffdu commented on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

[GitHub] mcapuccini edited a comment on issue #3283: [ZEPPELIN-3949] Add HADOOP_CLASSPATH in ZEPPELIN_CLASSPATH when starting Zeppelin

29 matches

Site Navigation

Mail list logo

Footer information