[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
@ejono The root cause is that SPARK_VER doesn't take effect in travis,  I 
created ZEPPELIN-1918. It would be better to fix the issue here with 
ZEPPELIN-1918 together. I would be happy to help if you want to contribute on 
this. BTW, you might need to create another profile for spark 2.1.0, because 
spark 2.1.0 use another version of pyspark.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1918) SPARK_VER doesn't take effect in travis

2017-01-06 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1918:


 Summary: SPARK_VER doesn't take effect in travis
 Key: ZEPPELIN-1918
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1918
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Jeff Zhang
Priority: Blocker


@ejono found that zeppelin could not build with spark 2.1.0. And the root cause 
is that SPARK_VER doesn't take effect in travis. Not sure when this issue come 
up. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1855: [MINOR][ZEPPELIN-1913] Separate "Apache Zeppelin Confi...

2017-01-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1855
  
CI failed in only 1 case like below 

```
Results :

Failed tests: 
  NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 
expected: but was:

Tests run: 153, Failures: 1, Errors: 0, Skipped: 0

```

This is irrelevant to this docs change(reported in 
[ZEPPELIN-1857](https://issues.apache.org/jira/browse/ZEPPELIN-1857)), so merge 
if there are no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...

2017-01-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1844
  
LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1849: [ZEPPELIN-1902] Fix blank default intp select box afte...

2017-01-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1849
  
CI is all green now. Ready for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...

2017-01-06 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1844
  
thanks @AhyoungRyu, updated!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1845: [ZEPPELIN-1906] Use multiple InterpreterResult ...

2017-01-06 Thread prabhjyotsingh
Github user prabhjyotsingh closed the pull request at:

https://github.com/apache/zeppelin/pull/1845


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1845: [ZEPPELIN-1906] Use multiple InterpreterResult ...

2017-01-06 Thread prabhjyotsingh
GitHub user prabhjyotsingh reopened a pull request:

https://github.com/apache/zeppelin/pull/1845

[ZEPPELIN-1906] Use multiple InterpreterResult for displaying multiple JDBC 
queries

### What is this PR for?
Use multiple InterpreterResult for displaying multiple JDBC queries. 
IMO since other sql editors allows to execute multiple sql separated with 
";" and ours display mechanism being more powerful, hence, it should also allow 
the same.

### What type of PR is it?
[Improvement]


### What is the Jira issue?
* [ZEPPELIN-1906](https://issues.apache.org/jira/browse/ZEPPELIN-1906)

### How should this be tested?
Try running following in a paragraph (with Postgres setting) and check for 
output. 

```
%jdbc
create table test_temp_table (id int);
select column_name, data_type, character_maximum_length from 
INFORMATION_SCHEMA.COLUMNS where table_name = 'test_temp_table';
SELECT table_name FROM information_schema.tables WHERE table_schema = 
'public';
drop table test_temp_table;
SELECT table_name FROM information_schema.tables WHERE table_schema = 
'public';
```

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1906

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1845


commit f5ab79687126849778809c9f1851171bacc52e15
Author: Prabhjyot Singh 
Date:   2017-01-05T05:48:29Z

Use multiple InterpreterResult for displaying multiple JDBC queries

commit e675190ac0674086dd7d34b4f810f3b0dab0a519
Author: Prabhjyot Singh 
Date:   2017-01-05T06:52:23Z

user same connection instead of creating new everytime

commit c096e76b1805fc5c3fea5bce1a31c0987ffae8cc
Author: Prabhjyot Singh 
Date:   2017-01-05T06:53:53Z

remove extra empty lines

commit e6727b555c146b1209b0533414b658b9c3079a52
Author: Prabhjyot Singh 
Date:   2017-01-05T15:06:38Z

add testcase for spliting sql.

commit f3da37f14601739219a8d771fbf3f5d0b7fce200
Author: Prabhjyot Singh 
Date:   2017-01-05T16:05:32Z

replace regex with slightly better logic.

commit ac4663d706841c8909f9ce99fbe952d2f9c4b1ac
Author: Prabhjyot Singh 
Date:   2017-01-05T16:19:24Z

add block comment

commit b3e742e8f60f8e5835fdd5e8aa006d0219310709
Author: Prabhjyot Singh 
Date:   2017-01-05T16:34:36Z

fixing checkstyle-fail-build

commit f9fd5c694f132a8953bf970d1686cdef714e1bae
Author: Prabhjyot Singh 
Date:   2017-01-05T16:57:19Z

allow last query to be without ";"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1848: [ZEPPELIN-1812] Ace editor show/hide problem.

2017-01-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1848


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1851: [ZEPPELIN-1908] Invalid Typo Method name

2017-01-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1851
  
Merge if there are no more comments on this 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...

2017-01-06 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1844
  
@khalidhuseynov Seems a default value of `ZEPPELIN_NOTEBOOK_STORAGE ` under 
[Apache Zeppelin 
configuration](https://github.com/apache/zeppelin/blob/master/docs/install/install.md#apache-zeppelin-configuration)
  table also needs to be updated :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1849: [ZEPPELIN-1902] Fix blank default intp select b...

2017-01-06 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at:

https://github.com/apache/zeppelin/pull/1849


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1849: [ZEPPELIN-1902] Fix blank default intp select b...

2017-01-06 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request:

https://github.com/apache/zeppelin/pull/1849

[ZEPPELIN-1902] Fix blank default intp select box after Zeppelin started 
when Shiro on

### What is this PR for?
After #1520 we can set default interpreter when we create new note. 
Currently this feature is implemented to get `interpreterSetting` list when 
Zeppelin is initiated (can be checked in dev console). And it needs user's 
info. So there can be two cases like below.

 - Shiro off 
It tries to get interpreter setting lists as `anonymous` user

![shirooff](https://cloud.githubusercontent.com/assets/10060731/21676394/cce513d8-d378-11e6-9645-99255882b664.png)
In this case, the problem is not happened. If we don't turn Shiro on, it 
doesn't need user's info and Zeppelin automatically creates fake user(?) info 
as `anonymous`. So there is no problem to get the interpreter setting lists. 

 - Shiro on
tries to get interpreter setting lists as '  ' user since we're not 
loggined yet. 

![shiroon](https://cloud.githubusercontent.com/assets/10060731/21676414/db03515a-d378-11e6-99c9-34775e07a2e8.png)
 
So it's failed to get interpreter setting lists since it doesn't have any 
user info. It needs reloading to get it. 

![whenshiroon](https://cloud.githubusercontent.com/assets/10060731/21676657/e08ee03e-d379-11e6-8844-6baa673e0308.gif)


Actually we don't need to send `GET_INTERPRETER_SETTINGS` msg when Zeppelin 
started. It would be fine when we click "Create new note" button. So I removed 
`init()` (it's used only for getting interpreter settings) and made 
`getInterpreterSettings` called only when user clicks "Create new note" in both 
Zeppelin home and Navbar. 


### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1902](https://issues.apache.org/jira/browse/ZEPPELIN-1902)

### How should this be tested?
In master (not this branch)
1. [Turn Shiro 
on](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#1-enable-shiro)
 and start(restart) Zeppelin 
2. Click "Create new note" in home (or Navbar)
3. the default interpreter select box will be like 
![screen shot 2017-01-05 at 7 16 08 
pm](https://cloud.githubusercontent.com/assets/10060731/21676986/7a005a80-d37b-11e6-80d9-1597914c4b05.png)

but it'll be okay after reloading. It shouldn't be like that with this 
patch. 


### Screenshots (if appropriate)
after fixing this problem

![whenshiroonafter](https://cloud.githubusercontent.com/assets/10060731/21676678/08a2360c-d37a-11e6-9a9b-03457b88a4fb.gif)
 

### Questions:
* Does the licenses files need update? no 
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1902

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1849


commit 30909338de44eef0171a00b4377b54a2acd94852
Author: AhyoungRyu 
Date:   2017-01-05T10:38:21Z

Fix blank default intp select box after Zeppelin started when Shiro on




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1857: [ZEPPELIN-1874] fix: sparkR doens't render output prop...

2017-01-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1857
  
Merge to master if no more comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-06 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1862
  
@jongyoul 
Yes, I was take look!
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1848: [ZEPPELIN-1812] Ace editor show/hide problem.

2017-01-06 Thread cloverhearts
GitHub user cloverhearts reopened a pull request:

https://github.com/apache/zeppelin/pull/1848

[ZEPPELIN-1812] Ace editor show/hide problem.

### What is this PR for?
When editor hide is on and page refresh then editor is gone.
I was solve this problem.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1812

### How should this be tested?
1. hide to editor mode on in paragraph configure.
2. page refresh (f5)
3. enable to show editor mode in paragraph configure.
4. if show editor then is correct.
### Screenshots (if appropriate)
 before

![badeditor](https://cloud.githubusercontent.com/assets/10525473/21677078/62136de2-d2ed-11e6-9418-0be4453fd839.gif)

 after

![goodeditor](https://cloud.githubusercontent.com/assets/10525473/21677092/6c8d97e8-d2ed-11e6-8966-a3b7af60c231.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-1812

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1848.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1848


commit b7cd700eccfd2ed51f29c17285bad36579c02208
Author: cloverhearts 
Date:   2017-01-05T10:09:38Z

fixed ace editor hide problem

commit 037993d23257b31836ad59d8805540d30dd1c420
Author: cloverhearts 
Date:   2017-01-06T04:09:33Z

fixed test case

commit c3efea2b93ce2defcf822ef380b5f66cc349c81a
Author: cloverhearts 
Date:   2017-01-06T05:25:26Z

Revert "fixed test case"

This reverts commit 037993d23257b31836ad59d8805540d30dd1c420.

commit 4750e6fce66e95265f2eea1ad45672a673ccd2a9
Author: cloverhearts 
Date:   2017-01-06T08:39:22Z

fix testcase

commit d10d53d6c578d4f0749402a38c9e9337fb68e702
Author: cloverhearts 
Date:   2017-01-06T08:42:06Z

add element null check

commit 9c5ee63e3217e25d92080101cd21baff542ec113
Author: cloverhearts 
Date:   2017-01-06T09:22:46Z

add size check




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1848: [ZEPPELIN-1812] Ace editor show/hide problem.

2017-01-06 Thread cloverhearts
Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/1848


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1917) Improve python.conda interpreter

2017-01-06 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-1917:
---

 Summary: Improve python.conda interpreter
 Key: ZEPPELIN-1917
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1917
 Project: Zeppelin
  Issue Type: Improvement
  Components: python-interpreter
Reporter: Hoon Park


Currently {{python.conda}} only support 

- env list
- activate
- deactivate

we need to support more commands.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1853: [ZEPPELIN-1911] Adding how to install evaluate ...

2017-01-06 Thread astroshim
GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1853

[ZEPPELIN-1911] Adding how to install evaluate package to build R.

### What is this PR for?
This PR inform how to avoid build failing with R.


### What type of PR is it?
Documentation


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1911


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1911

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1853


commit 2ca82573e497ebcdca373c2be1048b1b7a1b4afa
Author: astroshim 
Date:   2017-01-06T01:56:16Z

add doc how to install evaluate package




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1853: [ZEPPELIN-1911] Adding how to install evaluate ...

2017-01-06 Thread astroshim
Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1853


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1916) Provide a way to roll or rotate zeppelin-${USER}-${HOSTNAME}.out files

2017-01-06 Thread Leonardo Jimenez (JIRA)
Leonardo Jimenez created ZEPPELIN-1916:
--

 Summary: Provide a way to roll or rotate 
zeppelin-${USER}-${HOSTNAME}.out files
 Key: ZEPPELIN-1916
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1916
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.0
Reporter: Leonardo Jimenez
Priority: Minor


The size of zeppelin-${USER}-${HOSTNAME}.out files in 
//logs/ keeps increasing without bound. A way to handle this 
by rotating or rolling the file (similar to log files) should be provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-06 Thread ejono
Github user ejono commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
Thanks for confirming. The fix would not be too difficult, but yes, I'm 
puzzled as to why the CI isn't broken, so maybe we need to figure that out 
first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
yea, this is a bit puzzling...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1856: remove org.apache.spark.sql.hive.HiveSharedState class...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1856
  
it's only the python2 + spark 1.6 profile. It ran fine with the other spark 
1.6 profile so I think we are good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
Thanks @ejono for reporting this, I can also reproduce it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1859: ZEPPELIN-1432. Support cancellation of paragraph execu...

2017-01-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1859
  
cancel is only available in livy 0.3 which is not released yet, so no test 
for it. I can add that after livy 0.3 is released. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1856: remove org.apache.spark.sql.hive.HiveSharedState class...

2017-01-06 Thread lichenglin
Github user lichenglin commented on the issue:

https://github.com/apache/zeppelin/pull/1856
  
e...
It works on my local mac with spark 2.1.0.
And pass the build with 2.1.0.
I seems that the build fails with 
{code}
  "env": "PYTHON=\"2\" SCALA_VER=\"2.10\" SPARK_VER=\"1.6.1\" 
HADOOP_VER=\"2.6\" PROFILE=\"-Pspark-1.6 -Phadoop-2.6 -Ppyspark\" 
BUILD_FLAG=\"package -pl spark,python -am -DskipTests -DskipRat\" 
TEST_FLAG=\"verify -DskipRat\" TEST_PROJECTS=\"-pl 
zeppelin-interpreter,zeppelin-display,spark-dependencies,spark,python 
-Dtest=org.apache.zeppelin.spark.PySpark*Test,org.apache.zeppelin.python.* 
-Dpyspark.test.exclude='' -DfailIfNoTests=false\"",
{code}

I think we'd better reopen the PR and build once more.
Maybe the class check is still necessary for spark 1.6.1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1856: remove org.apache.spark.sql.hive.HiveSharedState class...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1856
  
I don't think we need to check for all 3 classes, so I believe this fix is 
good.
what I don't understand is why it is failing for you but running just fine 
in travis CI where we have tests for Spark 2.1 - which is why I'm asking.

to trigger test, close this PR and reopen it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1856: remove org.apache.spark.sql.hive.HiveSharedState class...

2017-01-06 Thread lichenglin
Github user lichenglin commented on the issue:

https://github.com/apache/zeppelin/pull/1856
  
I don't know either,It fails with spark 1.6.1.
May be the class check is still needed by 1.6,1?I'm not sure.
How can I trigger the build once more on travis-cli?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1859: ZEPPELIN-1432. Support cancellation of paragraph execu...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1859
  
looks good except for a few comments.
is it possible to add tests for these changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1857: [ZEPPELIN-1874] fix: sparkR doens't render output prop...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1857
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1862
  
LGTM
should there be tests for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1856: remove org.apache.spark.sql.hive.HiveSharedState class...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1856
  
would be great to understand why it worked before, but might merge this fix 
first.
merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1837: ZEPPELIN-1901. Output schema might be null for PigQuer...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1837
  
LGTM
merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-06 Thread ejono
Github user ejono commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
Answering my own questions:

I still haven't found a definitive answer to whether or not Java classes 
may take advantage of default parameter values defined in Scala classes, but 
it's pretty apparent that you cannot do this. This means that in order to 
support both Spark < 2.1.0 and Spark >= 2.1.0, we'd need to do a little more 
reflection magic to support the two possible versions of the SecurityManager 
constructor.

As for the link to the Jenkins CI, I found 
https://travis-ci.org/apache/zeppelin.  I don't at all understand though how 
the new Spark 2.1.0 profile is building successfully when I've found it so easy 
to reproduce this compilation error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1857: [ZEPPELIN-1874] fix: sparkR doens't render output prop...

2017-01-06 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1857
  
```
  ZeppelinSparkClusterTest.sparkRTest:186 expected:<[[1] 3]> but was:<[
```

The above test is failing. I will take a look into.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2017-01-06 Thread ejono
Github user ejono commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
When I compile Zeppelin (from master, including this change) against Spark 
2.1.0, I hit the following error:

[ERROR] 
/Volumes/Amazon/oss-workspace/src/zeppelin/spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1454,26]
 constructor SecurityManager in class org.apache.spark.SecurityManager cannot 
be applied to given types;
  required: org.apache.spark.SparkConf,scala.Option
  found: org.apache.spark.SparkConf
  reason: actual and formal argument lists differ in length
[ERROR] 
/Volumes/Amazon/oss-workspace/src/zeppelin/spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java:[1465,22]
 constructor SecurityManager in class org.apache.spark.SecurityManager cannot 
be applied to given types;
  required: org.apache.spark.SparkConf,scala.Option
  found: org.apache.spark.SparkConf
  reason: actual and formal argument lists differ in length

It doesn't matter if I'm using Scala 2.10 or 2.11. I can reproduce this 
with a command as simple as:

mvn clean package -DskipTests -Pspark-2.0 -Dspark.version=2.1.0

I'm not all that familiar with Scala, but I don't understand why this is a 
problem, as this Optional argument of the SecurityManager class (from 
Spark's source code) has a default of None, so I wouldn't think that it would 
be necessary to specify this second parameter to the constructor in Zeppelin 
code. Is it not possible for Java code to take advantage of the default value 
specified in the Scala code?

Also, isn't this breaking the Zeppelin CI? I don't know where to find the 
Zeppelin CI, so could somebody please provide a link?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1854: [ZEPPELIN-1912] fix: Improve perosnalized mode tooltip...

2017-01-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1854
  
LGTM and merge to master!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1857: [ZEPPELIN-1874] fix: sparkR doens't render output prop...

2017-01-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1857
  
Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...

2017-01-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1844
  
Thanks @khalidhuseynov for the improvement.

LGTM and merge if no more comments!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...

2017-01-06 Thread conker84
Github user conker84 commented on the issue:

https://github.com/apache/zeppelin/pull/1582
  
@felixcheung SourceTree works very well, thanks for the advice!
Now focusing to the PR, there still are conflicts, so i'll rebase the code 
again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1858: [ZEPPELIN-1229] Clear browser cache with versio...

2017-01-06 Thread astroshim
Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1858


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1858: [ZEPPELIN-1229] Clear browser cache with versio...

2017-01-06 Thread astroshim
GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1858

[ZEPPELIN-1229] Clear browser cache with version hashtag.

### What is this PR for?
This PR avoids browser cache.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1229

### How should this be tested?
1. Run old version of zeppelin(I was using 0.6.1) and show main page up in 
your browser.
2. Stop zeppelin.
3. Run this PR of Zeppelin and show page up on the same browser of 1.
4. check main page changed.

- before (Job menu doesn't show)
![2017-01-06 
01_50_29](https://cloud.githubusercontent.com/assets/3348133/21728478/43aec6d0-d3fb-11e6-84ce-9e1b18853611.gif)

- after (Job menu show)
![2017-01-06 
01_55_10](https://cloud.githubusercontent.com/assets/3348133/21728482/4a794e72-d3fb-11e6-8934-d6f92d65889b.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1229

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1858


commit 9d9f76f415e5b29c35b387cf1dcac889272b7503
Author: astroshim 
Date:   2017-01-06T08:14:35Z

fix ZEPPELIN-1229

commit c94de90832645da674bd2f1df2d4f7ddea1e14bf
Author: astroshim 
Date:   2017-01-06T08:15:53Z

delete unnecessary codes

commit 655dc3d67e587e6b46c4b147f28325d32d8cc746
Author: astroshim 
Date:   2017-01-06T09:38:17Z

tag all html




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1915) [Umbrella] Improve built-in visualizations

2017-01-06 Thread Lee moon soo (JIRA)
Lee moon soo created ZEPPELIN-1915:
--

 Summary: [Umbrella] Improve built-in visualizations
 Key: ZEPPELIN-1915
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1915
 Project: Zeppelin
  Issue Type: Task
Reporter: Lee moon soo


This is umbrella issues for

 - Bug fixes
 - Improvements

on built-in visualizations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1860: [ZEPPELIN-1848] add option for S3 KMS key regio...

2017-01-06 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1860


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1860: [ZEPPELIN-1848] add option for S3 KMS key regio...

2017-01-06 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1860

[ZEPPELIN-1848] add option for S3 KMS key region

### What is this PR for?
When using S3 storage layer with encryption keys, currently only keys 
created in `us-east-1` region can be used. This PR adds ability to set target 
region for AWS KMS keys.


### What type of PR is it?
Improvement

### Todos
* [x] - add region to awsClient 
* [x] - add conf for region
* [x] - tested with aws account `us-west-2` region

### What is the Jira issue?
[ZEPPELIN-1848](https://issues.apache.org/jira/browse/ZEPPELIN-1848)

### How should this be tested?
1. set up S3 storage as in 
[here](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#notebook-storage-in-s3)
2. add region variable with `export 
ZEPPELIN_NOTEBOOK_S3_KMS_KEY_REGION="us-west-2"` in `conf/zeppelin-env.sh`
3.  start Zeppelin and read/write S3

### Screenshots (if appropriate)

![kmc_region](https://cloud.githubusercontent.com/assets/1642088/21712912/0a79ee66-d3ac-11e6-8ba4-1e7f081f213f.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? updated


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/s3-repo-kms-region

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1860






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...

2017-01-06 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1844
  
@Leemoonsoo makes sense, added in 7cb133c8dc59357b0572c4f462ae04d5bbb55cce


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1848: [ZEPPELIN-1812] Ace editor show/hide problem.

2017-01-06 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1848
  
SELENIUM TEST PASSED

Currently, Current CI issues are irrelevant to my modifications.

```
10:45:01,535 ERROR org.apache.zeppelin.search.LuceneSearch:120 - Failed to 
open index dir RAMDirectory@4cc68af8 
lockFactory=org.apache.lucene.store.SingleInstanceLockFactory@7ecdc728, make 
sure indexing finished OK
org.apache.lucene.index.IndexNotFoundException: no segments* file found in 
RAMDirectory@4cc68af8 
lockFactory=org.apache.lucene.store.SingleInstanceLockFactory@7ecdc728: files: 
[]
at 
org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:726)
at 
org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:50)
at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:63)
at org.apache.zeppelin.search.LuceneSearch.query(LuceneSearch.java:104)
at 
org.apache.zeppelin.search.LuceneSearchTest.canNotSearchBeforeIndexing(LuceneSearchTest.java:147)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
10:45:01,544  INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2 
notebooks took 4ms
10:45:01,585  INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2 
notebooks took 4ms
10:45:01,632  INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2 
notebooks took 4ms
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.495 sec 
- in org.apache.zeppelin.search.LuceneSearchTest
Running org.apache.zeppelin.conf.ZeppelinConfigurationTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in 
[jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.347 sec - 
in org.apache.zeppelin.conf.ZeppelinConfigurationTest

Results :

Failed tests: 
  NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 
expected: but was:

Tests run: 153, Failures: 1, Errors: 0, Skipped: 0
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at 

[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...

2017-01-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1844
  
`VFSNotebookRepo` can be configured to use [other 
filesystems](https://commons.apache.org/proper/commons-vfs/filesystems.html) 
instead of local filesystem.
Those user might be confused when (default) notebook repo is changed to 
`GitNotebookRepo`.

How about add an item in 
[upgrade.md](https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md#upgrading-from-zeppelin-06-to-07)
 for this change? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-06 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1862
  
@cloverhearts Can you look into it? I think it can solve the problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1862: [HOTFIX] Removed non-string properties values s...

2017-01-06 Thread jongyoul
GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/1862

[HOTFIX] Removed non-string properties values since it's not used

### What is this PR for?
Removing an error when users try to connect running interpreter. Zeppelin 
Server passes those properties into RemoteInterpreter when it starts with 
RemoteInterpreter. But it supports only Map type for now, thus 
port information will make an error and also those information were not used in 
any code

### What type of PR is it?
[Hot Fix]

### Todos
* [ ] - Remove some properties

### What is the Jira issue?
N/A

### How should this be tested?
`Connect to existing process` should work well

### Screenshots (if appropriate)
N/A

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin 
hotfix/remove-non-string-properties

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1862


commit eaec6dee651e5806f9b0f2443f1a638e62ee8f54
Author: Jongyoul Lee 
Date:   2017-01-06T13:29:19Z

Removed non-string properties values since it's not used




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1859: ZEPPELIN-1432. Support cancellation of paragraph execu...

2017-01-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1859
  
CI failure is not relevant.
@prabhjyotsingh @felixcheung Please help review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1861: ZEPPELIN-1293. Livy Interpreter: Automatically attach ...

2017-01-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1861
  
@prabhjyotsingh @felixcheung Please help review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1447: [ZEPPELIN-1293] Re-create Livy session if it's lost

2017-01-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1447
  
@spektom Sorry, I didn't get your reply, I create another PR for it #1861 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1861: ZEPPELIN-1293. Livy Interpreter: Automatically ...

2017-01-06 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1861

ZEPPELIN-1293. Livy Interpreter: Automatically attach or create to a new 
session


### What is this PR for?
By default, livy session will expire after one hour. This PR would create 
session automatically for user if session is expired, and would also display 
the session expire information in frontend. The expire message would only 
display at the first time of session recreation, after that the message won't 
be displayed. 


### What type of PR is it?
[Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1293

### How should this be tested?
Tested manually. 

![2017-01-06_1903](https://cloud.githubusercontent.com/assets/164491/21716129/7fdab630-d443-11e6-9901-39130c3b1caf.png)


### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1293

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1861


commit 852f9829df58dce0dfb1ee78460884722a170b2b
Author: Jeff Zhang 
Date:   2017-01-06T11:05:38Z

ZEPPELIN-1293. Livy Interpreter: Automatically attach or create to a new 
session




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2017-01-06 Thread zjffdu
GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1765

[WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build

### What is this PR for?
Add more logging as I could not reproduce it locally. 


### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1761

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1765


commit 5cce03cdb7a637f97b6771cce4d9de524a315a87
Author: Jeff Zhang 
Date:   2016-12-15T07:29:07Z

ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2017-01-06 Thread zjffdu
Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/1765


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1854: [ZEPPELIN-1912] fix: Improve perosnalized mode tooltip...

2017-01-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1854
  
LGTM!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1848: [ZEPPELIN-1812] Ace editor show/hide problem.

2017-01-06 Thread cloverhearts
GitHub user cloverhearts reopened a pull request:

https://github.com/apache/zeppelin/pull/1848

[ZEPPELIN-1812] Ace editor show/hide problem.

### What is this PR for?
When editor hide is on and page refresh then editor is gone.
I was solve this problem.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1812

### How should this be tested?
1. hide to editor mode on in paragraph configure.
2. page refresh (f5)
3. enable to show editor mode in paragraph configure.
4. if show editor then is correct.
### Screenshots (if appropriate)
 before

![badeditor](https://cloud.githubusercontent.com/assets/10525473/21677078/62136de2-d2ed-11e6-9418-0be4453fd839.gif)

 after

![goodeditor](https://cloud.githubusercontent.com/assets/10525473/21677092/6c8d97e8-d2ed-11e6-8966-a3b7af60c231.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-1812

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1848.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1848


commit b7cd700eccfd2ed51f29c17285bad36579c02208
Author: cloverhearts 
Date:   2017-01-05T10:09:38Z

fixed ace editor hide problem

commit 037993d23257b31836ad59d8805540d30dd1c420
Author: cloverhearts 
Date:   2017-01-06T04:09:33Z

fixed test case

commit c3efea2b93ce2defcf822ef380b5f66cc349c81a
Author: cloverhearts 
Date:   2017-01-06T05:25:26Z

Revert "fixed test case"

This reverts commit 037993d23257b31836ad59d8805540d30dd1c420.

commit 4750e6fce66e95265f2eea1ad45672a673ccd2a9
Author: cloverhearts 
Date:   2017-01-06T08:39:22Z

fix testcase

commit d10d53d6c578d4f0749402a38c9e9337fb68e702
Author: cloverhearts 
Date:   2017-01-06T08:42:06Z

add element null check

commit 9c5ee63e3217e25d92080101cd21baff542ec113
Author: cloverhearts 
Date:   2017-01-06T09:22:46Z

add size check




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1848: [ZEPPELIN-1812] Ace editor show/hide problem.

2017-01-06 Thread cloverhearts
Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/1848


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1858: [ZEPPELIN-1229] Clear browser cache with version hasht...

2017-01-06 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1858
  
@corneadoug I updated screenshot and codes.
Could you help to review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1854: [ZEPPELIN-1912] fix: Improve perosnalized mode tooltip...

2017-01-06 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1854
  
more intuitive this way, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1860: [ZEPPELIN-1848] add option for S3 KMS key regio...

2017-01-06 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/1860

[ZEPPELIN-1848] add option for S3 KMS key region

### What is this PR for?
When using S3 storage layer with encryption keys, currently only keys 
created in `us-east-1` region can be used. This PR adds ability to set target 
region for AWS KMS keys.


### What type of PR is it?
Improvement

### Todos
* [x] - add region to awsClient 
* [x] - add conf for region
* [x] - tested with aws account `us-west-2` region

### What is the Jira issue?
[ZEPPELIN-1848](https://issues.apache.org/jira/browse/ZEPPELIN-1848)

### How should this be tested?
1. set up S3 storage as in 
[here](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#notebook-storage-in-s3)
2. add region variable with `export 
ZEPPELIN_NOTEBOOK_S3_KMS_KEY_REGION="us-west-2"` in `conf/zeppelin-env.sh`
3.  start Zeppelin and read/write S3

### Screenshots (if appropriate)

![kmc_region](https://cloud.githubusercontent.com/assets/1642088/21712912/0a79ee66-d3ac-11e6-8ba4-1e7f081f213f.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? updated


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/s3-repo-kms-region

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1860


commit da14298570ac6dbc3bbea7bc06a56f4ba1e456a3
Author: Khalid Huseynov 
Date:   2017-01-06T08:41:00Z

add property to ZeppelinConfiguration

commit 311019303216668b32a510761273dcdf8c5fe6e4
Author: Khalid Huseynov 
Date:   2017-01-06T08:41:40Z

add crypt conf to s3 repo

commit d5808cd73fd0c0c36c92ab72f8ebe79994fb2d83
Author: Khalid Huseynov 
Date:   2017-01-06T08:42:58Z

add env vars to .sh

commit 929d4017abcd7b715b99ff32617d445c3585c646
Author: Khalid Huseynov 
Date:   2017-01-06T08:43:23Z

add property to .site

commit 303f16d2b432bd15753be70bdbb3f4661102de9f
Author: Khalid Huseynov 
Date:   2017-01-06T09:02:10Z

add documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1859: ZEPPELIN-1432. Support cancellation of paragrap...

2017-01-06 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1859

ZEPPELIN-1432. Support cancellation of paragraph execution

### What is this PR for?
Livy 0.3 support cancel operation, this PR is to support cancel in livy 
interpreter. First we would check the livy version, then based on the livy 
version, we would call the livy rest api to cancel the statement. 


### What type of PR is it?
 Improvement | Feature ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1432

### How should this be tested?
Tested manually, because cancel is only avaible in livy 0.3 which is not 
released yet. 

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/21712520/3ed292ec-d430-11e6-8829-581e1bba1a9c.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1432

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1859


commit f1ace29d514d15afcdfe4d0e7f0cf9984bb67829
Author: Jeff Zhang 
Date:   2016-12-26T02:06:01Z

ZEPPELIN-1432. Support cancellation of paragraph execution




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1854: [ZEPPELIN-1912] fix: Improve perosnalized mode tooltip...

2017-01-06 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1854
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1858: [ZEPPELIN-1229] Clear browser cache with versio...

2017-01-06 Thread astroshim
GitHub user astroshim opened a pull request:

https://github.com/apache/zeppelin/pull/1858

[ZEPPELIN-1229] Clear browser cache with version hashtag.

### What is this PR for?
This PR avoids browser cache.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1229

### How should this be tested?
1. Run old version of zeppelin and show main page up in your browser.
2. Stop zeppelin.
3. Run this PR and show page up on the same browser with 1.
4. check main page changed.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1229

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1858


commit 9d9f76f415e5b29c35b387cf1dcac889272b7503
Author: astroshim 
Date:   2017-01-06T08:14:35Z

fix ZEPPELIN-1229

commit c94de90832645da674bd2f1df2d4f7ddea1e14bf
Author: astroshim 
Date:   2017-01-06T08:15:53Z

delete unnecessary codes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1838: [ZEPPELIN-1832] Fixed a bug in zombie process when Zep...

2017-01-06 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1838
  
That's sounds good! I agree with @cloverhearts. 
In my opinion, first of all, the zombie process problem is very important 
so must be removed as soon as possible. Then we must gradually resolve other 
things!

Anyway, I tested again, it works as expected :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1857: [ZEPPELIN-1874] fix: sparkR doens't render outp...

2017-01-06 Thread 1ambda
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1857

[ZEPPELIN-1874] fix: sparkR doens't render output properly

### What is this PR for?

Zeppelin sparkr only shows first element of all outputs due to invalid 
implementation

```scala
// 
https://github.com/apache/zeppelin/blob/master/spark/src/main/scala/org/apache/zeppelin/spark/ZeppelinRDisplay.scala#L71

private def textDisplay(body: Element): RDisplay = {
  // we are extracting only the first element. it shouldn't
  RDisplay(body.getElementsByTag("p").first().html(), TEXT, SUCCESS)
}
```

 Details

SparkR interpreter send message which containing multiple whitespaces, 
newlines. But zeppelin frontend breaks the space characters. This should be 
handled by other issue. As you can see the screenshot below, the result sent 
from websocket keeps whitespaces and newlines until rendering.

https://cloud.githubusercontent.com/assets/4968473/21711367/f11d7c72-d431-11e6-8b6b-e4b7cc603afb.png;>


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?

[ZEPPELIN-1874](https://issues.apache.org/jira/browse/ZEPPELIN-1874)

### How should this be tested?

1. Build Zeppelin with Spark 2.0+, R, sparkR
2. Execute this paragraph

```
%spark.r
mtcarsDF <- createDataFrame(mtcars)
model <- glm(vs ~ mpg + disp + hp + wt , data = mtcarsDF, family = 
"binomial")
summary(model)
``` 

3. Check you can get all result. 

```
Deviance Residuals:
(Note: These are approximate quantiles with relative error = 0.01)
Min 1Q Median 3Q Max
-2.11025 -0.08567 -0.00069 0.13214 1.10483
Coefficients:
Estimate Std. Error t value Pr(|t|)
(Intercept) -23.623 23.144 -1.0207 0.30739
mpg 0.78475 0.65026 1.2068 0.2275
disp -0.031549 0.027342 -1.1539 0.24854
hp -0.072188 0.045509 -1.5862 0.11269
wt 7.335 5.2336 1.4015 0.16105
(Dispersion parameter for binomial family taken to be 1)
Null deviance: 43.860 on 31 degrees of freedom
Residual deviance: 12.873 on 27 degrees of freedom
AIC: 22.87
Number of Fisher Scoring iterations: 9
```

### Screenshots (if appropriate)

Buggy (doesn't show full result)

https://cloud.githubusercontent.com/assets/4968473/21711437/723f00be-d432-11e6-9701-1bcd81f86fb7.png;>


### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-1874/sparkr-doesnot-render-all-output

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1857


commit 779b82f590aab04f9b2053295e573a63d39ec5fd
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-06T07:52:28Z

fix: sparkR doens't render output properly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---