[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-31 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1804 Thanks @Leemoonsoo for check it! You're right, I saw your issue not only my branch but also current master branch. both didn't work `homescreen`. I fixed this problem and CI is green

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-31 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1804 I agree with you. Let me create jira and solve this issue after merging. Thank you @Leemoonsoo and @AhyoungRyu --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #1804: [ZEPPELIN-1578] notes list in customizing zeppe...

2017-01-31 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1804 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-31 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1804 Thanks @AhyoungRyu for the delicate review :smile: I just updated as your comment! Could you review again, please? --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin pull request #1804: [ZEPPELIN-1578] notes list in customizing zeppe...

2017-01-31 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1804 [ZEPPELIN-1578] notes list in customizing zeppelin homepage isn't working ### What is this PR for? Customizing the Zeppelin Homepage to show the notebook list does not work as [0.6.2

[GitHub] zeppelin pull request #1966: [ZEPPELIN-2039] Upgrade safe_yaml version in gh...

2017-02-01 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1966 [ZEPPELIN-2039] Upgrade safe_yaml version in gh-page ### What is this PR for? This PR will fix some problem which I faced when starting the gh-page server like the following code

[GitHub] zeppelin issue #1966: [ZEPPELIN-2039] Upgrade safe_yaml version in gh-page

2017-02-01 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1966 I realized my branch is wrong. I closed this pr. Sorry for confusing :disappointed_relieved: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin pull request #1983: [ZEPPELIN-1808] disable shortcut key of window ...

2017-02-06 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1983 [ZEPPELIN-1808] disable shortcut key of window created by link this paragraph ### What is this PR for? If using a `Link this paragraph`, new window works the keyboard shortcut. Keyboard

[GitHub] zeppelin pull request #1984: [HOTFIX] Change the screenshot path in custome ...

2017-02-06 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1984 [HOTFIX] Change the screenshot path in custome page document ### What is this PR for? After merging [PR1804](https://github.com/apache/zeppelin/pull/1804), the following screenshot path

[GitHub] zeppelin issue #1984: [HOTFIX] Change the screenshot path in custom page doc...

2017-02-06 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1984 Thanks @AhyoungRyu for quick review! :smiley_cat: (and Sorry for that I missed your comment before) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1983: [ZEPPELIN-1808] disable shortcut key of window ...

2017-02-07 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1983 [ZEPPELIN-1808] disable shortcut key of window created by link this paragraph ### What is this PR for? If using a `Link this paragraph`, new window works the keyboard shortcut

[GitHub] zeppelin pull request #1983: [ZEPPELIN-1808] disable shortcut key of window ...

2017-02-07 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1983 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1984: [HOTFIX] Change the screenshot path in custom p...

2017-02-07 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1984: [HOTFIX] Change the screenshot path in custom p...

2017-02-07 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1984 [HOTFIX] Change the screenshot path in custom page document ### What is this PR for? After merging [PR1804](https://github.com/apache/zeppelin/pull/1804), the following screenshot path

[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode

2017-02-02 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1892 @1ambda I updated to extract `require('express')` module as variable and CI is green :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #1990: [ZEPPELIN-2072] Home Screen doesn't work on shi...

2017-02-08 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1990 [ZEPPELIN-2072] Home Screen doesn't work on shiro. ### What is this PR for? The home screen is a notebook for use as homepage. It is the zeppelin.notebook.homescreen variable in `conf

[GitHub] zeppelin issue #1984: [HOTFIX] Change the screenshot path in custom page doc...

2017-02-07 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1984 @AhyoungRyu Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-23 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1804 Ping! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin issue #1932: [ZEPPELIN-2000] Run paragraph on enter when select dyn...

2017-01-23 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1932 LGTM! Tested as described and it worked very well. ![z2000_a](https://cloud.githubusercontent.com/assets/8110458/22195973/01e07d98-e18e-11e6-928b-1a63d29443e6.gif) --- If your project

[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...

2017-01-23 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1833 Tested and it works very well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1942: [ZEPPELIN-1982] When using the 'Select * ...' statemen...

2017-01-25 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1942 Thank @del680202 for fixing this bug! I just tested it out and this problem works well. But, some existing sample paragraphs have the following problems. ![image](https

[GitHub] zeppelin issue #1943: [HOTFIX][ZEPPELIN-2011] Add lib/interpreter to classpa...

2017-01-25 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1943 Tested and it was working well, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1893: [ZEPPELIN-451] Save codes and messages as multi-line

2017-01-25 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1893 Thank @sixmen for improving this. It's very good feature! I think sudden changes, part of importing notebook, will make users uncomfortable. In my opinion, both old version notebook

[GitHub] zeppelin issue #1942: [ZEPPELIN-1982] When using the 'Select * ...' statemen...

2017-01-25 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1942 @del680202 I tested this again and I can't the above error in chrome. It's working well now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1804 Thanks @Leemoonsoo for review this! Yeah, it's make sense! I just updated filename, screenshot, description for this PR as well. --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...

2017-02-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1983 Hi @Leemoonsoo, I opened two issue as your comment (#2045, #2054) so it would be nice if you could check some PRs. Furthermore this CI is green now :) --- If your project is set up

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

2017-02-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2054 @1ambda Thanks for taking a look this! Regarding text layout, I don't consider left-pending because it already fixed #1983. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2053: [ZEPPELIN-1964] Layout info is lost after refresh

2017-02-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2053 Thanks @astroshim for fixing this! Tested and it works well like below! LGTM :+1: ![z_1964_a_check](https://cloud.githubusercontent.com/assets/8110458/23209270/f03b3acc-f93b-11e6-9b28

[GitHub] zeppelin pull request #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "L...

2017-02-20 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2045 [ZEPPELIN-2112] Disable keyboard shortcut in "Link this paragraph" URL on 0.7.0 version ### What is this PR for? If using a `Link this paragraph`, new window works the keyboar

[GitHub] zeppelin pull request #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "L...

2017-02-20 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2045 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "L...

2017-02-20 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2045 [ZEPPELIN-2112] Disable keyboard shortcut in "Link this paragraph" URL on 0.7.0 version ### What is this PR for? If using a `Link this paragraph`, new window works the keyboar

[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...

2017-02-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1983 Thanks @Leemoonsoo for taking care of this PR and testing it out :) Sure, Let me separate and create two issues that are branch-0.7 and shape of window. --- If your project is set up

[GitHub] zeppelin pull request #2000: [gh-pages] update contribution/webapplication.h...

2017-02-09 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2000 [gh-pages] update contribution/webapplication.html ### What is this PR for? This PR is for matching current web environment. I changed `dev mode` part from `./grunt serve` to `yarn run

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

2017-02-09 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2000 Hi~ @AhyoungRyu @1ambda I updated this as your comment! Thanks for that could you review again, please? :smiley: --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #1998: [ZEPPELIN-2070][DOCS] Create Docs for Spell

2017-02-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1998 Thanks for considering my comment! LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...

2017-02-12 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1983 @Leemoonsoo Could you review this PR as JIRA issue reporter? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #2013: [ZEPPELIN-2091] Disable add/remove operations i...

2017-02-13 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2013 [ZEPPELIN-2091] Disable add/remove operations in the window of Link this paragraph ### What is this PR for? When a paragraph is added or deleted from a note, the window which is created

[GitHub] zeppelin issue #1990: [ZEPPELIN-2072] Home Screen doesn't work on shiro.

2017-02-09 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1990 Thanks for taking care of @Leemoonsoo :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode

2017-01-18 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1892 @minahlee I updated and resolved another way. When web application develop mode, the source base of production mode is different to web application develop mode. So, I updated to correct

[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port

2017-02-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2073 Thanks for review @AhyoungRyu @1ambda @felixcheung! And I updated to remove `.` :smile: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...

2017-02-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2076 @r-kamath Thanks for fixing this issue! Let me check and give a feedback soon :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

2017-02-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2054 @prabhjyotsingh Thanks for review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...

2017-02-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2054 @1ambda Thanks for review :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #2076: ZEPPELIN-2173 Duplicate user names populated in the No...

2017-02-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2076 Tested and It works well as that remove duplication name. But, In my personal opinion, I'd like to suggest that It would be better to show it in its original state. For example, if user

[GitHub] zeppelin issue #2045: [ZEPPELIN-2112] Disable keyboard shortcut in "Link thi...

2017-03-02 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2045 Ping! @Leemoonsoo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #2073: [ZEPPELIN-2130][Doc]Do not use web development ...

2017-03-02 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2073 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port

2017-03-02 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2073 CI is [green](https://travis-ci.org/soralee/zeppelin/builds/206890162) but Jenkins is failed. So I reopen this PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin pull request #2073: [ZEPPELIN-2130][Doc]Do not use web development ...

2017-03-02 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2073 [ZEPPELIN-2130][Doc]Do not use web development port ### What is this PR for? If user uses web application development port such like 9000 which is default value, Zeppelin is not working

[GitHub] zeppelin pull request #2073: ZEPPELIN-2130_do_not_use_webDebPort

2017-02-26 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2073 ZEPPELIN-2130_do_not_use_webDebPort ### What is this PR for? If user uses web application development port such like 9000 which is default value, Zeppelin is not working because

[GitHub] zeppelin issue #2073: [ZEPPELIN-2130][Doc]Do not use web development port

2017-02-26 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2073 @AhyoungRyu I just updated that sentence as your describe. could you check again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

2016-11-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1684 @marchpig Thanks for this contribution! I tested it on Ubuntu and It works well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

2016-11-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1686 @1ambda Thanks for sharing issue!! I guess `CTRL+L` short key is being used by some ace editor users. So, I removed `CTRL-ALT-L` key binding and I changed **Clear output** short

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

2016-11-27 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1686 @1ambda Thanks for suggestion. :smile: I tried that but current `CTRL+L` short key is already worked by editor(ace) as the following picture. ![screenshot from 2016-11-28 11-27-57

[GitHub] zeppelin pull request #1686: [ZEPPELIN-1686] Added clear the output to a key...

2016-11-26 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1686 [ZEPPELIN-1686] Added clear the output to a keyboard shortcut ### What is this PR for? This PR Added clear the output of paragraph to a keyboard shortcut. ### What type of PR

[GitHub] zeppelin issue #1693: [ZEPPELIN-1695] chore: Set xml plugin phase to verify ...

2016-11-28 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1693 Thanks @1ambda for the contribution :smile: I tested on Ubuntu and it works well as expected ``` --- T E S T S

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

2016-11-28 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1686 Thanks for review @AhyoungRyu @Leemoonsoo, and could you check this PR again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1517: [MINOR] ui improvement

2016-10-14 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1517 Looks good to me It's very clear :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-07 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1736 [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut ### What is this PR for? Currently, keyboard shortcuts can be only seen by keyboard icon. It'll be very comfortable

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1756 [ZEPPELIN-1804] Added "Link this paragraph" to keyboard shortcut ### What is this PR for? Each paragraph menu, it has "Link this paragraph" function which is link e

[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...

2016-12-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 @AhyoungRyu I appreciate to your information! I think I already fixed ParagraphActionsIT.java file. But, each time I tested the CI, the build operation failed differently. So I just wondered

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-13 Thread soralee
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1756 [ZEPPELIN-1804] Added "Link this paragraph" to keyboard shortcut ### What is this PR for? Each paragraph menu, it has "Link this paragraph" function which is link e

[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...

2016-12-13 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Regarding `Link this paragraph `shortcut key, I just created this issue. (#1736) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-13 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1736 [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut ### What is this PR for? Currently, keyboard shortcuts can be only seen by keyboard icon. It'll be very comfortable

[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-13 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1756 [ZEPPELIN-1804] Added "Link this paragraph" to keyboard shortcut ### What is this PR for? Each paragraph menu, it has "Link this paragraph" function which is link e

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1756 [ZEPPELIN-1804] Added "Link this paragraph" to keyboard shortcut ### What is this PR for? Each paragraph menu, it has "Link this paragraph" function which is link e

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added Link this paragraph to ke...

2016-12-14 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1756 [ZEPPELIN-1804] Added "Link this paragraph" to keyboard shortcut ### What is this PR for? Each paragraph menu, it has "Link this paragraph" function which is link e

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added "Link this paragraph" to ...

2016-12-14 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1756: [ZEPPELIN-1804] Added Link this paragraph to ke...

2016-12-14 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1756 [ZEPPELIN-1804] Added Link this paragraph to keyboard shortcut ### What is this PR for? Each paragraph menu, it has "Link this paragraph" function which is link each of the

[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-14 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1756 @tae-jun Sorry for many reopened PR. I had a weird CI problem like the link (https://travis-ci.org/apache/zeppelin/builds/183881539). But I solved with recommit PR. Now, CI fail again

[GitHub] zeppelin issue #1771: [ZEPPELIN-1820] Fix action bar layout broken issue

2016-12-15 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1771 Tested and It works well! LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-13 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1736 [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut ### What is this PR for? Currently, keyboard shortcuts can be only seen by keyboard icon. It'll be very comfortable

[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-13 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-15 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1756 Finally, the CI is GREEN! (After about 7 attempts) :sob: It's time to ready to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin issue #1768: [DOCS] Separate "interpreter exec hooks (experimental)...

2016-12-15 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1768 @AhyoungRyu Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...

2016-12-15 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1756 @Leemoonsoo @AhyoungRyu Thanks for review :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1834 [ZEPPELIN-1864] Improvement to show folder and note after searching note ### What is this PR for? This PR is for improvement to show folder and note after using the filter. And I found

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1834 [ZEPPELIN-1864] Improvement to show folder and note after searching note ### What is this PR for? This PR is for improvement to show folder and note after using the filter. And I found

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1871: ZEPPELIN-1862 Move packages related Helium into a new ...

2017-01-10 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1871 Tested and it works well :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1842: [ZEPPELIN-1619] Load js package as a plugin visualizat...

2017-01-10 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1842 And when I test npm online package for using bubble chart, It works very well! ![z1842_b](https://cloud.githubusercontent.com/assets/8110458/21835960/94d69aee-d804-11e6-8b4f-8b51c0bf72cc.gif

[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-10 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1879 @cloverhearts I'd like to test this. could you resolve some conflict file? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-10 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1834 [ZEPPELIN-1864] Improvement to show folder and note after searching note ### What is this PR for? This PR is for improvement to show folder and note after using the filter. And I found

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-10 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1834 [ZEPPELIN-1864] Improvement to show folder and note after searching note ### What is this PR for? This PR is for improvement to show folder and note after using the filter. And I found

[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1879 Tested and it works well :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...

2017-01-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1834 Thank you @AhyoungRyu :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1879 @cloverhearts Thank you :+1: Let me test it out and I'll comment this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #1842: [ZEPPELIN-1619] Load js package as a plugin visualizat...

2017-01-10 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1842 It's very cool feature! Tested and It works very nice like below. **[Test result]** When I clicked `Enable` button for using `zeppelin_horizontalbar` visualization package

[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...

2017-01-10 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1834 @AhyoungRyu Yes, you're right. I mean, If I change **navbar** folder option, it works together both the filter in the **home** and **navbar**. So, I did not include this part because I think

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1834 [ZEPPELIN-1864] Improvement to show folder and note after searching note ### What is this PR for? This PR is for improvement to show folder and note after using the filter. And I found

[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

2016-11-29 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1630 @tae-jun This is Cool! and It works well! So, I suggest one thing. I think it would be nice to appear popup which is whether user will merge the folders or not before merging folders. In my

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

2016-11-30 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1686 @AhyoungRyu Thanks for guidance. Okay, Let me notify you after updating PR description. And my JIRA username is `sora`. --- If your project is set up for it, you can reply to this email

  1   2   3   4   >