[GitHub] zeppelin issue #3265: [ZEPPELIN-3910] IPython delete temp file and close str...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3265 LGTM ---
[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3266 LGTM ---
[GitHub] zeppelin issue #3269: [ZEPPELIN-3911] Move the scrollbar automatically when ...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3269 @HsuanXyz Thanks for the contribution, looks like the travis fails due to code style check. You can get these errors by running `mvn package -DskipTests -pl zeppelin-web` ---
[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3266 @xueyumusic Thanks for the contribution, we can make it as subtask of ZEPPELIN-3913. BTW I am curious to know whether you are using flink in zeppelin ? If yes, could you share more details ? Because currently I am doing some improvement on flink interpreter and try to provide better user experience for flink users. ---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 @monsieurp Is `Patrice Clement` your jira account ? I'd like to assign this ticket to you. ---
[GitHub] zeppelin pull request #3199: ZEPPELIN-3792. Support Kerberos Realm
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/3199 ---
[GitHub] zeppelin pull request #3263: ZEPPELIN-3907. Add code statement into Spark Jo...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3263 ZEPPELIN-3907. Add code statement into Spark JobGroup Id for SparkInterpreter ### What is this PR for? Straightforward change to add code statement into Spark JobGroupId, so that we can find the associated spark job in spark ui easier. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3907 ### How should this be tested? * Manually tested. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3907 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3263 commit 9c1d3ccd25287259578785ea23e329fdcedab700 Author: Jeff Zhang Date: 2018-12-13T08:22:33Z ZEPPELIN-3907. Add code statement into Spark JobGroup Id for SparkInterpreter ---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 Thanks @monsieurp Could you also delete `common.max_count` from `interpreter-setting.json` and test code ? ---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 It is weird that I see another property `common.max_count` but it is never used in `JdbcInterpreter`. I think we just need to keep one and remove others. Personally I prefer `zeppelin.jdbc.maxRows` ---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 ping @monsieurp ---
[GitHub] zeppelin issue #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3249 Thanks @OrDTesters LGTM ---
[GitHub] zeppelin issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and D...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3244 @conker84 #3243 is fixed, could you rebase this PR ? ---
[GitHub] zeppelin issue #3226: [ZEPPELIN-3095] fix UI when paragraphs run sequential
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3226 @Savalek I have merged it into master, could you create another PR for branch-0.8 if you'd like to merge it into branch-0.8 as well ? ---
[GitHub] zeppelin issue #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3249 @OrDTesters What do you mean "run on its own" ? Do you mean to run it in IDE ? ---
[GitHub] zeppelin issue #3234: ZEPPELIN-3876. Unable to rename note
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3234 Test is added, will merge it no more comments ---
[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3033 Thanks @HyukjinKwon feel free to take over this ---
[GitHub] zeppelin issue #3226: [ZEPPELIN-3095] fix UI when paragraphs run sequential
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3226 LGTM, merge if more comments ---
[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3245 @liuxunorg This is the change what I suggest https://github.com/zjffdu/zeppelin/commit/29593d74bac17f124e97fc43a4942e3365a12ed7 Could you verify whether it solve this issue ? ---
[GitHub] zeppelin issue #3245: [ZEPPELIN-3893] Bug Fix that clear paragraphs when exe...
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3245
Hi @liuxunorg I would prefer to add another method
```
public boolean runParagraph(String noteId,
String paragraphId,
Map params,
Map config,
boolean failIfDisabled,
boolean blocking,
ServiceContext context,
ServiceCallback callback) throws
IOException {
```
which would delegate to existing runParagraph method.
This is more clean for me.
---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 @monsieurp I though about it again, and feel that providing 2 properties is very confusing to users. I think it is better to give one property (zeppelin.jdbc.maxRows) what is user care about. `zeppelin.jdbc.rowsFetchSize` is internal property that zeppelin should configure to users. Here's one post explain the difference between `setFetchSize` and `setMaxRows` https://stackoverflow.com/questions/32399546/what-is-the-difference-between-statement-setmaxrows-vs-statement-setfetchsize-in?lq=1 ---
[GitHub] zeppelin issue #3226: [ZEPPELIN-3095] fix UI when paragraphs run sequential
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3226 @Savalek Could you remove `ZP-25` from commit message ? ---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 @monsieurp Could you do a rebase and retrigger the travis build ? ---
[GitHub] zeppelin issue #3226: [ZEPPELIN-3095] fix UI when paragraphs run sequential
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3226 @Savalek Could you resolve the conflicts ? ---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 @monsieurp This might be flaky test, let me take a look at it. ---
[GitHub] zeppelin issue #3239: Zeppelin 3879: create "maxRows" and "rowsFetchSize" va...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3239 Thanks @monsieurp for the contribution, I left a few comments, otherwise LGTM ---
[GitHub] zeppelin issue #3226: [ZEPPELIN-3095][ZP-25] fix UI when paragraphs run sequ...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3226 @Savalek Could you remove `ZP-25` from PR title ? ---
[GitHub] zeppelin pull request #3238: ZEPPELIN-3870. Configuration in spark-defaults....
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3238 ZEPPELIN-3870. Configuration in spark-defaults.conf doesn't take effect ### What is this PR for? This is due to another version of kryo in zeppelin-interpreter-api, this PR just exclude this and also add test to avoid regression. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3871 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3238 commit b6c001764c84e8c59dabd559c05b4c0f95624b47 Author: Jeff Zhang Date: 2018-11-21T06:17:15Z ZEPPELIN-3870. Configuration in spark-defaults.conf doesn't take effect when it is empty in interpreter setting ---
[GitHub] zeppelin pull request #3237: ZEPPELIN-3871. Spark interpreter doesn't work w...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3237 ZEPPELIN-3871. Spark interpreter doesn't work with KryoSerializer ### What is this PR for? This is due to another version of kryo in zeppelin-interpreter-api, this PR just exclude this and also add test to avoid regression. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3871 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3871 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3237.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3237 commit fac84d46949d24f5b950a1907df8b8a87447f6be Author: Jeff Zhang Date: 2018-11-21T07:31:27Z ZEPPELIN-3871. Spark interpreter doesn't work with KryoSerializer ---
[GitHub] zeppelin pull request #3234: ZEPPELIN-3876. Unable to rename note
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3234 ZEPPELIN-3876. Unable to rename note ### What is this PR for? This is trivial PR for fixing the issue of unable to rename note. The root cause is that the notePath may has 2 leading `/` which cause the error. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3876 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3876 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3234.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3234 commit e94ea7c37cd11f459cf57cfa1b7ae6475aa48b9c Author: Jeff Zhang Date: 2018-11-21T23:54:52Z ZEPPELIN-3876. Unable to rename note ---
[GitHub] zeppelin issue #3232: [ZEPPELIN-3838] Input function example code incorrect ...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3232 LGTM ---
[GitHub] zeppelin issue #3233: [ZEPPELIN-3875] Groups are not derived when using Acti...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3233 ping @prabhjyotsingh ---
[GitHub] zeppelin issue #3227: [ZEPPELIN-3863][ZP-63] fix collaborative mode
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3227 LGTM ---
[GitHub] zeppelin issue #3229: [ZEPPELIN-3869] Close interpreters in multithreaded mo...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3229 LGTM ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 I will try to do it by the end of 2018 ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 It is merged to branch-0.8 and master branch. So yes it will be released in zeppelin 0.9.0, but I believe 0.8.1 will be released before zeppelin 0.9.0 ---
[GitHub] zeppelin issue #3230: [ZEPPELIN-3847] Duplicate results in notebooks due to ...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3230 LGTM ---
[GitHub] zeppelin pull request #3228: ZEPPELIN-3865. Paragraph cancel is broken
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3228 ZEPPELIN-3865. Paragraph cancel is broken ### What is this PR for? Paragraph cancel is broken due to previous code refactoring, This PR fix it in straightforward way and add system test as well. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3865 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3865 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3228 commit 140c8bb93123e5261d0aec2247192d14db1e147d Author: Jeff Zhang Date: 2018-11-16T05:16:26Z ZEPPELIN-3865. Paragraph cancel is broken ---
[GitHub] zeppelin issue #3222: ZEPPELIN-3815. No interpreter group name in spark inte...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3222 Will merge if no more comments ---
[GitHub] zeppelin issue #3223: ZEPPELIN-3822. All interpreter folders (ZEPPELIN_HOME/...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3223 Will merge if no more comments ---
[GitHub] zeppelin pull request #3223: ZEPPELIN-3822. All interpreter folders (ZEPPELI...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3223 ZEPPELIN-3822. All interpreter folders (ZEPPELIN_HOME/interpreter) are deleted when maven clean is invoked ### What is this PR for? This PR is to fix the bug that `ZEPPELIN_HOME`/interpreter folder is always deleted when maven clean is invoked for module `zeppelin`. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3822 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3822 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3223 commit da4773dfe8fd8ae3254bcfe257adc4430ed6e09c Author: Jeff Zhang Date: 2018-11-12T03:32:37Z ZEPPELIN-3822. All interpreter folders (ZEPPELIN_HOME/interpreter) are deleted when maven clean is invoked ---
[GitHub] zeppelin pull request #3222: ZEPPELIN-3815. No interpreter group name in spa...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3222 ZEPPELIN-3815. No interpreter group name in spark interpreter log file ### What is this PR for? Trivial PR for fixing group name missing in spark interpreter log file ### What type of PR is it? [ Hot Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3815 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? NO * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3815 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3222.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3222 commit c1fee0326a1754abfe4dc0b8877e783c92ea19b3 Author: Jeff Zhang Date: 2018-10-17T13:04:48Z ZEPPELIN-3815. No interpreter group name in spark interpreter log file ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 CI is passed, will merge it if no more comments ---
[GitHub] zeppelin pull request #3221: ZEPPELIN-3858. Code completion doesn't work for...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3221 ZEPPELIN-3858. Code completion doesn't work for spark interpreter when cursor is in the middle of code ### What is this PR for? It is a trivial fix for the code completion of spark interpreter when the cursor is in the middle of code. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3858 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3221.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3221 commit 325888b529b8fdbc3c726fef08e82061b8ee39b1 Author: Jeff Zhang Date: 2018-11-09T09:25:04Z ZEPPELIN-3858. Code completion doesn't work for spark interpreter when cursor is in the middle of code ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 @HyukjinKwon I created one PR for you to add test for spark 2.4, would mind to merge that ? https://github.com/HyukjinKwon/zeppelin/pull/1 ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 Thanks for everyone, the only remaining thing is to update `.travis.yml` to make sure the test pass again spark 2.4 ---
[GitHub] zeppelin issue #3215: [ZEPPELIN-3167]
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3215 The unit test in `SparkRInterpreterTest` did cover the error case. We need to add this kind of unit test. ---
[GitHub] zeppelin issue #3220: ZEPPELIN-3846. Code Completion is broken
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3220 Merge if no more comments ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 That's correct, @dongjoon-hyun ---
[GitHub] zeppelin pull request #3220: ZEPPELIN-3846. Code Completion is broken
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3220 ZEPPELIN-3846. Code Completion is broken ### What is this PR for? Code completion is broken due to the shaded jar in zeppelin-interpreter-api, this PR fix this issue and also add unit test for it. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3846 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3846 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3220.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3220 commit 5cc385eeaa806cf4e9f1d70f7ce5840fff7fd975 Author: Jeff Zhang Date: 2018-11-02T06:02:47Z ZEPPELIN-3846. Code Completion is broken ---
[GitHub] zeppelin issue #3218: [ZEPPELIN-3849] display note name correctly.
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3218 Thanks @Leemoonsoo +1 ---
[GitHub] zeppelin issue #3215: [ZEPPELIN-3167]
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3215 Can you attach unit for it ? Add it to `SparkRInterpreterTest.java` ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 @HyukjinKwon I don't see the official announcement of spark 2.4 release. Zeppelin test also depends on the binary distribution of spark, so we have to wait for the official binary release of spark 2.4 ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 Awesome @HyukjinKwon Let's wait for spark 2.4 release ---
[GitHub] zeppelin issue #3210: [ZEPPELIN-3835] Update website for 0.8.0 release
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3210 LGTM ---
[GitHub] zeppelin issue #3209: ZEPPELIN-3818. Unit test failed: ZeppelinSparkClusterT...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3209 I will merge it soon as currently travis is broken ---
[GitHub] zeppelin pull request #3209: ZEPPELIN-3818. Unit test failed: ZeppelinSparkC...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3209 ZEPPELIN-3818. Unit test failed: ZeppelinSparkClusterTest.testAngularObjects ### What is this PR for? This is to fix the unit test failure of ZeppelinSparkClusterTest.testAngularObjects. It is due to the parsing logic bug in RemoteInterpreterUtils.java. Besides the fix, I also did some refactoring to add more logging. ### What type of PR is it? [Bug Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3818 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? NO * Does this needs documentation? NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3818 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3209 commit 8d462964e335e12551920b568a55fa45a414b80b Author: Jeff Zhang Date: 2018-10-26T06:58:21Z ZEPPELIN-3818. Unit test failed: ZeppelinSparkClusterTest.testAngularObjects ---
[GitHub] zeppelin pull request #3208: ZEPPELIN-3821. Yarn app is not killed after fli...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3208 ZEPPELIN-3821. Yarn app is not killed after flink interpreter is restarted ### What is this PR for? Trvial PR to shutdown cluster when flink shell is closed. ### What type of PR is it? [Hot Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3821 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3821 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3208 commit 8482bf31d0a01cba57ec471284e29dcb8af24ad4 Author: Jeff Zhang Date: 2018-10-23T09:37:14Z ZEPPELIN-3821. Yarn app is not killed after flink interpreter is restarted ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 Yesï¼ we need to support scala 2.11 for spark 2.4 first. And please also update travis.yml to build it with spark-2.4 profile ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3206 Thanks @HyukjinKwon Have you checked this PR (https://github.com/apache/zeppelin/pull/3034) for supporting scala 2.12 ---
[GitHub] zeppelin issue #3200: ZEPPELIN-3804. Separate log file for each interpreter ...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3200 Will merge if no more comments ---
[GitHub] zeppelin issue #3201: [ZEPPELIN-3805] Don't distribution shade jar to lib/in...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3201 It is not necessary to publish zeppelin-interpreter-api.jar to lib/interpreter. zeppelin interpreter api jar is already included to all interpreter jars under lib folder. ---
[GitHub] zeppelin pull request #3195: ZEPPELIN-3800. Allow to configure scheduler thr...
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/3195 ---
[GitHub] zeppelin issue #3195: ZEPPELIN-3800. Allow to configure scheduler thread poo...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3195 Will merge if no more comments ---
[GitHub] zeppelin issue #3196: ZEPPELIN-3800. Allow to configure scheduler thread poo...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3196 Will merge if no more comments ---
[GitHub] zeppelin issue #3200: ZEPPELIN-3804. Separate log file for each interpreter ...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3200 That's right @liuxunorg This is my plan, I'd like to show the log in the interpreter process monitoring page. ---
[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 @alonshoham Sorry I didn't notice you created the ticket, I have fixed via this commit, https://github.com/apache/zeppelin/commit/8b2f4a7bd89aa69661e09ef9ad73c04d862029ff Could you help verity it ? ---
[GitHub] zeppelin pull request #3200: ZEPPELIN-3804. Separate log file for each inter...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3200 ZEPPELIN-3804. Separate log file for each interpreter process ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3804 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3200 commit cc0ede55f83b42658975effaa95f52983be1399c Author: Jeff Zhang Date: 2018-10-01T09:09:36Z ZEPPELIN-3804. Separate log file for each interpreter process ---
[GitHub] zeppelin pull request #3199: ZEPPELIN-3792. Support Kerberos Realm
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3199 ZEPPELIN-3792. Support Kerberos Realm ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3792 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3199 commit f5fb6479e8a568c4c899f6f78237e81cda77e451 Author: Jeff Zhang Date: 2018-09-26T04:20:07Z ZEPPELIN-3792. Support Kerberos Realm ---
[GitHub] zeppelin pull request #3198: ZEPPELIN-3801. Code refactoring of org.apache.z...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3198 ZEPPELIN-3801. Code refactoring of org.apache.zeppelin.interpreter.remote ### What is this PR for? This PR is a refactoring PR which to refactor the code of package `org.apache.zeppelin.interpreter.remote`. * Remove `InterpreterClient`, and replace it with `RemoteInterpreterProcess`. * Use lambda function as possible as we can. ### What type of PR is it? [ Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3801 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3801 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3198 commit b886259e2dd30ce1bd59b4e87f6b58072d1b40e8 Author: Jeff Zhang Date: 2018-09-29T14:32:26Z ZEPPELIN-3801. Code refactoring of org.apache.zeppelin.interpreter.remote ---
[GitHub] zeppelin issue #3197: docs: fix punctuation
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3197 LGTM ---
[GitHub] zeppelin issue #3189: [ZEPPELIN-3758]. Convert old note file note.json to ne...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3189 Many classes are old existing code which I just rename them. e.g. `OldAzureNotebookRepo` is renamed from the old version of `AzureNotebookRepo` ---
[GitHub] zeppelin pull request #3193: [HOTFIX] Fix travis failure of branch-0.8
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/3193 ---
[GitHub] zeppelin pull request #3192: ZEPPELIN-3768. run all paragraphs sequential mo...
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/3192 ---
[GitHub] zeppelin pull request #3196: ZEPPELIN-3800. Allow to configure scheduler thr...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3196 ZEPPELIN-3800. Allow to configure scheduler thread pool size ### What is this PR for? This PR is for master branch. It just introduce new property `zeppelin.scheduler.threadpool.size` and allow user to customize it in zeppelin-site.xml. ### What type of PR is it? [ Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3800 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3800-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3196 commit 4e926d44b044aa3c3f8cdb78ceae90089d1c7011 Author: Jeff Zhang Date: 2018-09-28T08:48:21Z ZEPPELIN-3800. Allow to configure scheduler thread pool size ---
[GitHub] zeppelin pull request #3195: ZEPPELIN-3800. Allow to configure scheduler thr...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3195 ZEPPELIN-3800. Allow to configure scheduler thread pool size ### What is this PR for? This PR is for branch-0.8. It just introduce new property `zeppelin.scheduler.threadpool.size` and allow user to customize it in zeppelin-site.xml. ### What type of PR is it? [ Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3800 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3800 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3195 commit 6420f13ce2822101defc70b1e0f097df85b23014 Author: Jeff Zhang Date: 2018-09-28T08:45:58Z ZEPPELIN-3800. Allow to configure scheduler thread pool size ---
[GitHub] zeppelin issue #3188: ZEPPELIN-3791: Bump-Up shiro version from 1.3.2 to 1.4...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3188 Thanks @ajaygk95 LGTM ---
[GitHub] zeppelin pull request #3194: ZEPPELIN-3790. Move common interpreter dependen...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3194 ZEPPELIN-3790. Move common interpreter dependencies into zeppelin-interpreter-parent ### What is this PR for? This is refactoring PR which move common dependencies into zeppelin-interpreter-parent ### What type of PR is it? [Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3790 ### How should this be tested? * Ci pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3790 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3194 commit e4baa595e3d3072741dc30be4ab7000328f12ff7 Author: Jeff Zhang Date: 2018-09-25T09:37:58Z ZEPPELIN-3790. Move common interpreter dependencies into zeppelin-interpreter-parent commit 6229698ace4a1d58178e2a1a9310e14c73bdb9c4 Author: Jeff Zhang Date: 2018-09-28T01:27:57Z move junit to zeppelin-interpreter-parent ---
[GitHub] zeppelin issue #3183: [ZEPPELIN-3610] Cluster Raft module design
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3183 LGTM, will merge if no more comments ---
[GitHub] zeppelin pull request #3193: [HOTFIX] Fix travis failure of branch-0.8
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3193 [HOTFIX] Fix travis failure of branch-0.8 ### What is this PR for? This is for fixing the travis failure of branch-0.8 ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * No jira created ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin fix_0.8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3193 commit 92cf7a99db74beac0a15878cb19d2810fdfbdd4a Author: Jeff Zhang Date: 2018-09-27T09:07:14Z [HOTFIX] Fix travis failure of branch-0.8 ---
[GitHub] zeppelin issue #3192: ZEPPELIN-3768. run all paragraphs sequential mode when...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3192 Will merge if no more comments ---
[GitHub] zeppelin issue #3191: ZEPPELIN-3794. NPE when running paragraph without inte...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3191 Will merge it if no more comments ---
[GitHub] zeppelin issue #3190: ZEPPELIN-3796. Polluted output for spark interpreter
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3190 Will merge if no more comments ---
[GitHub] zeppelin pull request #3192: ZEPPELIN-3768. run all paragraphs sequential mo...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3192 ZEPPELIN-3768. run all paragraphs sequential mode when using ZeppelinContext api ### What is this PR for? This PR is to fix the bugs of ZeppelinContext.run api. It should run paragraph in blocking mode rather than non-blocking mode. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://jira.apache.org/jira/browse/ZEPPELIN-3768 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3192 commit 9ba9ebff04e6007d2ada9976f58976eac50fc731 Author: Jeff Zhang Date: 2018-09-27T07:46:54Z ZEPPELIN-3768. run all paragraphs sequentiall mode when using ZeppelinContext api ---
[GitHub] zeppelin pull request #3191: ZEPPELIN-3794. NPE when running paragraph witho...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3191 ZEPPELIN-3794. NPE when running paragraph without interpreter specified ### What is this PR for? This issue happens for the old note where no defaultInterpreterGroup is specified in note.json. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3794 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3794 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3191.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3191 commit a8a469fa06f0a61034982a9f10458621716e7250 Author: Jeff Zhang Date: 2018-09-27T03:29:43Z ZEPPELIN-3794. NPE when running paragraph without interpreter specified ---
[GitHub] zeppelin pull request #3190: ZEPPELIN-3796. Polluted output for spark interp...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3190 ZEPPELIN-3796. Polluted output for spark interpreter ### What is this PR for? This PR is to clear polluted spark interpreter output. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3796 ### How should this be tested? * CI pass ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3796 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3190 commit cebca39e3b7554a289b0c79eb93379ddac107536 Author: Jeff Zhang Date: 2018-09-27T04:22:06Z ZEPPELIN-3796. Polluted output for spark interpreter ---
[GitHub] zeppelin issue #2709: ZEPPELIN-3111. Refactor SparkInterpreter
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2709 Thanks @alonshoham feel free to create a PR for that. ---
[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3157 Thanks @selvinsource will merge it soon ---
[GitHub] zeppelin issue #3188: ZEPPELIN-3791: Bump-Up shiro version from 1.3.2 to 1.4...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3188 @ajaygk95 Thanks for the contribution, please configure your travis to enable CI. ---
[GitHub] zeppelin issue #3189: [ZEPPELIN-3758]. Convert old note file note.json to ne...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3189 Good idea, I can do it in a follow up PR. ---
[GitHub] zeppelin pull request #3189: [ZEPPELIN-3758]. Convert old note file note.jso...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3189 [ZEPPELIN-3758]. Convert old note file note.json to new style ### What is this PR for? This PR is follow up of ZEPPELIN-261, it is to convert old note file note.json to new style when user upgrading zeppelin before 0.9. 2 properties are introduced. * `zeppelin.notebook.new_format.convert`, by default it is false. When enabled, zeppelin will first find all the old note file note.json and then convert it into new style. * `zeppelin.notebook.new_format.delete_old`, by default it is false, when setting true, zeppelin will delete the old note file after converting it into new style. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3758 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3758 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3189.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3189 commit 1f3a39888adb9f1ce722e8304ce7e757893e37b0 Author: Jeff Zhang Date: 2018-09-25T08:59:10Z [ZEPPELIN-3758]. Convert old note file note.json to new style ---
[GitHub] zeppelin issue #3187: [HOTFIX] Fix CI on branch-0.8
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3187 LGTM ---
[GitHub] zeppelin pull request #3186: Zeppelin build fails with "Could not complete M...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3186 Zeppelin build fails with "Could not complete Mojo execution.." ### What is this PR for? Maven build fails due to invalid file name character, this PR fix it by renaming the note file name. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3788 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3788 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3186.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3186 commit 9d8e2a6692ea8f89e27752b8284c70fc68274103 Author: Jeff Zhang Date: 2018-09-25T01:16:40Z Zeppelin build fails with "Could not complete Mojo execution.." ---
[GitHub] zeppelin pull request #3184: [ZEPPELIN-3786]. Don't copy dependencies to tar...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3184 [ZEPPELIN-3786]. Don't copy dependencies to target/lib for interpreter modules ### What is this PR for? Only module zeppelin-interpreter,zeppelin,zengine,zeppelin-server needs that. They are just use it for testing purpose. Other modules don't need that. ### What type of PR is it? [Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3786 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3786 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3184 commit 5ba9ec0ae96d0e0ca13b48d2ee01eec6e220cd29 Author: Jeff Zhang Date: 2018-09-20T02:54:36Z [ZEPPELIN-3786]. Don't copy dependencies to target/lib for interpreter modules ---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3163 Thanks all for reviewing and testing, will merge it soon ---
[GitHub] zeppelin issue #3182: [ZEPPELIN-3761] Aliasing is not working with JDBC inte...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3182 LGTM, can we add unit test for this ? ---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3180 Is it necessary to backport to branch-0.8 ? Does it fix some critical issue ? ---
[GitHub] zeppelin issue #3181: ZEPPELIN-3633. ZeppelinContext Not Found in yarn-clust...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3181 @jongyoul Could you help review and verify it ? Thanks ---
[GitHub] zeppelin pull request #3181: ZEPPELIN-3633. ZeppelinContext Not Found in yar...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/3181 ZEPPELIN-3633. ZeppelinContext Not Found in yarn-cluster Mode ### What is this PR for? This issue is due to classpath in cluster mode. Because in cluster mode, driver run in the node of yarn cluster which don't have zeppelin installed. This PR fix this issue by updating the classpath of spark repl. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3633 ### How should this be tested? * Manually tested. Unfortunately this only happens on multiple node cluster, no unit test can be added for this scenario. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3181 commit 73ed8702a66456ed4066f339c84957ea7239b115 Author: Jeff Zhang Date: 2018-09-19T03:21:50Z ZEPPELIN-3633. ZeppelinContext Not Found in yarn-cluster Mode ---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3180 Thanks @prabhjyotsingh LGTM ---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3180 oops, it seems a large change, not sure why node npm package upgrade needs so large change. I am not an frontend expert, just need some explanation. ð ---
