[
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081673#comment-16081673
]
Michael Han commented on ZOOKEEPER-2770:
Please creating a pull request (see
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081645#comment-16081645
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user hanm commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081670#comment-16081670
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user andschwa commented on the issue:
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/306
@hanm I'm going to let you take care of the title, maybe it should be:
> ZOOKEEPER-2756 and ZOOKEEPER-2841: Improve cross-platform support with
CMake and refactor
But I don't
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081666#comment-16081666
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user andschwa commented on the issue:
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/306
@hanm ah, I see! That is no problem. I have taken the two messages,
improved them a bit as one message, and updated the description. It will be
easier to backport it this way.
---
If your
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081650#comment-16081650
]
ASF GitHub Bot commented on ZOOKEEPER-2804:
---
Github user hanm commented on the issue:
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/279
>> Please refer the null check added in PrepRequestProcessor class in
server side to safeguard against NPE.
@jainbhupendra24 thanks for clarification.
---
If your project is set up for
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126593104
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List acl,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081647#comment-16081647
]
ASF GitHub Bot commented on ZOOKEEPER-2804:
---
Github user hanm commented on a diff in the
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/306
If we want two commits, then we need two pull requests. Two (or more )
commits appertain to a single pull request will be squashed to a single commit
at commit time by our commit script. I think
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081634#comment-16081634
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user andschwa commented on the issue:
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/306
> Can you please describe what kinds of test / integration test you did on
windows?
Unfortunately, we don't have the unit tests building on Windows (under any
tools). So I ensured I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081625#comment-16081625
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user hanm commented on the issue:
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/306
@andschwa
Patch looks good to me. The readme update looks good too.
I also verified Linux and Mac c client builds with the patch. Unfortunately
I don't have a windows box to test. Can
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081514#comment-16081514
]
Ted Dunning commented on ZOOKEEPER-2770:
Who are we?
This kind of feature needs to be
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081519#comment-16081519
]
Andrew Purtell commented on ZOOKEEPER-2770:
---
[~tdunning] It's pretty common in other
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081493#comment-16081493
]
Karan Mehta commented on ZOOKEEPER-2770:
[~tdunning]
We felt the need of adding this
See https://builds.apache.org/job/ZooKeeper_branch34/2013/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 31.55 MB...]
[exec]
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1541/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 64.72 MB...]
[junit] 2017-07-10 20:01:12,293
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080812#comment-16080812
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user andschwa commented on the issue:
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/306
Hey, yay, Jenkins passed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/875/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.96 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080793#comment-16080793
]
Hadoop QA commented on ZOOKEEPER-2841:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080780#comment-16080780
]
Hadoop QA commented on ZOOKEEPER-2841:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/874/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 71.04 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080703#comment-16080703
]
Mohammad Arshad commented on ZOOKEEPER-1260:
Thanks [~fpj] for showing interest in this
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080754#comment-16080754
]
ASF GitHub Bot commented on ZOOKEEPER-2841:
---
Github user andschwa commented on the issue:
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/306
@hanm I ended up just adding it [straight to the
src/c/README](https://github.com/apache/zookeeper/pull/306/files#diff-a722fe5ba032cb8da6c78d0e929f4ac5R74),
let me know if you think it should
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080667#comment-16080667
]
ASF GitHub Bot commented on ZOOKEEPER-2804:
---
Github user arshadmohammad commented on a diff
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126482088
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1535,7 +1535,7 @@ public String create(final String path, byte data[],
List
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080660#comment-16080660
]
ASF GitHub Bot commented on ZOOKEEPER-2804:
---
Github user arshadmohammad commented on a diff
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126481060
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080541#comment-16080541
]
Hadoop QA commented on ZOOKEEPER-2755:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/873/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 72.10 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080511#comment-16080511
]
ASF GitHub Bot commented on ZOOKEEPER-2755:
---
Github user eolivelli commented on the issue:
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/227
@ivankelly I have rebased the patch to latest master and updated the commit
message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080487#comment-16080487
]
Enrico Olivelli commented on ZOOKEEPER-2755:
[~rakeshr] thank you for taking a look.
I
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1571/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
[EnvInject] - Loading node environment
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/596/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 65.50 MB...]
[junit] 2017-07-10 12:10:18,702
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/596/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.86 MB...]
[junit] 2017-07-10
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1039/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 67.17 MB...]
[junit] 2017-07-10 08:49:09,438
42 matches
Mail list logo
