Sounds a good plan to me. Thanks Enrico.
Regarding 4lw - my opinion is we could just leave it as is and don't expose
any of the newly added metrics through 4lw endpoints. Instead, advocating
admin server end points which will be supported moving forward.
On Tue, Sep 11, 2018 at 7:41 AM, Enrico
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/623#discussion_r217260419
--- Diff: src/java/test/org/apache/zookeeper/test/ClientTest.java ---
@@ -506,7 +506,7 @@ private void performClientTest(boolean withWatcherObj)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613021#comment-16613021
]
Michael Han commented on ZOOKEEPER-3141:
The failure does not reproduce in my stress test job
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612974#comment-16612974
]
shuoshi commented on ZOOKEEPER-2122:
I'd like to add openssl into zk's c client to support linux
See https://builds.apache.org/job/ZooKeeper-trunk/189/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 145.70 KB...]
[junit] Running
Historically we've always defined a minimum version and let users decide.
That seems to have worked pretty well. It provides the most flexibility and
hasn't really bothered us too much. It limits our use of new language
features of Java, but typically Java is ensuring b/w compat from a runtime
Michael Han created ZOOKEEPER-3147:
--
Summary: Enable server tracking client information
Key: ZOOKEEPER-3147
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3147
Project: ZooKeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612780#comment-16612780
]
Michael Han commented on ZOOKEEPER-3127:
If there is a conflict, it's expected that the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612748#comment-16612748
]
Fangmin Lv commented on ZOOKEEPER-3127:
---
[~andorm] what's the process for committer to port
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2160/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.83 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612710#comment-16612710
]
Hadoop QA commented on ZOOKEEPER-1260:
--
-1 overall. GitHub Pull Request Build
+1
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179715
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179644
--- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179296
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request
Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r217179236
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -250,30 +267,36 @@ public void processRequest(Request
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/605
@lvfangmin Cool, thanks for the info, but unfortunately the commit script
is quite strict and works with PRs. Maybe I could circumvent the process and
commit the change manually, but I think it
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612668#comment-16612668
]
Hadoop QA commented on ZOOKEEPER-1260:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2159/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 78.02 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612650#comment-16612650
]
Hadoop QA commented on ZOOKEEPER-3146:
--
+1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2158/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.05 MB...]
[exec] +1
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/605
@anmolnar the conflict is due to the missing of FuzzySnapshotRelatedTest
class introduced in ZOOKEEPER-3127, which is fixing the data inconsistency due
to multi-op txn.
We need that in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3146:
--
Labels: pull-request-available (was: )
> Limit the maximum client connections
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/623
[ZOOKEEPER-3146] Limit the maximum client connections per IP in
NettyServerCnxnFactory
Add similar max cnxn per ip throttling logic to Netty implementation.
You can merge this pull request
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612617#comment-16612617
]
Hadoop QA commented on ZOOKEEPER-3145:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2157/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 75.29 MB...]
[exec]
Fangmin Lv created ZOOKEEPER-3146:
-
Summary: Limit the maximum client connections per IP in
NettyServerCnxnFactory
Key: ZOOKEEPER-3146
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3146
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2933/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 9.71 KB...]
[ivy:retrieve] confs: [javacc]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3145:
--
Summary: Potential watch missing issue due to stale pzxid when replaying
CloseSession txn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3145:
--
Labels: pull-request-available (was: )
> Potential watch missing issue due to
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/622
[ZOOKEEPER-3145] Potential watch missing issue due to stale pzxid when
replaying CloseSession txn with fuzzy snapshot
Currently, the CloseSession txn is not idempotent, executing the
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2156/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.41 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612538#comment-16612538
]
Hadoop QA commented on ZOOKEEPER-1177:
--
-1 overall. GitHub Pull Request Build
+1
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
Resolve conflict with latest code on master.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
Update based on the comments:
1. add findbugs exclusion
2. add comments for the newly added classes
3. add admin doc for the new JVM options introduced in this diff
4. move
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2155/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 3.59 KB...]
at
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/590#discussion_r217112114
--- Diff:
src/java/main/org/apache/zookeeper/server/watch/WatchManagerOptimized.java ---
@@ -0,0 +1,355 @@
+/**
+ * Licensed to the Apache
Andor,
ZOOKEEPER-3114 is about adding real time digest checking to help detecting
inconsistency, it's a new feature with amounts of code change. I'll start
upstream it part by part, but I don't expect it's being merged in the next
few weeks. So yes, it's a nice to have, but definitely not a block
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/605
Thanks @anmolnar, will create a PR for 3.5.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612318#comment-16612318
]
Mohammad Arshad commented on ZOOKEEPER-1260:
To run the performance utility, go to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612315#comment-16612315
]
Mohammad Arshad commented on ZOOKEEPER-1260:
>From the performance readings, seems
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612302#comment-16612302
]
Mohammad Arshad commented on ZOOKEEPER-1260:
To assess the performance impact of audit
Il mer 12 set 2018, 11:37 Norbert Kalmar ha
scritto:
> Thanks Enrico!
>
> Agree, as I mentioned, only JDK8 and 11 should be tested on 3.4 and other
> branches as well.
>
> I checked the Kerby problems, 3.4 does not have Kerby, it uses Apache
> directory server.
> Maybe we should introduce also
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612136#comment-16612136
]
Hudson commented on ZOOKEEPER-1823:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #188 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612135#comment-16612135
]
Hudson commented on ZOOKEEPER-3125:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #188 (See
See https://builds.apache.org/job/ZooKeeper-trunk/188/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 150.96 KB...]
[junit] Tests run: 4, Failures: 0,
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1116/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 62.82 KB...]
[junit] Running
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2932/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 9.71 KB...]
[ivy:retrieve] confs: [javacc]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611993#comment-16611993
]
Andor Molnar commented on ZOOKEEPER-2990:
-
We can talk about it, but I would rather create
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-1823.
-
Resolution: Fixed
Issue resolved by pull request 613
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/613
Merged to 3.5 and master. Thanks @maoling !
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/613
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/605
@lvfangmin Committed to master. Conflicting with branch-3.5, please create
separate pull request for that.
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/605
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/590#discussion_r216973199
--- Diff:
src/java/main/org/apache/zookeeper/server/watch/WatchManagerOptimized.java ---
@@ -0,0 +1,355 @@
+/**
+ * Licensed to the Apache
Fangmin,
Sorry, I just noticed that you want to include the consistency fixes in the
stable version which is fine. Let’s finish the backports and we’ll be done with
them.
ZOOKEEPER-3114 is essentially a new feature, I wouldn’t block 3.5 with that.
What do you think?
Andor
> On 2018. Sep
Cool, thanks for the clarification.
The updated list is as follows:
- ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol)
- ZOOKEEPER-1818 (Fix don't care for trunk)
- ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader
and follower receiving external
Thanks Enrico!
Agree, as I mentioned, only JDK8 and 11 should be tested on 3.4 and other
branches as well.
I checked the Kerby problems, 3.4 does not have Kerby, it uses Apache
directory server.
Maybe we should introduce also introduce Kerby on 3.4? Or just try to fix
the problems with directory
Il giorno mer 12 set 2018 alle ore 11:04 Norbert Kalmar
ha scritto:
> Hi all,
>
> Oracle8 will have it's support end in January. They changed there release
> drastically.
> A good article on that:
> https://dev.karakun.com/java/2018/06/25/java-releases.html
>
> Long story short: From January, no
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2154/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.59 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611802#comment-16611802
]
Hadoop QA commented on ZOOKEEPER-1823:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611800#comment-16611800
]
Andor Molnar commented on ZOOKEEPER-3125:
-
Scoped to 3.5 branch too.
> Pzxid inconsistent
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3125:
Fix Version/s: 3.5.5
> Pzxid inconsistent issue when replaying a txn for a deleted
Hi all,
Oracle8 will have it's support end in January. They changed there release
drastically.
A good article on that:
https://dev.karakun.com/java/2018/06/25/java-releases.html
Long story short: From January, no Oracle JDK version can be used in PROD
environment without a license. End every
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611781#comment-16611781
]
Andor Molnar commented on ZOOKEEPER-3127:
-
[~lvfangmin]
Would you please port this to 3.5
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611777#comment-16611777
]
Andor Molnar commented on ZOOKEEPER-3104:
-
Thanks [~lvfangmin]
We don't get too many (maybe
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/590#discussion_r216912996
--- Diff: src/java/test/org/apache/zookeeper/server/DumbWatcher.java ---
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/590#discussion_r216910219
--- Diff:
src/java/main/org/apache/zookeeper/server/watch/WatchManagerOptimized.java ---
@@ -0,0 +1,355 @@
+/**
+ * Licensed to the Apache
67 matches
Mail list logo
