Great work Michael,
I am totally +1 on using docker for network isolation
I think that Apache CI may allow out-of-the-box execution in Docker
containers, in fact we have the "CloudBees Docker Custom Build
Environment Plugin"
We can use a public image or provide on the repo a Dockerfile.
In my
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237367857
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1989,6 +1989,38 @@ private boolean updateVote(long
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237368501
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/FLEOutOfElectionTest.java
---
@@ -0,0 +1,136 @@
+/**
+ * Licensed to
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237367990
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1989,6 +1989,38 @@ private boolean updateVote(long
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237367761
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java
---
@@ -1058,29 +1050,20 @@ else if (validVoter(n.sid)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237367684
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java
---
@@ -1042,14 +1035,13 @@ else if (validVoter(n.sid)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237368267
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Vote.java ---
@@ -125,11 +125,47 @@ public boolean equals(Object o) {
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237367977
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1989,6 +1989,38 @@ private boolean updateVote(long
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r237367661
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java
---
@@ -1023,9 +1016,9 @@ else if (validVoter(n.sid) &&
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/719
@anmolnar yes, it is okay
---
With the use of a Docker container (to prevent port collisions) and a
stack of cleanups to test code, I've made some progress towards
reliable test runs in our environment.
(https://github.com/mkedwards/zookeeper/commits/rollup-3.5, if you're
curious.) The list below consists of the "top 40"
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/719
I believe #707 has @eolivelli's LGTM now.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702645#comment-16702645
]
Hudson commented on ZOOKEEPER-3183:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #288 (See
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/726
Only a few nits, other LGTM.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702602#comment-16702602
]
Hudson commented on ZOOKEEPER-3183:
---
SUCCESS: Integrated in Jenkins build
Github user tumativ commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/712#discussion_r237324365
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/ZookeeperServerStabilizerConfig.java
---
@@ -0,0 +1,30 @@
+/**
+ *
+
Github user tumativ commented on the issue:
https://github.com/apache/zookeeper/pull/689
@lvfangmin Thanks for merging. My JIRA user id is Tumati.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv reassigned ZOOKEEPER-3183:
-
Assignee: (was: Fangmin Lv)
> Interrupting or notifying the WatcherCleaner
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv resolved ZOOKEEPER-3183.
---
Resolution: Fixed
Issue resolved by pull request 689
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/689
Merged, thanks @tumativ. Btw, what's your Jira user id, I tried to assign
this JIRA to you but I cannot find you.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv reassigned ZOOKEEPER-3183:
-
Assignee: Fangmin Lv
> Interrupting or notifying the WatcherCleaner thread during
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/689
---
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/722#discussion_r23726
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderBean.java
---
@@ -51,6 +51,15 @@ public String followerInfo() {
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
Ah, I hadn't realised that 3.5 was closed for stabilisation. So I should
recreate this PR for the master branch then?
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/703
@lvfangmin will review and provide feedback tonight. thanks
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/689
LGTM, +1
Thanks @tumativ for all your effort on this, I'll commit this today.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
May need an extra +1 from another committer, @hanm do you have time to
review this?
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/654
I just realized this is for 3.5. Did you create a PR for the master branch?
3.5 is pretty much closed for new features, in order to stabilize it for the
stable release.
---
Github user arankin-irl commented on the issue:
https://github.com/apache/zookeeper/pull/654
Addressed merge conflicts.
@nkalmar - Just wondering if there's anything else I can do to help this
get merged?
---
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1211/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 66.28 KB...]
[junit] Tests run: 1, Failures:
Github user akkumar commented on the issue:
https://github.com/apache/zookeeper/pull/726
@eolivelli - import static added. Let me know if this looks ok !
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/726#discussion_r236977045
--- Diff:
zookeeper-jute/src/test/java/org/apache/jute/XmlInputArchiveTest.java ---
@@ -0,0 +1,120 @@
+/**
+ * Licensed to the Apache Software
32 matches
Mail list logo
