Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r192604269
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm Got a few spare cycles to address my comments?
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Agreed @zodvik . The scope of this Jira is to limit it to a generic slow
query log and identify the outliers if any. For that reason, I am printing the
actual request to the log as well
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r187815218
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r187815108
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r187815063
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm Thank you! I have rebased the patch. The jenkins build has been
failing for a while and my patch doesn't introduce new failure. Thanks once
again!
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Hello everyone,
Appreciate your efforts in reviewing this patch. @hanm @tdunning @eribeiro
@skamille
Is there any possibility that the patch will get merged in (with minor
changes
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
> Can we at least make it so that the process of "push a metric to a
buffer, have a thread that wakes up periodically and flushes information out of
that buffer" is usable by m
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Ping @hanm @tdunning @eribeiro @skamille for a review if you got some time.
Thanks!
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Due to some reason, Jenkins didn't build it automatically. I triggered a
manual build with my latest commit ID SHA1 and the results are at
https://builds.apache.org/job/PreCommit-ZOOKEEPER
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r147047396
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -81,9 +81,11 @@
private static final Logger LOG
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r147047400
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +174,46 @@ synchronized public void resetRequestCounters
GitHub user karanmehta93 reopened a pull request:
https://github.com/apache/zookeeper/pull/307
ZOOKEEPER-2770 ZooKeeper slow operation log
ZooKeeper is a complex distributed application. There are many reasons why
any given read or write operation may become slow: a software bug
Github user karanmehta93 closed the pull request at:
https://github.com/apache/zookeeper/pull/307
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@tdunning Sorry about this. I rebased my branch with the current master and
pushed my patch along with it. Now it is showing up all those commits as my
commits. Let me try to figure out
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm @eribeiro @tdunning @skamille
Please review.
Now that I have added rate limiting to logging, can we also turn this on by
default?
---
If your project is set up for it, you
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r129450258
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -61,6 +61,7 @@
private static boolean
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r129431091
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -61,6 +61,7 @@
private static boolean
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm @eribeiro @tdunning
I have fixed the whitespace issues and final patch is ready, Please review
whenever convenient.
---
If your project is set up for it, you can reply
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r128330873
--- Diff: src/java/main/org/apache/zookeeper/server/Request.java ---
@@ -29,12 +29,14 @@
import
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r128155180
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm
> I think at some point after merge this you need create another pull
request targeting stable branch (branch-3.4) where the version number should be
3.4.11 (hopefu
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r128122188
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127892837
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127762613
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -460,11 +464,21 @@ public void processRequest(Request request
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127757305
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127633626
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127633278
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@eribeiro Thank you for your comments. Will post an updated patch soon.
A small concern regarding the `ServerStats.updateLatency()` method.
Should the updated patch have both
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm @eribeiro
Thank you for your comments. I have added a rebased patch with a test in
`ZooKeeperServerMainTest` class. Please review whenever convenient.
> It's odd to h
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127363108
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -61,6 +61,7 @@
private static boolean
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127127351
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
From my understanding, `QuorumPeer` class will be the candidate class to
maintain this data structure. Let me know alternatives.
I will look into the data-structure ideas you provided
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127048435
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -292,6 +293,8 @@ public void parseProperties(Properties
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
ZooKeeper is a complex distributed application. There are many reasons why
any given read or write operation may become slow: a software bug, a protocol
problem, a hardware issue
Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r126872020
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/zookeeper/pull/307
ZOOKEEPER-2770 ZooKeeper slow operation log
The patch sets a default threshold of 10 sec for request. If the value of
warn.responseTime is configured as -1 then logging is ignored.
You can
38 matches
Mail list logo
