Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r191252989
--- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java
---
@@ -102,9 +102,9 @@ public void testBindByAddress() throws Exception {
Github user anmolnar closed the pull request at:
https://github.com/apache/zookeeper/pull/451
---
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r191243666
--- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java
---
@@ -102,9 +102,9 @@ public void testBindByAddress() throws Exception {
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r191242849
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -21,6 +21,7 @@
import org.apache.yetus.audience.InterfaceAudience;
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r191087859
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r191034929
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*Milliseconds
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r191034452
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -30,76 +31,118 @@
import org.slf4j.Logger;
import
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r190899356
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r190846274
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r190789369
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*Milliseconds
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186759876
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186741712
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -30,76 +31,118 @@
import org.slf4j.Logger;
import
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186735649
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186734788
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186694289
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -30,76 +31,118 @@
import org.slf4j.Logger;
import
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186690327
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186690242
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186689865
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*Milliseconds
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186591847
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186591545
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186591140
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186553219
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186546855
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
*Milliseconds
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186553004
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168764368
--- Diff:
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java ---
@@ -119,6 +120,68 @@ public void testTwoInvalidHostAddresses() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168763559
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -239,13 +243,13 @@ public void testSessionEstablishment() throws
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168580127
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168575513
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -239,13 +243,13 @@ public void testSessionEstablishment() throws
Exception {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168578617
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168568596
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -47,59 +51,169 @@
private int currentIndex = -1;
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168572502
--- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java
---
@@ -104,7 +104,7 @@ public void testBindByAddress() throws Exception {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168576090
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -47,59 +51,169 @@
private int currentIndex = -1;
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168576884
--- Diff:
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java ---
@@ -119,6 +120,68 @@ public void testTwoInvalidHostAddresses() {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168565039
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -18,6 +18,10 @@
package org.apache.zookeeper.client;
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168564981
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -18,6 +18,10 @@
package org.apache.zookeeper.client;
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168524336
--- Diff:
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java ---
@@ -117,8 +116,32 @@ public void testTwoInvalidHostAddresses() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r167027624
--- Diff:
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java ---
@@ -117,8 +116,32 @@ public void testTwoInvalidHostAddresses() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r167024767
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r167013851
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166671671
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166670125
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r19488
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -239,13 +243,13 @@ public void testSessionEstablishment() throws
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166479687
--- Diff:
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java ---
@@ -117,8 +116,32 @@ public void testTwoInvalidHostAddresses() {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166476703
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166476047
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -239,13 +243,13 @@ public void testSessionEstablishment() throws
Exception {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166341540
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166329760
--- Diff:
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java ---
@@ -117,8 +116,32 @@ public void testTwoInvalidHostAddresses() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166328583
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166286605
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166286530
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -239,13 +243,13 @@ public void testSessionEstablishment() throws
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166097161
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0 (the
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166103404
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166105622
--- Diff:
src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java ---
@@ -117,8 +116,32 @@ public void testTwoInvalidHostAddresses() {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r166102194
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -58,48 +61,122 @@
public StaticHostProvider(Collection
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165666521
--- Diff:
src/java/test/org/apache/zookeeper/client/StaticHostProviderTest.java ---
@@ -16,7 +16,7 @@
* limitations under the License.
*/
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165665505
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -91,15 +79,106 @@ public
StaticHostProvider(Collection
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165658965
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,29 +62,12 @@
*/
public
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165658743
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -25,6 +25,8 @@
import java.util.Collection;
import
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165525652
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -239,13 +243,13 @@ public void testSessionEstablishment() throws
Exception {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165527366
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,29 +62,12 @@
*/
public
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165524377
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -25,6 +25,8 @@
import java.util.Collection;
import
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165529085
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -91,15 +79,106 @@ public
StaticHostProvider(Collection serverAddresses)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165525113
--- Diff:
src/java/test/org/apache/zookeeper/client/StaticHostProviderTest.java ---
@@ -16,7 +16,7 @@
* limitations under the License.
*/
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r163570637
--- Diff:
src/java/test/org/apache/zookeeper/client/StaticHostProviderTest.java ---
@@ -117,8 +117,32 @@ public void testTwoInvalidHostAddresses() {
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/451
ZOOKEEPER-2184: Zookeeper Client should re-resolve hosts when connection
attempts fail
This one is the pick-up of @fpj 's original PR: #150
Targeting and rebased on the 3.4 branch.
You
65 matches
Mail list logo
