I was just working on it, you already reviewed it. I fixed the javadoc
comment you mentioned, please check again :)
Thanks!
- Norbert
On Thu, Apr 2, 2020 at 10:42 AM Enrico Olivelli wrote:
> I would like to release 3.6.1 soon.
> Can you send a patch?
>
> Enrico
>
> Il Mer 1 Apr 2020, 13:09
I would like to release 3.6.1 soon.
Can you send a patch?
Enrico
Il Mer 1 Apr 2020, 13:09 Norbert Kalmar ha
scritto:
> I'll create a jira and the PR. I guess we should just return -1, that's
> what 3.5.5 did anyway:
>
>
I'll create a jira and the PR. I guess we should just return -1, that's
what 3.5.5 did anyway:
https://github.com/apache/zookeeper/blob/branch-3.5.5/zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java#L87
And keep it on 3.6 as well? Fine by me. So put this function back
I agree with you.
Also as far as I can remember on some of my leader election bug jira
tickets people asked when the next 3.5.x release would happen.
Kind regards,
Mate
On Wed, Apr 1, 2020 at 12:18 PM Enrico Olivelli wrote:
> We should restore it as we did for ZKUtils#delete
>
> Both in 3.5x
We should restore it as we did for ZKUtils#delete
Both in 3.5x and in 3.6
We just ensure smooth upgrade
Enrico
Il Mer 1 Apr 2020, 12:06 Norbert Kalmar ha
scritto:
> Hi all,
>
> We removed the getRevision() [1] function in 3.5.6 [2].
> I just tried updating to ZooKeeper 3.5.7 in our system,
