Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 27, 2015, 5:51 p.m.) Review request for zookeeper, fpj, Hongchao

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 27, 2015, 12:48 a.m.) Review request for zookeeper, fpj, Hongcha

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

> On March 27, 2015, 12:27 a.m., Hongchao Deng wrote: > > src/java/test/org/apache/zookeeper/test/SSLAuthTest.java, line 91 > > > > > > It's the same thing as testRejection(). They both have set the wrong > > configura

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

> On March 27, 2015, 12:27 a.m., Hongchao Deng wrote: > > src/java/test/org/apache/zookeeper/test/SSLAuthTest.java, line 73 > > > > > > > perform an end-to-end test that includes X509AuthenticationProvider > > as a gat

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review77988 --- src/java/test/org/apache/zookeeper/test/SSLAuthTest.java

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 27, 2015, 12:20 a.m.) Review request for zookeeper, fpj, Hongcha

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

> On March 25, 2015, 9:31 p.m., Hongchao Deng wrote: > > src/java/test/org/apache/zookeeper/test/SSLAuthTest.java, line 73 > > > > > > I think this test is duplicate to SSLTest. This leverages the ClientBase and Testab

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review77798 --- src/java/test/org/apache/zookeeper/test/SSLAuthTest.java

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

> On March 25, 2015, 6:28 p.m., Hongchao Deng wrote: > > src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java, line > > 309 > > > > > > Can we get rid of certificate chain in each cnxn and pass it as

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 25, 2015, 8:02 p.m.) Review request for zookeeper, fpj, Hongchao

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review77766 --- src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java <

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 25, 2015, 6:28 p.m.) Review request for zookeeper, fpj, Hongchao

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 25, 2015, 5:28 p.m.) Review request for zookeeper, fpj, Hongchao

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

> On March 22, 2015, 6:14 p.m., Rakesh R wrote: > > src/java/test/org/apache/zookeeper/test/ClientBase.java, line 251 > > > > > > Please modify the log by using {} instead of + > > > > LOG.error("server {} no

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review77710 --- src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java <

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 23, 2015, 10:29 p.m.) Review request for zookeeper, fpj, Hongcha

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

> On March 22, 2015, 6:14 p.m., Rakesh R wrote: > > src/java/test/org/apache/zookeeper/test/ClientBase.java, line 251 > > > > > > Please modify the log by using {} instead of + > > > > LOG.error("server {} no

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review77353 --- src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationPr

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- (Updated March 18, 2015, 4:34 a.m.) Review request for zookeeper, fpj, Hongchao

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

> On March 13, 2015, 6:33 a.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java, > > line 233 > > > > > > I couldn't see anyone is calling this. Do we need this metho

Re: Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/#review76341 --- src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.ja

Review Request 31963: Patch in X509AuthenticationProvider on top of ZOOKEEPER-2125

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31963/ --- Review request for zookeeper, fpj, Hongchao Deng, and Rakesh R. Repository: zoo