Re: Merge pull request using zk-merge-pr.py script

[Michael Han]

Maybe it's a good time to automate change log generation. Example:
https://issues.apache.org/jira/browse/HADOOP-11731

On Thu, Dec 15, 2016 at 10:04 PM, Rakesh Radhakrishnan <
rakeshr.apa...@gmail.com> wrote:

> Before migrating to git, committer has to update the CHANGE.TXT file
> manually and then push this along with the approved patch as a single
> commit.
>
> Thanks,
> Rakesh
>
> On 16-Dec-2016 11:16 AM, "Michael Han"  wrote:
>
> Good catch, I think a couple of recent commits on master branch missing
> editing of CHANGE.TXT
>
> How is CHANGE.TXT edited before migrating to git during a commit? Is it
> done automatically or manually (that a committer has to update the file)?
>
> On Thu, Dec 15, 2016 at 8:32 PM, Rakesh Radhakrishnan 
> wrote:
>
> > Hi,
> >
> > I have an observation about the merge PR python script.
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
> >
> > I could see the commit made using this automated merge script is missing
> to
> > edit the 'CHANGES.TXT' file and then add the jira details that correspond
> > to the patch. I feel, there is an inconsistency between the commit that
> > goes via manually and automated script. Welcome comments?
> >
> > Thanks & Regards,
> > Rakesh
> >
>
>
>
> --
> Cheers
> Michael.
>



-- 
Cheers
Michael.

Re: Merge pull request using zk-merge-pr.py script

[Rakesh Radhakrishnan]

Before migrating to git, committer has to update the CHANGE.TXT file
manually and then push this along with the approved patch as a single
commit.

Thanks,
Rakesh

On 16-Dec-2016 11:16 AM, "Michael Han"  wrote:

Good catch, I think a couple of recent commits on master branch missing
editing of CHANGE.TXT

How is CHANGE.TXT edited before migrating to git during a commit? Is it
done automatically or manually (that a committer has to update the file)?

On Thu, Dec 15, 2016 at 8:32 PM, Rakesh Radhakrishnan 
wrote:

> Hi,
>
> I have an observation about the merge PR python script.
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
>
> I could see the commit made using this automated merge script is missing
to
> edit the 'CHANGES.TXT' file and then add the jira details that correspond
> to the patch. I feel, there is an inconsistency between the commit that
> goes via manually and automated script. Welcome comments?
>
> Thanks & Regards,
> Rakesh
>



--
Cheers
Michael.

Re: Merge pull request using zk-merge-pr.py script

[Michael Han]

Good catch, I think a couple of recent commits on master branch missing
editing of CHANGE.TXT

How is CHANGE.TXT edited before migrating to git during a commit? Is it
done automatically or manually (that a committer has to update the file)?

On Thu, Dec 15, 2016 at 8:32 PM, Rakesh Radhakrishnan 
wrote:

> Hi,
>
> I have an observation about the merge PR python script.
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
>
> I could see the commit made using this automated merge script is missing to
> edit the 'CHANGES.TXT' file and then add the jira details that correspond
> to the patch. I feel, there is an inconsistency between the commit that
> goes via manually and automated script. Welcome comments?
>
> Thanks & Regards,
> Rakesh
>



-- 
Cheers
Michael.

Re: ZooKeeper-trunk-WinVS2008 - Build # 2357 - Still Failing

[Michael Han]

Logged https://issues.apache.org/jira/browse/INFRA-13112 to track this.

On Mon, Dec 12, 2016 at 9:45 AM, Michael Han  wrote:

> I assume we still care about windows build... this has been failing for
> the previous two weeks because of a host problem (no java compiler). The
> last known succeed build was running on host with name 'windows1' (which is
> dead now), and the current problematic host is https://builds.apache.org/
> computer/windows-2012-2/. I have no access to jenkins job config so not
> sure how to fix this. Should we raise an infra ticket for this?
>
> On Sun, Dec 11, 2016 at 9:23 PM, Apache Jenkins Server <
> jenk...@builds.apache.org> wrote:
>
>> See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2357/
>>
>> 
>> ###
>> ## LAST 60 LINES OF THE CONSOLE
>> ###
>> [...truncated 78 lines...]
>>
>> ivy-retrieve:
>> [ivy:retrieve] :: Apache Ivy 2.4.0 - 20141213170938 ::
>> http://ant.apache.org/ivy/ ::
>> [ivy:retrieve] :: loading settings :: file =
>> f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008
>> \ivysettings.xml
>> [ivy:retrieve] :: resolving dependencies :: org.apache.zookeeper#zookeeper
>> ;3.6.0-SNAPSHOT
>> [ivy:retrieve]  confs: [default]
>> [ivy:retrieve]  found jline#jline;2.11 in maven2
>> [ivy:retrieve]  found org.eclipse.jetty#jetty-server;9.2.18.v20160721 in
>> maven2
>> [ivy:retrieve]  found javax.servlet#javax.servlet-api;3.1.0 in maven2
>> [ivy:retrieve]  found org.eclipse.jetty#jetty-http;9.2.18.v20160721 in
>> maven2
>> [ivy:retrieve]  found org.eclipse.jetty#jetty-util;9.2.18.v20160721 in
>> maven2
>> [ivy:retrieve]  found org.eclipse.jetty#jetty-io;9.2.18.v20160721 in
>> maven2
>> [ivy:retrieve]  found org.eclipse.jetty#jetty-servlet;9.2.18.v20160721
>> in maven2
>> [ivy:retrieve]  found org.eclipse.jetty#jetty-security;9.2.18.v20160721
>> in maven2
>> [ivy:retrieve]  found org.codehaus.jackson#jackson-mapper-asl;1.9.11 in
>> maven2
>> [ivy:retrieve]  found org.codehaus.jackson#jackson-core-asl;1.9.11 in
>> maven2
>> [ivy:retrieve]  found org.slf4j#slf4j-api;1.7.5 in maven2
>> [ivy:retrieve]  found org.slf4j#slf4j-log4j12;1.7.5 in maven2
>> [ivy:retrieve]  found commons-cli#commons-cli;1.2 in maven2
>> [ivy:retrieve]  found log4j#log4j;1.2.17 in maven2
>> [ivy:retrieve]  found io.netty#netty;3.10.5.Final in maven2
>> [ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
>> [ivy:retrieve] :: resolution report :: resolve 400ms :: artifacts dl 21ms
>> 
>> -
>> |  |modules||
>>  artifacts   |
>> |   conf   | number| search|dwnlded|evicted||
>> number|dwnlded|
>> 
>> -
>> |  default |   16  |   0   |   0   |   0   ||   16  |
>>  0   |
>> 
>> -
>> [ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
>> [ivy:retrieve]  confs: [default]
>> [ivy:retrieve]  16 artifacts copied, 0 already retrieved (4635kB/35ms)
>>
>> generate_jute_parser:
>> [mkdir] Created dir: f:\jenkins\jenkins-slave\works
>> pace\ZooKeeper-trunk-WinVS2008\build\jute_compiler\org\
>> apache\jute\compiler\generated
>> [ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use
>> 'ivy.settings.file' instead
>> [ivy:artifactproperty] :: loading settings :: file =
>> f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008
>> \ivysettings.xml
>>  [move] Moving 1 file to f:\jenkins\jenkins-slave\works
>> pace\ZooKeeper-trunk-WinVS2008\build\lib
>>[javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
>>[javacc] (type "javacc" with no arguments for help)
>>[javacc] Reading from file f:\jenkins\jenkins-slave\works
>> pace\ZooKeeper-trunk-WinVS2008\src\java\main\org\apache\jute\compiler\generated\rcc.jj
>> . . .
>>[javacc] File "TokenMgrError.java" does not exist.  Will create one.
>>[javacc] File "ParseException.java" does not exist.  Will create one.
>>[javacc] File "Token.java" does not exist.  Will create one.
>>[javacc] File "SimpleCharStream.java" does not exist.  Will create one.
>>[javacc] Parser generated successfully.
>>
>> jute:
>>
>> BUILD FAILED
>> f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build.xml:273:
>> Unable to find a javac compiler;
>> com.sun.tools.javac.Main is not on the classpath.
>> Perhaps JAVA_HOME does not point to the JDK.
>> It is currently set to "C:\Program Files\Java\jre1.8.0_92"
>>
>> Total time: 3 seconds
>> Build step 'Invoke Ant' marked build as failure
>> Email was triggered for: Failure - Any
>> Sending email for trigger: Failure - Any
>>
>>
>>
>> 
>> 

ZooKeeper-trunk-WinVS2008 - Build # 2361 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2361/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 78 lines...]

ivy-retrieve:
[ivy:retrieve] :: Apache Ivy 2.4.0 - 20141213170938 :: 
http://ant.apache.org/ivy/ ::
[ivy:retrieve] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  found jline#jline;2.11 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-server;9.2.18.v20160721 in maven2
[ivy:retrieve]  found javax.servlet#javax.servlet-api;3.1.0 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-http;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-util;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-io;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-servlet;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-security;9.2.18.v20160721 in 
maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-mapper-asl;1.9.11 in maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-core-asl;1.9.11 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-api;1.7.5 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-log4j12;1.7.5 in maven2
[ivy:retrieve]  found commons-cli#commons-cli;1.2 in maven2
[ivy:retrieve]  found log4j#log4j;1.2.17 in maven2
[ivy:retrieve]  found io.netty#netty;3.10.5.Final in maven2
[ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
[ivy:retrieve] :: resolution report :: resolve 393ms :: artifacts dl 20ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   16  |   0   |   0   |   0   ||   16  |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  16 artifacts copied, 0 already retrieved (4635kB/34ms)

generate_jute_parser:
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\jute_compiler\org\apache\jute\compiler\generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
 [move] Moving 1 file to 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\src\java\main\org\apache\jute\compiler\generated\rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build.xml:273: 
Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "C:\Program Files\Java\jre1.8.0_92"

Total time: 3 seconds
Build step 'Invoke Ant' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753450#comment-15753450
 ] 

Rakesh R commented on ZOOKEEPER-2479:
-

Thanks [~fpj], I need to do the changes separately for branch-3.4 as trunk and 
branch-3.4 code are different. Do you prefer a new patch diff or PR against 
branch-3.4?

> Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean
> 
>
> Key: ZOOKEEPER-2479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2479
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, ZOOKEEPER-2479.patch, 
> ZOOKEEPER-2479.patch
>
>
> The idea of this jira is to expose {{time taken}} for the leader election via 
> jmx Leader, Follower beans.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Merge pull request using zk-merge-pr.py script

[Rakesh Radhakrishnan]

Hi,

I have an observation about the merge PR python script.
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes

I could see the commit made using this automated merge script is missing to
edit the 'CHANGES.TXT' file and then add the jira details that correspond
to the patch. I feel, there is an inconsistency between the commit that
goes via manually and automated script. Welcome comments?

Thanks & Regards,
Rakesh

Reg ZooKeeper git commit

[Rakesh Radhakrishnan]

Hi,

Commit Log:-
https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commit;h=
2afed855ad966d4c4cd0370e6d24a01c04e75d67

My bad, I have made a commit from the system where git user name and mail
id was configured in my colleague's name(PMC of another Apache project). So
the commit shows his details. I'm really sorry for this. One approach is to
use "git commit --amend" after changing the "git config --global user.name and
user.email" in my system. Please advice me if this is the correct way.
Thanks!

Thanks & Regards,
Rakesh

Success: ZOOKEEPER- PreCommit Build #128

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/128/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 472661 lines...]
 [exec] +1 overall.  GitHub Pull Request  Build
 [exec]   
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/128//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/128//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/128//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] c042825c2f3315a989ec5da4a179518bb5bfca31 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 19 minutes 6 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Could not determine description.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Failed: ZOOKEEPER- PreCommit Build #127

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/127/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 45 lines...]
stderr: 
hudson.plugins.git.GitException: Command "git merge 
1eafd74d56b02a82adad3fd4b83b440e3cdceba3" returned status code 1:
stdout: Auto-merging 
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
Auto-merging src/c/tests/TestReconfigServer.cc
CONFLICT (content): Merge conflict in src/c/tests/TestReconfigServer.cc
Auto-merging src/c/src/zookeeper.c
Auto-merging src/c/src/zk_adaptor.h
Auto-merging src/c/include/zookeeper.h
Automatic merge failed; fix conflicts and then commit the result.

stderr: 
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1723)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1699)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1695)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1317)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$3.execute(CliGitAPIImpl.java:587)
at 
org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.merge(AbstractGitAPIImpl.java:87)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.merge(CliGitAPIImpl.java:63)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:884)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:859)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:818)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:332)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to H6(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:781)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:249)
at com.sun.proxy.$Proxy90.merge(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.merge(RemoteGitImpl.java:438)
at 
com.cloudbees.jenkins.plugins.git.vmerge.BuildChooserImpl.getCandidateRevisions(BuildChooserImpl.java:107)
at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:984)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1087)
at hudson.scm.SCM.checkout(SCM.java:485)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1269)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1741)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Archiving artifacts
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper-trunk - Build # 3194 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3194/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 478467 lines...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-12-15 23:27:17,818 [myid:] - INFO  [ProcessThread(sid:0 
cport:30317)::PrepRequestProcessor@618] - Processed session termination for 
sessionid: 0x102422b4f1c
[junit] 2016-12-15 23:27:17,819 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30317,name1=Connections,name2=127.0.0.1,name3=0x102422b4f1c]
[junit] 2016-12-15 23:27:17,819 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x102422b4f1c closed
[junit] 2016-12-15 23:27:17,819 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x102422b4f1c
[junit] 2016-12-15 23:27:17,819 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 206724
[junit] 2016-12-15 23:27:17,820 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643
[junit] 2016-12-15 23:27:17,820 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-12-15 23:27:17,820 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-12-15 23:27:17,820 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-12-15 23:27:17,820 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:30317
[junit] 2016-12-15 23:27:17,823 [myid:] - INFO  [main:ZooKeeperServer@534] 
- shutting down
[junit] 2016-12-15 23:27:17,824 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 23:27:17,824 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-12-15 23:27:17,824 [myid:] - INFO  
[main:PrepRequestProcessor@1009] - Shutting down
[junit] 2016-12-15 23:27:17,824 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-12-15 23:27:17,826 [myid:] - INFO  [ProcessThread(sid:0 
cport:30317)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2016-12-15 23:27:17,827 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-12-15 23:27:17,828 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2016-12-15 23:27:17,828 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30317,name1=InMemoryDataTree]
[junit] 2016-12-15 23:27:17,828 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30317]
[junit] 2016-12-15 23:27:17,828 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 30317
[junit] 2016-12-15 23:27:17,829 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-12-15 23:27:17,836 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4831 at start it was 4831
[junit] 2016-12-15 23:27:17,836 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-12-15 23:27:17,836 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
470.597 sec, Thread: 8, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-12-15 23:27:18,054 [myid:127.0.0.1:30194] - INFO  
[main-SendThread(127.0.0.1:30194):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30194. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-12-15 23:27:18,055 [myid:127.0.0.1:30194] - WARN  
[main-SendThread(127.0.0.1:30194):ClientCnxn$SendThread@1235] - Session 
0x1024227fba0 for server 127.0.0.1/127.0.0.1:30194, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 

[GitHub] zookeeper pull request #90: ZOOKEEPER-761: Remove *synchronous* calls from t...

[breed]

Github user breed commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/90#discussion_r92719995
  
--- Diff: src/c/tests/TestClient.cc ---
@@ -47,6 +47,10 @@ struct buff_struct_2 {
 char *buffer;
 };
 
+// TODO(br33d): the vast majority of this test is not usable with single 
threaded.
--- End diff --

it's more a matter of implementing the tests than refactoring :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752784#comment-15752784
 ] 

ASF GitHub Bot commented on ZOOKEEPER-761:
--

Github user breed commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/90#discussion_r92719995
  
--- Diff: src/c/tests/TestClient.cc ---
@@ -47,6 +47,10 @@ struct buff_struct_2 {
 char *buffer;
 };
 
+// TODO(br33d): the vast majority of this test is not usable with single 
threaded.
--- End diff --

it's more a matter of implementing the tests than refactoring :)


> Remove *synchronous* calls from the *single-threaded* C clieant API, since 
> they are documented not to work
> --
>
> Key: ZOOKEEPER-761
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-761
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.1.1, 3.2.2
> Environment: RHEL 4u8 (Linux).  The issue is not OS-specific though.
>Reporter: Jozef Hatala
>Assignee: Benjamin Reed
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: fix-sync-apis-in-st-adaptor.patch, 
> fix-sync-apis-in-st-adaptor.v2.patch
>
>
> Since the synchronous calls are 
> [known|http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#Using+the+C+Client]
>  to be unimplemented in the single threaded version of the client library 
> libzookeeper_st.so, I believe that it would be helpful towards users of the 
> library if that information was also obvious from the header file.
> Anecdotally more than one of us here made the mistake of starting by using 
> the synchronous calls with the single-threaded library, and we found 
> ourselves debugging it.  An early warning would have been greatly appreciated.
> 1. Could you please add warnings to the doxygen blocks of all synchronous 
> calls saying that they are not available in the single-threaded API.  This 
> cannot be safely done with {{#ifdef THREADED}}, obviously, because the same 
> header file is included whichever client library implementation one is 
> compiling for.
> 2. Could you please bracket the implementation of all synchronous calls in 
> zookeeper.c with {{#ifdef THREADED}} and {{#endif}}, so that those symbols 
> are not present in libzookeeper_st.so?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-761:
---
Priority: Blocker  (was: Minor)

> Remove *synchronous* calls from the *single-threaded* C clieant API, since 
> they are documented not to work
> --
>
> Key: ZOOKEEPER-761
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-761
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.1.1, 3.2.2
> Environment: RHEL 4u8 (Linux).  The issue is not OS-specific though.
>Reporter: Jozef Hatala
>Assignee: Benjamin Reed
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: fix-sync-apis-in-st-adaptor.patch, 
> fix-sync-apis-in-st-adaptor.v2.patch
>
>
> Since the synchronous calls are 
> [known|http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#Using+the+C+Client]
>  to be unimplemented in the single threaded version of the client library 
> libzookeeper_st.so, I believe that it would be helpful towards users of the 
> library if that information was also obvious from the header file.
> Anecdotally more than one of us here made the mistake of starting by using 
> the synchronous calls with the single-threaded library, and we found 
> ourselves debugging it.  An early warning would have been greatly appreciated.
> 1. Could you please add warnings to the doxygen blocks of all synchronous 
> calls saying that they are not available in the single-threaded API.  This 
> cannot be safely done with {{#ifdef THREADED}}, obviously, because the same 
> header file is included whichever client library implementation one is 
> compiling for.
> 2. Could you please bracket the implementation of all synchronous calls in 
> zookeeper.c with {{#ifdef THREADED}} and {{#endif}}, so that those symbols 
> are not present in libzookeeper_st.so?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2646) Java target in branch 3.4 doesn't match documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752711#comment-15752711
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2646:
---

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/127
  
The test failure is simply because the pr test script doesn't exist in the 
3.4 branch. 


> Java target in branch 3.4 doesn't match documentation 
> --
>
> Key: ZOOKEEPER-2646
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2646
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.9
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.10
>
>
> Need to update build.xml 1.5->1.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #127: ZOOKEEPER-2646: Java target in branch 3.4 doesn't matc...

[fpj]

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/127
  
The test failure is simply because the pr test script doesn't exist in the 
3.4 branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2646) Java target in branch 3.4 doesn't match documentation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752707#comment-15752707
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2646:
---

GitHub user fpj opened a pull request:

https://github.com/apache/zookeeper/pull/127

ZOOKEEPER-2646: Java target in branch 3.4 doesn't match documentation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fpj/zookeeper ZK-2646

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit e6732f17d8df8b4815e4464f972f56ddc2322aea
Author: fpj 
Date:   2016-12-15T22:26:36Z

ZOOKEEPER-2646: Java target in branch 3.4 doesn't match documentation




> Java target in branch 3.4 doesn't match documentation 
> --
>
> Key: ZOOKEEPER-2646
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2646
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.9
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.10
>
>
> Need to update build.xml 1.5->1.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER- PreCommit Build #126

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/126/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 25 lines...]
  Getting sizes
Done: 2
  Compressing objects
Done: 0
  Writing objects
Done: 3
  remote: Updating references
Merging refs/tags/changes/126
 > git rev-parse refs/tags/changes/126^{commit} # timeout=10
 > git merge e6732f17d8df8b4815e4464f972f56ddc2322aea # timeout=10
 > git rev-parse branch-3.4^{commit} # timeout=10
Checking out Revision e6732f17d8df8b4815e4464f972f56ddc2322aea (branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e6732f17d8df8b4815e4464f972f56ddc2322aea
 > git rev-parse origin/branch-3.4^{commit} # timeout=10
 > git rev-list 48adec48be35f10a8fa45ecf6a7bdfc3a10a7f3c # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson6534833748294434540.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper pull request #127: ZOOKEEPER-2646: Java target in branch 3.4 doesn...

[fpj]

GitHub user fpj opened a pull request:

https://github.com/apache/zookeeper/pull/127

ZOOKEEPER-2646: Java target in branch 3.4 doesn't match documentation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fpj/zookeeper ZK-2646

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit e6732f17d8df8b4815e4464f972f56ddc2322aea
Author: fpj 
Date:   2016-12-15T22:26:36Z

ZOOKEEPER-2646: Java target in branch 3.4 doesn't match documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (ZOOKEEPER-2646) Java target in branch 3.4 doesn't match documentation

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-2646:

Affects Version/s: 3.4.9

> Java target in branch 3.4 doesn't match documentation 
> --
>
> Key: ZOOKEEPER-2646
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2646
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.9
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.10
>
>
> Need to update build.xml 1.5->1.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2646) Java target in branch 3.4 doesn't match documentation

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-2646:

Fix Version/s: 3.4.10

> Java target in branch 3.4 doesn't match documentation 
> --
>
> Key: ZOOKEEPER-2646
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2646
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.9
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
> Fix For: 3.4.10
>
>
> Need to update build.xml 1.5->1.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2646) Java target in branch 3.4 doesn't match documentation

[Flavio Junqueira (JIRA)]

Flavio Junqueira created ZOOKEEPER-2646:
---

 Summary: Java target in branch 3.4 doesn't match documentation 
 Key: ZOOKEEPER-2646
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2646
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira


Need to update build.xml 1.5->1.6.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752671#comment-15752671
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2383:
---

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/101#discussion_r92712695
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/ZooKeeperServerStartupTest.java ---
@@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.server;
+
+import static 
org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.zookeeper.PortAssignment;
+import org.apache.zookeeper.ZKTestCase;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.common.X509Exception.SSLContextException;
+import org.apache.zookeeper.test.ClientBase;
+import org.apache.zookeeper.test.ClientBase.CountdownWatcher;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This class tests the startup behavior of ZooKeeper server.
+ */
+public class ZooKeeperServerStartupTest extends ZKTestCase {
+private static final Logger LOG = LoggerFactory
+.getLogger(ZooKeeperServerStartupTest.class);
+private static int PORT = PortAssignment.unique();
+private static String HOST = "127.0.0.1";
+private static String HOSTPORT = HOST + ":" + PORT;
+private static final String ZK_NOT_SERVING = "This ZooKeeper instance 
is not currently serving requests";
+
+private ServerCnxnFactory servcnxnf;
+private ZooKeeperServer zks;
+private File tmpDir;
+private CountDownLatch startupDelayLatch = new CountDownLatch(1);
+
+@After
+public void teardown() throws Exception {
+// count down to avoid infinite blocking call due to this latch, if
+// any.
+startupDelayLatch.countDown();
+
+if (servcnxnf != null) {
+servcnxnf.shutdown();
+}
+if (zks != null) {
+zks.shutdown();
+}
+if (zks.getZKDatabase() != null) {
+zks.getZKDatabase().close();
+}
+ClientBase.recursiveDelete(tmpDir);
+}
+
+/**
+ * Test case for
+ * {@link https://issues.apache.org/jira/browse/ZOOKEEPER-2383}.
+ */
+@Test(timeout = 3)
+public void testClientConnectionRequestDuringStartupWithNIOServerCnxn()
+throws Exception {
+tmpDir = ClientBase.createTmpDir();
+ClientBase.setupTestEnv();
+
+startSimpleZKServer(startupDelayLatch);
+SimpleZooKeeperServer simplezks = (SimpleZooKeeperServer) zks;
+Assert.assertTrue(
+"Failed to invoke zks#startup() method during server 
startup",
+simplezks.waitForStartupInvocation(10));
+
+CountdownWatcher watcher = new CountdownWatcher();
+ZooKeeper zkClient = new ZooKeeper(HOSTPORT,
+ClientBase.CONNECTION_TIMEOUT, watcher);
+
+Assert.assertFalse(
+"Since server is not fully started, zks#createSession() 
shouldn't be invoked",
+simplezks.waitForSessionCreation(5));
+
+LOG.info(
+"Decrements the count of the latch, so that server will 
proceed with startup");
+startupDelayLatch.countDown();
+
+Assert.assertTrue("waiting for server being up ", ClientBase
+.waitForServerUp(HOSTPORT, ClientBase.CONNECTION_TIMEOUT));
+
+Assert.assertTrue(
+"Failed to invoke 

[GitHub] zookeeper pull request #101: ZOOKEEPER-2383

[fpj]

Github user fpj commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/101#discussion_r92712695
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/ZooKeeperServerStartupTest.java ---
@@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.server;
+
+import static 
org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.zookeeper.PortAssignment;
+import org.apache.zookeeper.ZKTestCase;
+import org.apache.zookeeper.ZooKeeper;
+import org.apache.zookeeper.common.X509Exception.SSLContextException;
+import org.apache.zookeeper.test.ClientBase;
+import org.apache.zookeeper.test.ClientBase.CountdownWatcher;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * This class tests the startup behavior of ZooKeeper server.
+ */
+public class ZooKeeperServerStartupTest extends ZKTestCase {
+private static final Logger LOG = LoggerFactory
+.getLogger(ZooKeeperServerStartupTest.class);
+private static int PORT = PortAssignment.unique();
+private static String HOST = "127.0.0.1";
+private static String HOSTPORT = HOST + ":" + PORT;
+private static final String ZK_NOT_SERVING = "This ZooKeeper instance 
is not currently serving requests";
+
+private ServerCnxnFactory servcnxnf;
+private ZooKeeperServer zks;
+private File tmpDir;
+private CountDownLatch startupDelayLatch = new CountDownLatch(1);
+
+@After
+public void teardown() throws Exception {
+// count down to avoid infinite blocking call due to this latch, if
+// any.
+startupDelayLatch.countDown();
+
+if (servcnxnf != null) {
+servcnxnf.shutdown();
+}
+if (zks != null) {
+zks.shutdown();
+}
+if (zks.getZKDatabase() != null) {
+zks.getZKDatabase().close();
+}
+ClientBase.recursiveDelete(tmpDir);
+}
+
+/**
+ * Test case for
+ * {@link https://issues.apache.org/jira/browse/ZOOKEEPER-2383}.
+ */
+@Test(timeout = 3)
+public void testClientConnectionRequestDuringStartupWithNIOServerCnxn()
+throws Exception {
+tmpDir = ClientBase.createTmpDir();
+ClientBase.setupTestEnv();
+
+startSimpleZKServer(startupDelayLatch);
+SimpleZooKeeperServer simplezks = (SimpleZooKeeperServer) zks;
+Assert.assertTrue(
+"Failed to invoke zks#startup() method during server 
startup",
+simplezks.waitForStartupInvocation(10));
+
+CountdownWatcher watcher = new CountdownWatcher();
+ZooKeeper zkClient = new ZooKeeper(HOSTPORT,
+ClientBase.CONNECTION_TIMEOUT, watcher);
+
+Assert.assertFalse(
+"Since server is not fully started, zks#createSession() 
shouldn't be invoked",
+simplezks.waitForSessionCreation(5));
+
+LOG.info(
+"Decrements the count of the latch, so that server will 
proceed with startup");
+startupDelayLatch.countDown();
+
+Assert.assertTrue("waiting for server being up ", ClientBase
+.waitForServerUp(HOSTPORT, ClientBase.CONNECTION_TIMEOUT));
+
+Assert.assertTrue(
+"Failed to invoke zks#createSession() method during client 
session creation",
+simplezks.waitForSessionCreation(5));
+watcher.waitForConnected(ClientBase.CONNECTION_TIMEOUT);
+zkClient.close();
+}
+
+/**
+ * Test 

ZooKeeper-trunk-openjdk7 - Build # 1278 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1278/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H12 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision cd0e323831c8b4cde64976325bfc79bb53cdd9b7 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f cd0e323831c8b4cde64976325bfc79bb53cdd9b7
 > git rev-list cd0e323831c8b4cde64976325bfc79bb53cdd9b7 # timeout=10
No emails were triggered.
[ZooKeeper-trunk-openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant 
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml 
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #125

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/125/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 24 lines...]
  Getting sizes
Done: 14
  Compressing objects
Done: 0
  Writing objects
Done: 15
  remote: Updating references
Merging refs/tags/changes/125
 > git rev-parse refs/tags/changes/125^{commit} # timeout=10
 > git merge 81451ddc233bbc07fe45b341e18ed5644c0ede4b # timeout=10
 > git rev-parse branch-3.4^{commit} # timeout=10
Checking out Revision 7f414d5f968ae94386df8546c9fc4c120e61b27c (branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 7f414d5f968ae94386df8546c9fc4c120e61b27c
 > git rev-parse origin/branch-3.4^{commit} # timeout=10
 > git rev-list 48adec48be35f10a8fa45ecf6a7bdfc3a10a7f3c # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson5670114933572153288.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752233#comment-15752233
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2470:
---

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/125
  
@hanm @rakeshadr Just a reminder: this patch will need to be applied to 
branch-3.5 and master too. The `zk-merge-pr.py` allows to do this, but a 
cherry-pick of this PR commit also does the work.


> ServerConfig#parse(String[])  ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Edward Ribeiro
>Priority: Trivial
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #125: ZOOKEEPER-2470: ServerConfig#parse(String[]) ignores t...

[eribeiro]

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/125
  
@hanm @rakeshadr Just a reminder: this patch will need to be applied to 
branch-3.5 and master too. The `zk-merge-pr.py` allows to do this, but a 
cherry-pick of this PR commit also does the work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752218#comment-15752218
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2470:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/125
  
+1. @rakeshadr please take a look and merge if this looks good to you.


> ServerConfig#parse(String[])  ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Edward Ribeiro
>Priority: Trivial
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #125: ZOOKEEPER-2470: ServerConfig#parse(String[]) ignores t...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/125
  
+1. @rakeshadr please take a look and merge if this looks good to you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752213#comment-15752213
 ] 

Michael Han commented on ZOOKEEPER-2325:


I noticed that the pull request of ZOOKEEPER-261 contains changes in 
ZOOKEEPER-2325 already: https://github.com/apache/zookeeper/pull/120/commits


> Data inconsistency if all snapshots empty or missing
> 
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
>Assignee: Andrew Grasso
>Priority: Critical
> Attachments: ZOOKEEPER-2325-test.patch, ZOOKEEPER-2325.001.patch, 
> zk.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the 
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found. 
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin 
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[Benjamin Reed (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752196#comment-15752196
 ] 

Benjamin Reed commented on ZOOKEEPER-2325:
--

[~rgs] can you commit this? we need it to get ZOOKEEPER-261 in.

> Data inconsistency if all snapshots empty or missing
> 
>
> Key: ZOOKEEPER-2325
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2325
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6
>Reporter: Andrew Grasso
>Assignee: Andrew Grasso
>Priority: Critical
> Attachments: ZOOKEEPER-2325-test.patch, ZOOKEEPER-2325.001.patch, 
> zk.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When loading state from snapshots on startup, FileTxnSnapLog.java ignores the 
> result of FileSnap.deserialize, which is -1L if no valid snapshots are found. 
> Recovery proceeds with dt.lastProcessed == 0, its initial value.
> The result is that Zookeeper will process the transaction logs and then begin 
> serving requests with a different state than the rest of the ensemble.
> To reproduce:
> In a healthy zookeeper cluster of size >= 3, shut down one node.
> Either delete all snapshots for this node or change all to be empty files.
> Restart the node.
> We believe this can happen organically if a node runs out of disk space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2470) ServerConfig#parse(String[]) ignores tickTime

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752084#comment-15752084
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2470:
---

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/125
  
@hanm Added a couple of tests to (hopefully) guard against regressions. 
:+1: 


> ServerConfig#parse(String[])  ignores tickTime
> --
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Alexander Shraer
>Assignee: Edward Ribeiro
>Priority: Trivial
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #125: ZOOKEEPER-2470: ServerConfig#parse(String[]) ignores t...

[eribeiro]

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/125
  
@hanm Added a couple of tests to (hopefully) guard against regressions. 
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2465) Documentation copyright notice is out of date.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752032#comment-15752032
 ] 

Hadoop QA commented on ZOOKEEPER-2465:
--

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12828341/ZOOKEEPER-2465.2.patch
  against trunk revision cd0e323831c8b4cde64976325bfc79bb53cdd9b7.

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3550//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3550//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3550//console

This message is automatically generated.

> Documentation copyright notice is out of date.
> --
>
> Key: ZOOKEEPER-2465
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2465
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Chris Nauroth
>Assignee: Edward Ribeiro
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2465.2.patch, ZOOKEEPER-2465.patch
>
>
> As reported by [~eribeiro], all of the documentation pages show a copyright 
> notice dating "2008-2013".  This issue tracks updating the copyright notice 
> on all documentation pages to show the current year.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2465 PreCommit Build #3550

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2465
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3550/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 478150 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3550//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3550//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3550//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 5b175efe9056e46063f372922b2da628be16c32e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 47 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2465
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #126: ZOOKEEPER-2465: Documentation copyright notice is out ...

[eribeiro]

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/126
  
@cnauroth and @fpj, this patch applies cleanly for both branch-3.5 and 
master. I also re-generated the docs to see if the year interval was omitted.

PS: unfortunately, it doesn't apply to branch-3.4 due to many new features 
and changes, so let me know if you want a variation of this PR targeting 
branch-3.4 (still unsure how to do this).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2465) Documentation copyright notice is out of date.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751999#comment-15751999
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2465:
---

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/126
  
@cnauroth and @fpj, this patch applies cleanly for both branch-3.5 and 
master. I also re-generated the docs to see if the year interval was omitted.

PS: unfortunately, it doesn't apply to branch-3.4 due to many new features 
and changes, so let me know if you want a variation of this PR targeting 
branch-3.4 (still unsure how to do this).


> Documentation copyright notice is out of date.
> --
>
> Key: ZOOKEEPER-2465
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2465
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Chris Nauroth
>Assignee: Edward Ribeiro
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2465.2.patch, ZOOKEEPER-2465.patch
>
>
> As reported by [~eribeiro], all of the documentation pages show a copyright 
> notice dating "2008-2013".  This issue tracks updating the copyright notice 
> on all documentation pages to show the current year.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2465) Documentation copyright notice is out of date.

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751992#comment-15751992
 ] 

Edward Ribeiro commented on ZOOKEEPER-2465:
---

hey [~cnauroth] and [~fpj], sorry taking too much time procrastinating on this 
issue. According the fruitful discussions we had back in September, 2016 (link 
provided by Flavio above), I have removed the date from copyright notices on 
current docs as well as in template XML that generates the HTML and PDFs. See 
if you agree, please.

> Documentation copyright notice is out of date.
> --
>
> Key: ZOOKEEPER-2465
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2465
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Chris Nauroth
>Assignee: Edward Ribeiro
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2465.2.patch, ZOOKEEPER-2465.patch
>
>
> As reported by [~eribeiro], all of the documentation pages show a copyright 
> notice dating "2008-2013".  This issue tracks updating the copyright notice 
> on all documentation pages to show the current year.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2465) Documentation copyright notice is out of date.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751967#comment-15751967
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2465:
---

GitHub user eribeiro opened a pull request:

https://github.com/apache/zookeeper/pull/126

ZOOKEEPER-2465: Documentation copyright notice is out of date.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2465

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit fea03adb512a6414e5b8733416c4bc3ef202d2cc
Author: Edward Ribeiro 
Date:   2016-12-15T17:25:24Z

ZOOKEEPER-2465: Documentation copyright notice is out of date.




> Documentation copyright notice is out of date.
> --
>
> Key: ZOOKEEPER-2465
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2465
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Chris Nauroth
>Assignee: Edward Ribeiro
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2465.2.patch, ZOOKEEPER-2465.patch
>
>
> As reported by [~eribeiro], all of the documentation pages show a copyright 
> notice dating "2008-2013".  This issue tracks updating the copyright notice 
> on all documentation pages to show the current year.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER- PreCommit Build #124

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/124/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 25 lines...]
Done: 18
  Compressing objects
Done: 0
  Writing objects
Done: 24
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/124
 > git rev-parse refs/tags/changes/124^{commit} # timeout=10
 > git merge fea03adb512a6414e5b8733416c4bc3ef202d2cc # timeout=10
 > git rev-parse branch-3.5^{commit} # timeout=10
Checking out Revision fea03adb512a6414e5b8733416c4bc3ef202d2cc (branch-3.5)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f fea03adb512a6414e5b8733416c4bc3ef202d2cc
 > git rev-parse origin/branch-3.5^{commit} # timeout=10
 > git rev-list e99c68316ecf19a1941fbf1290f11c4a65c1e268 # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson2043507395778203276.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper pull request #126: ZOOKEEPER-2465: Documentation copyright notice ...

[eribeiro]

GitHub user eribeiro opened a pull request:

https://github.com/apache/zookeeper/pull/126

ZOOKEEPER-2465: Documentation copyright notice is out of date.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2465

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit fea03adb512a6414e5b8733416c4bc3ef202d2cc
Author: Edward Ribeiro 
Date:   2016-12-15T17:25:24Z

ZOOKEEPER-2465: Documentation copyright notice is out of date.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch35_solaris - Build # 352 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/352/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 465971 lines...]
[junit] 2016-12-15 17:16:13,264 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-12-15 17:16:13,264 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-12-15 17:16:13,265 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-12-15 17:16:13,266 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-12-15 17:16:13,266 [myid:] - INFO  [main:ZooKeeperServer@893] 
- minSessionTimeout set to 6000
[junit] 2016-12-15 17:16:13,266 [myid:] - INFO  [main:ZooKeeperServer@902] 
- maxSessionTimeout set to 6
[junit] 2016-12-15 17:16:13,266 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test3669259344391286468.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test3669259344391286468.junit.dir/version-2
[junit] 2016-12-15 17:16:13,268 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test3669259344391286468.junit.dir/version-2/snapshot.b
[junit] 2016-12-15 17:16:13,271 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test3669259344391286468.junit.dir/version-2/snapshot.b
[junit] 2016-12-15 17:16:13,272 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 17:16:13,272 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-12-15 17:16:13,273 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:37454
[junit] 2016-12-15 17:16:13,275 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:37454
[junit] 2016-12-15 17:16:13,275 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-12-15 17:16:13,275 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:37454 (no session established for client)
[junit] 2016-12-15 17:16:13,276 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-12-15 17:16:13,278 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-12-15 17:16:13,278 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-12-15 17:16:13,278 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-12-15 17:16:13,278 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-12-15 17:16:13,278 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17745
[junit] 2016-12-15 17:16:13,279 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-12-15 17:16:13,279 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-12-15 17:16:13,279 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-12-15 17:16:13,342 [myid:] - INFO  [main:ZooKeeper@1311] - 
Session: 0x1258075d242 closed
[junit] 2016-12-15 17:16:13,343 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-12-15 17:16:13,343 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1258075d242
[junit] 2016-12-15 17:16:13,343 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-12-15 17:16:13,381 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-12-15 17:16:13,381 [myid:] - INFO  

Failed: ZOOKEEPER- PreCommit Build #123

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/123/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 25 lines...]
  Getting sizes
Done: 23
  Compressing objects
Done: 0
  Writing objects
Done: 25
  remote: Updating references
Merging refs/tags/changes/123
 > git rev-parse refs/tags/changes/123^{commit} # timeout=10
 > git merge 42b16bfaefdbe1589cc16f3e088cd36556ac347f # timeout=10
 > git rev-parse branch-3.4^{commit} # timeout=10
Checking out Revision 73cf51e557ff7c725e0dd20e8b356c4a756fbe77 (branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 73cf51e557ff7c725e0dd20e8b356c4a756fbe77
 > git rev-parse origin/branch-3.4^{commit} # timeout=10
 > git rev-list 48adec48be35f10a8fa45ecf6a7bdfc3a10a7f3c # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson5630140046602492297.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-2644) contrib/rest does not include rest.sh when packaged

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2644:
--
Assignee: Edward Ribeiro

> contrib/rest does not include rest.sh when packaged
> ---
>
> Key: ZOOKEEPER-2644
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2644
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: contrib
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Minoru Osuka
>Assignee: Edward Ribeiro
>Priority: Minor
> Attachments: ZOOKEEPER-2644.patch
>
>
> contrib/rest does not include rest.sh when packaged. I propose to add rest.sh 
> into tar.gz that it make ZooKeeper REST easier to use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2644) contrib/rest does not include rest.sh when packaged

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro updated ZOOKEEPER-2644:
--
Assignee: (was: Edward Ribeiro)

> contrib/rest does not include rest.sh when packaged
> ---
>
> Key: ZOOKEEPER-2644
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2644
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: contrib
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Minoru Osuka
>Priority: Minor
> Attachments: ZOOKEEPER-2644.patch
>
>
> contrib/rest does not include rest.sh when packaged. I propose to add rest.sh 
> into tar.gz that it make ZooKeeper REST easier to use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-2644) contrib/rest does not include rest.sh when packaged

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751730#comment-15751730
 ] 

Edward Ribeiro edited comment on ZOOKEEPER-2644 at 12/15/16 4:00 PM:
-

Hi, [~minoru], thanks for the patch! 

FYI, the ZK community is transitioning to a Github based contribution workflow, 
so would you mind to open a Pull Request on this issue? More instructions here: 
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

Cheers!


was (Author: eribeiro):
Hi, [~minoru], thanks for the patch! 

FYI, the ZK community is moving to a Github based contributions, so you would 
mind to open a Pull Request on this issue? More instructions here: 
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

Cheers!

> contrib/rest does not include rest.sh when packaged
> ---
>
> Key: ZOOKEEPER-2644
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2644
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: contrib
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Minoru Osuka
>Priority: Minor
> Attachments: ZOOKEEPER-2644.patch
>
>
> contrib/rest does not include rest.sh when packaged. I propose to add rest.sh 
> into tar.gz that it make ZooKeeper REST easier to use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2644) contrib/rest does not include rest.sh when packaged

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751730#comment-15751730
 ] 

Edward Ribeiro commented on ZOOKEEPER-2644:
---

Hi, [~minoru], thanks for the patch! 

FYI, the ZK community is moving to a Github based contributions, so you would 
mind to open a Pull Request on this issue? More instructions here: 
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

Cheers!

> contrib/rest does not include rest.sh when packaged
> ---
>
> Key: ZOOKEEPER-2644
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2644
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: contrib
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Minoru Osuka
>Priority: Minor
> Attachments: ZOOKEEPER-2644.patch
>
>
> contrib/rest does not include rest.sh when packaged. I propose to add rest.sh 
> into tar.gz that it make ZooKeeper REST easier to use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_openjdk7 - Build # 1309 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1309/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H12 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
Cloning the remote Git repository
Cloning repository git://git.apache.org/zookeeper.git
 > git init /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7 # 
 > timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision 48adec48be35f10a8fa45ecf6a7bdfc3a10a7f3c 
(refs/remotes/origin/branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 48adec48be35f10a8fa45ecf6a7bdfc3a10a7f3c
 > git rev-list 2afed855ad966d4c4cd0370e6d24a01c04e75d67 # timeout=10
First time build. Skipping changelog.
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant 
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml 
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch34_solaris - Build # 1392 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1392/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 187850 lines...]
[junit] 2016-12-15 14:55:39,753 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2016-12-15 14:55:39,753 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 14:55:39,753 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2016-12-15 14:55:39,753 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-12-15 14:55:39,753 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2016-12-15 14:55:39,753 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2016-12-15 14:55:39,753 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2016-12-15 14:55:39,754 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2016-12-15 14:55:39,754 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-12-15 14:55:39,754 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-12-15 14:55:39,755 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2016-12-15 14:55:39,755 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2016-12-15 14:55:39,756 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2016-12-15 14:55:39,756 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2016-12-15 14:55:39,756 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test2789248252480716828.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test2789248252480716828.junit.dir/version-2
[junit] 2016-12-15 14:55:39,759 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 14:55:39,759 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-12-15 14:55:39,759 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:50654
[junit] 2016-12-15 14:55:39,760 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:50654
[junit] 2016-12-15 14:55:39,760 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2016-12-15 14:55:39,760 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:50654 (no session established for client)
[junit] 2016-12-15 14:55:39,760 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-12-15 14:55:39,762 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2016-12-15 14:55:39,762 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2016-12-15 14:55:39,762 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-12-15 14:55:39,763 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-12-15 14:55:39,763 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 9048
[junit] 2016-12-15 14:55:39,764 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2016-12-15 14:55:39,764 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2016-12-15 14:55:39,764 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2016-12-15 14:55:39,847 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x15902fb466e closed
[junit] 2016-12-15 14:55:39,847 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2016-12-15 14:55:39,847 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x15902fb466e
[junit] 2016-12-15 14:55:39,847 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2016-12-15 14:55:39,848 [myid:] - 

[jira] [Commented] (ZOOKEEPER-2251) Add Client side packet response timeout to avoid infinite wait.

[Mel Martinez (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751475#comment-15751475
 ] 

Mel Martinez commented on ZOOKEEPER-2251:
-

Yes, we've been figuring this out.

Unfortunately, customer deployment requirements can sometimes limit our control 
over the environment.  We are trying to make things as robust and fault 
tolerant as possible while still allowing for as much flexibility in how things 
are deployed.  There are obviously limits to that!


> Add Client side packet response timeout to avoid infinite wait.
> ---
>
> Key: ZOOKEEPER-2251
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2251
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.9, 3.5.2
>Reporter: nijel
>Assignee: Arshad Mohammad
>Priority: Critical
>  Labels: fault
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2251-01.patch, ZOOKEEPER-2251-02.patch, 
> ZOOKEEPER-2251-03.patch, ZOOKEEPER-2251-04.patch
>
>
> I came across one issue related to Client side packet response timeout In my 
> cluster many packet drops happened for some time.
> One observation is the zookeeper client got hanged. As per the thread dump it 
> is waiting for the response/ACK for the operation performed (synchronous API 
> used here).
> I am using 
> zookeeper.serverCnxnFactory=org.apache.zookeeper.server.NIOServerCnxnFactory
> Since only few packets missed there is no DISCONNECTED event occurred.
> Need add a "response time out" for the operations or packets.
> *Comments from [~rakeshr]*
> My observation about the problem:-
> * Can use tools like 'Wireshark' to simulate the artificial packet loss.
> * Assume there is only one packet in the 'outgoingQueue' and unfortunately 
> the server response packet lost. Now, client will enter into infinite 
> waiting. 
> https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java#L1515
> * Probably we can discuss more about this problem and possible solutions(add 
> packet ACK timeout or another better approach) in the jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_solaris - Build # 1391 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1391/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 190693 lines...]
[junit] 2016-12-15 14:06:04,805 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-12-15 14:06:04,806 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2016-12-15 14:06:04,806 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2016-12-15 14:06:04,807 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2016-12-15 14:06:04,807 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2016-12-15 14:06:04,810 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test5856017792301846460.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test5856017792301846460.junit.dir/version-2
[junit] 2016-12-15 14:06:04,814 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 14:06:04,814 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-12-15 14:06:04,815 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:42708
[junit] 2016-12-15 14:06:04,815 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:42708
[junit] 2016-12-15 14:06:04,815 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2016-12-15 14:06:04,816 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:42708 (no session established for client)
[junit] 2016-12-15 14:06:04,816 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-12-15 14:06:04,817 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2016-12-15 14:06:04,817 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2016-12-15 14:06:04,817 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-12-15 14:06:04,818 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-12-15 14:06:04,818 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 9048
[junit] 2016-12-15 14:06:04,818 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2016-12-15 14:06:04,818 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2016-12-15 14:06:04,818 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2016-12-15 14:06:05,522 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x15902cdd8fa closed
[junit] 2016-12-15 14:06:05,522 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2016-12-15 14:06:05,522 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x15902cdd8fa
[junit] 2016-12-15 14:06:05,523 [myid:] - WARN  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@213] - 
Ignoring unexpected runtime exception
[junit] java.nio.channels.CancelledKeyException
[junit] at 
sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
[junit] at 
sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:69)
[junit] at 
org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:182)
[junit] at java.lang.Thread.run(Thread.java:662)
[junit] 2016-12-15 14:06:05,524 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2016-12-15 14:06:05,524 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 14:06:05,524 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2016-12-15 14:06:05,524 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-12-15 14:06:05,524 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2016-12-15 14:06:05,524 [myid:] - INFO  [ProcessThread(sid:0 

Failed: ZOOKEEPER- PreCommit Build #122

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/122/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 30 lines...]
at hudson.remoting.Request$2.run(Request.java:332)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to H6(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:781)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:249)
at com.sun.proxy.$Proxy90.checkoutBranch(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.checkoutBranch(RemoteGitImpl.java:327)
at 
com.cloudbees.jenkins.plugins.git.vmerge.BuildChooserImpl.getCandidateRevisions(BuildChooserImpl.java:78)
at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:984)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1087)
at hudson.scm.SCM.checkout(SCM.java:485)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1269)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1741)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: hudson.plugins.git.GitException: Command "git checkout -f 
origin/trunk" returned status code 1:
stdout: 
stderr: error: pathspec 'origin/trunk' did not match any file(s) known to git.

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1723)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1699)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1695)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1317)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1329)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:1979)
at 
org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.checkoutBranch(AbstractGitAPIImpl.java:82)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.checkoutBranch(CliGitAPIImpl.java:63)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:884)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:859)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:818)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:332)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Archiving artifacts
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper-trunk-jdk8 - Build # 857 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/857/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 452485 lines...]
[junit] 2016-12-15 13:09:21,569 [myid:127.0.0.1:30073] - WARN  
[main-SendThread(127.0.0.1:30073):ClientCnxn$SendThread@1235] - Session 
0x1019646edae for server 127.0.0.1/127.0.0.1:30073, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-12-15 13:09:21,951 [myid:] - INFO  [ProcessThread(sid:0 
cport:30317)::PrepRequestProcessor@618] - Processed session termination for 
sessionid: 0x1019650329a
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30317,name1=Connections,name2=127.0.0.1,name3=0x1019650329a]
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1019650329a closed
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 185206
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1644
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1019650329a
[junit] 2016-12-15 13:09:21,984 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:30317
[junit] 2016-12-15 13:09:21,992 [myid:] - INFO  [main:ZooKeeperServer@534] 
- shutting down
[junit] 2016-12-15 13:09:21,992 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 13:09:21,992 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-12-15 13:09:21,993 [myid:] - INFO  
[main:PrepRequestProcessor@1009] - Shutting down
[junit] 2016-12-15 13:09:21,993 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-12-15 13:09:21,993 [myid:] - INFO  [ProcessThread(sid:0 
cport:30317)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2016-12-15 13:09:21,993 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-12-15 13:09:21,993 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2016-12-15 13:09:21,993 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30317,name1=InMemoryDataTree]
[junit] 2016-12-15 13:09:21,993 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30317]
[junit] 2016-12-15 13:09:21,994 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 30317
[junit] 2016-12-15 13:09:21,994 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-12-15 13:09:22,013 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4838 at start it was 4838
[junit] 2016-12-15 13:09:22,013 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-12-15 13:09:22,013 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
614.235 sec, Thread: 8, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-12-15 13:09:22,163 [myid:127.0.0.1:30200] - INFO  
[main-SendThread(127.0.0.1:30200):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30200. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-12-15 13:09:22,163 [myid:127.0.0.1:30200] - WARN  
[main-SendThread(127.0.0.1:30200):ClientCnxn$SendThread@1235] - Session 
0x301964c8ed0 for server 127.0.0.1/127.0.0.1:30200, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] 

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[Jordan Zimmerman (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751303#comment-15751303
 ] 

Jordan Zimmerman commented on ZOOKEEPER-2642:
-

The test failures seem to be a chronic issue in ZK in general and not related 
to this PR: 
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?jql=project%20%3D%20ZOOKEEPER%20AND%20text%20~%20%22AssertionFailedError%3A%20waiting%20for%20server%22

> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751278#comment-15751278
 ] 

Hadoop QA commented on ZOOKEEPER-2642:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12843404/ZOOKEEPER-2642.patch
  against trunk revision cd0e323831c8b4cde64976325bfc79bb53cdd9b7.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 21 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3549//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3549//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3549//console

This message is automatically generated.

> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2642 PreCommit Build #3549

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3549/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 482289 lines...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3549//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3549//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3549//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 520357c0c8969de35e0d638b61e507696290d0f5 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1607: 
exec returned: 1

Total time: 17 minutes 49 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Compressed 555.64 KB of artifacts by 40.3% relative to #3537
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2642
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.SSLTest.testSecureQuorumServer

Error Message:
waiting for server 0 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 0 being up
at 
org.apache.zookeeper.test.SSLTest.testSecureQuorumServer(SSLTest.java:96)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-2230) Connections fo ZooKeeper server becomes slow over time with native GSSAPI

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751260#comment-15751260
 ] 

Hadoop QA commented on ZOOKEEPER-2230:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12830500/ZOOKEEPER-2230.patch
  against trunk revision cd0e323831c8b4cde64976325bfc79bb53cdd9b7.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3548//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3548//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3548//console

This message is automatically generated.

> Connections fo ZooKeeper server becomes slow over time with native GSSAPI
> -
>
> Key: ZOOKEEPER-2230
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2230
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.5.0
> Environment: OS: RHEL6
> Java: 1.8.0_40
> Configuration:
> java.env:
> {noformat}
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Xmx5120m"
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS 
> -Djava.security.auth.login.config=/local/apps/zookeeper-test1/conf/jaas-server.conf"
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Dsun.security.jgss.native=true"
> {noformat}
> jaas-server.conf:
> {noformat}
> Server {
> com.sun.security.auth.module.Krb5LoginModule required
> useKeyTab=true
> isInitiator=false
> principal="zookeeper/@";
> };
> {noformat}
> Process environment:
> {noformat}
> KRB5_KTNAME=/local/apps/zookeeper-test1/conf/keytab
> ZOO_LOG_DIR=/local/apps/zookeeper-test1/log
> ZOOCFGDIR=/local/apps/zookeeper-test1/conf
> {noformat}
>Reporter: Deepesh Reja
>Assignee: Enis Soztutar
>  Labels: patch
> Fix For: 3.4.6, 3.4.7, 3.4.8, 3.5.2
>
> Attachments: ZOOKEEPER-2230.patch
>
>
> ZooKeeper server becomes slow over time when native GSSAPI is used. The 
> connection to the server starts taking upto 10 seconds.
> This is happening with ZooKeeper-3.4.6 and is fairly reproducible.
> Debug logs:
> {noformat}
> 2015-07-02 00:58:49,318 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:NIOServerCnxnFactory@197] - 
> Accepted socket connection from /:47942
> 2015-07-02 00:58:49,318 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@78] - 
> serviceHostname is ''
> 2015-07-02 00:58:49,318 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@79] - 
> servicePrincipalName is 'zookeeper'
> 2015-07-02 00:58:49,318 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@80] - SASL 
> mechanism(mech) is 'GSSAPI'
> 2015-07-02 00:58:49,324 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@106] - Added 
> private credential to subject: [GSSCredential: 
> zookeeper@ 1.2.840.113554.1.2.2 Accept [class 
> sun.security.jgss.wrapper.GSSCredElement]]
> 2015-07-02 00:58:59,441 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@810] - Session 
> establishment request from client /:47942 client's lastZxid is 0x0
> 2015-07-02 00:58:59,441 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@868] - Client 
> attempting to establish new session at /:47942
> 2015-07-02 00:58:59,448 [myid:] - DEBUG 
> [SyncThread:0:FinalRequestProcessor@88] - Processing request:: 
> sessionid:0x14e486028785c81 type:createSession cxid:0x0 zxid:0x110e79 
> txntype:-10 reqpath:n/a
> 2015-07-02 00:58:59,448 [myid:] - DEBUG 
> [SyncThread:0:FinalRequestProcessor@160] - sessionid:0x14e486028785c81 
> type:createSession cxid:0x0 zxid:0x110e79 txntype:-10 reqpath:n/a
> 2015-07-02 00:58:59,448 [myid:] - INFO  [SyncThread:0:ZooKeeperServer@617] - 
> Established session 0x14e486028785c81 with negotiated timeout 1 for 
> 

Success: ZOOKEEPER- PreCommit Build #121

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/121/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 472778 lines...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 21 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/121//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/121//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/121//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] be5ba43c81db34092baad030ea0e8a4aeef93145 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 19 minutes 19 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2642
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751261#comment-15751261
 ] 

Hadoop QA commented on ZOOKEEPER-2642:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 21 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/121//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/121//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/121//console

This message is automatically generated.

> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2230 PreCommit Build #3548

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2230
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3548/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 475343 lines...]
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3548//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3548//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3548//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 00077875cb73c61dc2cdf067cb45c12cf34b6172 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1607: 
exec returned: 1

Total time: 19 minutes 1 second
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2230
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[Jordan Zimmerman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jordan Zimmerman updated ZOOKEEPER-2642:

Attachment: ZOOKEEPER-2642.patch

Note deprecated APIs in the doc and fix some style issues in ZooKeeper.java

> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2230) Connections fo ZooKeeper server becomes slow over time with native GSSAPI

[Deepesh Reja (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751226#comment-15751226
 ] 

Deepesh Reja commented on ZOOKEEPER-2230:
-

[~fittey] I think you are seeing different behavior because of setting 
"storeKey" to true which adds principal's key in the Subject's private 
credentials set. Due to this, there is always an entry in the set.

I'll see if I can come up with something so that this also work when "storeKey" 
is set to True.

Also, please let me know if you have something or need help on the patch you 
are working on.

> Connections fo ZooKeeper server becomes slow over time with native GSSAPI
> -
>
> Key: ZOOKEEPER-2230
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2230
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.5.0
> Environment: OS: RHEL6
> Java: 1.8.0_40
> Configuration:
> java.env:
> {noformat}
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Xmx5120m"
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS 
> -Djava.security.auth.login.config=/local/apps/zookeeper-test1/conf/jaas-server.conf"
> SERVER_JVMFLAGS="$SERVER_JVMFLAGS -Dsun.security.jgss.native=true"
> {noformat}
> jaas-server.conf:
> {noformat}
> Server {
> com.sun.security.auth.module.Krb5LoginModule required
> useKeyTab=true
> isInitiator=false
> principal="zookeeper/@";
> };
> {noformat}
> Process environment:
> {noformat}
> KRB5_KTNAME=/local/apps/zookeeper-test1/conf/keytab
> ZOO_LOG_DIR=/local/apps/zookeeper-test1/log
> ZOOCFGDIR=/local/apps/zookeeper-test1/conf
> {noformat}
>Reporter: Deepesh Reja
>Assignee: Enis Soztutar
>  Labels: patch
> Fix For: 3.4.6, 3.4.7, 3.4.8, 3.5.2
>
> Attachments: ZOOKEEPER-2230.patch
>
>
> ZooKeeper server becomes slow over time when native GSSAPI is used. The 
> connection to the server starts taking upto 10 seconds.
> This is happening with ZooKeeper-3.4.6 and is fairly reproducible.
> Debug logs:
> {noformat}
> 2015-07-02 00:58:49,318 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:NIOServerCnxnFactory@197] - 
> Accepted socket connection from /:47942
> 2015-07-02 00:58:49,318 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@78] - 
> serviceHostname is ''
> 2015-07-02 00:58:49,318 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@79] - 
> servicePrincipalName is 'zookeeper'
> 2015-07-02 00:58:49,318 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@80] - SASL 
> mechanism(mech) is 'GSSAPI'
> 2015-07-02 00:58:49,324 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperSaslServer@106] - Added 
> private credential to subject: [GSSCredential: 
> zookeeper@ 1.2.840.113554.1.2.2 Accept [class 
> sun.security.jgss.wrapper.GSSCredElement]]
> 2015-07-02 00:58:59,441 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@810] - Session 
> establishment request from client /:47942 client's lastZxid is 0x0
> 2015-07-02 00:58:59,441 [myid:] - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@868] - Client 
> attempting to establish new session at /:47942
> 2015-07-02 00:58:59,448 [myid:] - DEBUG 
> [SyncThread:0:FinalRequestProcessor@88] - Processing request:: 
> sessionid:0x14e486028785c81 type:createSession cxid:0x0 zxid:0x110e79 
> txntype:-10 reqpath:n/a
> 2015-07-02 00:58:59,448 [myid:] - DEBUG 
> [SyncThread:0:FinalRequestProcessor@160] - sessionid:0x14e486028785c81 
> type:createSession cxid:0x0 zxid:0x110e79 txntype:-10 reqpath:n/a
> 2015-07-02 00:58:59,448 [myid:] - INFO  [SyncThread:0:ZooKeeperServer@617] - 
> Established session 0x14e486028785c81 with negotiated timeout 1 for 
> client /:47942
> 2015-07-02 00:58:59,452 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@949] - Responding 
> to client SASL token.
> 2015-07-02 00:58:59,452 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@953] - Size of 
> client SASL token: 706
> 2015-07-02 00:58:59,460 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@984] - Size of 
> server SASL response: 161
> 2015-07-02 00:58:59,462 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@949] - Responding 
> to client SASL token.
> 2015-07-02 00:58:59,462 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@953] - Size of 
> client SASL token: 0
> 2015-07-02 00:58:59,462 [myid:] - DEBUG 
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:42405:ZooKeeperServer@984] - Size of 
> server SASL response: 32
> 2015-07-02 00:58:59,463 [myid:] - DEBUG 
> 

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751216#comment-15751216
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/122#discussion_r92597471
  
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -2910,4 +2923,49 @@ private ClientCnxnSocket getClientCnxnSocket() 
throws IOException {
 throw ioe;
 }
 }
+
+protected byte[] internalReconfig(String joiningServers, String 
leavingServers, String newMembers, long fromConfig, Stat stat) throws 
KeeperException, InterruptedException
+{
--- End diff --

fixed


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #122: [ZOOKEEPER-2642] Resurrect the reconfig() metho...

[Randgalt]

Github user Randgalt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/122#discussion_r92597471
  
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -2910,4 +2923,49 @@ private ClientCnxnSocket getClientCnxnSocket() 
throws IOException {
 throw ioe;
 }
 }
+
+protected byte[] internalReconfig(String joiningServers, String 
leavingServers, String newMembers, long fromConfig, Stat stat) throws 
KeeperException, InterruptedException
+{
--- End diff --

fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751215#comment-15751215
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/122#discussion_r92597402
  
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -39,32 +39,10 @@
 import org.apache.zookeeper.client.ZKClientConfig;
 import org.apache.zookeeper.client.ZooKeeperSaslClient;
 import org.apache.zookeeper.common.PathUtils;
+import org.apache.zookeeper.common.StringUtils;
 import org.apache.zookeeper.data.ACL;
 import org.apache.zookeeper.data.Stat;
-import org.apache.zookeeper.proto.CheckWatchesRequest;
-import org.apache.zookeeper.proto.Create2Response;
-import org.apache.zookeeper.proto.CreateRequest;
-import org.apache.zookeeper.proto.CreateResponse;
-import org.apache.zookeeper.proto.CreateTTLRequest;
-import org.apache.zookeeper.proto.DeleteRequest;
-import org.apache.zookeeper.proto.ExistsRequest;
-import org.apache.zookeeper.proto.GetACLRequest;
-import org.apache.zookeeper.proto.GetACLResponse;
-import org.apache.zookeeper.proto.GetChildren2Request;
-import org.apache.zookeeper.proto.GetChildren2Response;
-import org.apache.zookeeper.proto.GetChildrenRequest;
-import org.apache.zookeeper.proto.GetChildrenResponse;
-import org.apache.zookeeper.proto.GetDataRequest;
-import org.apache.zookeeper.proto.GetDataResponse;
-import org.apache.zookeeper.proto.RemoveWatchesRequest;
-import org.apache.zookeeper.proto.ReplyHeader;
-import org.apache.zookeeper.proto.RequestHeader;
-import org.apache.zookeeper.proto.SetACLRequest;
-import org.apache.zookeeper.proto.SetACLResponse;
-import org.apache.zookeeper.proto.SetDataRequest;
-import org.apache.zookeeper.proto.SetDataResponse;
-import org.apache.zookeeper.proto.SyncRequest;
-import org.apache.zookeeper.proto.SyncResponse;
+import org.apache.zookeeper.proto.*;
--- End diff --

fixed


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #122: [ZOOKEEPER-2642] Resurrect the reconfig() metho...

[Randgalt]

Github user Randgalt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/122#discussion_r92597402
  
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -39,32 +39,10 @@
 import org.apache.zookeeper.client.ZKClientConfig;
 import org.apache.zookeeper.client.ZooKeeperSaslClient;
 import org.apache.zookeeper.common.PathUtils;
+import org.apache.zookeeper.common.StringUtils;
 import org.apache.zookeeper.data.ACL;
 import org.apache.zookeeper.data.Stat;
-import org.apache.zookeeper.proto.CheckWatchesRequest;
-import org.apache.zookeeper.proto.Create2Response;
-import org.apache.zookeeper.proto.CreateRequest;
-import org.apache.zookeeper.proto.CreateResponse;
-import org.apache.zookeeper.proto.CreateTTLRequest;
-import org.apache.zookeeper.proto.DeleteRequest;
-import org.apache.zookeeper.proto.ExistsRequest;
-import org.apache.zookeeper.proto.GetACLRequest;
-import org.apache.zookeeper.proto.GetACLResponse;
-import org.apache.zookeeper.proto.GetChildren2Request;
-import org.apache.zookeeper.proto.GetChildren2Response;
-import org.apache.zookeeper.proto.GetChildrenRequest;
-import org.apache.zookeeper.proto.GetChildrenResponse;
-import org.apache.zookeeper.proto.GetDataRequest;
-import org.apache.zookeeper.proto.GetDataResponse;
-import org.apache.zookeeper.proto.RemoveWatchesRequest;
-import org.apache.zookeeper.proto.ReplyHeader;
-import org.apache.zookeeper.proto.RequestHeader;
-import org.apache.zookeeper.proto.SetACLRequest;
-import org.apache.zookeeper.proto.SetACLResponse;
-import org.apache.zookeeper.proto.SetDataRequest;
-import org.apache.zookeeper.proto.SetDataResponse;
-import org.apache.zookeeper.proto.SyncRequest;
-import org.apache.zookeeper.proto.SyncResponse;
+import org.apache.zookeeper.proto.*;
--- End diff --

fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch34_solaris - Build # 1390 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1390/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 189351 lines...]
[junit] 2016-12-15 11:55:03,650 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2016-12-15 11:55:03,650 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 11:55:03,650 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2016-12-15 11:55:03,650 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-12-15 11:55:03,651 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2016-12-15 11:55:03,651 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2016-12-15 11:55:03,651 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2016-12-15 11:55:03,651 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2016-12-15 11:55:03,651 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-12-15 11:55:03,652 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-12-15 11:55:03,653 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2016-12-15 11:55:03,653 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2016-12-15 11:55:03,653 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2016-12-15 11:55:03,653 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2016-12-15 11:55:03,654 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test5732089921135039259.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test5732089921135039259.junit.dir/version-2
[junit] 2016-12-15 11:55:03,656 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 11:55:03,656 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-12-15 11:55:03,657 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:34597
[junit] 2016-12-15 11:55:03,657 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:34597
[junit] 2016-12-15 11:55:03,657 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2016-12-15 11:55:03,657 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:34597 (no session established for client)
[junit] 2016-12-15 11:55:03,658 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-12-15 11:55:03,659 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2016-12-15 11:55:03,659 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2016-12-15 11:55:03,659 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-12-15 11:55:03,659 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-12-15 11:55:03,659 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 9048
[junit] 2016-12-15 11:55:03,660 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2016-12-15 11:55:03,660 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2016-12-15 11:55:03,660 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2016-12-15 11:55:03,742 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x1590255efc7 closed
[junit] 2016-12-15 11:55:03,742 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2016-12-15 11:55:03,742 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x1590255efc7
[junit] 2016-12-15 11:55:03,743 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2016-12-15 11:55:03,743 [myid:] - 

[jira] [Updated] (ZOOKEEPER-2552) Revisit release note doc and remove the items which are not related to the released version

[Rakesh R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-2552:

Affects Version/s: 3.4.9

> Revisit release note doc and remove the items which are not related to the 
> released version
> ---
>
> Key: ZOOKEEPER-2552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2552
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.9
>Reporter: Rakesh R
>Assignee: Edward Ribeiro
> Fix For: 3.4.10
>
> Attachments: ZOOKEEPER-2552.patch, closed.py
>
>
> Couple of issues listed on http://zookeeper.apache.org/
> doc/r3.4.9/releasenotes.html that are either 'Open' or 'Patch available'. For 
> example, issues were wrongly marked as "3.4.8" fix version in jira and has 
> caused the trouble.
> This jira to cross check all the jira issues present in the release note and 
> check the correctness.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (ZOOKEEPER-2552) Revisit release note doc and remove the items which are not related to the released version

[Rakesh R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R resolved ZOOKEEPER-2552.
-
Resolution: Fixed

> Revisit release note doc and remove the items which are not related to the 
> released version
> ---
>
> Key: ZOOKEEPER-2552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2552
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.9
>Reporter: Rakesh R
>Assignee: Edward Ribeiro
> Fix For: 3.4.10
>
> Attachments: ZOOKEEPER-2552.patch, closed.py
>
>
> Couple of issues listed on http://zookeeper.apache.org/
> doc/r3.4.9/releasenotes.html that are either 'Open' or 'Patch available'. For 
> example, issues were wrongly marked as "3.4.8" fix version in jira and has 
> caused the trouble.
> This jira to cross check all the jira issues present in the release note and 
> check the correctness.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2552) Revisit release note doc and remove the items which are not related to the released version

[Rakesh R (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750990#comment-15750990
 ] 

Rakesh R commented on ZOOKEEPER-2552:
-

+1, thank you [~eribeiro]

> Revisit release note doc and remove the items which are not related to the 
> released version
> ---
>
> Key: ZOOKEEPER-2552
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2552
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Rakesh R
>Assignee: Edward Ribeiro
> Fix For: 3.4.10
>
> Attachments: ZOOKEEPER-2552.patch, closed.py
>
>
> Couple of issues listed on http://zookeeper.apache.org/
> doc/r3.4.9/releasenotes.html that are either 'Open' or 'Patch available'. For 
> example, issues were wrongly marked as "3.4.8" fix version in jira and has 
> caused the trouble.
> This jira to cross check all the jira issues present in the release note and 
> check the correctness.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1422 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1422/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 468592 lines...]
[junit] 2016-12-15 08:26:53,542 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-12-15 08:26:53,542 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-12-15 08:26:53,543 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-12-15 08:26:53,543 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-12-15 08:26:53,544 [myid:] - INFO  [main:ZooKeeperServer@894] 
- minSessionTimeout set to 6000
[junit] 2016-12-15 08:26:53,544 [myid:] - INFO  [main:ZooKeeperServer@903] 
- maxSessionTimeout set to 6
[junit] 2016-12-15 08:26:53,544 [myid:] - INFO  [main:ZooKeeperServer@160] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2050435266525763782.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2050435266525763782.junit.dir/version-2
[junit] 2016-12-15 08:26:53,545 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2050435266525763782.junit.dir/version-2/snapshot.b
[junit] 2016-12-15 08:26:53,547 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test2050435266525763782.junit.dir/version-2/snapshot.b
[junit] 2016-12-15 08:26:53,548 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-12-15 08:26:53,548 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-12-15 08:26:53,549 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:59320
[junit] 2016-12-15 08:26:53,549 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:59320
[junit] 2016-12-15 08:26:53,550 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-12-15 08:26:53,550 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:59320 (no session established for client)
[junit] 2016-12-15 08:26:53,550 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-12-15 08:26:53,552 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-12-15 08:26:53,552 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-12-15 08:26:53,552 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-12-15 08:26:53,552 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-12-15 08:26:53,552 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17819
[junit] 2016-12-15 08:26:53,553 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-12-15 08:26:53,553 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-12-15 08:26:53,553 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-12-15 08:26:53,632 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1257e91430c closed
[junit] 2016-12-15 08:26:53,632 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1257e91430c
[junit] 2016-12-15 08:26:53,632 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-12-15 08:26:53,633 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-12-15 08:26:53,633 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-12-15 08:26:53,633 [myid:] - INFO  

[jira] [Updated] (ZOOKEEPER-2645) If embedded QuorumPeerMain is started with Properties no backupOldConfig should be done

[Tom Pijl (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom Pijl updated ZOOKEEPER-2645:

Priority: Major  (was: Blocker)

> If embedded QuorumPeerMain is started with Properties no backupOldConfig 
> should be done
> ---
>
> Key: ZOOKEEPER-2645
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2645
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Tom Pijl
>
> When starting an embedded _QuorumPeerMain_ by executing the _runFromConfig()_ 
> and providing _QuorumPeerConfig_ properties:
> {code}standaloneEnabled=false
> initLimit=5
> syncLimit=2
> clientPort=4101
> server.1=nlbantpijl01.infor.com:2101:3101:participant;4101
> dataDir=/Storage/zookeeper/server001{code}
> an NullPointerException is thrown in the _QuorumPeerConfig_ class in the 
> method _backupOldConfig()_ because the property configFileStr is null.
> A check must be made at the start of the method _backupOldConfig()_ if the 
> property _configFileStr_ is null. If so just exit the method. In the embedded 
> mode there is no config file, so no need to create a backup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)