ZooKeeper-trunk-WinVS2008 - Build # 2452 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2452/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 13.27 KB...]
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   15  |   15  |   15  |   0   ||   15  |   15  |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  15 artifacts copied, 0 already retrieved (4343kB/47ms)

ivy-retrieve-javacc:
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\javacc\lib
[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [javacc]
[ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
[ivy:retrieve] downloading 
https://repo1.maven.org/maven2/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar ...
[ivy:retrieve] .. (291kB)
[ivy:retrieve] .. (0kB)
[ivy:retrieve]  [SUCCESSFUL ] net.java.dev.javacc#javacc;5.0!javacc.jar (31ms)
[ivy:retrieve] :: resolution report :: resolve 47ms :: artifacts dl 31ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  javacc  |   1   |   1   |   1   |   0   ||   1   |   1   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [javacc]
[ivy:retrieve]  1 artifacts copied, 0 already retrieved (291kB/0ms)

generate_jute_parser:
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\jute_compiler\org\apache\jute\compiler\generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
 [move] Moving 1 file to 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\javacc\lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\src\java\main\org\apache\jute\compiler\generated\rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build.xml:275: 
Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "C:\Program Files\Java\jre1.8.0_121"

Total time: 8 seconds
Build step 'Invoke Ant' marked build as failure
No JDK named ‘JDK 1.8 (unlimited security) 64-bit Windows only’ found
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
No JDK named ‘JDK 1.8 (unlimited security) 64-bit Windows only’ found
No JDK named ‘JDK 1.8 (unlimited security) 64-bit Windows only’ found



###
## FAILED TESTS (if any) 
##
No tests ran.

Re: (U) Roadmap question

[Abraham Fine]

Hi Rich-

The latest release of ZooKeeper 3.5 currently supports TLS for
communication between clients and the quorum. TLS for communication
between the quorum members is currently being worked on here:
https://issues.apache.org/jira/browse/ZOOKEEPER-236 We don't have a
timetable for it yet.
Thanks,
Abe


On Fri, Apr 28, 2017, at 06:51, Rich Losier wrote:
>  
> ALCON: When do you forecast Zookeeper including TLS support on future
> releases?>  


>  


>  


>  


>  


>  


> Semper Vigilans,


>  


> Richard J. “Rich” Losier


> Solutions Architect


> *BRIDGES Consulting*


> *http://www.bridges-inc.com[1]*


> Main: 301.974.6200 Direct: 240.456.5912 | Mobile: 443.939.4985


> 2701 Technology Drive, Suite 210, Annapolis Junction, MD 20701


>  


> http://www.bridges-inc.com/sc-admin/uploads/bridges-logo-tagline1red-small90high-wka7.png>
>   


>  


>  


>  
>  


> *Trusted experts.  Intentional culture.  Limitless opportunities.*


> *Join our  cybersolutions team!  **bridges-inc.com*[2]


>  


> This email may contain confidential information and should not be used
> by anyone who is not the original intended recipient; if you have
> received this email in error, please delete and notify the sender.> 
> 
> This email has been scanned for email related threats and delivered
> safely by Mimecast. For more information please visit
> http://www.mimecast.com

Links:

  1. http://www.bridges-inc.com/
  2. http://www.bridges-inc.com/

(U) Roadmap question

[Rich Losier]

ALCON:
When do you forecast Zookeeper including TLS support on future releases?






Semper Vigilans,

Richard J. "Rich" Losier
Solutions Architect
BRIDGES Consulting
http://www.bridges-inc.com
Main: 301.974.6200 Direct: 240.456.5912 | Mobile: 443.939.4985
2701 Technology Drive, Suite 210, Annapolis Junction, MD 20701

[http://www.bridges-inc.com/sc-admin/uploads/bridges-logo-tagline1red-small90high-wka7.png]



[http://www.bridges-inc.com/sc-admin/uploads/bridges-logo-tagline1red-small90high-wka7.png]

Trusted experts.  Intentional culture.  Limitless opportunities.
Join our cybersolutions team!  bridges-inc.com

This email may contain confidential information and should not be used by 
anyone who is not the original intended recipient; if you have received this 
email in error, please delete and notify the sender.
---
 This email has been scanned for email related threats and delivered safely by 
Mimecast.
 For more information please visit http://www.mimecast.com
---

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989424#comment-15989424
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2755:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/227#discussion_r114013725
  
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java 
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.test;
+
+import org.junit.runners.Suite;
+
+/**
+ * Run tests with: Netty Client against Netty server
+ */
+@Suite.SuiteClasses({
--- End diff --

That makes sense. +1


> Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use 
> Netty Local transport
> -
>
> Key: ZOOKEEPER-2755
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2755
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client, server
>Affects Versions: 3.5.2
>Reporter: Enrico Olivelli
>
> ClientCnxnSocketNetty and NettyServerCnxn use explicitly InetSocketAddress 
> class to work with network addresses.
> We can do a little refactoring to use only SocketAddress and make it possible 
> to create subclasses of ClientCnxnSocketNetty and NettyServerCnxn which 
> leverage built-in Netty 'local' channels. 
> Such Netty local channels do not create real sockets and so allow a simple 
> ZooKeeper server + ZooKeeper client to be run on the same JVM without binding 
> to real TCP endpoints.
> Usecases:
> Ability to run concurrently on the same machine tests of projects which use 
> ZooKeeper (usually in unit tests the server and the client run inside the 
> same JVM) without dealing with random ports and in general using less network 
> resources
> Run simplified (standalone, all processes in the same JVM) versions of 
> applications which need a working ZooKeeper ensemble to run.
> Note:
> Embedding ZooKeeper server + client on the same JVM has many risks and in 
> general I think we should encourage users to do so, so I in this patch I will 
> not provide official implementations of ClientCnxnSocketNetty and 
> NettyServerCnxn. There will be implementations only inside the test packages, 
> in order to test that most of the features are working with custom socket 
> factories and in particular with the 'LocalAddress' specific subclass of 
> SocketAddress.
> Note:
> the 'Local' sockets feature will be available on Netty 4 too



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSock...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/227#discussion_r114013725
  
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java 
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.test;
+
+import org.junit.runners.Suite;
+
+/**
+ * Run tests with: Netty Client against Netty server
+ */
+@Suite.SuiteClasses({
--- End diff --

That makes sense. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Success: ZOOKEEPER- PreCommit Build #661

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/661/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.62 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 43 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/661//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/661//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/661//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 60febf5c5b47d334325c54e2f6fb94c0d254d674 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 21 minutes 50 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2750
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2750) Document SSL Support for Atomic Broadcast protocol

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989406#comment-15989406
 ] 

Hadoop QA commented on ZOOKEEPER-2750:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 43 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/661//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/661//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/661//console

This message is automatically generated.

> Document SSL Support for Atomic Broadcast protocol
> --
>
> Key: ZOOKEEPER-2750
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2750
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989405#comment-15989405
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2763:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/238#discussion_r114011352
  
--- Diff: src/java/main/org/apache/jute/Utils.java ---
@@ -190,19 +190,32 @@ static String fromCSVString(String s) throws 
IOException {
 }
 
 /**
+ * convert byte array to a string in hex format
  * 
- * @param s 
- * @return 
+ * @param barr
+ * @return
  */
-static String toXMLBuffer(byte barr[]) {
--- End diff --

Are you sure about that? I know next to nothing about JAXB so I can 
definitely be wrong, but I was able to drop `DatatypeConverter.printHexBinary` 
in place and have everything just work. Digging through the implementation and 
DatatypeConverter instantiation happening behind the scenes everything looked 
reasonable. Can you link me to something that shows what I am missing?

Thanks


> Utils.toCsvBuffer() omits leading 0 for bytes < 0x10
> 
>
> Key: ZOOKEEPER-2763
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2763
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jute
>Affects Versions: 3.5.2
>Reporter: Brandon Berg
>Assignee: Alburt Hoffman
>Priority: Minor
>
> org.apache.jute.Utils.toCsvBuffer(), which converts a byte array to a string 
> containing the hex representation of that byte array, omits the leading zero 
> for any byte less than 0x10, due to its use of Integer.toHexString, which has 
> the same behavior.
> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/jute/Utils.java#L234
> One consequence of this is that the hex strings printed by 
> ClientCnxn.Packet.toString(), used in the debug logging for 
> ClientCnxn.readResponse(), cannot be parsed to determine the result of a 
> Zookeeper request from client debug logs.
> Utils.toXmlBuffer() appears to have the same issue.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leadi...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/238#discussion_r114011352
  
--- Diff: src/java/main/org/apache/jute/Utils.java ---
@@ -190,19 +190,32 @@ static String fromCSVString(String s) throws 
IOException {
 }
 
 /**
+ * convert byte array to a string in hex format
  * 
- * @param s 
- * @return 
+ * @param barr
+ * @return
  */
-static String toXMLBuffer(byte barr[]) {
--- End diff --

Are you sure about that? I know next to nothing about JAXB so I can 
definitely be wrong, but I was able to drop `DatatypeConverter.printHexBinary` 
in place and have everything just work. Digging through the implementation and 
DatatypeConverter instantiation happening behind the scenes everything looked 
reasonable. Can you link me to something that shows what I am missing?

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2750) Document SSL Support for Atomic Broadcast protocol

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989373#comment-15989373
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2750:
---

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/245

ZOOKEEPER-2750: Document SSL Support for Atomic Broadcast protocol

This patch depends on ZOOKEEPER-236: SSL Support for Atomic Broadcast 
protocol (https://github.com/apache/zookeeper/pull/184), hence the large diff. 

This patch focuses on `zookeeperAdmin.xml` which documents the various new 
system properties associated with ZOOKEEPER-236. More documentation is in the 
works and a document with the suggested changes to the wiki will be linked here 
in the future.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2750

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #245


commit 2ab6c5e1b950c42c1be8d4f6c2bb0c98666e3a36
Author: Abraham Fine 
Date:   2017-03-06T23:12:59Z

ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol

commit 54d2f1093b69a4d884f0681d827e5cacdc87a99c
Author: Abraham Fine 
Date:   2017-03-14T17:56:03Z

hostname verification

commit a1ac5dbb204ad4e3c7c27f2a3bb5906f7e2bf7bf
Author: Abraham Fine 
Date:   2017-03-14T22:27:05Z

certificate revocation checking

commit 10b580dd7a8781e02dce44f5d021d62105d1d09e
Author: Abraham Fine 
Date:   2017-03-17T22:18:47Z

cleaner hostname verification

commit f1a9ff957c01c9e5e8498e3ad75c1fb6a3670278
Author: Abraham Fine 
Date:   2017-03-20T22:43:55Z

cleaner hostname verification

commit aed9c01f90a68dbb7b396820d755a2389ee14be8
Author: Abraham Fine 
Date:   2017-03-24T21:24:58Z

more cleanup and switch to hostname verifier from apache httpcomponents

commit 1909286f584d5d6b3f423430118da6ce6eb3501f
Author: Abraham Fine 
Date:   2017-03-31T22:46:32Z

add testing

commit c564ce839e2823dd69bfab8d26aed6c7284f2025
Author: Abraham Fine 
Date:   2017-04-04T03:01:33Z

OCSP test working

commit 3983a66199da294a491b20f55b1ae23278a27925
Author: Abraham Fine 
Date:   2017-04-04T03:28:11Z

support passwordless truststores
fix Zab1_0Test

commit ae165f63204a1af1b979037b3692bfc25d2f09c0
Author: Abraham Fine 
Date:   2017-04-04T22:31:56Z

UnifiedServerSocketTests and X509Util tests

commit 0396ac3403ccce8d04ece2be9962f8d102e936cb
Author: Abraham Fine 
Date:   2017-04-06T02:27:07Z

move X509UtilTest to the proper directory
unneeded remove QuorumServer changes

commit 735b58b131ad65cf661c69375ce5fb39a1470ab2
Author: Abraham Fine 
Date:   2017-04-06T02:53:37Z

remove unnecessary instantiation of X509Util in the learner

commit 6babcd56e81a64266479b887ed20d5aba4ef8f14
Author: Abraham Fine 
Date:   2017-04-06T20:41:28Z

change hostname verification to attempt just using the ip address before
trying reverse dns

commit 513439467230fb48a0ebeaa6fe6b93da2c3daf2c
Author: Abraham Fine 
Date:   2017-04-06T21:40:20Z

reduce flakyness in UnifiedServerSocketTest

commit 8fca7d6b9391df672d1679a9dbb9ce6102f2af1f
Author: Abraham Fine 
Date:   2017-04-06T21:44:32Z

replace magic numbers UnifiedServerSocketTest

commit 8fd892d1bbe51c8c50c585c1c9348e6bd5776ac6
Author: Abraham Fine 
Date:   2017-04-07T19:45:25Z

fix findbugs warnings

commit c00956aa2734a2c383961b5b3a6f2fd28f5715e5
Author: Abraham Fine 
Date:   2017-04-07T22:10:17Z

pull out zktrustmanager and add testing

commit 6f0f0696e6778fdc9bce1c2bd794108d7f4152f3
Author: Abraham Fine 
Date:   2017-04-13T22:27:31Z

Add comments regarding SunX509 to PKIX change
Add integration tests for tls cipher suites and protocol versions
Claify ZKTrustManager
Remove ssl socket creation code from UnifiedServerSocket
HostnameVerification now on by default

commit ff5ec577eb8204fc675dc8a9f0fc65e8ead48271
Author: Abraham Fine 
Date:   2017-04-14T17:19:22Z

Address stylistic comments from hanm's review
Clean up exception handling

commit 30090f7e166a7da80841c40893bec635d4385aac
Author: Abraham Fine 
Date:   2017-04-14T22:38:34Z

Attempt to fix flaky test

commit 1a20d14929b7427e51791bba3d40ead7853d44ca
Author: Abraham Fine 
Date:   2017-04-19T20:55:34Z

look for stuck thread in tests

commit 

[GitHub] zookeeper pull request #245: ZOOKEEPER-2750: Document SSL Support for Atomic...

[afine]

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/245

ZOOKEEPER-2750: Document SSL Support for Atomic Broadcast protocol

This patch depends on ZOOKEEPER-236: SSL Support for Atomic Broadcast 
protocol (https://github.com/apache/zookeeper/pull/184), hence the large diff. 

This patch focuses on `zookeeperAdmin.xml` which documents the various new 
system properties associated with ZOOKEEPER-236. More documentation is in the 
works and a document with the suggested changes to the wiki will be linked here 
in the future.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2750

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #245


commit 2ab6c5e1b950c42c1be8d4f6c2bb0c98666e3a36
Author: Abraham Fine 
Date:   2017-03-06T23:12:59Z

ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol

commit 54d2f1093b69a4d884f0681d827e5cacdc87a99c
Author: Abraham Fine 
Date:   2017-03-14T17:56:03Z

hostname verification

commit a1ac5dbb204ad4e3c7c27f2a3bb5906f7e2bf7bf
Author: Abraham Fine 
Date:   2017-03-14T22:27:05Z

certificate revocation checking

commit 10b580dd7a8781e02dce44f5d021d62105d1d09e
Author: Abraham Fine 
Date:   2017-03-17T22:18:47Z

cleaner hostname verification

commit f1a9ff957c01c9e5e8498e3ad75c1fb6a3670278
Author: Abraham Fine 
Date:   2017-03-20T22:43:55Z

cleaner hostname verification

commit aed9c01f90a68dbb7b396820d755a2389ee14be8
Author: Abraham Fine 
Date:   2017-03-24T21:24:58Z

more cleanup and switch to hostname verifier from apache httpcomponents

commit 1909286f584d5d6b3f423430118da6ce6eb3501f
Author: Abraham Fine 
Date:   2017-03-31T22:46:32Z

add testing

commit c564ce839e2823dd69bfab8d26aed6c7284f2025
Author: Abraham Fine 
Date:   2017-04-04T03:01:33Z

OCSP test working

commit 3983a66199da294a491b20f55b1ae23278a27925
Author: Abraham Fine 
Date:   2017-04-04T03:28:11Z

support passwordless truststores
fix Zab1_0Test

commit ae165f63204a1af1b979037b3692bfc25d2f09c0
Author: Abraham Fine 
Date:   2017-04-04T22:31:56Z

UnifiedServerSocketTests and X509Util tests

commit 0396ac3403ccce8d04ece2be9962f8d102e936cb
Author: Abraham Fine 
Date:   2017-04-06T02:27:07Z

move X509UtilTest to the proper directory
unneeded remove QuorumServer changes

commit 735b58b131ad65cf661c69375ce5fb39a1470ab2
Author: Abraham Fine 
Date:   2017-04-06T02:53:37Z

remove unnecessary instantiation of X509Util in the learner

commit 6babcd56e81a64266479b887ed20d5aba4ef8f14
Author: Abraham Fine 
Date:   2017-04-06T20:41:28Z

change hostname verification to attempt just using the ip address before
trying reverse dns

commit 513439467230fb48a0ebeaa6fe6b93da2c3daf2c
Author: Abraham Fine 
Date:   2017-04-06T21:40:20Z

reduce flakyness in UnifiedServerSocketTest

commit 8fca7d6b9391df672d1679a9dbb9ce6102f2af1f
Author: Abraham Fine 
Date:   2017-04-06T21:44:32Z

replace magic numbers UnifiedServerSocketTest

commit 8fd892d1bbe51c8c50c585c1c9348e6bd5776ac6
Author: Abraham Fine 
Date:   2017-04-07T19:45:25Z

fix findbugs warnings

commit c00956aa2734a2c383961b5b3a6f2fd28f5715e5
Author: Abraham Fine 
Date:   2017-04-07T22:10:17Z

pull out zktrustmanager and add testing

commit 6f0f0696e6778fdc9bce1c2bd794108d7f4152f3
Author: Abraham Fine 
Date:   2017-04-13T22:27:31Z

Add comments regarding SunX509 to PKIX change
Add integration tests for tls cipher suites and protocol versions
Claify ZKTrustManager
Remove ssl socket creation code from UnifiedServerSocket
HostnameVerification now on by default

commit ff5ec577eb8204fc675dc8a9f0fc65e8ead48271
Author: Abraham Fine 
Date:   2017-04-14T17:19:22Z

Address stylistic comments from hanm's review
Clean up exception handling

commit 30090f7e166a7da80841c40893bec635d4385aac
Author: Abraham Fine 
Date:   2017-04-14T22:38:34Z

Attempt to fix flaky test

commit 1a20d14929b7427e51791bba3d40ead7853d44ca
Author: Abraham Fine 
Date:   2017-04-19T20:55:34Z

look for stuck thread in tests

commit 3c6c81b69b7105fa7c5235a0f27718a7eae195de
Author: Abraham Fine 
Date:   2017-04-20T19:19:33Z

Make sure to close underlying socket when closing ssl socket

commit 08d29810aae233807f22a6adb5f797fb810807df
Author: Abraham Fine 
Date:   

Re: committing doc changes

[Abraham Fine]

Apologies for reviving an old thread.

I'm wondering if we can make this conversation actionable. It would be
great to remove the compiled documentation from the repository. I
created a JIRA to cover this work:
https://issues.apache.org/jira/browse/ZOOKEEPER-2769

Does anyone have any insight into what would be required to make sure
the trunk documentation remains available if we make this change. I do
not believe I have access to the trunk jenkins job configuration to see
exactly what is going on.

Thanks,
Abe


On Mon, Dec 5, 2016, at 16:10, Patrick Hunt wrote:
> As Flavio mentioned we (committers) commit the docs so that users
> interested in d/l the source and using it don't need to generate the
> docs,
> which requires forrest and could often be a pita. In the early days this
> was seen as a benefit. That's the history at least.
> 
> Patrick
> 
> On Thu, Dec 1, 2016 at 12:09 PM, Michael Han  wrote:
> 
> > Run forrest check only take a few seconds, so it seems worthwhile to add it
> > to QA target to have some sanity checks on the doc change.
> >
> > On Thu, Dec 1, 2016 at 3:20 AM, Flavio Junqueira  wrote:
> >
> > > We currently do it for the trunk build:
> > >
> > > 
> > >
> > > but not for pull request or patch QA:
> > >
> > > 
> > >
> > > "forrest.check" only checks if the forrest.home variable is defined.
> > >
> > > Is that enough that we run it as part of the trunk build?
> > >
> > > -Flavio
> > >
> > > > On 01 Dec 2016, at 01:04, Benjamin Reed  wrote:
> > > >
> > > > we could also build the doc as part of the tests.
> > > >
> > > > On Wed, Nov 30, 2016 at 3:26 PM, Flavio Junqueira 
> > > wrote:
> > > >> As part of the release process, we only copy the documentation, see it
> > > here:
> > > >>
> > > >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease <
> > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease>
> > > >>
> > > >> I think the reason we have gone this way is to avoid issues compiling
> > > the documentation at the time that we are preparing a release candidate
> > or
> > > after voting on a release candidate. We could for sure build the
> > > documentation right before generating the first rc for a release and
> > create
> > > blocker jiras in the case there is any issue.
> > > >>
> > > >> -Flavio
> > > >>
> > > >>> On 30 Nov 2016, at 23:12, Benjamin Reed  wrote:
> > > >>>
> > > >>> yeah, that's a deeper question. pat or flavio can correct me on this,
> > > >>> but i think the reason we check it in is so that the website's
> > "trunk"
> > > >>> documentation will work. now that we moved to git, i don't thing it
> > > >>> works though... i also would just like to only build it when we do
> > > >>> releases.
> > > >>>
> > > >>> On Wed, Nov 30, 2016 at 2:24 PM, Jordan Zimmerman
> > > >>>  wrote:
> > >  I wondered about that myself. Why bother building the docs? Isn’t
> > > that only needed for packaging/deployment? It ends up making PRs ugly
> > > because you have all the unnecessary docs in the diff.
> > > 
> > >  -Jordan
> > > 
> > > > On Nov 30, 2016, at 11:23 PM, Benjamin Reed 
> > > wrote:
> > > >
> > > > when we commit pull requests with doc changes, i think we should
> > > > commit the generated doc as a separate commit. what do you all
> > think?
> > > > i would like to do that to keep the change from the contributors
> > > > pristine :) and i think it simplifies things a bit.
> > > >
> > > > ben
> > > 
> > > >>
> > >
> > >
> >
> >
> > --
> > Cheers
> > Michael.
> >

[jira] [Created] (ZOOKEEPER-2769) Compiled documentation should not be under source control

[Abraham Fine (JIRA)]

Abraham Fine created ZOOKEEPER-2769:
---

 Summary: Compiled documentation should not be under source control
 Key: ZOOKEEPER-2769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2769
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Abraham Fine


We have xml files that compile into our documentation in src/docs/ and 
precompiled documentation docs/

We should remove them and only have uncompiled documentation under source 
control



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Failed: ZOOKEEPER- PreCommit Build #660

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/660/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 3.07 KB...]
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  Current- Going to parser args -
 [exec] 
 [exec] Pull request id: 244
 [exec] Pull request title: Clean up disk space for volumes not in use
 [exec]  Dload  Upload   Total   Spent
Left  SpeedDefect number: 
 [exec] 
 [exec] 
 [exec] - Parsed args, going to checkout -
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for pull request 244.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0100   1410   1410 0995  0 --:--:-- --:--:-- 
--:--:--   992
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest 
-Dforrest.home=/home/jenkins/tools/forrest/latest -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 102800 0  27930  0 --:--:-- --:--:-- 
--:--:-- 27930mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1642:
 exec returned: 1

Total time: 10 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper pull request #244: Clean up disk space for volumes not in use

[dnarasim9]

GitHub user dnarasim9 opened a pull request:

https://github.com/apache/zookeeper/pull/244

Clean up disk space for volumes not in use



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnarasim9/zookeeper disk-clean-up

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #244


commit 1f45212deec07e2252db717f8e1bea7cb19373a8
Author: Dheemanth Narasimhan 
Date:   2017-04-28T19:07:46Z

Clean up disk space for volumes not in use




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch34_openjdk7 - Build # 1480 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1480/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 32.59 MB...]
[junit] 2017-04-28 19:08:50,721 [myid:] - INFO  
[main:PrepRequestProcessor@764] - Shutting down
[junit] 2017-04-28 19:08:50,721 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-04-28 19:08:50,721 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2017-04-28 19:08:50,733 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-04-28 19:08:50,733 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2017-04-28 19:08:50,733 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-04-28 19:08:50,734 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-04-28 19:08:50,735 [myid:] - INFO  [main:ClientBase@469] - 
STARTING server
[junit] 2017-04-28 19:08:50,735 [myid:] - INFO  [main:ClientBase@390] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-04-28 19:08:50,735 [myid:] - INFO  
[main:ServerCnxnFactory@111] - Using 
org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory
[junit] 2017-04-28 19:08:50,736 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-04-28 19:08:50,736 [myid:] - INFO  [main:ClientBase@365] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-04-28 19:08:50,736 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build/test/tmp/test8627437436014907869.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build/test/tmp/test8627437436014907869.junit.dir/version-2
[junit] 2017-04-28 19:08:50,739 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-04-28 19:08:50,740 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-04-28 19:08:50,740 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:45694
[junit] 2017-04-28 19:08:50,740 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@883] - Processing 
stat command from /127.0.0.1:45694
[junit] 2017-04-28 19:08:50,741 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@674] - Stat command output
[junit] 2017-04-28 19:08:50,741 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1044] - Closed socket connection for client 
/127.0.0.1:45694 (no session established for client)
[junit] 2017-04-28 19:08:50,741 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-04-28 19:08:50,743 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-04-28 19:08:50,743 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-04-28 19:08:50,743 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-04-28 19:08:50,743 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-04-28 19:08:50,744 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 24639
[junit] 2017-04-28 19:08:50,744 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-04-28 19:08:50,744 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-04-28 19:08:50,744 [myid:] - INFO  [main:ClientBase@546] - 
tearDown starting
[junit] 2017-04-28 19:08:50,809 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x15bb5f73c1b closed
[junit] 2017-04-28 19:08:50,809 [myid:] - INFO  [main:ClientBase@516] - 
STOPPING server
[junit] 2017-04-28 19:08:50,809 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2017-04-28 19:08:50,809 [myid:] - INFO  [main:ZooKeeperServer@505] 
- shutting down
[junit] 2017-04-28 19:08:50,810 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-04-28 19:08:50,810 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 

ZooKeeper_branch35_jdk8 - Build # 506 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/506/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 63.57 MB...]
[junit] 2017-04-28 17:36:42,936 [myid:] - WARN  [New I/O boss 
#2763:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x66f9cc41] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:22118
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:22118
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-04-28 17:36:42,936 [myid:] - INFO  [New I/O boss 
#2763:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2017-04-28 17:36:42,936 [myid:127.0.0.1:22118] - INFO  
[main-SendThread(127.0.0.1:22118):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x104fb6ef86c is lost, closing socket connection and attempting 
reconnect
[junit] 2017-04-28 17:36:42,958 [myid:127.0.0.1:22121] - INFO  
[main-SendThread(127.0.0.1:22121):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22121. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 17:36:42,959 [myid:] - INFO  [New I/O boss 
#2772:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:22121
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-04-28 17:36:42,959 [myid:] - WARN  [New I/O boss 
#2772:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0xcbeb7eec] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:22121
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:22121
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 

[GitHub] zookeeper pull request #242: ZOOKEEPER-2759: Flaky test: org.apache.zookeepe...

[afine]

Github user afine closed the pull request at:

https://github.com/apache/zookeeper/pull/242


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2759) Flaky test: org.apache.zookeeper.server.quorum.QuorumCnxManagerTest.testNoAuthLearnerConnectToAuthRequiredServerWithHigherSid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989182#comment-15989182
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2759:
---

Github user afine closed the pull request at:

https://github.com/apache/zookeeper/pull/242


> Flaky test: 
> org.apache.zookeeper.server.quorum.QuorumCnxManagerTest.testNoAuthLearnerConnectToAuthRequiredServerWithHigherSid
> -
>
> Key: ZOOKEEPER-2759
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2759
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 3.4.11
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

ZooKeeper_branch34_openjdk7 - Build # 1479 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1479/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by an SCM change
[EnvInject] - Loading node environment variables.
ERROR: SEVERE ERROR occurs
org.jenkinsci.lib.envinject.EnvInjectException: 
hudson.remoting.ChannelClosedException: channel is already closed
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvironmentVariablesNode(EnvironmentVariablesNodeLoader.java:79)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:80)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.setUpEnvironment(EnvInjectListener.java:42)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:572)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:492)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Caused by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:604)
at hudson.remoting.Request.call(Request.java:130)
at hudson.remoting.Channel.call(Channel.java:821)
at hudson.FilePath.act(FilePath.java:1080)
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvironmentVariablesNode(EnvironmentVariablesNodeLoader.java:48)
... 8 more
Caused by: java.io.IOException
at hudson.remoting.Channel.close(Channel.java:1284)
at hudson.slaves.ChannelPinger$1.onDead(ChannelPinger.java:115)
at hudson.remoting.PingThread.ping(PingThread.java:130)
at hudson.remoting.PingThread.run(PingThread.java:86)
Caused by: java.util.concurrent.TimeoutException: Ping started at 1493395274138 
hasn't completed by 1493395514139
... 2 more
ERROR: Step ?Publish JUnit test result report? failed: no workspace for 
ZooKeeper_branch34_openjdk7 #1479
[EnvInject] - [ERROR] - SEVERE ERROR occurs: channel is already closed
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_jdk7 - Build # 943 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/943/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by an SCM change
[EnvInject] - Loading node environment variables.
ERROR: SEVERE ERROR occurs
org.jenkinsci.lib.envinject.EnvInjectException: 
hudson.remoting.ChannelClosedException: channel is already closed
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvironmentVariablesNode(EnvironmentVariablesNodeLoader.java:79)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:80)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.setUpEnvironment(EnvInjectListener.java:42)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:572)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:492)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Caused by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:604)
at hudson.remoting.Request.call(Request.java:130)
at hudson.remoting.Channel.call(Channel.java:821)
at hudson.FilePath.act(FilePath.java:1080)
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvironmentVariablesNode(EnvironmentVariablesNodeLoader.java:48)
... 8 more
Caused by: java.io.IOException
at hudson.remoting.Channel.close(Channel.java:1284)
at hudson.slaves.ChannelPinger$1.onDead(ChannelPinger.java:115)
at hudson.remoting.PingThread.ping(PingThread.java:130)
at hudson.remoting.PingThread.run(PingThread.java:86)
Caused by: java.util.concurrent.TimeoutException: Ping started at 1493395274138 
hasn't completed by 1493395514139
... 2 more
ERROR: Step ?Publish JUnit test result report? failed: no workspace for 
ZooKeeper_branch35_jdk7 #943
[EnvInject] - [ERROR] - SEVERE ERROR occurs: channel is already closed
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989096#comment-15989096
 ] 

Michael Han commented on ZOOKEEPER-2662:


bq. ZOOKEEPER-261 that both of us reviewed, but it got only committed on master.

There is a closely related issue ZOOKEEPER-2325 and both combined solved an 
issue of inconsistent quorum in certain cases - since we have ZOOKEEPER-2325 
committed in br-3.5, 261 should be committed to br-3.5. I believe 261 fell out 
of radar when we did cherry picks for 3.5. If no objection I'll port 
ZOOKEEPER-261 in br-3.5.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #243: ZOOKEEPER-2662: Export a metric for txn log syn...

[eribeiro]

Github user eribeiro closed the pull request at:

https://github.com/apache/zookeeper/pull/243


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989081#comment-15989081
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user eribeiro closed the pull request at:

https://github.com/apache/zookeeper/pull/243


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper issue #243: ZOOKEEPER-2662: Export a metric for txn log sync times

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/243
  
merged, please close this pr @eribeiro .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989069#comment-15989069
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/243
  
merged, please close this pr @eribeiro .


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han resolved ZOOKEEPER-2662.

   Resolution: Fixed
Fix Version/s: 3.5.4

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989067#comment-15989067
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/243
  
lgtm, thanks for doing this. Merging.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper issue #243: ZOOKEEPER-2662: Export a metric for txn log sync times

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/243
  
lgtm, thanks for doing this. Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper issue #242: ZOOKEEPER-2759: Flaky test: org.apache.zookeeper.serve...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/242
  
merged, please close this pr @afine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2759) Flaky test: org.apache.zookeeper.server.quorum.QuorumCnxManagerTest.testNoAuthLearnerConnectToAuthRequiredServerWithHigherSid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989058#comment-15989058
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2759:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/242
  
merged, please close this pr @afine.


> Flaky test: 
> org.apache.zookeeper.server.quorum.QuorumCnxManagerTest.testNoAuthLearnerConnectToAuthRequiredServerWithHigherSid
> -
>
> Key: ZOOKEEPER-2759
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2759
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 3.4.11
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

ZooKeeper_branch34_openjdk7 - Build # 1478 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1478/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 31.19 MB...]
[junit] 2017-04-28 15:13:07,285 [myid:] - INFO  
[main:PrepRequestProcessor@764] - Shutting down
[junit] 2017-04-28 15:13:07,285 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-04-28 15:13:07,285 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2017-04-28 15:13:07,290 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-04-28 15:13:07,290 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2017-04-28 15:13:07,290 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-04-28 15:13:07,291 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-04-28 15:13:07,292 [myid:] - INFO  [main:ClientBase@469] - 
STARTING server
[junit] 2017-04-28 15:13:07,292 [myid:] - INFO  [main:ClientBase@390] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-04-28 15:13:07,292 [myid:] - INFO  
[main:ServerCnxnFactory@111] - Using 
org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory
[junit] 2017-04-28 15:13:07,293 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-04-28 15:13:07,293 [myid:] - INFO  [main:ClientBase@365] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-04-28 15:13:07,293 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build/test/tmp/test5395900362526694002.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build/test/tmp/test5395900362526694002.junit.dir/version-2
[junit] 2017-04-28 15:13:07,296 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-04-28 15:13:07,296 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-04-28 15:13:07,297 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:38295
[junit] 2017-04-28 15:13:07,297 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@883] - Processing 
stat command from /127.0.0.1:38295
[junit] 2017-04-28 15:13:07,297 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@674] - Stat command output
[junit] 2017-04-28 15:13:07,298 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1044] - Closed socket connection for client 
/127.0.0.1:38295 (no session established for client)
[junit] 2017-04-28 15:13:07,298 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-04-28 15:13:07,299 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-04-28 15:13:07,300 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-04-28 15:13:07,300 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-04-28 15:13:07,300 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-04-28 15:13:07,300 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 24639
[junit] 2017-04-28 15:13:07,300 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-04-28 15:13:07,300 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-04-28 15:13:07,301 [myid:] - INFO  [main:ClientBase@546] - 
tearDown starting
[junit] 2017-04-28 15:13:07,372 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x15bb51f6c25 closed
[junit] 2017-04-28 15:13:07,372 [myid:] - INFO  [main:ClientBase@516] - 
STOPPING server
[junit] 2017-04-28 15:13:07,372 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2017-04-28 15:13:07,373 [myid:] - INFO  [main:ZooKeeperServer@505] 
- shutting down
[junit] 2017-04-28 15:13:07,373 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-04-28 15:13:07,373 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 

ZooKeeper-trunk-jdk8 - Build # 1028 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1028/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 66.46 MB...]
[junit] 2017-04-28 11:58:24,181 [myid:2] - INFO  
[NIOServerCxnFactory.AcceptThread:localhost/127.0.0.1:11228:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:45838
[junit] 2017-04-28 11:58:33,693 [myid:127.0.0.1:11228] - WARN  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1181] - Client session 
timed out, have not heard from server in 30021ms for sessionid 0x2032dd31da8
[junit] 2017-04-28 11:58:33,693 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1229] - Client session 
timed out, have not heard from server in 30021ms for sessionid 
0x2032dd31da8, closing socket connection and attempting reconnect
[junit] 2017-04-28 11:58:35,426 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11228. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 11:58:35,427 [myid:2] - INFO  
[NIOServerCxnFactory.AcceptThread:localhost/127.0.0.1:11228:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:46748
[junit] 2017-04-28 11:58:35,427 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: /127.0.0.1:46748, server: 
127.0.0.1/127.0.0.1:11228
[junit] 2017-04-28 11:58:54,203 [myid:127.0.0.1:11228] - WARN  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1181] - Client session 
timed out, have not heard from server in 30023ms for sessionid 0x0
[junit] 2017-04-28 11:58:54,203 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1229] - Client session 
timed out, have not heard from server in 30023ms for sessionid 0x0, closing 
socket connection and attempting reconnect
[junit] 2017-04-28 11:58:55,361 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11228. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 11:58:55,361 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: /127.0.0.1:48350, server: 
127.0.0.1/127.0.0.1:11228
[junit] 2017-04-28 11:58:55,362 [myid:2] - INFO  
[NIOServerCxnFactory.AcceptThread:localhost/127.0.0.1:11228:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:48350
[junit] 2017-04-28 11:59:05,453 [myid:127.0.0.1:11228] - WARN  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1181] - Client session 
timed out, have not heard from server in 30027ms for sessionid 0x2032dd31da8
[junit] 2017-04-28 11:59:05,453 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1229] - Client session 
timed out, have not heard from server in 30027ms for sessionid 
0x2032dd31da8, closing socket connection and attempting reconnect
[junit] 2017-04-28 11:59:07,415 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11228. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 11:59:07,416 [myid:2] - INFO  
[NIOServerCxnFactory.AcceptThread:localhost/127.0.0.1:11228:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:49316
[junit] 2017-04-28 11:59:07,416 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@948] - Socket 
connection established, initiating session, client: /127.0.0.1:49316, server: 
127.0.0.1/127.0.0.1:11228
[junit] 2017-04-28 11:59:25,384 [myid:127.0.0.1:11228] - WARN  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1181] - Client session 
timed out, have not heard from server in 30023ms for sessionid 0x0
[junit] 2017-04-28 11:59:25,384 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1229] - Client session 
timed out, have not heard from server in 30023ms for sessionid 0x0, closing 
socket connection and attempting reconnect
[junit] 2017-04-28 11:59:26,996 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11228. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 11:59:26,996 [myid:127.0.0.1:11228] - INFO  
[main-SendThread(127.0.0.1:11228):ClientCnxn$SendThread@948] - Socket 
connection established, 

[jira] [Commented] (ZOOKEEPER-2755) Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use Netty Local transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988652#comment-15988652
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2755:
---

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/227#discussion_r113903695
  
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java 
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.test;
+
+import org.junit.runners.Suite;
+
+/**
+ * Run tests with: Netty Client against Netty server
+ */
+@Suite.SuiteClasses({
--- End diff --

@afine I'm sorry it is not possible for old style sockets. We should 
provide  a full custom SocketImpl.

This change will help testing apps which use ZooKeeper and usually launch 
only a single node embedded ZK server inside the JVM which is running the unit 
test.

I think that a switch to Netty for the server-to-server communications will 
be a good enhancement for the future. I saw recent work about SSL on 
server-to-server, using Netty it would have been very simple.

I can create a JIRA for Netty on server-to-server, eventually I can work on 
a proposal in the near future


> Allow to subclass ClientCnxnSocketNetty and NettyServerCnxn in order to use 
> Netty Local transport
> -
>
> Key: ZOOKEEPER-2755
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2755
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client, server
>Affects Versions: 3.5.2
>Reporter: Enrico Olivelli
>
> ClientCnxnSocketNetty and NettyServerCnxn use explicitly InetSocketAddress 
> class to work with network addresses.
> We can do a little refactoring to use only SocketAddress and make it possible 
> to create subclasses of ClientCnxnSocketNetty and NettyServerCnxn which 
> leverage built-in Netty 'local' channels. 
> Such Netty local channels do not create real sockets and so allow a simple 
> ZooKeeper server + ZooKeeper client to be run on the same JVM without binding 
> to real TCP endpoints.
> Usecases:
> Ability to run concurrently on the same machine tests of projects which use 
> ZooKeeper (usually in unit tests the server and the client run inside the 
> same JVM) without dealing with random ports and in general using less network 
> resources
> Run simplified (standalone, all processes in the same JVM) versions of 
> applications which need a working ZooKeeper ensemble to run.
> Note:
> Embedding ZooKeeper server + client on the same JVM has many risks and in 
> general I think we should encourage users to do so, so I in this patch I will 
> not provide official implementations of ClientCnxnSocketNetty and 
> NettyServerCnxn. There will be implementations only inside the test packages, 
> in order to test that most of the features are working with custom socket 
> factories and in particular with the 'LocalAddress' specific subclass of 
> SocketAddress.
> Note:
> the 'Local' sockets feature will be available on Netty 4 too



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSock...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/227#discussion_r113903695
  
--- Diff: src/java/test/org/apache/zookeeper/test/NettyLocalSuiteTest.java 
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.test;
+
+import org.junit.runners.Suite;
+
+/**
+ * Run tests with: Netty Client against Netty server
+ */
+@Suite.SuiteClasses({
--- End diff --

@afine I'm sorry it is not possible for old style sockets. We should 
provide  a full custom SocketImpl.

This change will help testing apps which use ZooKeeper and usually launch 
only a single node embedded ZK server inside the JVM which is running the unit 
test.

I think that a switch to Netty for the server-to-server communications will 
be a good enhancement for the future. I saw recent work about SSL on 
server-to-server, using Netty it would have been very simple.

I can create a JIRA for Netty on server-to-server, eventually I can work on 
a proposal in the near future


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988645#comment-15988645
 ] 

Hadoop QA commented on ZOOKEEPER-2697:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//console

This message is automatically generated.

> Handle graceful stop of ZookKeeper client
> -
>
> Key: ZOOKEEPER-2697
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2697
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.4.9
>Reporter: Enrico Olivelli
>Priority: Critical
>
> As seen in ZOOKEEPER-1394 I would like to have the "close"  which waits for 
> all background activities to  finish.
> In tests the method "testableWaitForShutdown" is used.
> We can add a new ZooKeeper.close(int tineout)  method which will act as 
> testableWaitForShutdown, joining all support threads.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988646#comment-15988646
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 5 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Failed: ZOOKEEPER- PreCommit Build #658

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 58.17 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/658//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 0b03211ee8b7e841f8a8426c4a4ff2fe3769599e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1642:
 exec returned: 2

Total time: 8 minutes 25 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Compressed 577.80 KB of artifacts by 49.8% relative to #657
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2697
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Failed: ZOOKEEPER- PreCommit Build #659

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 32.09 KB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] b234f8a324e54888901a1611b213b69fb596b650 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1642:
 exec returned: 1

Total time: 3 minutes 10 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2662
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988638#comment-15988638
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

GitHub user eribeiro opened a pull request:

https://github.com/apache/zookeeper/pull/243

ZOOKEEPER-2662: Export a metric for txn log sync times

Addressed review comments

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662-branch-3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit cfd12f86b0a244b6bd697af35e2b6d03c20e31fd
Author: Edward Ribeiro 
Date:   2017-04-27T00:21:18Z

ZOOKEEPER-2662: Export a metric for txn log sync times

Addressed review comments




> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #243: ZOOKEEPER-2662: Export a metric for txn log syn...

[eribeiro]

GitHub user eribeiro opened a pull request:

https://github.com/apache/zookeeper/pull/243

ZOOKEEPER-2662: Export a metric for txn log sync times

Addressed review comments

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662-branch-3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit cfd12f86b0a244b6bd697af35e2b6d03c20e31fd
Author: Edward Ribeiro 
Date:   2017-04-27T00:21:18Z

ZOOKEEPER-2662: Export a metric for txn log sync times

Addressed review comments




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988635#comment-15988635
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2697:
---

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/222
  
@hanm thank you for your review.

I have added a javadoc note on the close() method and the @since tag.
Thank for including this in the 3.5.4 release too


> Handle graceful stop of ZookKeeper client
> -
>
> Key: ZOOKEEPER-2697
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2697
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.4.9
>Reporter: Enrico Olivelli
>Priority: Critical
>
> As seen in ZOOKEEPER-1394 I would like to have the "close"  which waits for 
> all background activities to  finish.
> In tests the method "testableWaitForShutdown" is used.
> We can add a new ZooKeeper.close(int tineout)  method which will act as 
> testableWaitForShutdown, joining all support threads.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper issue #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeeper clie...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/222
  
@hanm thank you for your review.

I have added a javadoc note on the close() method and the @since tag.
Thank for including this in the 3.5.4 release too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2697) Handle graceful stop of ZookKeeper client

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988634#comment-15988634
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2697:
---

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/222#discussion_r113902401
  
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,20 @@ public synchronized void close() throws 
InterruptedException {
 }
 
 /**
+ * Close this client object as the {@link #close() } method.
+ * This method will wait for internal resources to be released.
+ *
+ * @param waitForShutdownTimeoutMs timeout (in milliseconds) to wait 
for resources to be released.
+ * Use zero or a negative value to skip the wait
+ * @throws InterruptedException
+ * @return true if waitForShutdownTimeout is greater than zero and all 
of the resources have been released
--- End diff --

@hanm done


> Handle graceful stop of ZookKeeper client
> -
>
> Key: ZOOKEEPER-2697
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2697
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client
>Affects Versions: 3.4.9
>Reporter: Enrico Olivelli
>Priority: Critical
>
> As seen in ZOOKEEPER-1394 I would like to have the "close"  which waits for 
> all background activities to  finish.
> In tests the method "testableWaitForShutdown" is used.
> We can add a new ZooKeeper.close(int tineout)  method which will act as 
> testableWaitForShutdown, joining all support threads.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeep...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/222#discussion_r113902401
  
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,20 @@ public synchronized void close() throws 
InterruptedException {
 }
 
 /**
+ * Close this client object as the {@link #close() } method.
+ * This method will wait for internal resources to be released.
+ *
+ * @param waitForShutdownTimeoutMs timeout (in milliseconds) to wait 
for resources to be released.
+ * Use zero or a negative value to skip the wait
+ * @throws InterruptedException
+ * @return true if waitForShutdownTimeout is greater than zero and all 
of the resources have been released
--- End diff --

@hanm done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2699) Restrict 4lw commands based on client IP

[Bhupendra Kumar Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988627#comment-15988627
 ] 

Bhupendra Kumar Jain commented on ZOOKEEPER-2699:
-

Currently 4lw commands are executed without authentication and command 
white-listing mechanism is available to control DoS.  But I think still 
Authentication should be supported for example IP based as mentioned in this 
JIRA ...  Is there any other way of authentication ?

> Restrict 4lw commands based on client IP
> 
>
> Key: ZOOKEEPER-2699
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2699
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: security, server
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>
> Currently 4lw commands are executed without authentication and can be 
> accessed from any IP which has access to ZooKeeper server. ZOOKEEPER-2693 
> attempts to limit the 4lw commands which are enabled by default or enabled by 
> configuration.
> In addition to ZOOKEEPER-2693 we should also restrict 4lw commands based on 
> client IP as well. It is required for following scenario
> # User wants to enable all the 4lw commands
> # User wants to limit the access of the commands which are considered to be 
> safe by default.
>  
> *Implementation:*
> we can introduce new property 4lw.commands.host.whitelist
> # By default we allow all the hosts, but off course only on the 4lw exposed 
> commands as per the ZOOKEEPER-2693
> # It can be configured to allow individual IPs(192.168.1.2,192.168.1.3 etc.)
> # It can also be configured to allow group of IPs like 192.168.1.*



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988614#comment-15988614
 ] 

Edward Ribeiro commented on ZOOKEEPER-2662:
---

Sure [~hanm], gonna port it to branch-3.5! :)

By the way, I saw that {{FileTxnSnapLogTest}}, that this patch uses, doesn't 
exist on branch-3.5. It was created as part of ZOOKEEPER-261 that both of us 
reviewed, but it got only committed on master. It was that on purpose [~breed]?

Best regards!

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ZOOKEEPER-2768) Some ideas about four word command

[JIRA]

王震 created ZOOKEEPER-2768:
-

 Summary: Some ideas about four word command
 Key: ZOOKEEPER-2768
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2768
 Project: ZooKeeper
  Issue Type: Improvement
  Components: contrib
Affects Versions: 3.5.2, 3.5.1, 3.4.10
Reporter: 王震
Priority: Critical


Some ideas about four word command
1) about cons,can we add command dimension data,such like
now
/10.204.2.39:63943[1](queued=0,recved=7,sent=7,sid=0x154c32e8c2a5b8c,lop=PING,est=1483669807748,
to=1,lzxid=0x,lresp=1493362823544,llat=0,minlat=0,avglat=0,maxlat=1)
---
after
/10.204.2.39:63943[1](queued=0,recved=7,sent=7,sid=0x154c32e8c2a5b8c,lop=PING,est=1483669807748,
to=1,lzxid=0x,lresp=1493362823544,llat=0,minlat=0,avglat=0,maxlat=1,
cmd={{name=ping,count=1,time=123405,maxAvg=34},{name=setData,count=5000,time=2246,maxAvg=21},{name=getData,count=3000,time=34345,maxAvg=14}})

2) about wchc and wchp,can we add param in order to return  litter  data,such as
wchc 0x154c32e8c2a5b8c
wchp /path/temp

3）many scenarios we need to monitor the detailed slow request,so we need a slow 
log queue,such as

slow

setData  /path/temp   aaa clientIp useTime
setData  /path/temp   bbb clientIp useTime






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988442#comment-15988442
 ] 

Hadoop QA commented on ZOOKEEPER-2763:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//console

This message is automatically generated.

> Utils.toCsvBuffer() omits leading 0 for bytes < 0x10
> 
>
> Key: ZOOKEEPER-2763
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2763
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jute
>Affects Versions: 3.5.2
>Reporter: Brandon Berg
>Assignee: Alburt Hoffman
>Priority: Minor
>
> org.apache.jute.Utils.toCsvBuffer(), which converts a byte array to a string 
> containing the hex representation of that byte array, omits the leading zero 
> for any byte less than 0x10, due to its use of Integer.toHexString, which has 
> the same behavior.
> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/jute/Utils.java#L234
> One consequence of this is that the hex strings printed by 
> ClientCnxn.Packet.toString(), used in the debug logging for 
> ClientCnxn.readResponse(), cannot be parsed to determine the result of a 
> Zookeeper request from client debug logs.
> Utils.toXmlBuffer() appears to have the same issue.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Success: ZOOKEEPER- PreCommit Build #657

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 68.49 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 59fd3981f21e6942fe710626620ac7d33c332d21 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 41 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2763
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper_branch35_jdk7 - Build # 942 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/942/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 64.89 MB...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-04-28 08:50:31,087 [myid:127.0.0.1:22117] - INFO  
[main-SendThread(127.0.0.1:22117):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22117. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 08:50:31,087 [myid:127.0.0.1:22117] - WARN  
[main-SendThread(127.0.0.1:22117):ClientCnxn$SendThread@1235] - Session 
0x1032d2f523d for server 127.0.0.1/127.0.0.1:22117, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-04-28 08:50:31,308 [myid:127.0.0.1:21994] - INFO  
[main-SendThread(127.0.0.1:21994):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:21994. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 08:50:31,309 [myid:127.0.0.1:21994] - WARN  
[main-SendThread(127.0.0.1:21994):ClientCnxn$SendThread@1235] - Session 
0x1032d2b45d4 for server 127.0.0.1/127.0.0.1:21994, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-04-28 08:50:31,769 [myid:] - INFO  [ProcessThread(sid:0 
cport:22240)::PrepRequestProcessor@613] - Processed session termination for 
sessionid: 0x1032d329943
[junit] 2017-04-28 08:50:31,772 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port22240,name1=Connections,name2=127.0.0.1,name3=0x1032d329943]
[junit] 2017-04-28 08:50:31,772 [myid:] - INFO  [main:ZooKeeper@1326] - 
Session: 0x1032d329943 closed
[junit] 2017-04-28 08:50:31,773 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 148347
[junit] 2017-04-28 08:50:31,773 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 861
[junit] 2017-04-28 08:50:31,773 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-04-28 08:50:31,773 [myid:] - INFO  [main:ClientBase@567] - 
tearDown starting
[junit] 2017-04-28 08:50:31,773 [myid:] - INFO  [main:ClientBase@537] - 
STOPPING server
[junit] 2017-04-28 08:50:31,773 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:22240
[junit] 2017-04-28 08:50:31,772 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1032d329943
[junit] 2017-04-28 08:50:31,776 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-04-28 08:50:31,777 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-04-28 08:50:31,777 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-04-28 08:50:31,777 [myid:] - INFO  
[main:PrepRequestProcessor@1004] - Shutting down
[junit] 2017-04-28 08:50:31,777 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-04-28 08:50:31,777 [myid:] - INFO  [ProcessThread(sid:0 
cport:22240)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2017-04-28 08:50:31,777 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-04-28 08:50:31,778 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-04-28 08:50:31,778 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988422#comment-15988422
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2763:
---

Github user alburthoffman commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/238#discussion_r113880584
  
--- Diff: src/java/main/org/apache/jute/Utils.java ---
@@ -190,19 +190,32 @@ static String fromCSVString(String s) throws 
IOException {
 }
 
 /**
+ * convert byte array to a string in hex format
  * 
- * @param s 
- * @return 
+ * @param barr
+ * @return
  */
-static String toXMLBuffer(byte barr[]) {
--- End diff --

@afine found the reason why not use DatatypeConverter:
JAXB Providers are required to call the setDatatypeConverter api at some 
point before the first marshal or unmarshal operation (perhaps during the call 
to JAXBContext.newInstance). This step is necessary to configure the converter 
that should be used to perform the print and parse functionality.

In utils class, initialize JAXB is too heavy, so let's make it simple


> Utils.toCsvBuffer() omits leading 0 for bytes < 0x10
> 
>
> Key: ZOOKEEPER-2763
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2763
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jute
>Affects Versions: 3.5.2
>Reporter: Brandon Berg
>Assignee: Alburt Hoffman
>Priority: Minor
>
> org.apache.jute.Utils.toCsvBuffer(), which converts a byte array to a string 
> containing the hex representation of that byte array, omits the leading zero 
> for any byte less than 0x10, due to its use of Integer.toHexString, which has 
> the same behavior.
> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/jute/Utils.java#L234
> One consequence of this is that the hex strings printed by 
> ClientCnxn.Packet.toString(), used in the debug logging for 
> ClientCnxn.readResponse(), cannot be parsed to determine the result of a 
> Zookeeper request from client debug logs.
> Utils.toXmlBuffer() appears to have the same issue.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leadi...

[alburthoffman]

Github user alburthoffman commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/238#discussion_r113880584
  
--- Diff: src/java/main/org/apache/jute/Utils.java ---
@@ -190,19 +190,32 @@ static String fromCSVString(String s) throws 
IOException {
 }
 
 /**
+ * convert byte array to a string in hex format
  * 
- * @param s 
- * @return 
+ * @param barr
+ * @return
  */
-static String toXMLBuffer(byte barr[]) {
--- End diff --

@afine found the reason why not use DatatypeConverter:
JAXB Providers are required to call the setDatatypeConverter api at some 
point before the first marshal or unmarshal operation (perhaps during the call 
to JAXBContext.newInstance). This step is necessary to configure the converter 
that should be used to perform the print and parse functionality.

In utils class, initialize JAXB is too heavy, so let's make it simple


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

[Alburt Hoffman (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988419#comment-15988419
 ] 

Alburt Hoffman commented on ZOOKEEPER-2763:
---

avoid DatatypeConverter because JAXB has to been initialized at some point, 
otherwise it will throw NullPointerException.

In utils class, initialize JAXB is too heavy, so let's make it simple

> Utils.toCsvBuffer() omits leading 0 for bytes < 0x10
> 
>
> Key: ZOOKEEPER-2763
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2763
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jute
>Affects Versions: 3.5.2
>Reporter: Brandon Berg
>Assignee: Alburt Hoffman
>Priority: Minor
>
> org.apache.jute.Utils.toCsvBuffer(), which converts a byte array to a string 
> containing the hex representation of that byte array, omits the leading zero 
> for any byte less than 0x10, due to its use of Integer.toHexString, which has 
> the same behavior.
> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/jute/Utils.java#L234
> One consequence of this is that the hex strings printed by 
> ClientCnxn.Packet.toString(), used in the debug logging for 
> ClientCnxn.readResponse(), cannot be parsed to determine the result of a 
> Zookeeper request from client debug logs.
> Utils.toXmlBuffer() appears to have the same issue.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Failed: ZOOKEEPER- PreCommit Build #656

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/656/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.97 MB...]
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] -1 javadoc.  The javadoc tool appears to have generated 1 
warning messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 90 new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/656//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/656//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/656//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] 21a313795679c9a5bcdb68c2fb82d3b2aba9965d logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1703:
 exec returned: 2

Total time: 34 minutes 58 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper-trunk-jdk8 - Build # 1027 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1027/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 65.95 MB...]
[junit] 2017-04-28 06:10:17,400 [myid:127.0.0.1:30196] - WARN  
[main-SendThread(127.0.0.1:30196):ClientCnxn$SendThread@1235] - Session 
0x1032c9c942e for server 127.0.0.1/127.0.0.1:30196, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-04-28 06:10:17,455 [myid:] - INFO  [ProcessThread(sid:0 
cport:30319)::PrepRequestProcessor@617] - Processed session termination for 
sessionid: 0x1032c9fe5b6
[junit] 2017-04-28 06:10:17,458 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30319,name1=Connections,name2=127.0.0.1,name3=0x1032c9fe5b6]
[junit] 2017-04-28 06:10:17,458 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1032c9fe5b6
[junit] 2017-04-28 06:10:17,458 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x1032c9fe5b6 closed
[junit] 2017-04-28 06:10:17,458 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 110681
[junit] 2017-04-28 06:10:17,459 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 859
[junit] 2017-04-28 06:10:17,459 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-04-28 06:10:17,459 [myid:] - INFO  [main:ClientBase@582] - 
tearDown starting
[junit] 2017-04-28 06:10:17,459 [myid:] - INFO  [main:ClientBase@552] - 
STOPPING server
[junit] 2017-04-28 06:10:17,459 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:30319
[junit] 2017-04-28 06:10:17,461 [myid:] - INFO  [main:ZooKeeperServer@542] 
- shutting down
[junit] 2017-04-28 06:10:17,462 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-04-28 06:10:17,462 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-04-28 06:10:17,462 [myid:] - INFO  
[main:PrepRequestProcessor@1008] - Shutting down
[junit] 2017-04-28 06:10:17,463 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-04-28 06:10:17,463 [myid:] - INFO  [ProcessThread(sid:0 
cport:30319)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2017-04-28 06:10:17,463 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-04-28 06:10:17,463 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-04-28 06:10:17,463 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port30319,name1=InMemoryDataTree]
[junit] 2017-04-28 06:10:17,464 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port30319]
[junit] 2017-04-28 06:10:17,464 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 30319
[junit] 2017-04-28 06:10:17,464 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-04-28 06:10:17,469 [myid:] - INFO  [main:ClientBase@607] - 
fdcount after test is: 2534 at start it was 2534
[junit] 2017-04-28 06:10:17,469 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-04-28 06:10:17,469 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
482.819 sec, Thread: 8, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-04-28 06:10:17,799 [myid:127.0.0.1:30202] - INFO  
[main-SendThread(127.0.0.1:30202):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:30202. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-04-28 06:10:17,800 [myid:127.0.0.1:30202] - WARN  
[main-SendThread(127.0.0.1:30202):ClientCnxn$SendThread@1235] - Session 
0x3032c9c9437 for server 127.0.0.1/127.0.0.1:30202, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at