[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1641#comment-1641
 ] 

Hudson commented on ZOOKEEPER-2997:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3778 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3778/])
ZOOKEEPER-2997: CMake should not force static CRT linking (hanm: rev 
13c9f899ff62be6a2eacb28e522d06703f1dab08)
* (edit) src/c/CMakeLists.txt


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2998) CMake declares incorrect ZooKeeper version

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413332#comment-16413332
 ] 

Hudson commented on ZOOKEEPER-2998:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3778 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3778/])
ZOOKEEPER-2998: CMake declares incorrect ZooKeeper version (hanm: rev 
29a892907eb175adc0c6908a1fde3e7bf8d655b6)
* (edit) src/c/CMakeLists.txt


> CMake declares incorrect ZooKeeper version
> --
>
> Key: ZOOKEEPER-2998
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2998
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Minor
> Fix For: 3.6.0
>
>
> The \{{CMakeLists.txt}} file in the master branch declares version 3.5.3 
> instead of 3.6.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch35_jdk7 - Build # 1335 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1335/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 59.92 KB...]
[junit] Running org.apache.zookeeper.test.SaslClientTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.099 sec, Thread: 1, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 5
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.082 sec, Thread: 5, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.286 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.5 
sec, Thread: 1, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 5
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
1
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.126 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
122.023 sec, Thread: 8, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.65 sec, Thread: 8, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.842 sec, Thread: 8, Class: org.apache.zookeeper.test.StatTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
72.615 sec, Thread: 4, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 4
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.14 sec, Thread: 8, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.005 sec, Thread: 8, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 8
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.154 sec, Thread: 4, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.499 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.17 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.854 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 1
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.462 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 5
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.174 sec, Thread: 5, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.254 sec, Thread: 8, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 5
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.354 sec, Thread: 8, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.827 sec, Thread: 4, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
14.304 sec, Thread: 5, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 

ZooKeeper-trunk - Build # 3777 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3777/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 141.59 KB...]
[junit] Running org.apache.zookeeper.test.StatTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.038 sec, Thread: 5, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 5
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.18 sec, Thread: 5, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.077 sec, Thread: 5, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
36.518 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 5
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.012 sec, Thread: 5, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
238.675 sec, Thread: 1, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.115 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.801 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.73 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.137 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.826 sec, Thread: 5, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.336 sec, Thread: 5, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
174.545 sec, Thread: 4, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.062 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
37.619 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
305.364 sec, Thread: 8, Class: org.apache.zookeeper.test.ReconfigTest
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
690.765 sec, Thread: 7, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
698.063 sec, Thread: 2, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] Running org.apache.zookeeper.test.DisconnectedWatcherTest in thread 
6
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 6, Class: org.apache.zookeeper.test.DisconnectedWatcherTest
[junit] Test org.apache.zookeeper.test.DisconnectedWatcherTest FAILED 
(timeout)

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1395: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1276: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1280: Tests 
failed!

Total time: 20 minutes 36 seconds
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording fingerprints
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[JIRA] Updating issue ZOOKEEPER-3001
Recording test results

[jira] [Commented] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413295#comment-16413295
 ] 

Hudson commented on ZOOKEEPER-3001:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3777 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3777/])
ZOOKEEPER-3001: Incorrect log message when try to delete container node (hanm: 
rev 8cfca3add9c7fd705f9114daf4adaac9fc90f040)
* (edit) src/java/main/org/apache/zookeeper/server/ContainerManager.java


> Incorrect log message when try to delete container node
> ---
>
> Key: ZOOKEEPER-3001
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3001
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Sel-fish Finch
>Assignee: Sel-fish Finch
>Priority: Trivial
> Fix For: 3.5.4, 3.6.0
>
>
> The log message when trying to delete a container node is not proper, missing
> *_String.format_*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413291#comment-16413291
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3006:
---

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
Hi @hanm,

Excuse me for the mess up and subsequent confusion. @edwardoliveira is me, 
@eribeiro (on GH and JIRA), but I inadvertedly opened the PR using my second GH 
account. :(

My e-mail is edward.ribe...@gmail.com

If you prefer, I may close this PR and open a new PR from my main account. 
The referenced branch comes from the right account, already.

I have already assigned the issue to myself, btw. 

Cheers!


> Potential NPE in ZKDatabase#calculateTxnLogSizeLimit
> 
>
> Key: ZOOKEEPER-3006
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3006
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: lujie
>Assignee: Edward Ribeiro
>Priority: Major
>
> I have found a potential NPE in ZKDatabase#calculateTxnLogSizeLimit:
>  
> {code:java}
> //ZKDatabase
> public long calculateTxnLogSizeLimit() {
> long snapSize = 0;
> try {
> snapSize = snapLog.findMostRecentSnapshot().length();
> } catch (IOException e) {
> LOG.error("Unable to get size of most recent snapshot");
> }
> return (long) (snapSize * snapshotSizeFactor);
> }
> {code}
>  in FileTxnSnapLog#findMostRecentSnapshot(), it will return the result of  
> FileSnap#findMostRecentSnapshot:
> {code:java}
> // called by FileTxnSnapLog#findMostRecentSnapshot()
> public File findMostRecentSnapshot() throws IOException {
> List files = findNValidSnapshots(1);
> if (files.size() == 0) {
> return null;
> }
> return files.get(0);
> }
> {code}
> So it will return null when the files sizes is 0, but 
> ZKDatabase#calculateTxnLogSizeLimit has no null checker
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

[eribeiro]

Github user eribeiro commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
Hi @hanm,

Excuse me for the mess up and subsequent confusion. @edwardoliveira is me, 
@eribeiro (on GH and JIRA), but I inadvertedly opened the PR using my second GH 
account. :(

My e-mail is edward.ribe...@gmail.com

If you prefer, I may close this PR and open a new PR from my main account. 
The referenced branch comes from the right account, already.

I have already assigned the issue to myself, btw. 

Cheers!


---

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413285#comment-16413285
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/485


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #485: ZOOKEEPER-2997: CMake should not force static C...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/485


---

[jira] [Commented] (ZOOKEEPER-2998) CMake declares incorrect ZooKeeper version

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413281#comment-16413281
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2998:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/484


> CMake declares incorrect ZooKeeper version
> --
>
> Key: ZOOKEEPER-2998
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2998
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Minor
> Fix For: 3.6.0
>
>
> The \{{CMakeLists.txt}} file in the master branch declares version 3.5.3 
> instead of 3.6.0.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #484: ZOOKEEPER-2998: CMake declares incorrect ZooKee...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/484


---

[jira] [Assigned] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

[Edward Ribeiro (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Edward Ribeiro reassigned ZOOKEEPER-3006:
-

Assignee: Edward Ribeiro

> Potential NPE in ZKDatabase#calculateTxnLogSizeLimit
> 
>
> Key: ZOOKEEPER-3006
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3006
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: lujie
>Assignee: Edward Ribeiro
>Priority: Major
>
> I have found a potential NPE in ZKDatabase#calculateTxnLogSizeLimit:
>  
> {code:java}
> //ZKDatabase
> public long calculateTxnLogSizeLimit() {
> long snapSize = 0;
> try {
> snapSize = snapLog.findMostRecentSnapshot().length();
> } catch (IOException e) {
> LOG.error("Unable to get size of most recent snapshot");
> }
> return (long) (snapSize * snapshotSizeFactor);
> }
> {code}
>  in FileTxnSnapLog#findMostRecentSnapshot(), it will return the result of  
> FileSnap#findMostRecentSnapshot:
> {code:java}
> // called by FileTxnSnapLog#findMostRecentSnapshot()
> public File findMostRecentSnapshot() throws IOException {
> List files = findNValidSnapshots(1);
> if (files.size() == 0) {
> return null;
> }
> return files.get(0);
> }
> {code}
> So it will return null when the files sizes is 0, but 
> ZKDatabase#calculateTxnLogSizeLimit has no null checker
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
@edwardoliveira : could you please share your email so I can put it in 
commit message when merge this? 
Also, could you please create a JIRA account if you don't have one on 
https://issues.apache.org/jira/projects/ZOOKEEPER so I can assign 
ZOOKEEPER-3006 to you? This is to make sure we distribute commit credits to 
contributors.


---

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413274#comment-16413274
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3006:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
@edwardoliveira : could you please share your email so I can put it in 
commit message when merge this? 
Also, could you please create a JIRA account if you don't have one on 
https://issues.apache.org/jira/projects/ZOOKEEPER so I can assign 
ZOOKEEPER-3006 to you? This is to make sure we distribute commit credits to 
contributors.


> Potential NPE in ZKDatabase#calculateTxnLogSizeLimit
> 
>
> Key: ZOOKEEPER-3006
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3006
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: lujie
>Priority: Major
>
> I have found a potential NPE in ZKDatabase#calculateTxnLogSizeLimit:
>  
> {code:java}
> //ZKDatabase
> public long calculateTxnLogSizeLimit() {
> long snapSize = 0;
> try {
> snapSize = snapLog.findMostRecentSnapshot().length();
> } catch (IOException e) {
> LOG.error("Unable to get size of most recent snapshot");
> }
> return (long) (snapSize * snapshotSizeFactor);
> }
> {code}
>  in FileTxnSnapLog#findMostRecentSnapshot(), it will return the result of  
> FileSnap#findMostRecentSnapshot:
> {code:java}
> // called by FileTxnSnapLog#findMostRecentSnapshot()
> public File findMostRecentSnapshot() throws IOException {
> List files = findNValidSnapshots(1);
> if (files.size() == 0) {
> return null;
> }
> return files.get(0);
> }
> {code}
> So it will return null when the files sizes is 0, but 
> ZKDatabase#calculateTxnLogSizeLimit has no null checker
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk-openjdk7 - Build # 1843 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1843/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.97 KB...]
[junit] Running org.apache.zookeeper.test.SaslClientTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.08 sec, Thread: 4, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 3
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.923 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.42 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.547 sec, Thread: 4, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 3
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
4
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.111 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
58.773 sec, Thread: 8, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
46.925 sec, Thread: 1, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 8
[junit] Running org.apache.zookeeper.test.StatTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.606 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.791 sec, Thread: 8, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.099 sec, Thread: 8, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.332 sec, Thread: 8, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 8
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.821 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.071 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.16 sec, Thread: 4, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 4
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.606 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.602 sec, Thread: 8, Class: org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.668 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 8
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.102 sec, Thread: 8, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.315 sec, Thread: 8, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.34 sec, Thread: 1, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.805 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 

[jira] [Assigned] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han reassigned ZOOKEEPER-3001:
--

Assignee: Sel-fish Finch

> Incorrect log message when try to delete container node
> ---
>
> Key: ZOOKEEPER-3001
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3001
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Sel-fish Finch
>Assignee: Sel-fish Finch
>Priority: Trivial
> Fix For: 3.5.4, 3.6.0
>
>
> The log message when trying to delete a container node is not proper, missing
> *_String.format_*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #492: ZOOKEEPER-3001: Incorrect log message when try ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/492


---

[jira] [Commented] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413271#comment-16413271
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3001:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/492


> Incorrect log message when try to delete container node
> ---
>
> Key: ZOOKEEPER-3001
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3001
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Sel-fish Finch
>Priority: Trivial
> Fix For: 3.5.4, 3.6.0
>
>
> The log message when trying to delete a container node is not proper, missing
> *_String.format_*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ZOOKEEPER-3001) Incorrect log message when try to delete container node

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han resolved ZOOKEEPER-3001.

   Resolution: Fixed
Fix Version/s: 3.5.4
   3.6.0

Issue resolved by pull request 492
[https://github.com/apache/zookeeper/pull/492]

> Incorrect log message when try to delete container node
> ---
>
> Key: ZOOKEEPER-3001
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3001
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Sel-fish Finch
>Priority: Trivial
> Fix For: 3.6.0, 3.5.4
>
>
> The log message when trying to delete a container node is not proper, missing
> *_String.format_*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Let's cut a ZK 3.5.4-beta release

[Michael Han]

+1 on 3.5.4 release planning.

>> There are 10 open blocker issues marked for 3.5.4. Can I get some help
to sort out those issues?

The url posted does not work for me, here is the query I use:
https://goo.gl/3MJZMN

Just had a chance to go through the JIRA and did some clean ups.
- 1159: lower the priority from blocker to major.
- 761: resolved because the code is merged.

ZOOKEEPER-2903, 2184, 2982 looks like real blockers for the 3.5.4 release.
The rest of the blockers are legacy that's get postponed indefinitely.


On Wed, Mar 14, 2018 at 11:59 AM, Flavio Junqueira  wrote:

> Ok, I can have a look at ZK-2901. I'd like to get ZK-2982 in as well as it
> is causing us problems with Kubernetes. The fix is simple, but I'm
> wondering about adding a test case.
>
> -Flavio
>
> > On 14 Mar 2018, at 17:30, Patrick Hunt  wrote:
> >
> > I would like to cut 3.5.4. Need more eyes on 2901 though.
> >
> > Patrick
> >
> > On Wed, Mar 14, 2018 at 4:26 AM, Flavio Junqueira 
> wrote:
> >
> >> I think ZK-2901 is close to being merged, yes? And with that, will we
> cut
> >> a 3.5.4 release?
> >>
> >> -Flavio
> >>
> >>> On 7 Dec 2017, at 00:27, Patrick Hunt  wrote:
> >>>
> >>> I haven't forgotten about this - we've been stuck on ZOOKEEPER-2901 . I
> >>> think we getting closer but it's been tricky to navigate addressing the
> >>> issue vs backward compat vs making things worse. I was about to sign
> off
> >>> then noticed I had missed something. Jordan has been working to
> address.
> >>>
> >>> Camille, Edward -- it would be good if you could take a look at 2901
> >> given
> >>> you participated in the original creation/commit of this feature.
> >>>
> >>> Regards,
> >>>
> >>> Patrick
> >>>
> >>> On Tue, Nov 21, 2017 at 11:32 AM, Karan Mehta 
> >>> wrote:
> >>>
>  Can we get ZOOKEEPER-2770
>   in as well?
> The
> >> PR
>  is ready for review at https://github.com/apache/zookeeper/pull/307
>  It will be a nice feature addition. Thanks!
> 
>  Regards
>  Karan
>  ᐧ
> 
>  On Tue, Nov 21, 2017 at 11:00 AM, Jordan Zimmerman <
>  jor...@jordanzimmerman.com> wrote:
> 
> >> Afaict the only real blocker for the release at this point is
> >> ZOOKEEPER-2901 - Jordan can you resolve the comments, after which we
> > should
> >> be good to go. LMK if there's anything I'm missing.
> >
> > I'll have this done in the next day or so. Please wait for me if you
> >> can!
> >
> > -Jordan
> 
> >>
> >>
>
>

[jira] [Updated] (ZOOKEEPER-1159) ClientCnxn does not propagate session expiration indication

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-1159:
---
Priority: Major  (was: Blocker)

> ClientCnxn does not propagate session expiration indication
> ---
>
> Key: ZOOKEEPER-1159
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1159
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.0
>Reporter: Andrew Purtell
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> ClientCnxn does not always propagate session expiration indication up to 
> clients. If a reconnection attempt fails because the session has since 
> expired, the KeeperCode is still Disconnected, but shouldn't it be set to 
> Expired? Perhaps like so:
> {code}
> --- a/src/java/main/org/apache/zookeeper/ClientCnxn.java
> +++ b/src/java/main/org/apache/zookeeper/ClientCnxn.java
> @@ -1160,6 +1160,7 @@ public class ClientCnxn {
>  clientCnxnSocket.doTransport(to, pendingQueue, 
> outgoingQueue);
>  
>  } catch (Exception e) {
> +Event.KeeperState eventState = 
> Event.KeeperState.Disconnected;
>  if (closing) {
>  if (LOG.isDebugEnabled()) {
>  // closing so this is expected
> @@ -1172,6 +1173,7 @@ public class ClientCnxn {
>  // this is ugly, you have a better way speak up
>  if (e instanceof SessionExpiredException) {
>  LOG.info(e.getMessage() + ", closing socket 
> connection");
> +eventState = Event.KeeperState.Expired;
>  } else if (e instanceof SessionTimeoutException) {
>  LOG.info(e.getMessage() + RETRY_CONN_MSG);
>  } else if (e instanceof EndOfStreamException) {
> @@ -1191,7 +1193,7 @@ public class ClientCnxn {
>  if (state.isAlive()) {
>  eventThread.queueEvent(new WatchedEvent(
>  Event.EventType.None,
> -Event.KeeperState.Disconnected,
> +eventState,
>  null));
>  }
>  clientCnxnSocket.updateNow();
> {code}
> This affects HBase. HBase master and region server processes will shut down 
> by design if their session has expired, but will attempt to reconnect if they 
> think they have been disconnected. The above prevents proper termination.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413265#comment-16413265
 ] 

Michael Han commented on ZOOKEEPER-761:
---

The patch was merged in 3.5 (and released as part of 3.5.3-beta on March/2017) 
as well as in master. 

The remaining issue is to decide whether or not to get the patch in 3.4 branch, 
but that's not a blocker for any of the future 3.5/3.6 releases, so resolve the 
JIRA.

> Remove *synchronous* calls from the *single-threaded* C clieant API, since 
> they are documented not to work
> --
>
> Key: ZOOKEEPER-761
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-761
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.1.1, 3.2.2
> Environment: RHEL 4u8 (Linux).  The issue is not OS-specific though.
>Reporter: Jozef Hatala
>Assignee: Benjamin Reed
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: fix-sync-apis-in-st-adaptor.patch, 
> fix-sync-apis-in-st-adaptor.v2.patch
>
>
> Since the synchronous calls are 
> [known|http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#Using+the+C+Client]
>  to be unimplemented in the single threaded version of the client library 
> libzookeeper_st.so, I believe that it would be helpful towards users of the 
> library if that information was also obvious from the header file.
> Anecdotally more than one of us here made the mistake of starting by using 
> the synchronous calls with the single-threaded library, and we found 
> ourselves debugging it.  An early warning would have been greatly appreciated.
> 1. Could you please add warnings to the doxygen blocks of all synchronous 
> calls saying that they are not available in the single-threaded API.  This 
> cannot be safely done with {{#ifdef THREADED}}, obviously, because the same 
> header file is included whichever client library implementation one is 
> compiling for.
> 2. Could you please bracket the implementation of all synchronous calls in 
> zookeeper.c with {{#ifdef THREADED}} and {{#endif}}, so that those symbols 
> are not present in libzookeeper_st.so?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han resolved ZOOKEEPER-761.
---
   Resolution: Fixed
Fix Version/s: (was: 3.5.4)
   3.5.3

> Remove *synchronous* calls from the *single-threaded* C clieant API, since 
> they are documented not to work
> --
>
> Key: ZOOKEEPER-761
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-761
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.1.1, 3.2.2
> Environment: RHEL 4u8 (Linux).  The issue is not OS-specific though.
>Reporter: Jozef Hatala
>Assignee: Benjamin Reed
>Priority: Blocker
> Fix For: 3.6.0, 3.5.3
>
> Attachments: fix-sync-apis-in-st-adaptor.patch, 
> fix-sync-apis-in-st-adaptor.v2.patch
>
>
> Since the synchronous calls are 
> [known|http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#Using+the+C+Client]
>  to be unimplemented in the single threaded version of the client library 
> libzookeeper_st.so, I believe that it would be helpful towards users of the 
> library if that information was also obvious from the header file.
> Anecdotally more than one of us here made the mistake of starting by using 
> the synchronous calls with the single-threaded library, and we found 
> ourselves debugging it.  An early warning would have been greatly appreciated.
> 1. Could you please add warnings to the doxygen blocks of all synchronous 
> calls saying that they are not available in the single-threaded API.  This 
> cannot be safely done with {{#ifdef THREADED}}, obviously, because the same 
> header file is included whichever client library implementation one is 
> compiling for.
> 2. Could you please bracket the implementation of all synchronous calls in 
> zookeeper.c with {{#ifdef THREADED}} and {{#endif}}, so that those symbols 
> are not present in libzookeeper_st.so?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Upgrade 3.5 and trunk to Java8

[Camille Fournier]

+1

On Sun, Mar 25, 2018, 9:16 PM Michael Han  wrote:

> +1.
>
> On Sat, Mar 24, 2018 at 9:53 AM, Edward Ribeiro 
> wrote:
>
> > +1 (non-binding)
> >
> > On Sat, Mar 24, 2018 at 1:42 PM, Brian Nixon 
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > On Fri, Mar 23, 2018 at 2:15 AM, Mark Fenes 
> wrote:
> > >
> > > > +1
> > > >
> > > >
> > > > On Thu, Mar 22, 2018 at 6:57 PM, Andor Molnar 
> > > wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > Let's start the vote on upgrading to Java8.
> > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3002
> > > > >
> > > > > *Shall we upgrade the minimum required Java version to compile and
> > run
> > > > > ZooKeeper on 3.5 and master branches to Java 1.8?*
> > > > >
> > > > > Please cast your vote by replying 'Yes' or 'No' to this thread.
> > > > >
> > > > > Thanks,
> > > > > Andor
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Upgrade 3.5 and trunk to Java8

[Michael Han]

+1.

On Sat, Mar 24, 2018 at 9:53 AM, Edward Ribeiro 
wrote:

> +1 (non-binding)
>
> On Sat, Mar 24, 2018 at 1:42 PM, Brian Nixon 
> wrote:
>
> > +1 (non-binding)
> >
> > On Fri, Mar 23, 2018 at 2:15 AM, Mark Fenes  wrote:
> >
> > > +1
> > >
> > >
> > > On Thu, Mar 22, 2018 at 6:57 PM, Andor Molnar 
> > wrote:
> > >
> > > > Hi all,
> > > >
> > > > Let's start the vote on upgrading to Java8.
> > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3002
> > > >
> > > > *Shall we upgrade the minimum required Java version to compile and
> run
> > > > ZooKeeper on 3.5 and master branches to Java 1.8?*
> > > >
> > > > Please cast your vote by replying 'Yes' or 'No' to this thread.
> > > >
> > > > Thanks,
> > > > Andor
> > > >
> > >
> >
>

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 0

[Michael Han]

-1 because release note is not correct. ZOOKEEPER-2948 and ZOOKEEPER-2806
should be included in release notes and corresponding JIRA needs update.

Other than this, rc0 looks good.

- verified xsum/sig
- go through release notes.
- verified cluster with different sizes.
- verified with few 4lw commands.
- verified data / log dir swap was fixed.
- all unit test passed.


On Fri, Mar 23, 2018 at 1:23 PM, Ted Yu  wrote:

> I just ran the test suite again - there was no test failure.
>
> So +1 from my side.
>
> On Fri, Mar 23, 2018 at 9:54 AM, Abraham Fine  wrote:
>
> > Do they always fail when run with the rest of the test suite or is it
> > inconsistent?
> >
> > The reason I ask is that the failure you are reporting is a
> ConnectionLoss
> > and testSessionTimeout has a history of being flaky (generally on
> ZooKeeper
> > 3.5 though).
> >
> >
> > On Fri, Mar 23, 2018, at 09:45, Ted Yu wrote:
> > > Here is OS:
> > >
> > > Linux h.com 3.10.0-327.28.3.el7.x86_64 #1 SMP Thu Aug 18 19:05:49 UTC
> > 2016
> > > x86_64 x86_64 x86_64 GNU/Linux
> > >
> > > java version "1.8.0_161"
> > > Java(TM) SE Runtime Environment (build 1.8.0_161-b12)
> > > Java HotSpot(TM) 64-Bit Server VM (build 25.161-b12, mixed mode)
> > >
> > > The tests don't fail when run alone.
> > >
> > > FYI
> > >
> > > On Fri, Mar 23, 2018 at 9:41 AM, Abraham Fine 
> wrote:
> > >
> > > > Hi Ted-
> > > >
> > > > Thanks for running the test cases on the RC. I am not able to
> reproduce
> > > > the failures. Would you mind telling us a little bit more about the
> > > > environment you are running the tests in (operating system, jvm)? In
> > > > addition, to the failures occur every time you run the tests or just
> > > > occasionally?
> > > >
> > > > Thanks,
> > > > Abe
> > > >
> > > > On Thu, Mar 22, 2018, at 17:16, Ted Yu wrote:
> > > > > Hi,
> > > > > I ran test suite for the RC.
> > > > >
> > > > > Testcase: testSessionTimeout took 22.686 sec
> > > > >   Caused an ERROR
> > > > > KeeperErrorCode = ConnectionLoss for /stest
> > > > > org.apache.zookeeper.KeeperException$ConnectionLossException:
> > > > > KeeperErrorCode = ConnectionLoss for /stest
> > > > >   at org.apache.zookeeper.KeeperException.create(
> > > > KeeperException.java:102)
> > > > >   at org.apache.zookeeper.KeeperException.create(
> > > > KeeperException.java:54)
> > > > >   at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1105)
> > > > >   at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1133)
> > > > >   at
> > > > > org.apache.zookeeper.test.SessionTest.testSessionTimeout(
> > > > SessionTest.java:300)
> > > > >
> > > > > 
> > > > >
> > > > > Testcase: testWatcherAutoResetDisabledWithLocal took 8.545 sec
> > > > >   Caused an ERROR
> > > > > KeeperErrorCode = ConnectionLoss for /watchtest/child2
> > > > > org.apache.zookeeper.KeeperException$ConnectionLossException:
> > > > > KeeperErrorCode = ConnectionLoss for /watchtest/child2
> > > > >   at
> > > > > org.apache.zookeeper.KeeperException.create(
> > KeeperException.java:102)
> > > > >   at
> > > > > org.apache.zookeeper.KeeperException.create(
> KeeperException.java:54)
> > > > >   at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:876)
> > > > >   at
> > > > > org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(
> > > > WatcherTest.java:369)
> > > > >   at
> > > > > org.apache.zookeeper.test.WatcherTest.
> testWatcherAutoResetWithLocal(
> > > > WatcherTest.java:255)
> > > > >   at
> > > > > org.apache.zookeeper.test.WatcherTest.
> testWatcherAutoResetDisabledWi
> > > > thLocal(WatcherTest.java:268)
> > > > >
> > > > > Has anyone else seen the above test failures ?
> > > > >
> > > > > Cheers
> > > >
> >
>

Success: ZOOKEEPER- PreCommit Build #1548

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1548/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.16 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1548//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1548//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1548//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 8 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-3006
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Failed: ZOOKEEPER- PreCommit Build #1547

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1547/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 78.99 MB...]
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1547//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1547//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1547//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1722:
 exec returned: 1

Total time: 19 minutes 56 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-3006
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
2 tests failed.
FAILED:  org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:745)


FAILED:  
org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged

Error Message:
expected: but was:

Stack Trace:
junit.framework.AssertionFailedError: expected: but 
was:
at 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest$EventsWatcher.assertEvent(WatchEventWhenAutoResetTest.java:67)
at 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged(WatchEventWhenAutoResetTest.java:117)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413181#comment-16413181
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3006:
---

Github user edwardoliveira commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
Hey, @LJ1043041006, I have just added a unit test. Cheers!


> Potential NPE in ZKDatabase#calculateTxnLogSizeLimit
> 
>
> Key: ZOOKEEPER-3006
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3006
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: lujie
>Priority: Major
>
> I have found a potential NPE in ZKDatabase#calculateTxnLogSizeLimit:
>  
> {code:java}
> //ZKDatabase
> public long calculateTxnLogSizeLimit() {
> long snapSize = 0;
> try {
> snapSize = snapLog.findMostRecentSnapshot().length();
> } catch (IOException e) {
> LOG.error("Unable to get size of most recent snapshot");
> }
> return (long) (snapSize * snapshotSizeFactor);
> }
> {code}
>  in FileTxnSnapLog#findMostRecentSnapshot(), it will return the result of  
> FileSnap#findMostRecentSnapshot:
> {code:java}
> // called by FileTxnSnapLog#findMostRecentSnapshot()
> public File findMostRecentSnapshot() throws IOException {
> List files = findNValidSnapshots(1);
> if (files.size() == 0) {
> return null;
> }
> return files.get(0);
> }
> {code}
> So it will return null when the files sizes is 0, but 
> ZKDatabase#calculateTxnLogSizeLimit has no null checker
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

[edwardoliveira]

Github user edwardoliveira commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
Hey, @LJ1043041006, I have just added a unit test. Cheers!


---

ZooKeeper-trunk-jdk8 - Build # 1419 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1419/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.38 KB...]
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.586 sec, Thread: 1, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.437 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
57.482 sec, Thread: 6, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
6
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.127 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
52.055 sec, Thread: 7, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.937 sec, Thread: 7, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.48 sec, Thread: 7, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 7
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.311 sec, Thread: 7, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.095 sec, Thread: 7, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.048 sec, Thread: 7, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.638 sec, Thread: 6, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 6
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.047 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.114 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.267 sec, Thread: 7, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 7
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.587 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.127 sec, Thread: 1, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.236 sec, Thread: 6, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.923 sec, Thread: 1, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.098 sec, Thread: 6, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.636 sec, Thread: 7, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
550.286 sec, Thread: 4, Class: org.apache.zookeeper.test.DisconnectedWatcherTest
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
523.396 sec, Thread: 3, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time 

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412977#comment-16412977
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3006:
---

Github user maoling commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
+1,LGTM


> Potential NPE in ZKDatabase#calculateTxnLogSizeLimit
> 
>
> Key: ZOOKEEPER-3006
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3006
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: lujie
>Priority: Major
>
> I have found a potential NPE in ZKDatabase#calculateTxnLogSizeLimit:
>  
> {code:java}
> //ZKDatabase
> public long calculateTxnLogSizeLimit() {
> long snapSize = 0;
> try {
> snapSize = snapLog.findMostRecentSnapshot().length();
> } catch (IOException e) {
> LOG.error("Unable to get size of most recent snapshot");
> }
> return (long) (snapSize * snapshotSizeFactor);
> }
> {code}
>  in FileTxnSnapLog#findMostRecentSnapshot(), it will return the result of  
> FileSnap#findMostRecentSnapshot:
> {code:java}
> // called by FileTxnSnapLog#findMostRecentSnapshot()
> public File findMostRecentSnapshot() throws IOException {
> List files = findNValidSnapshots(1);
> if (files.size() == 0) {
> return null;
> }
> return files.get(0);
> }
> {code}
> So it will return null when the files sizes is 0, but 
> ZKDatabase#calculateTxnLogSizeLimit has no null checker
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

[maoling]

Github user maoling commented on the issue:

https://github.com/apache/zookeeper/pull/493
  
+1,LGTM


---