ZooKeeper-trunk - Build # 3815 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3815/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 258.26 KB...]
 [exec] Log Message Received: [2018-04-24 
04:32:19,281:14088(0x2ab12f568f40):ZOO_INFO@zookeeper_init_internal@1152: 
Initiating client connection, host=127.0.0.1:22181 sessionTimeout=1 
watcher=0x461d20 sessionId=0 sessionPasswd= context=0x7fff7c7ba200 
flags=0]
 [exec] Log Message Received: [2018-04-24 
04:32:19,282:14088(0x2ab1315cb700):ZOO_INFO@check_events@2439: initiated 
connection to server [127.0.0.1:22181]]
 [exec] Log Message Received: [2018-04-24 
04:32:19,298:14088(0x2ab1315cb700):ZOO_INFO@check_events@2491: session 
establishment complete on server [127.0.0.1:22181], 
sessionId=0x10091abf1a4000f, negotiated timeout=1 ]
 [exec]  : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server 
started : elapsed 10490 : OK
 [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 [exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testNullData : elapsed 1044 : OK
 [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1009 : OK
 [exec] Zookeeper_simpleSystem::testCreate : elapsed 1024 : OK
 [exec] Zookeeper_simpleSystem::testPath : elapsed 1066 : OK
 [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1137 : OK
 [exec] Zookeeper_simpleSystem::testPing : elapsed 17718 : OK
 [exec] Zookeeper_simpleSystem::testAcl : elapsed 1024 : OK
 [exec] Zookeeper_simpleSystem::testChroot : elapsed 3106 : OK
 [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper 
server started : elapsed 31105 : OK
 [exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1059 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
15642 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
15800 : OK
 [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1079 : OK
 [exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4546 : OK
 [exec] Zookeeper_simpleSystem::testRemoveWatchers ZooKeeper server started 
: elapsed 4598 : OK
 [exec] *** Error in `./zktest-mt': corrupted double-linked list: 
0x0267d730 ***
 [exec] /bin/bash: line 5: 14088 Aborted 
ZKROOT=/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/src/c/../.. 
CLASSPATH=$CLASSPATH:$CLOVER_HOME/lib/clover.jar ${dir}$tst
 [exec] Zookeeper_readOnly::testReadOnly : elapsed 4152 : OK
 [exec] OK (74)
 [exec] FAIL: zktest-mt
 [exec] ==
 [exec] 1 of 2 tests failed
 [exec] Please report to u...@zookeeper.apache.org
 [exec] ==
 [exec] make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build/test/test-cppunit'
 [exec] make[1]: *** [check-TESTS] Error 1
 [exec] make: *** [check-am] Error 2

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1395: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1355: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1365: exec 
returned: 2

Total time: 17 minutes 46 seconds
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording fingerprints
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[JIRA] Updating issue ZOOKEEPER-3025
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Publishing Javadoc
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449270#comment-16449270
 ] 

Hudson commented on ZOOKEEPER-3025:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3815 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3815/])
ZOOKEEPER-3025: cmake broken on windows - make `hashtable` search (phunt: rev 
cb6cae91c71b679d5bbc3fb48bf707fd1bb14493)
* (edit) src/c/CMakeLists.txt


> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 3814 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3814/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 11.24 KB...]
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git clean -fdx" returned 
status code 1:
stdout: 
stderr: warning: failed to remove 
build/test/tmp/test6830417574664709851.junit.dir/data/version-2/snapshot.0

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1964)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1960)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1597)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1609)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.clean(CliGitAPIImpl.java:787)
at hudson.plugins.git.GitAPI.clean(GitAPI.java:311)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:922)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:896)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:853)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H12
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:281)
at com.sun.proxy.$Proxy110.clean(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.clean(RemoteGitImpl.java:450)
at 
hudson.plugins.git.extensions.impl.CleanBeforeCheckout.decorateFetchCommand(CleanBeforeCheckout.java:30)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:858)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1129)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1160)
at hudson.scm.SCM.checkout(SCM.java:495)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1202)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Recording fingerprints
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Publishing Javadoc
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper-trunk - Build # 3813 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3813/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 11.24 KB...]
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git clean -fdx" returned 
status code 1:
stdout: 
stderr: warning: failed to remove 
build/test/tmp/test6830417574664709851.junit.dir/data/version-2/snapshot.0

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1964)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1960)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1597)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1609)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.clean(CliGitAPIImpl.java:787)
at hudson.plugins.git.GitAPI.clean(GitAPI.java:311)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:922)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:896)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:853)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H12
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:281)
at com.sun.proxy.$Proxy110.clean(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.clean(RemoteGitImpl.java:450)
at 
hudson.plugins.git.extensions.impl.CleanBeforeCheckout.decorateFetchCommand(CleanBeforeCheckout.java:30)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:858)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1129)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1160)
at hudson.scm.SCM.checkout(SCM.java:495)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1202)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Recording fingerprints
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Publishing Javadoc
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_jdk8 - Build # 931 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/931/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.28 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.657 sec, Thread: 1, Class: 
org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.679 sec, Thread: 2, Class: 
org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.684 sec, Thread: 7, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 1
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
2
[junit] Running org.apache.zookeeper.test.SessionTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.638 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.092 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.468 sec, Thread: 1, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.739 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.464 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.93 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.076 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
77.946 sec, Thread: 4, Class: org.apache.zookeeper.test.QuorumTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.936 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 1
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 4
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
71.434 sec, Thread: 3, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.138 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 2
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.368 sec, Thread: 1, Class: org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec, Thread: 2, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 2
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.08 sec, Thread: 2, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.426 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.889 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.119 sec, Thread: 7, Class: org.apache.zookeeper.test.SessionTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
19.921 sec, Thread: 4, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.605 sec, Thread: 2, Class: 

ZooKeeper-trunk - Build # 3812 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3812/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 146.00 KB...]
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git clean -fdx" returned 
status code 1:
stdout: 
stderr: warning: failed to remove 
build/test/tmp/test6830417574664709851.junit.dir/data/version-2/snapshot.0

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1964)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1960)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1597)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1609)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.clean(CliGitAPIImpl.java:787)
at hudson.plugins.git.GitAPI.clean(GitAPI.java:311)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:922)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:896)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:853)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H12
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:281)
at com.sun.proxy.$Proxy110.clean(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.clean(RemoteGitImpl.java:450)
at 
hudson.plugins.git.extensions.impl.CleanBeforeCheckout.decorateFetchCommand(CleanBeforeCheckout.java:30)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:858)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1129)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1160)
at hudson.scm.SCM.checkout(SCM.java:495)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1202)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Recording fingerprints
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Publishing Javadoc
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Andrew Schwartzmeyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449109#comment-16449109
 ] 

Andrew Schwartzmeyer commented on ZOOKEEPER-3025:
-

No problem [~phunt]! I am very glad to see a working Windows CI system :D

> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449090#comment-16449090
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3025:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/505
  
+1. Thanks @andschwa 


> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #505: ZOOKEEPER-3025: Make `hashtable` search `include`

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/505
  
+1. Thanks @andschwa 


---

[jira] [Updated] (ZOOKEEPER-2999) CMake build should use target-level commands

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2999:

Affects Version/s: 3.5.4

> CMake build should use target-level commands
> 
>
> Key: ZOOKEEPER-2999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2999
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Minor
> Fix For: 3.5.4, 3.6.0
>
>
> Originally suggested in [GitHub PR 
> #386|https://github.com/apache/zookeeper/pull/386], the CMake build I wrote 
> used {{include_directories}}, which has global side effects, instead of the 
> more explicit {{target_include_directories}}, to include directories per 
> target (and with private or public scoping).
> Furthermore, it should also use {{CMAKE_CURRENT_SOURCE_DIR}} over 
> {{CMAKE_SOURCE_DIR}} in order to allow inclusion in other projects via 
> {{add_subdirectory()}}, and we can reduce the minimally required CMake 
> version to 3.5 from 3.6.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-3025.
-
  Resolution: Fixed
Hadoop Flags: Reviewed

The patch fixed it, jenkins is green again:

 

https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/

> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449086#comment-16449086
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3025:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/505


> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #505: ZOOKEEPER-3025: Make `hashtable` search `includ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/505


---

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449084#comment-16449084
 ] 

Patrick Hunt commented on ZOOKEEPER-3025:
-

No worries at all [~andschwa] - I'll take a look at the PR. Thanks for the 
followup.

> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449082#comment-16449082
 ] 

Hadoop QA commented on ZOOKEEPER-3025:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621//console

This message is automatically generated.

> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #1621

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.48 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16449082 added to ZOOKEEPER-3025.
 [exec] Session logged out. Session was 
JSESSIONID=3871A3477C0FF128B5EAF63110D8B98B.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1722:
 exec returned: 1

Total time: 12 minutes 24 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3025
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
KeeperErrorCode = Session expired for /zk2

Stack Trace:
org.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode = 
Session expired for /zk2
at org.apache.zookeeper.KeeperException.create(KeeperException.java:134)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1927)
at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1955)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1012)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-2983) Print the classpath when running compile and test ant targets

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449077#comment-16449077
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2983:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/469
  
@mfenes @anmolnar @afine   - ant already has a -d and a -v option, why do 
we need to add additional? Is it really necessary that all the builds include 
this information? Why is -d/-v not sufficient?


> Print the classpath when running compile and test ant targets
> -
>
> Key: ZOOKEEPER-2983
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2983
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Mark Fenes
>Assignee: Mark Fenes
>Priority: Major
>
> Printing the classpath helps to verify that we have only the intended 
> classes, jars on the classpath, e.g. clover.jar is included only when running 
> coverage tests.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #469: ZOOKEEPER-2983: Print the classpath when running compi...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/469
  
@mfenes @anmolnar @afine   - ant already has a -d and a -v option, why do 
we need to add additional? Is it really necessary that all the builds include 
this information? Why is -d/-v not sufficient?


---

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449069#comment-16449069
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3019:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/501
  
Can we get this into 3.4 as well?


> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Andrew Schwartzmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Schwartzmeyer reassigned ZOOKEEPER-3025:
---

Assignee: Andrew Schwartzmeyer  (was: Michael Han)

> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #501: ZOOKEEPER-3019 add metric for slow fsyncs count

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/501
  
Can we get this into 3.4 as well?


---

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449068#comment-16449068
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3025:
---

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/505
  
Built successfully both in-tree and out-of-tree on Windows using the VS 
generator, also successfully built with the Ninja generator  


> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Andrew Schwartzmeyer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #505: ZOOKEEPER-3025: Make `hashtable` search `include`

[andschwa]

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/505
  
Built successfully both in-tree and out-of-tree on Windows using the VS 
generator, also successfully built with the Ninja generator 😉 


---

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449066#comment-16449066
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3019:
---

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/501#discussion_r183573019
  
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java 
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
 line = in.readLine();
 Assert.assertTrue(Pattern.matches("^Mode: .*$", line));
 line = in.readLine();
+Assert.assertTrue(Pattern.matches("^Fsync threshold exceeded: 
\\d+$", line));
--- End diff --

any chance we can add this to the very end of the output? We weren't very 
clear on order and in some cases existing monitoring may be expecting the 
original order. Appending helps wrt b/w compat.


> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

[phunt]

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/501#discussion_r183573019
  
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java 
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
 line = in.readLine();
 Assert.assertTrue(Pattern.matches("^Mode: .*$", line));
 line = in.readLine();
+Assert.assertTrue(Pattern.matches("^Fsync threshold exceeded: 
\\d+$", line));
--- End diff --

any chance we can add this to the very end of the output? We weren't very 
clear on order and in some cases existing monitoring may be expecting the 
original order. Appending helps wrt b/w compat.


---

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449064#comment-16449064
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3025:
---

GitHub user andschwa opened a pull request:

https://github.com/apache/zookeeper/pull/505

ZOOKEEPER-3025: Make `hashtable` search `include`

When ZOOKEEPER-2999 removed the directory side-effect of
`include_directories(include)`, and added it as a target-level include
to the `zookeeper` library, this broke the Windows build. It worked on
Linux (where the patch was tested) because `winconfig.h` and is not
included, but on Windows, the `hashtable` library included
`winconfig.h` (found in `include`) but no longer knew where to find
it. The fix is to add `include` to the `hashtable` library's list of
include directories.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andschwa/zookeeper ZOOKEEPER-3025

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #505


commit 69afce4df5a5cc71999d67c87578e236b58d17a1
Author: Andrew Schwartzmeyer 
Date:   2018-04-23T23:38:03Z

ZOOKEEPER-3025: Make `hashtable` search `include`

When ZOOKEEPER-2999 removed the directory side-effect of
`include_directories(include)`, and added it as a target-level include
to the `zookeeper` library, this broke the Windows build. It worked on
Linux (where the patch was tested) because `winconfig.h` and is not
included, but on Windows, the `hashtable` library included
`winconfig.h` (found in `include`) but no longer knew where to find
it. The fix is to add `include` to the `hashtable` library's list of
include directories.




> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #505: ZOOKEEPER-3025: Make `hashtable` search `includ...

[andschwa]

GitHub user andschwa opened a pull request:

https://github.com/apache/zookeeper/pull/505

ZOOKEEPER-3025: Make `hashtable` search `include`

When ZOOKEEPER-2999 removed the directory side-effect of
`include_directories(include)`, and added it as a target-level include
to the `zookeeper` library, this broke the Windows build. It worked on
Linux (where the patch was tested) because `winconfig.h` and is not
included, but on Windows, the `hashtable` library included
`winconfig.h` (found in `include`) but no longer knew where to find
it. The fix is to add `include` to the `hashtable` library's list of
include directories.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andschwa/zookeeper ZOOKEEPER-3025

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/505.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #505


commit 69afce4df5a5cc71999d67c87578e236b58d17a1
Author: Andrew Schwartzmeyer 
Date:   2018-04-23T23:38:03Z

ZOOKEEPER-3025: Make `hashtable` search `include`

When ZOOKEEPER-2999 removed the directory side-effect of
`include_directories(include)`, and added it as a target-level include
to the `zookeeper` library, this broke the Windows build. It worked on
Linux (where the patch was tested) because `winconfig.h` and is not
included, but on Windows, the `hashtable` library included
`winconfig.h` (found in `include`) but no longer knew where to find
it. The fix is to add `include` to the `hashtable` library's list of
include directories.




---

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

[phunt]

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/501#discussion_r183571986
  
--- Diff: docs/zookeeperAdmin.html ---
@@ -2213,6 +2213,7 @@ The Four Letter Words
   zk_min_latency  0
   zk_packets_received 70
   zk_packets_sent 69
+  zk_num_alive_connections 1
--- End diff --

Please remove doc/{html,pdf} from PRs - these files are regenerated during 
commit time by the committer. (and are a pain to manage wrt the PR merge tool)


---

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449062#comment-16449062
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3019:
---

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/501#discussion_r183571986
  
--- Diff: docs/zookeeperAdmin.html ---
@@ -2213,6 +2213,7 @@ The Four Letter Words
   zk_min_latency  0
   zk_packets_received 70
   zk_packets_sent 69
+  zk_num_alive_connections 1
--- End diff --

Please remove doc/{html,pdf} from PRs - these files are regenerated during 
commit time by the committer. (and are a pain to manage wrt the PR merge tool)


> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-3019:

Fix Version/s: 3.4.13
   3.6.0
   3.5.4

> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-3019:

Affects Version/s: 3.6.0

> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449059#comment-16449059
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3000:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/490
  
This is a good addition, thanks for bringing to our attention @leventov .

Unfortunately however we can't replace the std javac compiler with 
error_prone in the toolchain outright - we can have a separate option/target to 
do this, but it can't be the default. 

I would recommend separating this into two jiras/pullrequests - one to 
change the build, the other to address the found issues.

@leventov you mentioned "I'm not proficient in Ant" - perhaps one of the 
other folks could help with this? @anmolnar you mentioned hbase is using it - 
anything we can pull from there wrt how they integrate it into their build?

ps. I like the idea of also getting this into 3.4 branch as well, which 
means it needs to be optional so that the user can run it when they have 
java8+, but otw not. Which matches my intent/statement above.

pps. looks like there is a new version of error_prone, might want to take 
this opportunity to update the dependency version. I notice the library is 
ASL2.0 which is also good (license is in the COPYING file currently)


> Use error-prone compiler
> 
>
> Key: ZOOKEEPER-3000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Roman Leventov
>Assignee: Roman Leventov
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> See http://errorprone.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/490
  
This is a good addition, thanks for bringing to our attention @leventov .

Unfortunately however we can't replace the std javac compiler with 
error_prone in the toolchain outright - we can have a separate option/target to 
do this, but it can't be the default. 

I would recommend separating this into two jiras/pullrequests - one to 
change the build, the other to address the found issues.

@leventov you mentioned "I'm not proficient in Ant" - perhaps one of the 
other folks could help with this? @anmolnar you mentioned hbase is using it - 
anything we can pull from there wrt how they integrate it into their build?

ps. I like the idea of also getting this into 3.4 branch as well, which 
means it needs to be optional so that the user can run it when they have 
java8+, but otw not. Which matches my intent/statement above.

pps. looks like there is a new version of error_prone, might want to take 
this opportunity to update the dependency version. I notice the library is 
ASL2.0 which is also good (license is in the COPYING file currently)


---

[jira] [Assigned] (ZOOKEEPER-3000) Use error-prone compiler

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-3000:
---

Assignee: Roman Leventov

> Use error-prone compiler
> 
>
> Key: ZOOKEEPER-3000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Roman Leventov
>Assignee: Roman Leventov
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> See http://errorprone.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch35_jdk8 - Build # 930 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/930/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.24 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.073 sec, Thread: 5, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.606 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.792 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.44 sec, Thread: 5, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
5
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.102 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 5
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
69.205 sec, Thread: 7, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
81.178 sec, Thread: 6, Class: org.apache.zookeeper.test.QuorumTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 7
[junit] Running org.apache.zookeeper.test.StatTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.13 sec, Thread: 6, Class: org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.629 sec, Thread: 7, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 6
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.065 sec, Thread: 7, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.668 sec, Thread: 7, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.634 sec, Thread: 6, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 7
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 6
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.645 sec, Thread: 7, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.075 sec, Thread: 7, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.021 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 5
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.645 sec, Thread: 7, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 7
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.094 sec, Thread: 7, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 7
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.522 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.839 sec, Thread: 7, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.854 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.773 sec, Thread: 6, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.207 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
353.308 sec, 

[jira] [Updated] (ZOOKEEPER-3000) Use error-prone compiler

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-3000:

Fix Version/s: 3.6.0
   3.5.4

> Use error-prone compiler
> 
>
> Key: ZOOKEEPER-3000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Roman Leventov
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> See http://errorprone.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3000) Use error-prone compiler

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-3000:

Affects Version/s: 3.6.0
   3.5.4

> Use error-prone compiler
> 
>
> Key: ZOOKEEPER-3000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Roman Leventov
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> See http://errorprone.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 3811 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3811/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 143.60 KB...]
[junit] Running org.apache.zookeeper.test.StatTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
27.891 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.38 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.058 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.332 sec, Thread: 3, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.501 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
27.811 sec, Thread: 1, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.162 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 1
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.944 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
40.683 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.166 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
379.461 sec, Thread: 4, Class: 
org.apache.zookeeper.test.ObserverQuorumHammerTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 4
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.186 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.312 sec, Thread: 4, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
382.21 sec, Thread: 6, Class: org.apache.zookeeper.test.QuorumHammerTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
37.414 sec, Thread: 1, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
194.274 sec, Thread: 8, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 13, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
341.075 sec, Thread: 7, Class: org.apache.zookeeper.test.ReconfigTest
[junit] Test org.apache.zookeeper.test.ReconfigTest FAILED
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
690.069 sec, Thread: 5, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
871.909 sec, Thread: 2, Class: org.apache.zookeeper.test.DisconnectedWatcherTest

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk@2/build.xml:1395: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk@2/build.xml:1276: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk@2/build.xml:1280: Tests 
failed!

Total time: 19 minutes 43 seconds
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording fingerprints
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
JIRA: Update relevant issues is waiting for a checkpoint on ZooKeeper-trunk 
#3810
Recording test results
Setting 

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449043#comment-16449043
 ] 

Hudson commented on ZOOKEEPER-2994:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3810 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3810/])
ZOOKEEPER-2994: Tool required to recover log and snapshot entries with (phunt: 
rev 154f9c536f7c696b774361937c6b4b08603d16cf)
* (add) bin/zkTxnLogToolkit.cmd
* (edit) src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
* (add) src/java/main/org/apache/zookeeper/server/persistence/FilePadding.java
* (add) src/java/main/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
* (edit) src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
* (edit) docs/zookeeperAdmin.pdf
* (edit) 
src/java/test/org/apache/zookeeper/server/persistence/FileTxnLogTest.java
* (add) 
src/java/test/org/apache/zookeeper/server/persistence/TxnLogToolkitTest.java
* (add) bin/zkTxnLogToolkit.sh
* (edit) docs/zookeeperAdmin.html
* (edit) src/java/test/org/apache/zookeeper/test/ClientBase.java
* (add) src/java/test/data/invalidsnap/version-2/log.42


> Tool required to recover log and snapshot entries with CRC errors
> -
>
> Key: ZOOKEEPER-2994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2994
> Project: ZooKeeper
>  Issue Type: New Feature
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> In the even that the zookeeper transaction log or snapshot become corrupted 
> and fail CRC checks (preventing startup) we should have a mechanism to get 
> the cluster running again.
> Previously we achieved this by loading the broken transaction log with a 
> modified version of ZK with disabled CRC check and forced it to snapshot.
> It'd very handy to have a tool which can do this for us. LogFormatter and 
> SnapshotFormatter have already been designed to dump log and snapshot files, 
> it'd be nice to extend their functionality and add ability for such recovery.
> It has proven that once you end up with the corrupt txn log there is no way 
> to recover except manually modifying the crc check. That's basically why the 
> tool is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Andrew Schwartzmeyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449039#comment-16449039
 ] 

Andrew Schwartzmeyer commented on ZOOKEEPER-3025:
-

Ah, my bad. Turns out to be caused by 
[https://github.com/apache/zookeeper/pull/486/commits/b030f29c02bd87f10c0ac995f4c8abf85eb7bf9b]

We'd tested on Linux, but not Windows, which has an extra include file. Writing 
a patch currently.

> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449033#comment-16449033
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2940:
---

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/466#discussion_r183565978
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1897,6 +1896,12 @@ server.3=zoo3:2888:3888
   zk_pending_syncs0   - only exposed by the 
Leader
   zk_open_file_descriptor_count 23- only available on Unix 
platforms
   zk_max_file_descriptor_count 1024   - only available on Unix 
platforms
+  zk_last_proposal_size
--- End diff --

these are missing example values


> Deal with maxbuffer as it relates to large requests from clients
> 
>
> Key: ZOOKEEPER-2940
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> Monitor real-time Jute buffer usage as it relates to large requests from 
> clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449031#comment-16449031
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2940:
---

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/466#discussion_r183565848
  
--- Diff: src/contrib/monitoring/ganglia/zookeeper_ganglia.py ---
@@ -213,7 +213,13 @@ def metric_init(params=None):
 'zk_max_file_descriptor_count': {'units': 'descriptors'},
 'zk_followers': {'units': 'nodes'},
 'zk_synced_followers': {'units': 'nodes'},
-'zk_pending_syncs': {'units': 'syncs'}
+'zk_pending_syncs': {'units': 'syncs'},
+'zk_last_proposal_size': {'units': 'ms'},
--- End diff --

Should these values be in "ms"? Seems like a cut/paste typo? I suspect you 
rather "bytes" - right?


> Deal with maxbuffer as it relates to large requests from clients
> 
>
> Key: ZOOKEEPER-2940
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> Monitor real-time Jute buffer usage as it relates to large requests from 
> clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

[phunt]

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/466#discussion_r183565978
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1897,6 +1896,12 @@ server.3=zoo3:2888:3888
   zk_pending_syncs0   - only exposed by the 
Leader
   zk_open_file_descriptor_count 23- only available on Unix 
platforms
   zk_max_file_descriptor_count 1024   - only available on Unix 
platforms
+  zk_last_proposal_size
--- End diff --

these are missing example values


---

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

[phunt]

Github user phunt commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/466#discussion_r183565848
  
--- Diff: src/contrib/monitoring/ganglia/zookeeper_ganglia.py ---
@@ -213,7 +213,13 @@ def metric_init(params=None):
 'zk_max_file_descriptor_count': {'units': 'descriptors'},
 'zk_followers': {'units': 'nodes'},
 'zk_synced_followers': {'units': 'nodes'},
-'zk_pending_syncs': {'units': 'syncs'}
+'zk_pending_syncs': {'units': 'syncs'},
+'zk_last_proposal_size': {'units': 'ms'},
--- End diff --

Should these values be in "ms"? Seems like a cut/paste typo? I suspect you 
rather "bytes" - right?


---

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449020#comment-16449020
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2940:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/466
  
is this intended for 3.4 or just 3.5+ ? The jira says 3.5+, is that right?


> Deal with maxbuffer as it relates to large requests from clients
> 
>
> Key: ZOOKEEPER-2940
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> Monitor real-time Jute buffer usage as it relates to large requests from 
> clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/466
  
is this intended for 3.4 or just 3.5+ ? The jira says 3.5+, is that right?


---

Move github discussions from JIRA comments to the JIRA worklog?

[Patrick Hunt]

Hey devs, I noticed this recently filed by the Apache Arrow team:

"Change GitHub Bot to post to Work Log instead of Comments"
https://issues.apache.org/jira/browse/INFRA-16426

which really resonates with me - I'm finding that the JIRA comments are
being lost amongst the github updates related to PRs occurring there
(github reviews).

Any objections to doing similar for ZK? We'd still capture the gh comments
in JIRA, but under the worklog tab rather than in the comments. I think
this would be alot more sane.

If you have any objections please speak up in the next few (3) days, otw
I'll open a similar JIRA for us.

Regards,

Patrick

[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449004#comment-16449004
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2979:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/440
  
@anmolnar I believe you misunderstood my comment above:

> likely this change will go into master (3.6.0+) - impact on backports. 
I'm assuming we would want to take advantage of this library across the board. 
(can we do that? I assume yes?)

> Sure, I'll have to backport it to branch-3.4, it will need some manual 
work for sure, but I don't expect it to be the end of the world.

I meant that I was planning to only commit this change for 3.6.0+ - I am 
generally reticent to add a new dependency so late in the 3.5 train. Do you 
feel strongly otw?


> Use dropwizard library histogram for proposal-related metrics
> -
>
> Key: ZOOKEEPER-2979
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2979
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>
> This Jira in intended to be the successor of ZOOKEEPER-2939.
> By using dropwizard library's Histogram component we'll be able to provide 
> more sophisticated statistics on Proposal sizes.
> From the docs:
> "A histogram measures the statistical distribution of values in a stream of 
> data. In addition to minimum, maximum, mean, etc., it also measures median, 
> 75th, 90th, 95th, 98th, 99th, and 99.9th percentiles."
> [http://metrics.dropwizard.io/3.1.0/manual/core/#histograms]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #440: ZOOKEEPER-2979 Use dropwizard library histogram for pr...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/440
  
@anmolnar I believe you misunderstood my comment above:

> likely this change will go into master (3.6.0+) - impact on backports. 
I'm assuming we would want to take advantage of this library across the board. 
(can we do that? I assume yes?)

> Sure, I'll have to backport it to branch-3.4, it will need some manual 
work for sure, but I don't expect it to be the end of the world.

I meant that I was planning to only commit this change for 3.6.0+ - I am 
generally reticent to add a new dependency so late in the 3.5 train. Do you 
feel strongly otw?


---

ZooKeeper-trunk-windows-cmake - Build # 2727 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2727/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 18.50 KB...]
  Creating "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.
CustomBuild:
  Checking Build System
  CMake does not need to re-run because 
F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/src/c/CMakeFiles/generate.stamp
 is up-to-date.
FinalizeBuildStatus:
  Deleting file "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".
  Touching "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate".
Done Building Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\ZERO_CHECK.vcxproj"
 (default targets).
The target "_ConvertPdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,37)" does not exist in the project, and will be ignored.
The target "_CollectPdbFiles" listed in an AfterTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,70)" does not exist in the project, and will be ignored.
The target "_CollectMdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,38)" does not exist in the project, and will be ignored.
The target "_CopyMdbFiles" listed in an AfterTargets attribute at "C:\Program 
Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,71)" does not exist in the project, and will be ignored.
The target "_ConvertPdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,37)" does not exist in the project, and will be ignored.
The target "_CollectPdbFiles" listed in an AfterTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,70)" does not exist in the project, and will be ignored.
The target "_CollectMdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,38)" does not exist in the project, and will be ignored.
The target "_CopyMdbFiles" listed in an AfterTargets attribute at "C:\Program 
Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,71)" does not exist in the project, and will be ignored.
Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\ALL_BUILD.vcxproj"
 (1) is building 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\cli.vcxproj"
 (3) on node 1 (default targets).
Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\cli.vcxproj"
 (3) is building 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj"
 (4) on node 1 (default targets).
PrepareForBuild:
  Creating directory "hashtable.dir\Debug\".
  Creating directory "hashtable.dir\Debug\hashtable.tlog\".
InitializeBuildStatus:
  Creating "hashtable.dir\Debug\hashtable.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.
CustomBuild:
  Building Custom Rule 
F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/src/c/CMakeLists.txt
  CMake does not need to re-run because 
F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\CMakeFiles\generate.stamp
 is up-to-date.
ClCompile:
  F:\Microsoft\Visual Studio CE 2015\VC\bin\CL.exe /c /Zi /nologo /W3 /WX- /Od 
/Ob0 /Oy- /D WIN32 /D _WINDOWS /D _DEBUG /D USE_STATIC_LIB /D THREADED /D 
"CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /RTC1 /MDd /GS /fp:precise /Zc:wchar_t 
/Zc:forScope /Zc:inline /Fo"hashtable.dir\Debug\\" 
/Fd"hashtable.dir\Debug\hashtable.pdb" /Gd /TC /analyze- /errorReport:queue 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable_itr.c"
 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.c"
  hashtable_itr.c
f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
 fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
directory 
[F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
  hashtable.c
f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
 fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
directory 
[F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
  Generating Code...
Done Building Project 

[jira] [Commented] (ZOOKEEPER-2982) Re-try DNS hostname -> IP resolution

[Eron Wright (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448996#comment-16448996
 ] 

Eron Wright  commented on ZOOKEEPER-2982:
-

[~fpj] would you please assign this issue to someone and clarify what your 
expectations are? 

> Re-try DNS hostname -> IP resolution
> 
>
> Key: ZOOKEEPER-2982
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2982
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0, 3.5.1, 3.5.3
>Reporter: Eron Wright 
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
> Attachments: 3.5.3-beta.zip, fixed.log
>
>
> ZOOKEEPER-1506 fixed a DNS resolution issue in 3.4.  Some portions of the fix 
> haven't yet been ported to 3.5.
> To recap the outstanding problem in 3.5, if a given ZK server is started 
> before all peer addresses are resolvable, that server may cache a negative 
> lookup result and forever fail to resolve the address.For example, 
> deploying ZK 3.5 to Kubernetes using a StatefulSet plus a Service (headless) 
> may fail because the DNS records are created lazily.
> {code}
> 2018-02-18 09:11:22,583 [myid:0] - WARN  
> [QuorumPeer[myid=0](plain=/0:0:0:0:0:0:0:0:2181)(secure=disabled):Follower@95]
>  - Exception when following the leader
> java.net.UnknownHostException: zk-2.zk.default.svc.cluster.local
> at 
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184)
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> at java.net.Socket.connect(Socket.java:589)
> at 
> org.apache.zookeeper.server.quorum.Learner.sockConnect(Learner.java:227)
> at 
> org.apache.zookeeper.server.quorum.Learner.connectToLeader(Learner.java:256)
> at 
> org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:76)
> at 
> org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1133)
> {code}
> In the above example, the address `zk-2.zk.default.svc.cluster.local` was not 
> resolvable when the server started, but became resolvable shortly thereafter. 
>The server should eventually succeed but doesn't.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2415) SessionTest is using Thread deprecated API.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448991#comment-16448991
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2415:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/497
  
+1. Looks reasonable however:

1) this problem also exists in 
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java - do you want to 
fix it as part of this change or handle as a separate jira? (either way is fine 
with me - separate might make it simpler to review/commit and make progress 
tbh, but up to you)

2) regardless 1) above, this doesn't apply to branch-3.4 - the original 
jira says it affects 3.4, I'm assuming we want to fix there as well? Could you 
create a separate PR for this? I'd like to commit both at the same time.


> SessionTest is using Thread deprecated API.
> ---
>
> Key: ZOOKEEPER-2415
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2415
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.4.8, 3.5.1, 3.6.0
>Reporter: Flavio Junqueira
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> The test class is using calls such as {{Thread.suspend}} and 
> {{Thread.resume}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-2415) SessionTest is using Thread deprecated API.

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2415:

Fix Version/s: 3.4.13
   3.6.0
   3.5.4

> SessionTest is using Thread deprecated API.
> ---
>
> Key: ZOOKEEPER-2415
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2415
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.4.8, 3.5.1, 3.6.0
>Reporter: Flavio Junqueira
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> The test class is using calls such as {{Thread.suspend}} and 
> {{Thread.resume}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #497: ZOOKEEPER-2415. SessionTest is using Thread deprecated...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/497
  
+1. Looks reasonable however:

1) this problem also exists in 
src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java - do you want to 
fix it as part of this change or handle as a separate jira? (either way is fine 
with me - separate might make it simpler to review/commit and make progress 
tbh, but up to you)

2) regardless 1) above, this doesn't apply to branch-3.4 - the original 
jira says it affects 3.4, I'm assuming we want to fix there as well? Could you 
create a separate PR for this? I'd like to commit both at the same time.


---

[jira] [Updated] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2994:

Affects Version/s: 3.6.0
   3.5.4

> Tool required to recover log and snapshot entries with CRC errors
> -
>
> Key: ZOOKEEPER-2994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2994
> Project: ZooKeeper
>  Issue Type: New Feature
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> In the even that the zookeeper transaction log or snapshot become corrupted 
> and fail CRC checks (preventing startup) we should have a mechanism to get 
> the cluster running again.
> Previously we achieved this by loading the broken transaction log with a 
> modified version of ZK with disabled CRC check and forced it to snapshot.
> It'd very handy to have a tool which can do this for us. LogFormatter and 
> SnapshotFormatter have already been designed to dump log and snapshot files, 
> it'd be nice to extend their functionality and add ability for such recovery.
> It has proven that once you end up with the corrupt txn log there is no way 
> to recover except manually modifying the crc check. That's basically why the 
> tool is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448975#comment-16448975
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2994:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/487
  
+1 Thanks @anmolnar this looks good. Please consider backporting to 3.4 
(separate jira).

Also in future please don't include any changed files from the toplevel 
docs directory (html/pdf files) as these are regenerated during commit.


> Tool required to recover log and snapshot entries with CRC errors
> -
>
> Key: ZOOKEEPER-2994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2994
> Project: ZooKeeper
>  Issue Type: New Feature
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> In the even that the zookeeper transaction log or snapshot become corrupted 
> and fail CRC checks (preventing startup) we should have a mechanism to get 
> the cluster running again.
> Previously we achieved this by loading the broken transaction log with a 
> modified version of ZK with disabled CRC check and forced it to snapshot.
> It'd very handy to have a tool which can do this for us. LogFormatter and 
> SnapshotFormatter have already been designed to dump log and snapshot files, 
> it'd be nice to extend their functionality and add ability for such recovery.
> It has proven that once you end up with the corrupt txn log there is no way 
> to recover except manually modifying the crc check. That's basically why the 
> tool is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #487: ZOOKEEPER-2994 Tool required to recover log and snapsh...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/487
  
+1 Thanks @anmolnar this looks good. Please consider backporting to 3.4 
(separate jira).

Also in future please don't include any changed files from the toplevel 
docs directory (html/pdf files) as these are regenerated during commit.


---

[jira] [Resolved] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2994.
-
   Resolution: Fixed
Fix Version/s: (was: 3.4.13)

Issue resolved by pull request 487
[https://github.com/apache/zookeeper/pull/487]

> Tool required to recover log and snapshot entries with CRC errors
> -
>
> Key: ZOOKEEPER-2994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2994
> Project: ZooKeeper
>  Issue Type: New Feature
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.6.0, 3.5.4
>
>
> In the even that the zookeeper transaction log or snapshot become corrupted 
> and fail CRC checks (preventing startup) we should have a mechanism to get 
> the cluster running again.
> Previously we achieved this by loading the broken transaction log with a 
> modified version of ZK with disabled CRC check and forced it to snapshot.
> It'd very handy to have a tool which can do this for us. LogFormatter and 
> SnapshotFormatter have already been designed to dump log and snapshot files, 
> it'd be nice to extend their functionality and add ability for such recovery.
> It has proven that once you end up with the corrupt txn log there is no way 
> to recover except manually modifying the crc check. That's basically why the 
> tool is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448961#comment-16448961
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2994:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/487


> Tool required to recover log and snapshot entries with CRC errors
> -
>
> Key: ZOOKEEPER-2994
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2994
> Project: ZooKeeper
>  Issue Type: New Feature
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> In the even that the zookeeper transaction log or snapshot become corrupted 
> and fail CRC checks (preventing startup) we should have a mechanism to get 
> the cluster running again.
> Previously we achieved this by loading the broken transaction log with a 
> modified version of ZK with disabled CRC check and forced it to snapshot.
> It'd very handy to have a tool which can do this for us. LogFormatter and 
> SnapshotFormatter have already been designed to dump log and snapshot files, 
> it'd be nice to extend their functionality and add ability for such recovery.
> It has proven that once you end up with the corrupt txn log there is no way 
> to recover except manually modifying the crc check. That's basically why the 
> tool is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #487: ZOOKEEPER-2994 Tool required to recover log and...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/487


---

[jira] [Assigned] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-3025:
---

Assignee: Michael Han

[~hanm] - could you take a look at this issue? Seems to be related to recent 
commit.

Also note original authors: [~andschwa] and [~dforsyth] may have insight?

> cmake windows build is broken on jenkins
> 
>
> Key: ZOOKEEPER-3025
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Patrick Hunt
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
>
> Jenkins build for windows cmake is failing:
> started here:
> [https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
> {noformat}
> f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
>  fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
> directory 
> [F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
>   hashtable.c{noformat}
>  
> Looks like one or the other or both of these commits are at issue (jenkins 
> build broken on these two changes being committed)
> h2. [#2717 (Apr 16, 2018 4:58:17 
> AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
>  # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
>  # ZOOKEEPER-2999: CMake build should use target-level commands — 
> [hanm|https://builds.apache.org/user/hanm/] / 
> [detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

[Patrick Hunt (JIRA)]

Patrick Hunt created ZOOKEEPER-3025:
---

 Summary: cmake windows build is broken on jenkins
 Key: ZOOKEEPER-3025
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025
 Project: ZooKeeper
  Issue Type: Bug
  Components: build
Affects Versions: 3.5.4, 3.6.0
Reporter: Patrick Hunt
 Fix For: 3.5.4, 3.6.0


Jenkins build for windows cmake is failing:

started here:

[https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/console]
{noformat}
f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
 fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
directory 
[F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
  hashtable.c{noformat}
 

Looks like one or the other or both of these commits are at issue (jenkins 
build broken on these two changes being committed)
h2. [#2717 (Apr 16, 2018 4:58:17 
AM)|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes]
 # ZOOKEEPER-3017: Link libm in CMake on FreeBSD. — 
[hanm|https://builds.apache.org/user/hanm/] / 
[detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#67378512285c4b8dc9be50b90bbd2967068fc24e]
 # ZOOKEEPER-2999: CMake build should use target-level commands — 
[hanm|https://builds.apache.org/user/hanm/] / 
[detail|https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-windows-cmake/2717/changes#9ba4aeb4f92c1fc3167ff8e2b56e02f3e344d3ba]

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk-windows-cmake - Build # 2726 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2726/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 18.44 KB...]
  Creating "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.
CustomBuild:
  Checking Build System
  CMake does not need to re-run because 
F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/src/c/CMakeFiles/generate.stamp
 is up-to-date.
FinalizeBuildStatus:
  Deleting file "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".
  Touching "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate".
Done Building Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\ZERO_CHECK.vcxproj"
 (default targets).
The target "_ConvertPdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,37)" does not exist in the project, and will be ignored.
The target "_CollectPdbFiles" listed in an AfterTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,70)" does not exist in the project, and will be ignored.
The target "_CollectMdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,38)" does not exist in the project, and will be ignored.
The target "_CopyMdbFiles" listed in an AfterTargets attribute at "C:\Program 
Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,71)" does not exist in the project, and will be ignored.
The target "_ConvertPdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,37)" does not exist in the project, and will be ignored.
The target "_CollectPdbFiles" listed in an AfterTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,70)" does not exist in the project, and will be ignored.
The target "_CollectMdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,38)" does not exist in the project, and will be ignored.
The target "_CopyMdbFiles" listed in an AfterTargets attribute at "C:\Program 
Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,71)" does not exist in the project, and will be ignored.
Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\ALL_BUILD.vcxproj"
 (1) is building 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\cli.vcxproj"
 (3) on node 1 (default targets).
Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\cli.vcxproj"
 (3) is building 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj"
 (4) on node 1 (default targets).
PrepareForBuild:
  Creating directory "hashtable.dir\Debug\".
  Creating directory "hashtable.dir\Debug\hashtable.tlog\".
InitializeBuildStatus:
  Creating "hashtable.dir\Debug\hashtable.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.
CustomBuild:
  Building Custom Rule 
F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/src/c/CMakeLists.txt
  CMake does not need to re-run because 
F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\CMakeFiles\generate.stamp
 is up-to-date.
ClCompile:
  F:\Microsoft\Visual Studio CE 2015\VC\bin\CL.exe /c /Zi /nologo /W3 /WX- /Od 
/Ob0 /Oy- /D WIN32 /D _WINDOWS /D _DEBUG /D USE_STATIC_LIB /D THREADED /D 
"CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /RTC1 /MDd /GS /fp:precise /Zc:wchar_t 
/Zc:forScope /Zc:inline /Fo"hashtable.dir\Debug\\" 
/Fd"hashtable.dir\Debug\hashtable.pdb" /Gd /TC /analyze- /errorReport:queue 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable_itr.c"
 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.c"
  hashtable_itr.c
f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
 fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
directory 
[F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
  hashtable.c
f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
 fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
directory 
[F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
  Generating Code...
Done Building Project 

Apache ZooKeeper meetup May 9th in Palo Alto?

[Patrick Hunt]

Hi folks. I am interested in hosting a ZooKeeper meetup May 9th in
Cloudera's Palo Alto offices. It's been a while since we last got together,
lots of recent changes and some big plans, new additions to the PMC and
committer lists, new contributors.

I was hoping to use the mailing lists to gauge interest. Please reply if you
think you would be able to attend or would prefer a different date. Also
let me know if there's something you would like to present to the group. Food
and beer will be provided.

Looking forward to hearing from everyone.

Regards,

Patrick

Re: [VOTE] Migrate ZK to Maven build

[Karan Mehta]

+1 (non binding)

Thanks
Karan Mehta

On Mon, Apr 23, 2018 at 4:06 AM Jordan Zimmerman 
wrote:

> +1 (non binding)
>
> > On Apr 23, 2018, at 6:21 PM, Mohammad arshad 
> wrote:
> >
> > +1
> >
> > -Original Message-
> > From: Andor Molnar [mailto:an...@cloudera.com]
> > Sent: Monday, April 23, 2018 4:43 PM
> > To: dev@zookeeper.apache.org
> > Subject: Re: [VOTE] Migrate ZK to Maven build
> >
> > +1 (non-binding)
> >
> > On Mon, Apr 23, 2018 at 10:30 AM, Tamas Penzes 
> wrote:
> >
> >> +1 (non-binding)
> >>
> >> On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar 
> >> wrote:
> >>
> >>> Hi,
> >>>
> >>> Let's start a vote on migrating to maven instead of ant.
> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> >>>
> >>> *Shall we migrate ZooKeeper build from ant to Maven?*
> >>>
> >>> Please reply with [Yes / +1] or [No / -1] to this thread.
> >>>
> >>> Thanks,
> >>> Norbert
> >>>
> >>
> >>
> >>
> >> --
> >> *Tamás Pénzes* | Engineering Manager
> >> e. tam...@cloudera.com
> >> cloudera.com 
> >>
> >> [image: Cloudera] 
> >>
> >> [image: Cloudera on Twitter]  [image:
> >> Cloudera on Facebook]  [image:
> >> Cloudera on LinkedIn] 
> >> --
> >>
>
>

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448310#comment-16448310
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183433194
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -250,30 +267,36 @@ public void processRequest(Request request) {
 lastOp = "CREA";
 rsp = new Create2Response(rc.path, rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_CREATE, 
rc.path, null, err);
 break;
 }
 case OpCode.delete:
 case OpCode.deleteContainer: {
 lastOp = "DELE";
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_DELETE, 
rc.path, null, err);
 break;
 }
 case OpCode.setData: {
 lastOp = "SETD";
 rsp = new SetDataResponse(rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_SETDATA, 
rc.path, null, err);
 break;
 }
 case OpCode.reconfig: {
 lastOp = "RECO";
 rsp = new 
GetDataResponse(((QuorumZooKeeperServer)zks).self.getQuorumVerifier().toString().getBytes(),
 rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_RECONFIG, 
rc.path, null, err);
 break;
 }
 case OpCode.setACL: {
 lastOp = "SETA";
 rsp = new SetACLResponse(rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_SETACL, 
rc.path, getACLs(request),
--- End diff --

I believe this approach has some performance impact even if audit logging 
is disabled. The flag gets checked within the method, therefore `getACLs()` 
will be evaluated even if there's no need for the result.
Passing only `request` and calling `getACLs()` from `addAuditLog()` would 
be slightly faster.  


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448311#comment-16448311
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183435384
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request request) {
 }
 }
 
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addSuccessAudit(request, cnxn, op, path, null);
+}
+
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addFailureAudit(request, cnxn, op, path, null);
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addAuditLog(Request request, ServerCnxn cnxn, String op, 
String path, String acl,
+Code err) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+if (err == Code.OK) {
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+} else {
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+}
+
+private String getACLs(Request request)
+{
+ByteBuffer reqData = request.request.duplicate();
+reqData.rewind();
+SetACLRequest setACLRequest = new SetACLRequest();
+try {
+ByteBufferInputStream.byteBuffer2Record(reqData, 
setACLRequest);
+} catch (IOException e) {
+e.printStackTrace();
+}
+return ZKUtil.aclToString(setACLRequest.getAcl());
+}
+
+private void addFailedTxnAduitLog(Request request) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+String op = AuditConstants.OP_CREATE;
+String path=null;
+long sessionId = -1;
+String address = null;
+String acls = null;
+ByteBuffer reqData = request.request.duplicate();
+reqData.rewind();
+try {
+sessionId = request.cnxn.getSessionId();
+switch (request.type) {
+case OpCode.create:
+case  OpCode.create2:
+case  OpCode.createContainer:
+op = AuditConstants.OP_CREATE;
+CreateRequest createRequest = new CreateRequest();
+ByteBufferInputStream.byteBuffer2Record(reqData, 
createRequest);
+path=createRequest.getPath();
+break;
+case OpCode.delete:
+case OpCode.deleteContainer:
+op = AuditConstants.OP_DELETE;
+//path = new String(request.request.array());
--- End diff --

Please the commented line.


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448308#comment-16448308
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183432327
  
--- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.audit;
+
+import org.apache.zookeeper.server.ServerCnxnFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ZKAuditLogger {
+public static final String SYSPROP_AUDIT_ENABLED = 
"zookeeper.audit.enabled";
+private static final Logger LOG = 
LoggerFactory.getLogger(ZKAuditLogger.class);
+// By default audit logging is disabled
+public static final boolean isAuditEnabled = 
Boolean.getBoolean(SYSPROP_AUDIT_ENABLED);
+
+/**
+ *
+ * Prints audit log based on log level specified
+ *
+ */
+public static enum LogLevel {
+ERROR {
+@Override
+public void printLog(String logMsg) {
+LOG.error(logMsg);
+}
+},
+INFO {
+@Override
+public void printLog(String logMsg) {
+LOG.info(logMsg);
+}
+};
+public abstract void printLog(String logMsg);
+}
+
+public static enum Keys {
+USER, OPERATION, RESULT, IP, ACL, ZNODE, SESSION;
+}
+
+public static void logInvoked(String user, String operation) {
+log(LogLevel.INFO, user, operation, AuditConstants.INVOKED);
+}
+
+public static void logSuccess(String user, String operation) {
+log(LogLevel.INFO, user, operation, AuditConstants.SUCCESS);
+}
+
+public static void logFailure(String user, String operation) {
+log(LogLevel.ERROR, user, operation, AuditConstants.FAILURE);
+}
+
+private static void log(LogLevel level, String user, String operation, 
String logType) {
+level.printLog(createLog(user, operation, null, null, null, null, 
logType));
+}
+
+public static void logSuccess(String user, String operation, String 
znode, String acl, String session, String ip) {
+LogLevel.INFO.printLog(createLog(user, operation, znode, acl, 
session, ip, AuditConstants.SUCCESS));
+}
+
+public static void logFailure(String user, String operation, String 
znode, String acl, String session, String ip) {
+LogLevel.ERROR.printLog(createLog(user, operation, znode, acl, 
session, ip, AuditConstants.FAILURE));
+}
+
+/**
+ * A helper api for creating an audit log string.
+ */
+public static String createLog(String user, String operation, String 
znode, String acl, String session, String ip,
+String status) {
+ZKAuditLogFormatter fmt = new ZKAuditLogFormatter();
--- End diff --

If I got it right, this is the only place where you use 
`ZKAuditLogFormatter`. Why don't you just use `String.format()` instead of a 
custom formatter?


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop 

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448309#comment-16448309
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183434909
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request request) {
 }
 }
 
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addSuccessAudit(request, cnxn, op, path, null);
+}
+
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addFailureAudit(request, cnxn, op, path, null);
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addAuditLog(Request request, ServerCnxn cnxn, String op, 
String path, String acl,
+Code err) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+if (err == Code.OK) {
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+} else {
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+}
+
+private String getACLs(Request request)
+{
+ByteBuffer reqData = request.request.duplicate();
+reqData.rewind();
+SetACLRequest setACLRequest = new SetACLRequest();
+try {
+ByteBufferInputStream.byteBuffer2Record(reqData, 
setACLRequest);
+} catch (IOException e) {
+e.printStackTrace();
+}
+return ZKUtil.aclToString(setACLRequest.getAcl());
+}
+
+private void addFailedTxnAduitLog(Request request) {
--- End diff --

Typo here


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448307#comment-16448307
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183430034
  
--- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java ---
@@ -168,4 +169,41 @@ private static void visitSubTreeDFSHelper(ZooKeeper 
zk, final String path,
 return; // ignore
 }
 }
+
+/**
+ * @param perms
+ *ACL permissions
+ * @return string representation of permissions
+ */
+public static String getPermString(int perms) {
--- End diff --

Have you considered caching these values in some way?
I see 2 options to make this faster:
1. dynamic caching of already generated values,
2. static caching of all possible values in a static hashmap (32 possible 
values if I'm not mistaken)


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183435384
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request request) {
 }
 }
 
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addSuccessAudit(request, cnxn, op, path, null);
+}
+
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addFailureAudit(request, cnxn, op, path, null);
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addAuditLog(Request request, ServerCnxn cnxn, String op, 
String path, String acl,
+Code err) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+if (err == Code.OK) {
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+} else {
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+}
+
+private String getACLs(Request request)
+{
+ByteBuffer reqData = request.request.duplicate();
+reqData.rewind();
+SetACLRequest setACLRequest = new SetACLRequest();
+try {
+ByteBufferInputStream.byteBuffer2Record(reqData, 
setACLRequest);
+} catch (IOException e) {
+e.printStackTrace();
+}
+return ZKUtil.aclToString(setACLRequest.getAcl());
+}
+
+private void addFailedTxnAduitLog(Request request) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+String op = AuditConstants.OP_CREATE;
+String path=null;
+long sessionId = -1;
+String address = null;
+String acls = null;
+ByteBuffer reqData = request.request.duplicate();
+reqData.rewind();
+try {
+sessionId = request.cnxn.getSessionId();
+switch (request.type) {
+case OpCode.create:
+case  OpCode.create2:
+case  OpCode.createContainer:
+op = AuditConstants.OP_CREATE;
+CreateRequest createRequest = new CreateRequest();
+ByteBufferInputStream.byteBuffer2Record(reqData, 
createRequest);
+path=createRequest.getPath();
+break;
+case OpCode.delete:
+case OpCode.deleteContainer:
+op = AuditConstants.OP_DELETE;
+//path = new String(request.request.array());
--- End diff --

Please the commented line.


---

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183433194
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -250,30 +267,36 @@ public void processRequest(Request request) {
 lastOp = "CREA";
 rsp = new Create2Response(rc.path, rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_CREATE, 
rc.path, null, err);
 break;
 }
 case OpCode.delete:
 case OpCode.deleteContainer: {
 lastOp = "DELE";
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_DELETE, 
rc.path, null, err);
 break;
 }
 case OpCode.setData: {
 lastOp = "SETD";
 rsp = new SetDataResponse(rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_SETDATA, 
rc.path, null, err);
 break;
 }
 case OpCode.reconfig: {
 lastOp = "RECO";
 rsp = new 
GetDataResponse(((QuorumZooKeeperServer)zks).self.getQuorumVerifier().toString().getBytes(),
 rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_RECONFIG, 
rc.path, null, err);
 break;
 }
 case OpCode.setACL: {
 lastOp = "SETA";
 rsp = new SetACLResponse(rc.stat);
 err = Code.get(rc.err);
+addAuditLog(request, cnxn, AuditConstants.OP_SETACL, 
rc.path, getACLs(request),
--- End diff --

I believe this approach has some performance impact even if audit logging 
is disabled. The flag gets checked within the method, therefore `getACLs()` 
will be evaluated even if there's no need for the result.
Passing only `request` and calling `getACLs()` from `addAuditLog()` would 
be slightly faster.  


---

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183434909
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -465,6 +488,127 @@ public void processRequest(Request request) {
 }
 }
 
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addSuccessAudit(request, cnxn, op, path, null);
+}
+
+private void addSuccessAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path) {
+addFailureAudit(request, cnxn, op, path, null);
+}
+
+private void addFailureAudit(Request request, ServerCnxn cnxn, String 
op, String path,
+String acl) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+
+private void addAuditLog(Request request, ServerCnxn cnxn, String op, 
String path, String acl,
+Code err) {
+if (!ZKAuditLogger.isAuditEnabled) {
+return;
+}
+if (err == Code.OK) {
+ZKAuditLogger.logSuccess(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+} else {
+ZKAuditLogger.logFailure(request.getUsers(), op, path, acl, 
cnxn.getSessionIdHex(),
+cnxn.getHostAddress());
+}
+}
+
+private String getACLs(Request request)
+{
+ByteBuffer reqData = request.request.duplicate();
+reqData.rewind();
+SetACLRequest setACLRequest = new SetACLRequest();
+try {
+ByteBufferInputStream.byteBuffer2Record(reqData, 
setACLRequest);
+} catch (IOException e) {
+e.printStackTrace();
+}
+return ZKUtil.aclToString(setACLRequest.getAcl());
+}
+
+private void addFailedTxnAduitLog(Request request) {
--- End diff --

Typo here


---

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183432327
  
--- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.audit;
+
+import org.apache.zookeeper.server.ServerCnxnFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ZKAuditLogger {
+public static final String SYSPROP_AUDIT_ENABLED = 
"zookeeper.audit.enabled";
+private static final Logger LOG = 
LoggerFactory.getLogger(ZKAuditLogger.class);
+// By default audit logging is disabled
+public static final boolean isAuditEnabled = 
Boolean.getBoolean(SYSPROP_AUDIT_ENABLED);
+
+/**
+ *
+ * Prints audit log based on log level specified
+ *
+ */
+public static enum LogLevel {
+ERROR {
+@Override
+public void printLog(String logMsg) {
+LOG.error(logMsg);
+}
+},
+INFO {
+@Override
+public void printLog(String logMsg) {
+LOG.info(logMsg);
+}
+};
+public abstract void printLog(String logMsg);
+}
+
+public static enum Keys {
+USER, OPERATION, RESULT, IP, ACL, ZNODE, SESSION;
+}
+
+public static void logInvoked(String user, String operation) {
+log(LogLevel.INFO, user, operation, AuditConstants.INVOKED);
+}
+
+public static void logSuccess(String user, String operation) {
+log(LogLevel.INFO, user, operation, AuditConstants.SUCCESS);
+}
+
+public static void logFailure(String user, String operation) {
+log(LogLevel.ERROR, user, operation, AuditConstants.FAILURE);
+}
+
+private static void log(LogLevel level, String user, String operation, 
String logType) {
+level.printLog(createLog(user, operation, null, null, null, null, 
logType));
+}
+
+public static void logSuccess(String user, String operation, String 
znode, String acl, String session, String ip) {
+LogLevel.INFO.printLog(createLog(user, operation, znode, acl, 
session, ip, AuditConstants.SUCCESS));
+}
+
+public static void logFailure(String user, String operation, String 
znode, String acl, String session, String ip) {
+LogLevel.ERROR.printLog(createLog(user, operation, znode, acl, 
session, ip, AuditConstants.FAILURE));
+}
+
+/**
+ * A helper api for creating an audit log string.
+ */
+public static String createLog(String user, String operation, String 
znode, String acl, String session, String ip,
+String status) {
+ZKAuditLogFormatter fmt = new ZKAuditLogFormatter();
--- End diff --

If I got it right, this is the only place where you use 
`ZKAuditLogFormatter`. Why don't you just use `String.format()` instead of a 
custom formatter?


---

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r183430034
  
--- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java ---
@@ -168,4 +169,41 @@ private static void visitSubTreeDFSHelper(ZooKeeper 
zk, final String path,
 return; // ignore
 }
 }
+
+/**
+ * @param perms
+ *ACL permissions
+ * @return string representation of permissions
+ */
+public static String getPermString(int perms) {
--- End diff --

Have you considered caching these values in some way?
I see 2 options to make this faster:
1. dynamic caching of already generated values,
2. static caching of all possible values in a static hashmap (32 possible 
values if I'm not mistaken)


---

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

[Flavio Junqueira]

+1, verified the following:

- checksums and signature
- build passes
- rat tool output does not indicate any problem
- LICENSE and NOTICE look both ok
- local simple smoke tests work

-Flavio


> On 2 Apr 2018, at 02:01, Michael Han  wrote:
> 
> +1
> 
> - verified xsum/sig.
> - release notes looks good.
> - verified cluster with different sizes.
> - verified with few 4lw commands.
> - verified data / log dir swap was fixed.
> - all unit test passed.
> 
> 
> On Wed, Mar 28, 2018 at 11:55 AM, Patrick Hunt  wrote:
> 
>> +1. sig/xsum verified, RAT ran OK. I tested a few operational scenarios
>> which seemed fine. Ran the tests and they passed. LGTM.
>> 
>> Patrick
>> 
>> On Mon, Mar 26, 2018 at 10:05 PM, Abraham Fine  wrote:
>> 
>>> This is a bugfix release candidate for 3.4.12. It fixes 22 issues,
>>> including issues that
>>> affect incorrect handling of the dataDir and the dataLogDir.
>>> 
>>> This candidate fixes an issue in the release notes of candidate 0.
>>> 
>>> The full release notes are available at:
>>> 
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>> projectId=12310801=12342040
>>> 
>>> *** Please download, test and vote by March 31st 2018, 23:59 UTC+0. ***
>>> 
>>> Source files:
>>> http://people.apache.org/~afine/zookeeper-3.4.12-candidate-1/
>>> 
>>> Maven staging repo:
>>> https://repository.apache.org/content/groups/staging/org/
>>> apache/zookeeper/zookeeper/3.4.12/
>>> 
>>> The release candidate tag in git to be voted upon: release-3.4.12-rc1
>>> 
>>> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>>> http://www.apache.org/dist/zookeeper/KEYS
>>> 
>>> Should we release this candidate?
>>> 
>> 

[jira] [Updated] (ZOOKEEPER-3022) Step 1 to maven - Separate project structure

[Norbert Kalmar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3022:
--
Description: 
Create a project structure that separates the different parts of ZooKeeper into 
a more meaningful packages for the future maven build.

This first step should not impact Jenkins QA.

{noformat}
zookeeper
|-bin
|-conf
|-zk-client
| |-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}

  was:
Create a project structure that separates the different parts of ZooKeeper into 
a more meaningful packages for the future maven build.

This first step should not impact Jenkins QA.

{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}


> Step 1 to maven - Separate project structure
> 
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> This first step should not impact Jenkins QA.
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client
> | |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

[Norbert Kalmar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3021:
--
Description: 
In multiple steps, Maven should replace current ant build in ZooKeeper.

 
 First iteration: separate project structure
{noformat}
zookeeper
|-bin
|-conf
|-zk-client
| |-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 With this kind of structure, the code change could be kept to a bare minimum, 
if any at all.
 Just change the ant script to conform to the new structure. 
  
 Second iteration: code changes:
{noformat}
zookeeper
|-bin
|-conf
|-jute
|-zk-client
| |-zk-client-c
| |-zk-client-java
| \-zk-client-go (or any other language)
|-zk-common
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 Here, java client code is separated from the server code (and any other 
supported languages client code).
  
 Third iteration: maven structure
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}

There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
proxy on top of ant. 
The main idea here is to replace ant with "pure" maven, and update the project 
structure accordingly.

It is also worth noting, that backporting only the package changes to 3.4 is a 
good practice for future backport commits. Maven build implementation not 
needed, just the directory structuro to be compatible with 3.5/master.

  was:
In multiple steps, Maven should replace current ant build in ZooKeeper.

 
 First iteration: separate project structure
{noformat}
zookeeper
|-bin
|-conf
|-zk-client
| |-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 With this kind of structure, the code change could be kept to a bare minimum, 
if any at all.
 Just change the ant script to conform to the new structure. 
  
 Second iteration: code changes:
{noformat}
zookeeper
|-bin
|-conf
|-jute
|-zk-client
| |-zk-client-c
| |-zk-client-java
| \-zk-client-go (or any other language)
|-zk-common
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 Here, java client code is separated from the server code (and any other 
supported languages client code).
  
 Third iteration: maven structure
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}

There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
proxy on top of ant. 
The main idea here is to replace ant with "pure" maven, and update the project 
structure accordingly.


> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
>  
>  First iteration: separate project structure
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client
> | |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | 

[jira] [Updated] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

[Norbert Kalmar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3021:
--
Description: 
In multiple steps, Maven should replace current ant build in ZooKeeper.

 
 First iteration: separate project structure
{noformat}
zookeeper
|-bin
|-conf
|-zk-client
| |-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 With this kind of structure, the code change could be kept to a bare minimum, 
if any at all.
 Just change the ant script to conform to the new structure. 
  
 Second iteration: code changes:
{noformat}
zookeeper
|-bin
|-conf
|-jute
|-zk-client
| |-zk-client-c
| |-zk-client-java
| \-zk-client-go (or any other language)
|-zk-common
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 Here, java client code is separated from the server code (and any other 
supported languages client code).
  
 Third iteration: maven structure
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}

There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
proxy on top of ant. 
The main idea here is to replace ant with "pure" maven, and update the project 
structure accordingly.

  was:
In multiple steps, Maven should replace current ant build in ZooKeeper.

 
 First iteration: separate project structure
{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 With this kind of structure, the code change could be kept to a bare minimum, 
if any at all.
 Just change the ant script to conform to the new structure. 
  
 Second iteration: code changes:
{noformat}
zookeeper
|-bin
|-conf
|-jute
|-zk-client
| |-zk-client-c
| |-zk-client-java
| \-zk-client-go (or any other language)
|-zk-common
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 Here, java client code is separated from the server code (and any other 
supported languages client code).
  
 Third iteration: maven structure
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}

There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
proxy on top of ant. 
The main idea here is to replace ant with "pure" maven, and update the project 
structure accordingly.


> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
>  
>  First iteration: separate project structure
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client
> | |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  With this 

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448028#comment-16448028
 ] 

Hadoop QA commented on ZOOKEEPER-1260:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12823635/ZOOKEEPER-1260-01.patch
  against trunk revision 519db3f5c585f63a0a55e9f7929a07f9715bd729.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3665//console

This message is automatically generated.

> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-1260 PreCommit Build #3665

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3665/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 8.65 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12823635/ZOOKEEPER-1260-01.patch
 [exec]   against trunk revision 519db3f5c585f63a0a55e9f7929a07f9715bd729.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3665//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16448028 added to ZOOKEEPER-1260.
 [exec] Session logged out. Session was 
JSESSIONID=E2431EF9E69137AE93FBE6A0CD92E129.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1701: 
exec returned: 1

Total time: 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3002
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448023#comment-16448023
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2940:
---

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/466
  
@rakeshadr thanks, this is done.


> Deal with maxbuffer as it relates to large requests from clients
> 
>
> Key: ZOOKEEPER-2940
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> Monitor real-time Jute buffer usage as it relates to large requests from 
> clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/466
  
@rakeshadr thanks, this is done.


---

[GitHub] zookeeper issue #338: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

[pmoust]

Github user pmoust commented on the issue:

https://github.com/apache/zookeeper/pull/338
  
@arshadmohammad I'd also be curious as to the perf implications of this, 
have you run a load test-suite against this?


---

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448022#comment-16448022
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user pmoust commented on the issue:

https://github.com/apache/zookeeper/pull/338
  
@arshadmohammad I'd also be curious as to the perf implications of this, 
have you run a load test-suite against this?


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch35_jdk8 - Build # 928 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/928/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 3.51 KB...]
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8 does not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:298)
at 
hudson.tasks.ArtifactArchiver$ListFiles.invoke(ArtifactArchiver.java:278)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Build step 'Archive the artifacts' marked build as failure
Recording test results
ERROR: Build step failed with exception
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to H24
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:975)
at 
hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)
at 
hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:136)
at 
hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:166)
at 
hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:153)
at 
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at 
hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
at hudson.model.Run.execute(Run.java:1749)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk8 does not exist.
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:483)
at 
org.apache.tools.ant.types.AbstractFileSet.getDirectoryScanner(AbstractFileSet.java:460)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:141)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:118)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2760)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Build step 'Publish JUnit test result report' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 

Success: ZOOKEEPER- PreCommit Build #1620

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.40 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 22 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16448008 added to ZOOKEEPER-2940.
 [exec] Session logged out. Session was 
JSESSIONID=A0CBABF4079C511B9FCC1D82F34D31E5.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 39 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2940
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448008#comment-16448008
 ] 

Hadoop QA commented on ZOOKEEPER-2940:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 22 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620//console

This message is automatically generated.

> Deal with maxbuffer as it relates to large requests from clients
> 
>
> Key: ZOOKEEPER-2940
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: jute, server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> Monitor real-time Jute buffer usage as it relates to large requests from 
> clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [SUGGESTION] Migrate project structure to Maven build

[Norbert Kalmar]

Hi @maoling

To answer your questions:

1. Yes, we should strive to keep the current end artifact structure. The
end jar for example shouldn't change.
2. I think nothing really changes in this matter. If there are uncommitted
changes after some refactor, it will have to be rebased or resolved some
other way.

Regards,
Norbert

On Sun, Apr 22, 2018 at 7:29 PM, Santosh Srinivas 
wrote:

> Hi Zookeeper community,
>
> Nice suggestion Norbert. Without getting into the discussion of whether ant
> or maven is a better build system we should chose a build mechanism that is
> easier to maintain. Dependency management for big projects like zookeeper
> can be quite a task and maven can help with its builtin dependency
> management. Main benefit of ant is it does not impose any coding
> conventions or project structures. I would like to know form the community
> on any reasons to stick with Ant builds.
>
>
> Best Regards,
> Santosh.
>
> On Sun, Apr 22, 2018 at 3:06 PM, 岭秀  wrote:
>
> > +1.
> > It will be very,very useful,but a long way to go
> > 1. Your roadmap of migrating to maven is thoughtful.It will be huge works
> > to compatible with other plug-ins,dependency jars,systems just as ant did
> > formerly?
> > 2. In the process of migrating, how can we apply the new patch?
> > - 原始邮件 -
> > 发件人：Norbert Kalmar 
> > 收件人：dev@zookeeper.apache.org
> > 主题：[SUGGESTION] Migrate project structure to Maven build
> > 日期：2018年04月19日 19点28分
> >
> > Hi ZooKeeper community,
> > As the vast majority of the components in the Hadoop ecosystem is built
> > with Maven, what do you think of moving Zookeeper to a Maven structure as
> > well?
> > This would bring the benefit of a more consistent project structure,
> better
> > dependency management and more possibilities for future changes (i.e.: we
> > could separate java client code so that projects like HDFS that only
> needs
> > the client doesn't have to import the whole ZooKeeper).
> > This could be done as a multi-step change.
> > The change would also include the separation of unit tests from
> integration
> > and/or functional tests.
> > In the first iteration, the project structure could be separated
> something
> > like:
> > zookeeper
> > |-bin
> > |-conf
> > |-zk-client-c
> > |-zk-contrib
> > | |-zk-contrib-fatjar
> > | |-zk-contrib-huebrowser
> > | |-zk-contrib-loggraph
> > | |-zk-contrib-monitoring
> > | |-zk-contrib-rest
> > | |-zk-contrib-zkfuse
> > | |-zk-contrib-zkperl
> > | |-zk-contrib-zkpython
> > | |-zk-contrib-zktreeutil
> > | \-zk-contrib-zooinspector
> > |-zk-docs
> > |-zk-it (integration tests)
> > |-zk-server
> > |-zk-recipes
> > | |-zk-recipes-election
> > | |-zk-recipes-lock
> > \ \-zk-recipes-queue
> > With this kind of structure, the code change could be kept to a bare
> > minimum, if any at all.
> > Just change the ant script to conform to the new structure.
> > In a second iteration, we could start the changes that require code
> changes
> > as well:
> > zookeeper
> > |-bin
> > |-conf
> > |-jute
> > |-zk-client
> > | |-zk-client-c
> > | |-zk-client-java
> > | \-zk-client-go (or any other language)
> > |-zk-common
> > |-zk-contrib
> > | |-zk-contrib-fatjar
> > | |-zk-contrib-huebrowser
> > | |-zk-contrib-loggraph
> > | |-zk-contrib-monitoring
> > | |-zk-contrib-rest
> > | |-zk-contrib-zkfuse
> > | |-zk-contrib-zkperl
> > | |-zk-contrib-zkpython
> > | |-zk-contrib-zktreeutil
> > | \-zk-contrib-zooinspector
> > |-zk-docs
> > |-zk-it (integration tests)
> > |-zk-server
> > |-zk-recipes
> > | |-zk-recipes-election
> > | |-zk-recipes-lock
> > \ \-zk-recipes-queue
> > Here, java client code is separated from the server code (and any other
> > supported languages client code).
> > The final iteration would be something like:
> > zk-something
> > |-src
> > | |-main
> > | |  |-java
> > | |  | \org...
> > | |   \resources
> > | \test (unit tests only?)
> > |  |-java
> > |  |  \org...
> > |  \resources
> > \pom.xml
> > But this is just to give a high level example/vision.
> > Of course, with all the iteration, even at the end when possibly moving
> to
> > a full Maven build, it is important that the final jar structure remains
> > the same.
> > What do you think?
> > Kind regards,
> > Norbert
> >
>
>
>
> --
> Santosh Srinivas. V | salesforce.com, Hyderabad
>

Re: [VOTE] Migrate ZK to Maven build

[Jordan Zimmerman]

+1 (non binding)

> On Apr 23, 2018, at 6:21 PM, Mohammad arshad  
> wrote:
> 
> +1
> 
> -Original Message-
> From: Andor Molnar [mailto:an...@cloudera.com] 
> Sent: Monday, April 23, 2018 4:43 PM
> To: dev@zookeeper.apache.org
> Subject: Re: [VOTE] Migrate ZK to Maven build
> 
> +1 (non-binding)
> 
> On Mon, Apr 23, 2018 at 10:30 AM, Tamas Penzes  wrote:
> 
>> +1 (non-binding)
>> 
>> On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar 
>> wrote:
>> 
>>> Hi,
>>> 
>>> Let's start a vote on migrating to maven instead of ant.
>>> https://issues.apache.org/jira/browse/ZOOKEEPER-3021
>>> 
>>> *Shall we migrate ZooKeeper build from ant to Maven?*
>>> 
>>> Please reply with [Yes / +1] or [No / -1] to this thread.
>>> 
>>> Thanks,
>>> Norbert
>>> 
>> 
>> 
>> 
>> --
>> *Tamás Pénzes* | Engineering Manager
>> e. tam...@cloudera.com
>> cloudera.com 
>> 
>> [image: Cloudera] 
>> 
>> [image: Cloudera on Twitter]  [image:
>> Cloudera on Facebook]  [image: 
>> Cloudera on LinkedIn] 
>> --
>> 

RE: [VOTE] Migrate ZK to Maven build

[Mohammad arshad]

+1

-Original Message-
From: Andor Molnar [mailto:an...@cloudera.com] 
Sent: Monday, April 23, 2018 4:43 PM
To: dev@zookeeper.apache.org
Subject: Re: [VOTE] Migrate ZK to Maven build

+1 (non-binding)

On Mon, Apr 23, 2018 at 10:30 AM, Tamas Penzes  wrote:

> +1 (non-binding)
>
> On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar 
> wrote:
>
> > Hi,
> >
> > Let's start a vote on migrating to maven instead of ant.
> > https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> >
> > *Shall we migrate ZooKeeper build from ant to Maven?*
> >
> > Please reply with [Yes / +1] or [No / -1] to this thread.
> >
> > Thanks,
> > Norbert
> >
>
>
>
> --
> *Tamás Pénzes* | Engineering Manager
> e. tam...@cloudera.com
> cloudera.com 
>
> [image: Cloudera] 
>
> [image: Cloudera on Twitter]  [image:
> Cloudera on Facebook]  [image: 
> Cloudera on LinkedIn] 
> --
>

Re: [VOTE] Migrate ZK to Maven build

[Andor Molnar]

+1 (non-binding)

On Mon, Apr 23, 2018 at 10:30 AM, Tamas Penzes  wrote:

> +1 (non-binding)
>
> On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar 
> wrote:
>
> > Hi,
> >
> > Let's start a vote on migrating to maven instead of ant.
> > https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> >
> > *Shall we migrate ZooKeeper build from ant to Maven?*
> >
> > Please reply with [Yes / +1] or [No / -1] to this thread.
> >
> > Thanks,
> > Norbert
> >
>
>
>
> --
> *Tamás Pénzes* | Engineering Manager
> e. tam...@cloudera.com
> cloudera.com 
>
> [image: Cloudera] 
>
> [image: Cloudera on Twitter]  [image:
> Cloudera on Facebook]  [image: Cloudera
> on LinkedIn] 
> --
>

Re: [VOTE] Migrate ZK to Maven build

[Tamas Penzes]

+1 (non-binding)

On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar 
wrote:

> Hi,
>
> Let's start a vote on migrating to maven instead of ant.
> https://issues.apache.org/jira/browse/ZOOKEEPER-3021
>
> *Shall we migrate ZooKeeper build from ant to Maven?*
>
> Please reply with [Yes / +1] or [No / -1] to this thread.
>
> Thanks,
> Norbert
>



-- 
*Tamás Pénzes* | Engineering Manager
e. tam...@cloudera.com
cloudera.com 

[image: Cloudera] 

[image: Cloudera on Twitter]  [image:
Cloudera on Facebook]  [image: Cloudera
on LinkedIn] 
--

Failed: ZOOKEEPER- PreCommit Build #1619

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.02 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16447661 added to ZOOKEEPER-2959.
 [exec] Session logged out. Session was 
JSESSIONID=E4EDEC1BC5F93FB9C6C64D9C95CB6AA7.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1722:
 exec returned: 1

Total time: 13 minutes 37 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2959
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.EphemeralNodeDeletionTest.testEphemeralNodeDeletion

Error Message:
After session close ephemeral node must be deleted expected null, but 
was:<4294967302,4294967302,1524467089629,1524467089629,0,0,0,144660371324600320,1,0,4294967302
>

Stack Trace:
junit.framework.AssertionFailedError: After session close ephemeral node must 
be deleted expected null, but 
was:<4294967302,4294967302,1524467089629,1524467089629,0,0,0,144660371324600320,1,0,4294967302
>
at 
org.apache.zookeeper.server.quorum.EphemeralNodeDeletionTest.testEphemeralNodeDeletion(EphemeralNodeDeletionTest.java:156)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447661#comment-16447661
 ] 

Hadoop QA commented on ZOOKEEPER-2959:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 7 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619//console

This message is automatically generated.

> ignore accepted epoch and LEADERINFO ack from observers when a newly elected 
> leader computes new epoch
> --
>
> Key: ZOOKEEPER-2959
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2959
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10, 3.5.3
>Reporter: xiangyq000
>Assignee: Bogdan Kanivets
>Priority: Blocker
>
> Once the ZooKeeper cluster finishes the election for new leader, all learners 
> report their accepted epoch to the leader for the computation of new cluster 
> epoch.
> org.apache.zookeeper.server.quorum.Leader#getEpochToPropose
> {code:java}
> private final HashSet connectingFollowers = new HashSet();
> public long getEpochToPropose(long sid, long lastAcceptedEpoch) throws 
> InterruptedException, IOException {
> synchronized(connectingFollowers) {
> if (!waitingForNewEpoch) {
> return epoch;
> }
> if (lastAcceptedEpoch >= epoch) {
> epoch = lastAcceptedEpoch+1;
> }
> connectingFollowers.add(sid);
> QuorumVerifier verifier = self.getQuorumVerifier();
> if (connectingFollowers.contains(self.getId()) &&
> 
> verifier.containsQuorum(connectingFollowers)) {
> waitingForNewEpoch = false;
> self.setAcceptedEpoch(epoch);
> connectingFollowers.notifyAll();
> } else {
> long start = Time.currentElapsedTime();
> long cur = start;
> long end = start + self.getInitLimit()*self.getTickTime();
> while(waitingForNewEpoch && cur < end) {
> connectingFollowers.wait(end - cur);
> cur = Time.currentElapsedTime();
> }
> if (waitingForNewEpoch) {
> throw new InterruptedException("Timeout while waiting for 
> epoch from quorum");
> }
> }
> return epoch;
> }
> }
> {code}
> The computation will get an outcome once :
> # The leader has call method "getEpochToPropose"
> # The number of all reporters is greater than half of participants.
> The problem is, an observer server will also send its accepted epoch to the 
> leader, while this procedure treat observers as participants.
> Supposed that the cluster consists of 1 leader, 2 followers and 1 observer, 
> and now the leader and the observer have reported their accepted epochs while 
> neither of the followers has. Thus, the connectingFollowers set consists of 
> two elements, resulting in a size of 2, which is greater than half quorum, 
> namely, 2. Then QuorumVerifier#containsQuorum will return true, because it 
> does not check whether the elements of the parameter are participants.
> The same flaw exists in 
> org.apache.zookeeper.server.quorum.Leader#waitForEpochAck



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3024) C++ Client return sub paths in String_vector illegal after zoo_get_children completed with ZOK

[yijie (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yijie updated ZOOKEEPER-3024:
-
Description: 
we use  c++ client api:

int zoo_get_children(zhandle_t *zh, const char *path, int watch, struct 
String_vector *strings)

to list zookeeper dir, zoo_get_children return zok。

then we visit strings, its not right

!image-2018-04-23-14-05-03-534.png!

  was:
we use  c++ client api:

int zoo_get_children(zhandle_t *zh, const char *path, int watch, struct 
String_vector *strings) 

to list zookeeper dir, zoo_get_children return zok。

zhen we visit strings, its not right

!image-2018-04-23-14-05-03-534.png!


> C++ Client return sub paths in String_vector illegal after zoo_get_children 
> completed with ZOK
> --
>
> Key: ZOOKEEPER-3024
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3024
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: yijie
>Priority: Major
> Attachments: image-2018-04-23-14-05-03-534.png
>
>
> we use  c++ client api:
> int zoo_get_children(zhandle_t *zh, const char *path, int watch, struct 
> String_vector *strings)
> to list zookeeper dir, zoo_get_children return zok。
> then we visit strings, its not right
> !image-2018-04-23-14-05-03-534.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3024) C++ Client return sub paths in String_vector illegal after zoo_get_children completed with ZOK

[yijie (JIRA)]

yijie created ZOOKEEPER-3024:


 Summary: C++ Client return sub paths in String_vector illegal 
after zoo_get_children completed with ZOK
 Key: ZOOKEEPER-3024
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3024
 Project: ZooKeeper
  Issue Type: Bug
Reporter: yijie
 Attachments: image-2018-04-23-14-05-03-534.png

we use  c++ client api:

int zoo_get_children(zhandle_t *zh, const char *path, int watch, struct 
String_vector *strings) 

to list zookeeper dir, zoo_get_children return zok。

zhen we visit strings, its not right

!image-2018-04-23-14-05-03-534.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)