we stop reading the socket once we hit max buffer size so we don't
overflow memory. it was put in when a buggy client cause the server to
think it was getting a 1G packet and ran out of memory trying to
allocate memory for it. in theory we could read in the data and just
drop it on the floor. this
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r212782182
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
---
@@ -1641,6 +1641,24 @@ server.3=zoo3:2888:3888
Default
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/586#discussion_r212781950
--- Diff: src/contrib/zkpython/src/c/zookeeper.c ---
@@ -387,8 +387,8 @@ int parse_acls(struct ACL_vector *acls, PyObject
*pyacls)
PyObject *perms
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/605#discussion_r212781611
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -452,7 +452,7 @@ public void testElectionFraud() throws
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/606
+1 thank you @lvfangmin
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2090/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 78.10 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592323#comment-16592323
]
Hadoop QA commented on ZOOKEEPER-3127:
--
+1 overall. GitHub Pull Request Build
+1
See https://builds.apache.org/job/ZooKeeper-trunk/163/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 145.18 KB...]
[junit] Running
Github user suyogmapara commented on the issue:
https://github.com/apache/zookeeper/pull/567
Hi @maoling
Regarding 1, preAllocSize controls how big the contiguous region of
transaction file would be on disk (to reduce number seeks you need to do) while
this feature controls
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2905/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 9.68 KB...]
[ivy:retrieve] confs: [javacc]
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212587862
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -325,6 +327,8 @@ public void parseProperties(Properties zkProp)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591412#comment-16591412
]
Hari Sekhon edited comment on ZOOKEEPER-3037 at 8/24/18 10:02 AM:
--
I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591412#comment-16591412
]
Hari Sekhon commented on ZOOKEEPER-3037:
I think this is actually a really good improvement,
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212545767
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java ---
@@ -117,13 +121,23 @@ public void runFromConfig(ServerConfig config)
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212544888
--- Diff:
src/java/main/org/apache/zookeeper/metrics/impl/NullMetricsProvider.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache
Mohammad Arshad created ZOOKEEPER-3128:
--
Summary: CLI Commands display Authentication error for
Authorization error
Key: ZOOKEEPER-3128
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3128
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591225#comment-16591225
]
Fangmin Lv commented on ZOOKEEPER-3099:
---
[~jiangjiafu] please change the title to be explicitly
Hello everyone,
Why do we close the clientCnxn whenever a client sends a request which
payload larger than jute max buffer size? (and similar for client as well)
Is it a security issue if we send a relevant KeeperException instead? Even
more, we send the parameter value to the client and client
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212527464
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -325,6 +327,8 @@ public void parseProperties(Properties zkProp)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212526201
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
@@ -141,6 +145,16 @@ public void runFromConfig(QuorumPeerConfig
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212522424
--- Diff: src/java/main/org/apache/zookeeper/server/ServerConfig.java ---
@@ -115,4 +118,6 @@ public InetSocketAddress getSecureClientPortAddress() {
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212526114
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java ---
@@ -117,13 +121,23 @@ public void runFromConfig(ServerConfig config)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212526680
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
@@ -159,6 +173,7 @@ public void runFromConfig(QuorumPeerConfig
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212527486
--- Diff:
src/java/main/org/apache/zookeeper/metrics/impl/NullMetricsProvider.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212526157
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java ---
@@ -117,13 +121,23 @@ public void runFromConfig(ServerConfig config)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212528161
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
@@ -141,6 +145,16 @@ public void runFromConfig(QuorumPeerConfig
26 matches
Mail list logo
