[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221416362 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java --- @@ -196,6 +224,10 @@ protected long getLastQueued() { return

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221338505 --- Diff: docs/zookeeperAdmin.html --- @@ -1126,6 +1126,14 @@ Minimum Configuration zookeeper.serverCnxnFactory,

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221393478 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -764,6 +764,16 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221415847 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -84,8 +84,12 @@ public Socket getSocket() { protected

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221416332 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -232,8 +236,8 @@ protected void sockConnect(Socket sock, InetSocketAddress

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221415836 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -84,8 +84,12 @@ public Socket getSocket() { protected

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221389580 --- Diff: src/java/test/org/apache/zookeeper/server/util/PortForwarder.java --- @@ -29,62 +26,15 @@ import java.net.Socket; import

[jira] [Updated] (ZOOKEEPER-3158) firstConnect.countDown() will not be executed where sendThread.primeConnection() has thrown an exception

2018-09-28 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3158: --- Description: look at the source code in the ClientCnxnSocketNetty.connect(InetSocketAddress):

[jira] [Created] (ZOOKEEPER-3158) firstConnect.countDown() will not be executed where sendThread.primeConnection() has thrown an exception

2018-09-28 Thread maoling (JIRA)
maoling created ZOOKEEPER-3158: -- Summary: firstConnect.countDown() will not be executed where sendThread.primeConnection() has thrown an exception Key: ZOOKEEPER-3158 URL:

ZooKeeper-trunk - Build # 209 - Still Failing

2018-09-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/209/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 149.71 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-1177) Enabling a large number of watches for a large number of clients

2018-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632641#comment-16632641 ] Hudson commented on ZOOKEEPER-1177: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #208 (See

ZooKeeper-trunk - Build # 208 - Still Failing

2018-09-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/208/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 149.89 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-2847) Cannot bind to client port when reconfig based on old static config

2018-09-28 Thread Yisong Yue (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632638#comment-16632638 ] Yisong Yue commented on ZOOKEEPER-2847: --- [~andorm] [~hanm] Sorry for the delay! It has been a

[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-09-28 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/647 @anmolnar here is the scenario shows why the previous fix on master has problem: 1. parent A is in it's parent's serializing list 2. before it's being serialized, child 1 was

[jira] [Commented] (ZOOKEEPER-2847) Cannot bind to client port when reconfig based on old static config

2018-09-28 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632598#comment-16632598 ] Fangmin Lv commented on ZOOKEEPER-2847: --- Sorry, this is a known issue, I was planning to 

[GitHub] zookeeper issue #647: ZOOKEEPER-3125: Fixing pzxid consistent issue when rep...

2018-09-28 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/647 @anmolnar it's not fixing multiple issues but the same in ZOOKEEPER-3125, the fix on master has bug we found recently, I think we should include this when port back to 3.5 ---

[GitHub] zookeeper pull request #647: ZOOKEEPER-3125: Fixing pzxid consistent issue w...

2018-09-28 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/647#discussion_r221391402 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -527,6 +527,24 @@ public void deleteNode(String path, long zxid)

ZooKeeper-trunk-windows-cmake - Build # 2954 - Still Failing

2018-09-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2954/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.79 KB...] [ivy:retrieve] confs: [javacc]

[GitHub] zookeeper pull request #647: ZOOKEEPER-3125: Fixing pzxid consistent issue w...

2018-09-28 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/647#discussion_r221390760 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -162,6 +167,98 @@ public void process(String path) {

[GitHub] zookeeper issue #605: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-09-28 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/605 That seems reasonable to me, I'll provide a separate PR for improving the connection loss thing in ZOOKEEPER-3157. ---

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/648#discussion_r221389383 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -997,12 +999,31 @@ private void startConnect(InetSocketAddress addr) throws

[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...

2018-09-28 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/590 merged to master. great work @lvfangmin ! ---

[GitHub] zookeeper pull request #590: [ZOOKEEPER-1177] Add the memory optimized watch...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/590 ---

[jira] [Resolved] (ZOOKEEPER-1177) Enabling a large number of watches for a large number of clients

2018-09-28 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-1177. Resolution: Fixed Fix Version/s: (was: 3.5.5) Issue resolved by pull

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-09-28 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/648 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2284/ ---

Success: ZOOKEEPER- PreCommit Build #2284

2018-09-28 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2284/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 41.47 MB...] [exec] +1

[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...

2018-09-28 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/590 got a ["green" build](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2285/testReport/) (minors the known failed test `testReconfigRemoveClientFromStatic` discussed at

Failed: ZOOKEEPER- PreCommit Build #2285

2018-09-28 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2285/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.60 MB...] [exec] +1

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-09-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/648 @anmolnar I think I have addressed all of your comments. Please have another look. ---

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/648#discussion_r221377101 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -990,6 +992,27 @@ private void sendPing() { private boolean

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/648#discussion_r221376870 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -990,6 +992,27 @@ private void sendPing() { private boolean

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-09-28 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/648 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2282/ ---

Failed: ZOOKEEPER- PreCommit Build #2282

2018-09-28 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2282/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.91 MB...] [exec]

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/648#discussion_r221367697 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -990,6 +992,27 @@ private void sendPing() { private boolean

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/648#discussion_r221367723 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -990,6 +992,27 @@ private void sendPing() { private boolean

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-09-28 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r221368066 --- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/648#discussion_r221368841 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -990,6 +992,27 @@ private void sendPing() { private boolean

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-09-28 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r221369391 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java --- @@ -303,6 +305,10 @@ public void parseProperties(Properties zkProp)

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/648#discussion_r221367991 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -990,6 +992,27 @@ private void sendPing() { private boolean

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-09-28 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r221367412 --- Diff: ivy.xml --- @@ -63,6 +63,10 @@ + --- End diff -- remove ---

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-09-28 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r221367305 --- Diff: build.xml --- @@ -38,11 +38,15 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> + --- End diff --

Failed: ZOOKEEPER- PreCommit Build #2283

2018-09-28 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2283/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.56 MB...] [exec] +1

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-28 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/184 @anmolnar you just need to copy `ZKTrustManager.java` from #627 to #184, and remove the dependency on httpclient from build.xml and ivy.xml. And comment out the 2 lines of code in

[jira] [Commented] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name

2018-09-28 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632482#comment-16632482 ] Robert Joseph Evans commented on ZOOKEEPER-3156: OK I have a patch up for 3.4 and if

[jira] [Updated] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name

2018-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3156: -- Labels: pull-request-available (was: ) > ZOOKEEPER-2184 causes kerberos principal

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-09-28 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/zookeeper/pull/648 ZOOKEEPER-3156: Add in option to canonicalize host name You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/zookeeper ZOOKEEPER-3156-3.4

[GitHub] zookeeper issue #605: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-09-28 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/605 +1 for @hanm 's concern. Auto-retrying tests wouldn't be good here. ---

[jira] [Commented] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name

2018-09-28 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632380#comment-16632380 ] Andor Molnar commented on ZOOKEEPER-3156: - [~revans2] Thanks for looking into this. As long

ZooKeeper-trunk-windows-cmake - Build # 2953 - Still Failing

2018-09-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2953/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.78 KB...] [ivy:retrieve] confs: [javacc]

[jira] [Commented] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name

2018-09-28 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632211#comment-16632211 ] Robert Joseph Evans commented on ZOOKEEPER-3156: [~andorm], Sorry I was on a plane

Failed: ZOOKEEPER- PreCommit Build #2281

2018-09-28 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2281/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.17 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3157) Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss

2018-09-28 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632139#comment-16632139 ] Michael Han commented on ZOOKEEPER-3157: [~lvfangmin] thanks for making a fix on this. For

[jira] [Commented] (ZOOKEEPER-2847) Cannot bind to client port when reconfig based on old static config

2018-09-28 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632131#comment-16632131 ] Michael Han commented on ZOOKEEPER-2847: not sure, this test passed in the pre-commit check

[GitHub] zookeeper issue #605: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-09-28 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/605 >> since it's actually 'hiding' the flaky tests This is my main concern. If we do this to all test cases, it's very likely there will be no follow ups or investigations on the flaky tests

Re: ZooKeeper 3.5 blocker issues

2018-09-28 Thread Tamas Penzes
Hi All, I would add ZOOKEEPER-3021 Migrate project structure to Maven build as a blocker too. Since the migration has started it would be good to finish before releasing ZK 3.5.x GA. ZOOKEEPER-925

Failed: ZOOKEEPER- PreCommit Build #2280

2018-09-28 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2280/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.88 MB...] [exec]

[GitHub] zookeeper issue #456: ZOOKEEPER-2930: Leader cannot be elected due to networ...

2018-09-28 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/456 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2280/ ---

[GitHub] zookeeper issue #629: ZOOKEEPER-2641:AvgRequestLatency metric improves to be...

2018-09-28 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/629 @anmolnar - branch 3.4 is freezed and only accepted bugfix? If so, I can port this PR to master - exec mntr , we can find AvgRequestLatency metric can be 0 all the time which let user

ZooKeeper_branch35_jdk8 - Build # 1133 - Failure

2018-09-28 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1133/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 63.06 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-3156) ZOOKEEPER-2184 causes kerberos principal to not have resolved host name

2018-09-28 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631671#comment-16631671 ] Andor Molnar commented on ZOOKEEPER-3156: - [~revans2] Any thoughts? > ZOOKEEPER-2184 causes

[jira] [Assigned] (ZOOKEEPER-1908) setAcl should be have a recursive function

2018-09-28 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan reassigned ZOOKEEPER-1908: Assignee: Reid Chan > setAcl should be have a recursive function >

[jira] [Commented] (ZOOKEEPER-1908) setAcl should be have a recursive function

2018-09-28 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631658#comment-16631658 ] Andor Molnar commented on ZOOKEEPER-1908: - [~reidchan] This is done. Have fun! :) > setAcl

[jira] [Commented] (ZOOKEEPER-1908) setAcl should be have a recursive function

2018-09-28 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631653#comment-16631653 ] Reid Chan commented on ZOOKEEPER-1908: -- Thanks [~andorm], would you mind authorizing a

Trunk builds are failing

2018-09-28 Thread Andor Molnar
Hi, As far as I can see ZOOKEEPER-2847 broke testReconfigRemoveClientFromStatic. Is that correct? Hope it will be fixed soon. Regards, Andor

[jira] [Comment Edited] (ZOOKEEPER-2847) Cannot bind to client port when reconfig based on old static config

2018-09-28 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631649#comment-16631649 ] Andor Molnar edited comment on ZOOKEEPER-2847 at 9/28/18 10:12 AM: ---

[jira] [Commented] (ZOOKEEPER-2847) Cannot bind to client port when reconfig based on old static config

2018-09-28 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631649#comment-16631649 ] Andor Molnar commented on ZOOKEEPER-2847: - [~yisong-yue] Are u able to submit for this

[GitHub] zookeeper pull request #647: ZOOKEEPER-3125: Fixing pzxid consistent issue w...

2018-09-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/647#discussion_r221201278 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -162,6 +167,98 @@ public void process(String path) {

[GitHub] zookeeper pull request #647: ZOOKEEPER-3125: Fixing pzxid consistent issue w...

2018-09-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/647#discussion_r221200308 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -527,6 +527,24 @@ public void deleteNode(String path, long zxid)

[GitHub] zookeeper pull request #647: ZOOKEEPER-3125: Fixing pzxid consistent issue w...

2018-09-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/647#discussion_r221200641 --- Diff: src/java/test/org/apache/zookeeper/server/DataTreeTest.java --- @@ -153,6 +153,31 @@ public void testIncrementCversion() throws Exception {

[jira] [Commented] (ZOOKEEPER-1908) setAcl should be have a recursive function

2018-09-28 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631609#comment-16631609 ] Andor Molnar commented on ZOOKEEPER-1908: - [~reidchan] Thanks for volunteering. I don't see

Failed: ZOOKEEPER- PreCommit Build #2279

2018-09-28 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2279/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.77 MB...] [exec]

[GitHub] zookeeper issue #647: ZOOKEEPER-3125: Fixing pzxid consistent issue when rep...

2018-09-28 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/647 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2279/ ---

[GitHub] zookeeper pull request #647: ZOOKEEPER-3125: Fixing pzxid consistent issue w...

2018-09-28 Thread lvfangmin
GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/647 ZOOKEEPER-3125: Fixing pzxid consistent issue when replaying a txn for a deleted node Port this to 3.5, this also fixed the issue where the pzxid might be overwritten by a smaller one when

[GitHub] zookeeper issue #605: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-09-28 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/605 @anmolnar thanks for the context, I'll provide a separate patch for 3.5 as well. Also I created a JIRA to improve the test: ZOOKEEPER-3157. As I mentioned in that JIRA,